- 10 Feb, 2016 40 commits
-
-
thakis authored
Also blacklist a few more bots in manage.py. This mostly affects the Clang ToT and the clang/win FYI bots: $ testing/buildbot/manage.py --convert content_unittests Convert content_unittests to run exclusively on Swarming 4 used to run locally and were converted: - chromium.fyi.json: ClangToTLinux tester - chromium.fyi.json: ClangToTMac tester - chromium.fyi.json: ClangToTMacASan tester - chromium.fyi.json: CrWinClang64(dbg) tester $ testing/buildbot/manage.py --convert components_unittests Convert components_unittests to run exclusively on Swarming 18 used to run locally and were converted: - chromium.fyi.json: Chromium Win 10 - chromium.fyi.json: ClangToTLinux tester - chromium.fyi.json: ClangToTLinuxASan tester - chromium.fyi.json: ClangToTMac tester - chromium.fyi.json: ClangToTMacASan tester - chromium.fyi.json: ClangToTWin tester - chromium.fyi.json: ClangToTWin(dbg) tester - chromium.fyi.json: ClangToTWin(dll) tester - chromium.fyi.json: ClangToTWin64 tester - chromium.fyi.json: ClangToTWin64(dbg) tester - chromium.fyi.json: ClangToTWin64(dll) tester - chromium.fyi.json: CrWinClang tester - chromium.fyi.json: CrWinClang(dbg) tester - chromium.fyi.json: CrWinClang(shared) tester - chromium.fyi.json: CrWinClang64 tester - chromium.fyi.json: CrWinClang64(dbg) tester - chromium.fyi.json: CrWinClang64(dll) tester - chromium.fyi.json: CrWinClangLLD tester $ testing/buildbot/manage.py --convert content_browsertests Convert content_browsertests to run exclusively on Swarming 2 used to run locally and were converted: - chromium.fyi.json: ClangToTLinux tester - chromium.fyi.json: CrWinClang64(dbg) tester BUG=98637,82385 Review URL: https://codereview.chromium.org/1683253003 Cr-Commit-Position: refs/heads/master@{#374755}
-
watk authored
Previously there were cases where MediaCodec#stop would be called while the MediaCodec was in a broken state, which results in hitting a CHECK. In AVDA we don't actually need to call stop() because it's always called right before deleting the MediaCodec. This replaces those calls with explicit deletion. BUG=582275 TEST=Trying to play videos with unsupported profiles; no crashes Review URL: https://codereview.chromium.org/1687143002 Cr-Commit-Position: refs/heads/master@{#374754}
-
junov authored
When creating a WebGL canvas, and when allocating a 2D canvas backing, the implementation was triggering an immediate style calculation to evaluate the image-redering CSS property. This CL gets rid of of these calculations by relying on the fact that if the style is dirty, it will be updated before the next paint, which will allow for the state to be corrected after the fact, if necessary. BUG=585135 Review URL: https://codereview.chromium.org/1674123003 Cr-Commit-Position: refs/heads/master@{#374753}
-
agrieve authored
Missed this one first time around. BUG=none Review URL: https://codereview.chromium.org/1684193002 Cr-Commit-Position: refs/heads/master@{#374752}
-
gogerald authored
This CL adds BluetoothRemoteGattServiceWin to BluetoothDeviceWin. The upcoming CL will implement BluetoothRemoteGattServiceWin. BUG=579202 Review URL: https://codereview.chromium.org/1681853003 Cr-Commit-Position: refs/heads/master@{#374751}
-
primiano authored
Leftover from the previous cleanups. Previously, when base did pretend to not know anything about allocator, tc_set_new_mode was invoked by the content layer (in content_main). But this required this base unittest to mimic the same content behavior. These days, instead, tc_set_new_mode() is called by base's EnableTerminationOnOutOfMemory(). This test is already invoking EnableTerminationOnOutOfMemory() in its initialization, so there is no need to perform a 2nd call to tc_set_new_mode. Also this makes the code in this test conceptually cleaner and smaller. BUG=564618 TEST=base_unittests Review URL: https://codereview.chromium.org/1683153002 Cr-Commit-Position: refs/heads/master@{#374750}
-
rockot authored
We tried dropping this, but there are still uninitialized bytes somewhere. Zero them again for now. BUG=585804 TBR=amistry@chromium.org Review URL: https://codereview.chromium.org/1684733004 Cr-Commit-Position: refs/heads/master@{#374749}
-
krasin authored
BUG=584828 Review URL: https://codereview.chromium.org/1691533002 Cr-Commit-Position: refs/heads/master@{#374748}
-
donnd authored
Now GetResponseHeaders won't check the navigation state, instead it will just return a nullptr if there are no response headers available. In some cases the response headers are not available, but in the previous code there's no safe way to know that. This removes the CHECK for the navigation state that was causing this problem. BUG=526291 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Review URL: https://codereview.chromium.org/1681703002 Cr-Commit-Position: refs/heads/master@{#374747}
-
iclelland authored
BUG=575808 Review URL: https://codereview.chromium.org/1682473002 Cr-Commit-Position: refs/heads/master@{#374746}
-
binji authored
If munmap is called during ki_init() in a kernel_wrap_test, it will print a message saying the call was unexpected. This will cause a deadlock since it is trying to print a message inside the memory allocator. BUG=378596 R=sbc@chromium.org CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk;tryserver.chromium.win:win_nacl_sdk Review URL: https://codereview.chromium.org/1681223004 Cr-Commit-Position: refs/heads/master@{#374745}
-
martijn authored
BUG=496258 TBR=dtrainor@chromium.org Review URL: https://codereview.chromium.org/1676023002 Cr-Commit-Position: refs/heads/master@{#374744}
-
ripp authored
On some Android devices, the device will restart right after the browser is launched. This is due to a kernel bug on these devices when using the Linux GetWifiSSID implementation, which causes a kernel panic and device restart. To avoid this, a Java-based implementation is used for Android devices, which avoids this. Examples of affected devices include: HTC One S Lenovo A820 Asus ZenFone 2 MediaPad 10 FHD R=bengr@chromium.org,rch@chromium.org BUG=555067 TEST=Take the problem device, install browser and start it, wait for 10 seconds. Make 10 experiments, cleaning data before each run. Device should not reboot. Review URL: https://codereview.chromium.org/1633733005 Cr-Commit-Position: refs/heads/master@{#374743}
-
Nico Weber authored
Notably, this includes browser_tests, which when run locally takes 3h to run and (since recently) also doesn't pass all tests when not run on swarming. BUG=498033 R=dpranke@chromium.org Review URL: https://codereview.chromium.org/1685223002 . Cr-Commit-Position: refs/heads/master@{#374742}
-
charliea authored
TBR=simonhatch@chromium.org BUG=585872 Review URL: https://codereview.chromium.org/1682363004 Cr-Commit-Position: refs/heads/master@{#374741}
-
kenrb authored
Creating a select element dropdown in an out-of-process iframe is crashing the browser process because the RenderWidgetHostView for the new widget becomes associated with the top-level frame's renderer process, creating a routing ID conflict. This CL initializes the new RenderWidgetHostView with the correct RenderProcessHost. BUG=582511 Review URL: https://codereview.chromium.org/1685133003 Cr-Commit-Position: refs/heads/master@{#374740}
-
lukasza authored
In crrev.com/14046012 we started to iterate over all RenderViews and navigating them to about:blank to trigger their unload event handlers while the main window is still present. This code is broken when OOPIFs are enabled (i.e. we cannot navigate a *remote* RenderView / RenderFrame). This CL basically reverts crrev.com/14046012 and instead puts the burden on test authors, to make sure that their unload handlers can robustly handle being executed when the main window is gone. This makes the test harness work better in presence of OOPIFs. BUG=583089 Review URL: https://codereview.chromium.org/1656033004 Cr-Commit-Position: refs/heads/master@{#374739}
-
chrishtr authored
Previously, any image animating would trigger low-quality filters for all images during the animation timer window. Now only do so for images that are actually animating. BUG=583238 Review URL: https://codereview.chromium.org/1685933002 Cr-Commit-Position: refs/heads/master@{#374738}
-
bcwhite authored
Writing to disk via data()/used() creates a file of the minimum possible size which exposed an off-by-one bug in a corruption check. BUG= Review URL: https://codereview.chromium.org/1654053002 Cr-Commit-Position: refs/heads/master@{#374737}
-
Reilly Grant authored
This patch will have to be landed manually because line ending changes are mangled by the CQ. Local presubmit tests pass. BUG=None R=creis@chromium.org Review URL: https://codereview.chromium.org/1680333003 . Cr-Commit-Position: refs/heads/master@{#374736}
-
estade authored
this is a revert of a change I made here: https://codereview.chromium.org/1637203002/diff/60001/chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.cc BUG=585522 Review URL: https://codereview.chromium.org/1690443002 Cr-Commit-Position: refs/heads/master@{#374735}
-
timav authored
MediaCodecAudioDecoder is an audio decoder that uses Android MediaCodec API and implements the AudioDecoder interface, i.e. it can be attached to the DecoderStream and used in the Spitzer pipeline directly. This CL only defines its interface and have notes about possible implementation. BUG=542910 Review URL: https://codereview.chromium.org/1685483002 Cr-Commit-Position: refs/heads/master@{#374734}
-
tzik authored
base::Callback will have extra template parameters with default values. But manual forward declaration causes a compile error on the parameter addition. This CL unifies the forward decls for its preparation. BUG=554299 Review URL: https://codereview.chromium.org/1658813003 Cr-Commit-Position: refs/heads/master@{#374733}
-
mathp authored
BUG=None Review URL: https://codereview.chromium.org/1688783004 Cr-Commit-Position: refs/heads/master@{#374732}
-
lushnikov authored
The message removes alignment of search results to the right of status bar. BUG=585853 R=pfeldman, dgozman Review URL: https://codereview.chromium.org/1689743002 Cr-Commit-Position: refs/heads/master@{#374731}
-
scottmg authored
R=sky@chromium.org BUG=558054 Review URL: https://codereview.chromium.org/1684843002 Cr-Commit-Position: refs/heads/master@{#374730}
-
aberent authored
Previously this was enabled through the (lock screen) RemoteControlClient, but this was removed in https://codereview.chromium.org/1652163002/. Reenable it through the notification's MediaSessionCompat. BUG=585393 Review URL: https://codereview.chromium.org/1679923005 Cr-Commit-Position: refs/heads/master@{#374729}
-
dtseng authored
TEST=reproduction in bug no longer occurs. BUG=576607 Review URL: https://codereview.chromium.org/1668973002 Cr-Commit-Position: refs/heads/master@{#374728}
-
senorblanco authored
BUG=585692,585211 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel Review URL: https://codereview.chromium.org/1684173002 Cr-Commit-Position: refs/heads/master@{#374727}
-
lwchkg authored
ProfileInfoCache is being refactored into ProfileAttributesStorage and ProfileAttributesEntry, which use profile paths instead of numerical indices in the interface. See https://codereview.chromium.org/1599013002/ for details. This CL adds an comparator for sorting ProfileAttributesEntry, and also converts the calls in c/b/ui/app_list to use the new interface. BUG=305720 Review URL: https://codereview.chromium.org/1631373003 Cr-Commit-Position: refs/heads/master@{#374726}
-
rkuroiwa authored
- Hosts work even if the touch size is not clamped. BUG=461526 Review URL: https://codereview.chromium.org/1682133002 Cr-Commit-Position: refs/heads/master@{#374725}
-
sigbjornf authored
TBR=oilpan-reviews BUG=503491 Review URL: https://codereview.chromium.org/1688893002 Cr-Commit-Position: refs/heads/master@{#374724}
-
thakis authored
This has the effect of not copying dbghelp.dll into the nacl toolchain dir. Doing this isn't really harmful, but also not useful. Follow-up to https://codereview.chromium.org/1683793003/ BUG=460506, 461160, 498033 Review URL: https://codereview.chromium.org/1688903002 Cr-Commit-Position: refs/heads/master@{#374723}
-
nacl-deps-roller authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/0bab2ce2cf6d..49db56d2728a $ git log 0bab2ce2c..49db56d27 --date=short --no-merges --format='%ad %ae %s' 2016-02-10 mseaborn PNaCl dynamic linking: Enable tests in more cases 2016-02-10 mseaborn PNaCl dynamic linking: Add test of imports referenced by global variables CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build TBR=mseaborn@chromium.org Review URL: https://codereview.chromium.org/1679373003 Cr-Commit-Position: refs/heads/master@{#374722}
-
robliao authored
BUG=426656 Review URL: https://codereview.chromium.org/1687103002 Cr-Commit-Position: refs/heads/master@{#374721}
-
mathp authored
Upcoming DEPS change in https://codereview.chromium.org/1674373003/ conflicts with this file. BUG=585286 Review URL: https://codereview.chromium.org/1688913002 Cr-Commit-Position: refs/heads/master@{#374720}
-
sky authored
These two places may create native_widgets. We want to route to the factory first, else the wrong thing can happen. BUG=581198 TEST=none R=ben@chromium.org Review URL: https://codereview.chromium.org/1686153003 Cr-Commit-Position: refs/heads/master@{#374719}
-
tommycli authored
Hijacked from https://codereview.chromium.org/1607833004/. dschuyler reported the problem and suggested a patch. BUG=NONE Review URL: https://codereview.chromium.org/1608103002 Cr-Commit-Position: refs/heads/master@{#374718}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/f398a005cf9c..3486501058c0 $ git log f398a005c..348650105 --date=short --no-merges --format='%ad %ae %s' CQ_INCLUDE_TRYBOTS= TBR=catapult-sheriff@chromium.org Review URL: https://codereview.chromium.org/1690663002 Cr-Commit-Position: refs/heads/master@{#374717}
-
gmanikpure authored
[Chromedriver] Enabling java tests ClickScrollingTest & WindowSwitchingTest on android waterfall bots. BUG=chromedriver:1006 , chromedriver:1044 Review URL: https://codereview.chromium.org/1562803004 Cr-Commit-Position: refs/heads/master@{#374716}
-