GitLab

This adds in a new function, PartitionRellocGenericFlags, which allows
invoking realloc with passed in flags. This in turn allows for
controlling behaviours like if the call should return null or OOM when
unable to satisfy a request. The existing method
PartitionRootGeneric::Realloc has been refactored to use this new
function with no flags, so there only needs to be one implementation.

BUG=chromium:783022

Change-Id: Iee783874b16b56efdaa1ad0bd0dd8f0b485c68f3
Reviewed-on: https://chromium-review.googlesource.com/1044971
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556862}

Change-Id: I8bafe64117d7247b7806e1d64d6e7e793078877c
Reviewed-on: https://chromium-review.googlesource.com/1028452Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556861}

For mustash we are building the window service code into ash as a
library. Remove the switch that ran the window service code as a
separate mojo service.

Bug: 838597
Test: bots
Change-Id: Ibf76fc2616a221a04776a955ef134b43a1b90bfe
Reviewed-on: https://chromium-review.googlesource.com/1048945Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556860}

This CL logs the Windows.PostOperationState.DeleteFile.* and
Windows.FileSystemError.DeleteFile.* histograms to shed some light on
when and why deletes fail on Windows. These will help inform subsequent
changes to our delete strategy to be sure that we don't make things
worse.

BUG=599084

Change-Id: Ieefdd6a98a7d6636f7cfb2cffd4685e32bf00283
Reviewed-on: https://chromium-review.googlesource.com/1044193
Commit-Queue: Greg Thompson <grt@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556859}

This patch adds unit tests to record the current behavior of bidi
adjustment in hit testing.

Test cases generated by https://jsfiddle.net/zxdavu94/8/
Baselines matched by https://jsfiddle.net/fyj66tn9/

Bug: 811502
Change-Id: I334adc887794fa5dc3d5bf57b2fd5c47518f40a1
Reviewed-on: https://chromium-review.googlesource.com/1049268
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556858}

This adds more startup traces inside WebViewChromium.init, with the goal
of identifying what is responsible for the 8 ms chunk of unaccounted
work.

Because there is no obvious suspect for such a long duration of time,
this adds a couple different logs:

 * Invoking createWebViewContentsClientAdapter (intentionally logged
   outside the body of the method, to measure Class loading)
 * checkThread

Bug: 838702
Test: N/A
Change-Id: Ic3029d897f66ddad09cf0c41d49689fdf7833d5a
Reviewed-on: https://chromium-review.googlesource.com/1048485
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556857}

Java adjustSelectionByCharacterOffset() will be triggered if
|TextClassifier| API thinks we should adjust previous selection, the
renderer FrameInputHandlerImpl::AdjustSelectionByCharacterOffset() is
called with the need to show context menu later.

Eventually it will call EventHanlder::ShowNonLocatedContextMenu(),
which will give us the left selection bound's middle point as the new
point for MouseEvent.

In ContextMenuController#ShowContextMenu() there is another hit test
based on this point. In some cases, this point is under other HTML
element, so we won't get current selection text based on the hit test
result.

Later in SelectionPopupController::ShowSelectionMenu() we checked that
if the selection text is empty and this is non-editable element, we
won't call Java side SelectionPopupControllerImpl#showSelectionMenu().

Users are expecting context menu, but there won't be one.

In this CL, we set |data.selected_text| when |source_type| is
|kMenuSourceAdjustSelection|. Hit test isn't needed in this case.

Bug: 840007, b/78631924
Change-Id: I9631773655300b2fc1dc5f84faa161093fae900f
Reviewed-on: https://chromium-review.googlesource.com/1045510Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556856}

In addition, we also now activate the widget on Show.

Bug: b:79375309
Change-Id: I7054d12edbcc94064fccd8a13ff0c507eda9c9d6
Reviewed-on: https://chromium-review.googlesource.com/1048805Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#556855}

Dismissing the touch handles is redundant since clearing the selection
already hides them.

Change-Id: I0a9d6fc59cec6b00a6e9aa5d1c6e716f91976872
Reviewed-on: https://chromium-review.googlesource.com/1036201Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556854}

The standard got updated to invalidate the internal slot after
a setParameters() call to enforce having a single matching
getParameters() call.

Bug: 803494
Change-Id: Ia6b1483b908c3ef29c31fdcf2fb8014735cea322
Reviewed-on: https://chromium-review.googlesource.com/1047426
Commit-Queue: Florent Castelli <orphis@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556853}

Bug: 812051
Change-Id: I32375672b2fef31603c2eefdd13fd60a12a40206
Reviewed-on: https://chromium-review.googlesource.com/1050435Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556852}

This CL moves GPU related code in SkiaOutputSurfaceImpl into a new class
SkiaOutputSurfaceImplOnGpu. This new class is created, used and destroyed
on the GPU thread.

Bug: 824382
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Ib5809b1b42b73e296344be4459058b52b36fee6a
Reviewed-on: https://chromium-review.googlesource.com/1017237
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556851}

Before this CL, if the list of configured proxies to use as Data
Reduction Proxies changes while a request to a previously configured
Data Reduction Proxy server is in-progress, then DRP-specific bypass
logic and metrics wouldn't be applied to that response since its proxy
server doesn't match the currently configured proxies.

To solve this, this CL changes Chrome to keep track of the two most
recent previous proxy configurations, such that it treats any proxy that
matches the current configuration or these old configurations as a Data
Reduction Proxy.

This CL also includes some clean up and minor miscellaneous
refactoring/optimizations.

Bug: 839140
Change-Id: I93ea5c45723aabea2f6a2a4960ad72132f5c30b9
Reviewed-on: https://chromium-review.googlesource.com/1045025Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Scott Little <sclittle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556850}

This helps system administrators notice when compromised renderer
processes are trying to access cross-site data.

BUG=780106

Change-Id: Ib5b2581376d11ead1947bc385410ddf387dbc1a1
Reviewed-on: https://chromium-review.googlesource.com/989654Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556849}

This should fix the problem with sending 2 requests to iTunes servers
with cases of StoreKit handling.

Bug: 838359
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I14ef3b3053391187d34885be939d598827e7bb6d
Reviewed-on: https://chromium-review.googlesource.com/1043648Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556848}

TBR=elawrence@chromium.org

Change-Id: If90c8ec8a9600e8a4600ab655f3d5e1898d12aab
Reviewed-on: https://chromium-review.googlesource.com/1048832Reviewed-by: Nick Harper <nharper@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556847}

Material Refresh - ensure the currently hovered tab is always painted on top of all the other inactive tabs, but not the active tab.

Paint the inactive tab which is hovered right before the active tab so it appears above the others but not the active tab.

Bug: 836424
Change-Id: Ic21e72177de41f793425de48f231031efed136a8
Reviewed-on: https://chromium-review.googlesource.com/1048172
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556846}

These are used when the window:
- is an app
- is inactive
- is restored
- does not have a custom color (as does the files app, for example)

They add a 1dip thick white-ish border around the inside of the top
of the window frame. The border is invisible to the naked eye:
the majority of the frame is #fdfeff and the part with the border is
#fefeff.

Active/inactive states these days are signaled via shadows and it's
safe to call this border asset completely vestigial.

Change-Id: I6d14ae24928ddf87c1786aaa271b54f03256fc6f
Reviewed-on: https://chromium-review.googlesource.com/1048181
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556845}

That prevents linker on Mac from dead-stripping the function, as it's actually used
but is being called indirectly using dlsym().

Bug: 837477
Change-Id: Ic02066132cba3e1f9deb977219b4f3ec13207991
Reviewed-on: https://chromium-review.googlesource.com/1050505Reviewed-by: Jonathan Metzman <metzman@chromium.org>
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556844}

Using wpt-import in Chromium cdc12d12.
With Chromium commits locally applied on WPT:
3055ddf8 "webrtc wpt: pass test function in more tests"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17159

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=danyao

No-Export: true
Change-Id: I60ee6bd59679d03f12bfba023cfba9d67a69f915
Reviewed-on: https://chromium-review.googlesource.com/1050069
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556843}

This CL switches all system_health benchmarks to the histogram pipeline.

Bug: 744736
Change-Id: Icb97397ec417d27220e489651cc51591757d8c9e
Reviewed-on: https://chromium-review.googlesource.com/1048626Reviewed-by: Emily Hanley <eyaich@chromium.org>
Commit-Queue: Ethan Kuefner <eakuefner@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556842}

Non-functional change: Clarify description of metric QueryTime2, that it
includes synchronous providers.

Change-Id: I65dbbe9bad3418966c3ca34386ef01946e74dde7
Reviewed-on: https://chromium-review.googlesource.com/1048316Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Kevin Bailey <krb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556841}

When violating optimized image policies, images should be rendered with
inverted color. This CL
https://chromium-review.googlesource.com/c/chromium/src/+/1030758
added the inverting code in style.
This CL moves the inverting code into paint instead.

Tests will be added as image policies are implemented. But this has
been manually verified to work.

Bug: 837346
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I99f4e8611295c878f5feb6bac8f72883f4e8c70c
Reviewed-on: https://chromium-review.googlesource.com/1037783
Commit-Queue: Luna Lu <loonybear@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556840}

This will allow me to make AXPosition implementations simpler because there will be less difference between AXNode objects and AXPlatformNode / BrowserAccessibility objects.
Also, we will be able to simplify our code in AXPlatformNode and its subclasses and remove the frequent call to data() on AXNode.
R=dmazzoni@chromium.org, aleventhal@chromium.org

Change-Id: Ib0e6ff205210ca0b2f1a5e766d98e42a89d3cd68
Reviewed-on: https://chromium-review.googlesource.com/1050006Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556839}

BUG=840381

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I90d32c586261ed2c492c3e639554ee61215ec492
Reviewed-on: https://chromium-review.googlesource.com/1049825Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556838}

Pixel_OffscreenCanvas2DResizeOnWorker is flaky across multiple GPUs.
Expand the test suppression.

Bug: 840394
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I009217c0c9d47d4bc854b8175e00064e70e78f8e
TBR: kbr@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1050067Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556837}

Bug: 812051
Change-Id: I47902739d2caaabe3646d52eb2d14688b5d1a7d0
Reviewed-on: https://chromium-review.googlesource.com/1039143
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556836}

Supervised users are deprecated, and Sync hasn't been working for them
for a while.

Bug: 829304
Change-Id: I30db644e5fecadeefe7b268fafd3fd0a67f68a0b
Reviewed-on: https://chromium-review.googlesource.com/1049650Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556835}

This was implemented for Chrome ~47 but never launched due to product
concerns. We can revisit this decision in time as there would still be
significant benefit, but hooking in to platform-provided push services
for a wake-up ping might be an approach that's preferable to keeping
Chrome around indefinitely.

The ScopedKeepAlive code will continue to be used, as that makes sure
that Chrome doesn't shut down while handling received messages.

Bug: 402456
Change-Id: I7e35e27c3f1dc79ce62d2479763b35565c402814
Reviewed-on: https://chromium-review.googlesource.com/1049979Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556834}

RenderViewImpl::SetFocusAndActivateForTesting is setting page level focus
which is not supported for out-of-process main frame. This CL adds an
early return for this case to avoid hitting CHECK during tests.

Bug: 839783
Change-Id: Ie1d613647f78e72a943fc35cc0366b96e84cdad5
Reviewed-on: https://chromium-review.googlesource.com/1049114Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556833}

After UI review, UI folks suggested to have a flag to turn "swipe to
navigation change" off although chrome://flags. Edge, Safari, and
Chrome(Mac) users asked Internet how to disable it (search for 'swipe
to navigate how to disable on [edge/mac/chrome]'. But Win 10 doesn't
have a specific setting. MacOS has the specific control and it works
for Chrome on Mac. Also we know the user can trigger this
unintentionally and be frustrated.

This flag might be maintained while we continue to improve it over time.

Bug: 647140
Change-Id: I8e855216fc834fd8f0acbb6011be12f13eda4cd7
Reviewed-on: https://chromium-review.googlesource.com/1047785
Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556832}

There is a glitch when the drag indicators slide in or out. The corners
stretch or squash a bit during animation before going back to normal
after animation ends.

This is known issue, since we animate the entire rect by applying
transform. The transform effects the rounded corners as well. The
transform is removed and the bounds are set at the end of animation,
so that the glitch is only seen during animation.

This patch fixes that by changing the indicators to not use a single rounded
rect anymore, but instead to use a new class which has two rounded
rect and a solid rect between them, with the solid rect
 covering the rounded corners so the final element looks like one
big rounded rect. On bounds changed, the two rounded
rects will get translated only, therefore preserving the rounded
edges, while the middle section will be the one shrinking or expanding.

There is some tricky logic to position the components of the new
view due to the animation and rtl, so added new test cases.

Test: covered by tests, manually all orientations and rtl
Bug: 824860
Change-Id: I183fa3de4e0a481ad2c7a208feec33a286505ad8
Reviewed-on: https://chromium-review.googlesource.com/1029191
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556831}

The omnibox and its security indicator remains on screen even when
in fullscreen mode, so there is no longer a need to disable fullscreen
for the UI refresh.

Bug: 840828
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I5eb89f2992fec399287807d77089a34af88d141c
Reviewed-on: https://chromium-review.googlesource.com/1050376Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556830}

Rename ash/system/web_notification to message_center/ since it holds
ash message center UI code rather than web notification related code.

Also fixed a few presubmit warnings.

Bug: 768439
Change-Id: Ifaf7b8795ebdebff482dc9ac25ab9961dcb6d939
Reviewed-on: https://chromium-review.googlesource.com/1047986
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556829}

Elipses have been removed from context menu strings per request from UX.

Bug: 832850
Change-Id: I7d54dd75ac4b44b8c4aaaaba9fff008af1e7972b
Reviewed-on: https://chromium-review.googlesource.com/1050373Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556828}

Pending floats are now automatically positioned as part of resolving the
BFC offset. Don't know why this one got left behind.

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Id089ab99e780fc5fb4638f8f1d63dc0d41195251
Reviewed-on: https://chromium-review.googlesource.com/1049967Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556827}

These are vestiges of gyp and can be removed.

Bug: None
Test: Build cast_shell_apk
Change-Id: I7cdbfe5f7b664def8103354b32be9ce502919bbc
Reviewed-on: https://chromium-review.googlesource.com/1048027Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Simeon Anfinrud <sanfin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556826}

Some tweaks in the instructions to make sure it's friendly to macOS.

Changed the path for clang-format since the current solution will
not work as it will output :
"Set CHROMIUM_BUILDTOOLS_PATH to use outside of a chromium checkout."

There is no way to tell QtCreator about CHROMIUM_BUILDTOOLS_PATH before
it runs clang-format so the solution is to point right away to the
right binary.

Change-Id: Icad9d6998063c2b70fc50027161c212063b06c25
Reviewed-on: https://chromium-review.googlesource.com/1044762Reviewed-by: Jianpeng Chao <chaopeng@chromium.org>
Commit-Queue: Alexis Menard <alexis.menard@intel.com>
Cr-Commit-Position: refs/heads/master@{#556825}

Bug: 75305
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Iaed1d7d2a5d70245bd38b5fd044428b4ee795ad5
TBR: kbr@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1048310Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556824}

Bug: 672962
TBR: piman@chromium.org
Change-Id: I5e9b9e40794e67c876ac2c2153c00d3ef0c2e099
Reviewed-on: https://chromium-review.googlesource.com/1050366Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556823}