- 10 Oct, 2019 40 commits
-
-
siyua authored
The idea is to move autofill bubble showing logic out of browser window to keep it short and clean. Also this extracted class can be a observer for autofill data saving and notify avatar so that avatar itself does not need to be such observers. Also add avatar button accessor in the ToolbarButtonProvider. Bug: 964127 Change-Id: I46f85f01b1da9d8d85d9049a1acd95ebe9bb2c21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845827 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#704474}
-
Yusuke Sato authored
This allows us to inject failures to the StartJob and StopJob functions for better unit test coverage. BUG=b:142144019 TEST=try Change-Id: I17ebd3ddd74cd78bb7b123a7fda0a377d53963ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850572Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#704473}
-
Nico Weber authored
This reverts commit 3a54e6fa. Reason for revert: Possibly no longer needed after #703693 disabled g2gtest()s in cross builds in a different way. Original change's description: > Don't build js2gtest()s in win/cross builds. > > Bug: 1010561 > Change-Id: Ic6b0d656af1944d9dbb16f5fb96d70fe1ad90f14 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835157 > Auto-Submit: Nico Weber <thakis@chromium.org> > Commit-Queue: Dan Beam <dbeam@chromium.org> > Reviewed-by: Dan Beam <dbeam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#702156} TBR=thakis@chromium.org,dbeam@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1010561 Change-Id: I7b8fd3399786da5d51b827b846d2b03c72efb337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851085 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#704472}
-
Darren Shen authored
As of cl/258693469, our code no longer uses ProcessText API, which has been deprecated. We delete the unused code. Bug: 1009903 Change-Id: I4d920d6b147df086c01fb4d5e3c18f31b5ed2f5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833018Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#704471}
-
Cathie Chen authored
Currently, the value of ScrollLeft / ScrollTop / ScrollTo for a box in Element is the offset to the origin of ScrollableArea(left-top corner). This behavior isn't consistent with Document-scroll or the behavior of other vendors either whose origin is ScrollOrigin. There're compatibility problems when the box has leftward or upwards scroll overflow direction. According to the Specification, the scroll x-coordinate of a leftward box is nonpositive, and the scroll y-coordinate of an upwards box is also nonpositive. With using the origin of ScrollableArea, the coordinate is always nonnegative. In order to fix it, this patch transforms the scroll coordinate of a box in Element interface to use ScrollOrigin as its origin. There are a few cases needed to recalculate the scroll coordinate to meet this change. Since the origin of scroll coordinate transforms from the ScrollableArea origin to ScrollOrigin(), current_coordinate is equal to old_coordinate - ScrollOrigin. E.g. current_scrollLeft = old_scrollLeft - ScrollOrigin().X(). This behavior is guarded by a feature flag. See intent to ship blink-dev thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/7X2CKPGeEa0 Bug: 721759 Change-Id: I0ceed62e6845c6e5cd976e59b36f292d60bb669c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700001Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Frédéric Wang <fwang@igalia.com> Commit-Queue: cathie chen <cathiechen@igalia.com> Cr-Commit-Position: refs/heads/master@{#704470}
-
Aaron Colwell authored
Updating naming in response to https://crrev.com/c/1848912 and the discussion on chromium-dev list. Bug: 842296 Change-Id: I35c512a9139c993225ea95e9e345c9f5ca46f673 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849208 Auto-Submit: Aaron Colwell <acolwell@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#704469}
-
Peter Kotwicz authored
This CL deletes AppBannerUiDelegateAndroid::OnNativeAppInstallStarted() AppBannerUiDelegateAndroid::OnNativeAppInstallFinished() which are unused as a result of http://crrev.com/c/1338337 BUG=1013004 Change-Id: I8d53baa1c8b8d324b18d89e5f0f84cc5c1c87f98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847673 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#704468}
-
David Staessens authored
This CL fixes some thread-safety issues in our video decoder tests. These might be responsible for some rare crashes we've been seeing when running the tests on our test infrastructure, but are not reproducible locally. Most callbacks will be triggered on the same thread that scheduled these, but this is not always the case. However WeakPtrs are not thread-safe, so this CL introduces functors that guarantee that WeakPtrs are only dereferenced on the thread that created them. This CL also adds an additional sequence check to make sure events are sent on the correct thread, and a comment is added about the use of base::Unretained for the video player event callback. TEST=./video_decode_accelerator_tests on samus BUG=981718 Change-Id: If04268953f9be5dabc4ec11759fb3223f45055cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1843998 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#704467}
-
Miyoung Shin authored
This CL converts IsolatedXRRuntimeProviderClientPtr and mojo::Binding<T> in chrome to the new Mojo type, and use pending_remote<T> in isolated_xr_service.mojom. Bug: 955171 Change-Id: I2c186d27cb3c3c346504a61ec70839346a21b033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847706 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#704466}
-
Lukasz Anforowicz authored
This CL is a follow-up for r694827 (Set |request_initiator| to the website, not to the content script's origin) which started selecting Chrome-Extension-specific factories based on a (newly-introduced) network::ResourceRequest::isolated_world_origin field (rather than the old network::ResourceRequest::request_initiator field). After this CL, the |initiator_specific_factories| and similar names are no longer accurate - this CL fixes this by changing such names to refer to isolated worlds. Ideally this CL would be part of r694827 - it is done as a separate CL to 1) keep r694827 smaller / more focused and 2) make sure that r694827 "sticks" first. Bug: 940068 Tbr: nasko@chromium.org, kinuko@chromium.org Change-Id: I02c75e97dc456a3961043af2d783bfb3a8e54e24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835972 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#704465}
-
Tiansong Cui authored
We have to pause BLE scan before setting scan parameters. This CL will make the API easier to use. Bug: internal b/140961065 Test: Build and run, check HCI logs Change-Id: Ia63b392ab09505d3d284d150d71b07d134d8a4e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850801Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Tiansong Cui <tiansong@google.com> Auto-Submit: Tiansong Cui <tiansong@google.com> Cr-Commit-Position: refs/heads/master@{#704464}
-
Nico Weber authored
win: Assert goma is not used with cl.exe, and stop setting symbol_level to 1 in non-clang goma builds. We're removing support for MSVC on goma, so this combination of toggles will be impossible soon. Assert it's unused, and remove a bit of code I found that checked for this combination. Bug: 1006238 Change-Id: Id00f887d37139262970d9d6a1a9c78fc18bb0bb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846674Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#704463}
-
yilkal authored
Bug: 850328 Change-Id: I7bc5fcd828f7f47230c4c967a28fb24525fd59b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838382 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#704462}
-
Alex Cooper authored
A page may not be submitting frames because blink isn't allowing it to submit frames based on various states. In these cases, the browser should not be showing UI indicating that the page is unresponsive. This change adds plumbing for blink to inform the browser process that it is the one throttling frame requests so that the browser can suspend any timeout logic, and potentially (in the future) take over rendering a more customized message. Bug: 1009813 Change-Id: I2d1a3bb609eb305225493b67c630b32999735a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841585Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Giovanni Ortuño Urquidi authored
Replaces usage of DataPipe, which is deprecated, with CreateDataPipe. There is no change in behavior, if the pipe fails to be created we will crash. Bug: 1012150 Change-Id: Ib077284f14c7232a0a78afcf0d1d3e1cc4f07380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846621Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#704460}
-
nancy authored
BUG=1005640 Change-Id: I441c389203be3c7eb1f06ddbdce09d3441677958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830483 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#704459}
-
Aidan Beggs authored
heuristic. This CL adds a set of the top 500 keywords to the binary at compile time, to enable usage of this information in the phishing detection keywords heuristic. Additionally, this CL cleans up and refactors the compile-time processing and embedding of information related to the top 500 keywords, into the binary. Bug: 1012476 Change-Id: I9d75d962d0425b0f037c87a5d6801c7c9299c476 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849183 Commit-Queue: Aidan Beggs <beggs@google.com> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#704458}
-
Alexander Timin authored
NativeFileSystem uses RenderFrameHost::IsCurrent which is problematic for bfcache, as it means that for some frames the permissions might be requested while the frame is in back-forward cache (IsCurrent is true for iframes) and for some the requests will be denied and will not be resumed after restoring from back-forward cache. Disable back-forward cache as soon as we make a request for now. Some background on why we sometimes need to disable bfcache: https://docs.google.com/document/d/1NjZeusdS1kyEkZyfLggndU1A6qVt0Y1sa-LRUxnMoK8 R=mek@chromium.org CC=bfcache-bugs@chromium.org BUG=1001087 Change-Id: I6a1f0153df4c13fbaba900af049e0c852d340513 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837813Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#704457}
-
John Emau authored
This change adds basic tests that capture current behavior around the Audio Context Selector. It is meant as a start and not a complete list of tests, more tests should be added in the future. This also indirectly tests the UI.ListModel, UI.SoftDropDown, and UI.ToolbarItem. Change-Id: I7506c06e6cf8b865ab2645c9e9e4004df162e629 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824060Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Mandy Chen <mandy.chen@microsoft.com> Commit-Queue: John Emau <John.Emau@microsoft.com> Cr-Commit-Position: refs/heads/master@{#704456}
-
Gyuyoung Kim authored
To reduce pre-processed size of header files have been including foo.mojom-blink.h, this CL replaces .mojom-blink.h with .mojom-blink-forward.h in blink header files. This CL has no behavior changes and following CLs will continue replacing them more. Bug: 1001360 Change-Id: I467c6ee86c44e581a6fee3cdcb8a5fdf6ed29aa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847599Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#704455}
-
Kenichi Ishibashi authored
Bug: 692909 Change-Id: If4c656288728f6c52440fc4b2e834e3e2b6e8c61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846611Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#704454}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5ee5b8853db6..992c5b481bab git log 5ee5b8853db6..992c5b481bab --date=short --no-merges --format='%ad %ae %s' 2019-10-09 engeg@google.com buildbucket_api: Add retry to GetBuild and extend sleep duration Created with: gclient setdep -r src/third_party/chromite@992c5b481bab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ifbc28622327883953b1353a19241e44bcb2626c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849635Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704453}
-
Sanket Joshi authored
Bug: 1012387 Change-Id: I9627134583db5f0b0c8390ccf4792b5287a5a0b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847869Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
-
Anand K. Mistry authored
When the dropdown is opened, the entire element should appear as a single element, with no space between the input field and the opened dropdown. http://go/siygs BUG=977313 Change-Id: I81912cb7f6101a8fc8a54f60a4095e42a210ca8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847703 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
-
Yulun Wu authored
This reverts changes from: CL:1808426 which caused the ripple circle around the page switcher button to get cut off. Bug: 1011518 Change-Id: I5da49ce4122cdb5dbf083eda6a8f23ec371f5946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846012Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#704450}
-
Avery Musbach authored
Change-Id: Ie673d63862039d35a1c769db62c5d59562d4fde9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850725 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#704449}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ebc6287a..8374dec2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ide31ca94326b5f09a84e8946cc70248dd1596643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850174Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704448}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/cb1eb4896663..71681bf1e84a git log cb1eb4896663..71681bf1e84a --date=short --no-merges --format='%ad %ae %s' 2019-10-09 ehmaldonado@chromium.org git-common: Explicitly specify utf-8 when encoding. 2019-10-09 tandrii@google.com git cl: record additional tag for builds triggered via retry-failed. Created with: gclient setdep -r src/third_party/depot_tools@71681bf1e84a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1012773,chromium:445502 Change-Id: Idb99126e85be36c35ccd468ea5a0824a049baebc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850927Reviewed-by:
-
John Budorick authored
results in a screen width of 480dp, which should put it in the middle of large portrait phones per https://bit.ly/311hcJ1 Bug: 922145 Change-Id: I7bb00196dfa48a53467dc35646b81160f9fd8892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849429 Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#704446}
-
Sophie Chang authored
Bug: 1001194 Change-Id: I91e678bf04c15864618ec69fa1e2fa20c6c43af3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848153 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#704445}
-
Meilin Wang authored
This change extends the expiration date of AssistantExitPoint UMA histogram for another one year, as this UMA will still be actively in use for collecting data. Bug: None. Test: manually. Change-Id: Ic963434386363c12b9f65e6c666954e72f4847c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848939Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#704444}
-
Nate Fischer authored
No change to logic. This cleans up a temporary adapter version of AwSafeBrowsingConfigHelper, as it is no longer needed by downstream code. Bug: 934597 Test: ninja -C out/Default system_webview_google_apk Change-Id: Iac5de65423e1444b14b5c2e249c24764d97f40d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845884 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#704443}
-
David Tseng authored
This change breaks up incremental change utterances spoken by ChromeVox. For example: - Search+/ - type 'chromi' - speak 'Chromi, ', ' um, an open source project' - type 'u' - speak 'Chromiu, ' 'm, an open source project'. - Change-Id: Ic34cfac814d8d376a041ae21c0cee44f75c9906e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832529 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#704442}
-
Makoto Shimazu authored
This CL converts base::Bind to BindOnce or BindRepeating, and also changes relevant base::Callbacks or base::Closures to appropriate types. This CL is split from https://crrev.com/1831621. This CL was uploaded by git cl split. R=reillyg@chromium.org Bug: 1007760 Change-Id: I915acf6516bd67d6c244dfb2fd6688df7717ace6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849534 Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#704441}
-
yilkal authored
Bug: 850328 Change-Id: Iae5af42094a9ac0943b7a50f270abaae11b23f23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838521 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
-
Miyoung Shin authored
This CL converts IsolatedXRGamepadProvider{Ptr, Request} in device to the new Mojo type, and use pending_receiver<IsolatedXRGamepadProvider> in isolated_xr_service.mojom. Bug: 955171 Change-Id: Ib42d1a7f36c748849bbab5f058fbe7f2c0d129e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847531Reviewed-by:Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts ColorPanel and ColorPanelHost to new Mojo types using PendingReceiver, Receiver, PendingRemote, Remote and SelfOwnedReceiver. Bug: 955171 Change-Id: Ie147c1bde436e427ca086a21a5ba7dd16e33b26a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847491Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#704438}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0947ef87. With Chromium commits locally applied on WPT: 23748e60 "Change text directive to text=" 2f7c5562 "Fetch Metadata: Split `sec-fetch-dest` out from other headers' tests." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I7e34273895ad7b98d12412bce287f65a233f5b2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849952Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704437}
-
Ken Rockot authored
All clients can now make direct calls into LevelDBDatabaseImpl. This deletes the LevelDBDatabase mojom interface definition as well as the OpenOptions struct, its corresponding type traits and tests, and the leveldb_service_unittests test suite which was only used to test the latter code. Bug: 1000959 Change-Id: Ibb542604885e16abbf135e9af6ba9b3777aae026 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838293 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
Darren Shen authored
In a previous CL [1], we fixed a bug with autocapitalize="off". However, we forgot to handle autocapitalize="sentence", because in the old code, "sentence" was automatically handled as a default case, but we changed the default behaviour to "none", so sentence was treated as none. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1762254 Bug: 995703 Change-Id: Id1e634386676c62270d00f365004bebbc170538a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850673Reviewed-by:
-
