- 15 Sep, 2016 40 commits
-
-
bashi authored
This is the first CL to move memory_coordinator outside components/. Also, per discussion on [1], this CL removes MemoryCoordinatorClient from HistoryBackend. We can re-add it if needed. [1] https://codereview.chromium.org/2297243004/#msg14 BUG=644022 Review-Url: https://codereview.chromium.org/2311723002 Cr-Commit-Position: refs/heads/master@{#418766}
-
ikilpatrick authored
This patch does the plumbing from the animationworklet to the globalscope to import scripts etc. BUG=567358 Review-Url: https://codereview.chromium.org/2312493002 Cr-Commit-Position: refs/heads/master@{#418765}
-
yosin authored
This patch converts "editing/inserting/insert-div-010.html" to use w3c test harness to simplify test script for improving code health. BUG=n/a TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2338223002 Cr-Commit-Position: refs/heads/master@{#418764}
-
yosin authored
This patch converts "editing/inserting/insert-div-009.html" to use w3c test harness to simplify test script for improving code health. BUG=n/a TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2340713002 Cr-Commit-Position: refs/heads/master@{#418763}
-
yurak authored
For custom built-in elements: https://html.spec.whatwg.org/multipage/scripting.html#element-definition 7. If an element interface is provided for the extends option, it is assumed to be a customized built-in element. 7.1. If element interface is valid custom element name, throws NotSupportedError DOMException https://html.spec.whatwg.org/multipage/scripting.html#valid-custom-element-name 7.2. If element interface is HTMLUnknownElement, throws NotSupportedError DOMException https://html.spec.whatwg.org/multipage/dom.html#elements-in-the-dom:element-interface 7.3. localName set to extends value and not the define-name A -expected.txt file was included since this isn't implemented yet. BUG= Review-Url: https://codereview.chromium.org/2321363002 Cr-Commit-Position: refs/heads/master@{#418762}
-
davaajav authored
1. attributeChangedCallback should be fired only from the elements in observedAttributes 2. Checks for cases when converting observedAttributes to sequence<DOMString> should throw TypeError https://heycam.github.io/webidl/#create-sequence-from-iterable BUG=643049 Review-Url: https://codereview.chromium.org/2321903003 Cr-Commit-Position: refs/heads/master@{#418761}
-
mgiuca authored
WebShare.ApiCount is needed (in addition to the existing use counter) to get the total number of calls to the API, not de-duplicated per page view. BUG=636288 Review-Url: https://codereview.chromium.org/2228403002 Cr-Commit-Position: refs/heads/master@{#418760}
-
flandy authored
These buttons will appear in same toolbar as "Add background-color" and "Add color." BUG=639095 Review-Url: https://codereview.chromium.org/2324313002 Cr-Commit-Position: refs/heads/master@{#418759}
-
sadrul authored
gpu thread in chrome gpu process uses different types of message-pumps in different platforms (e.g. MessagePumpGpu on Windows etc.) Make sure mus gpu does the same. Also, set the gpu thread priority to DISPLAY, on android and cros. BUG=643746 Review-Url: https://codereview.chromium.org/2331453004 Cr-Commit-Position: refs/heads/master@{#418758}
-
tkent authored
* Mark collectChildrenAndRemoveFromOldParent |inline| There is only one callsite. * collectChildrenAndRemoveFromOldParentWithCheck() returns bool It makes callsites simpler. * We don't need to return |nullptr| in a case of hadException(). Callsites should check hadException() before referring the return value. * Remove useless local variables. * Use functors in parseInsertBefore() and parserAppendChild(). This CL has no behavior changes. Review-Url: https://codereview.chromium.org/2343513002 Cr-Commit-Position: refs/heads/master@{#418757}
-
khushalsagar authored
Removes all external access to LayerTreeHost except for tests. Next change will remove it from Layer altogether. BUG=628683 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2331983002 Cr-Commit-Position: refs/heads/master@{#418756}
-
harukam authored
Repeat mode can be 3 states. A) Stop playing when all songs have been played. B) Keep on playing by same order when all songs have been played. C) Set a single song to repeat. Created a repeat-button that has 1 state (A) as the OFF, and 2 states (B/C) as the ON in toggle-button in order to show all 3 states visually. BUG=524884 TEST=manually tested Review-Url: https://codereview.chromium.org/2305623003 Cr-Commit-Position: refs/heads/master@{#418755}
-
danakj authored
After this, OutputSurface is only used for the display compositor (ie cc::Display and friends). And the CompositorFrameSink API is used for the layer tree compositor (ie LayerTreeHost and friends). OutputSurfaceClient is also forked to an identical CompositorFrameSinkClient. For now the two are identical, after this they can diverge and we can delete things on each that doesn't apply anymore. Broad renamings are: SynchronousCompositorOutputSurface -> SynchronousCompositorFrameSink blimp::DelegatedOutputSurface -> BlimpCompositorFrameSink BlimpOutputSurfaceClient -> BlimpCompositorFrameSinkProxy BlimpOutputSurface -> BlimpCompositorFrameSinkProxyClient SurfaceDisplayOutputSurface -> DirectCompositorFrameSink TestDelegatingOutputSurface -> TestCompositorFrameSink CompositorOutputSurface -> RendererCompositorFrameSink mus::OutputSurface -> mus::CompositorFrameSink TBR=piman BUG=606056 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2337913003 Cr-Commit-Position: refs/heads/master@{#418754}
-
jbauman authored
Threads seem to be exiting unexpectedly, so to help debugging set a crash key if an unexpected WM_QUIT message is received. BUG=647068 Review-Url: https://codereview.chromium.org/2342713002 Cr-Commit-Position: refs/heads/master@{#418753}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/8484270f6d2c..5148bd4b2be6 $ git log 8484270f6..5148bd4b2 --date=short --no-merges --format='%ad %ae %s' 2016-09-14 nednguyen Fix typo with setting chrome category in TimelineBasedMeasurement 2016-09-14 nednguyen Revert of Revert "[Clock sync] Use clock sync manager to convert trace event timestamps" (patchset #1 id:1 of https://codereview.chromium.org/2345463003/ ) 2016-09-14 charliea Revert "[Clock sync] Use clock sync manager to convert trace event timestamps" 2016-09-14 nduca Add benjhayden@ to tracing OWNERS 2016-09-14 nednguyen Add breakdown UI for TTI & FMP metrics TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2340943002 Cr-Commit-Position: refs/heads/master@{#418752}
-
bnc authored
Review-Url: https://codereview.chromium.org/2339473005 Cr-Commit-Position: refs/heads/master@{#418751}
-
wangxianzhu authored
When we invalidate a media control, we need to invalidate the whole subtree because not only the top-level layout object but also the descendants may paint differently. BUG=645225 TEST=paint/invalidation/video-play-no-source-under-invalidation.html Review-Url: https://codereview.chromium.org/2343713003 Cr-Commit-Position: refs/heads/master@{#418750}
-
einbinder authored
Also stop matched brackets from breaking through syntax highlighting. BUG=none Review-Url: https://codereview.chromium.org/2334073002 Cr-Commit-Position: refs/heads/master@{#418749}
-
asargent authored
When we changed content verification to strict mode (crbug.com/601512), it turns out that the code for downloading missing verified_contents.json files from the webstore had two longstanding bugs that we never noticed due to insufficient tests: a) Returning the results of a boolean expression as an integer b) Use after free of an object The end result is that when the patch for crbug.com/601512 hit stable, many users became unable to run the EFF's HTTPS Everywhere and Privacy Badger extensions because those are uploaded via a special process where the webstore does not have a copy of their private key and cannot include the verified_contents.json file in the .crx file; rather we rely on being able to download it after install but fail due to the above mentioned bugs. This patch fixes the bugs and also introduces a change which clears the corruption "disable reason" on extension autoupdate, so that users who had the extension disabled because of this bug can get it re-enabled automatically by an extension autoupdate. BUG=643814 Review-Url: https://codereview.chromium.org/2336403002 Cr-Commit-Position: refs/heads/master@{#418748}
-
wangxianzhu authored
BUG=637316 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2343673003 Cr-Commit-Position: refs/heads/master@{#418747}
-
arthursonzogni authored
This patch prevents the FrameLoader to send 'complete' notification when there is still a navigation handled by the client ongoing. This bug caused several tests to end too early and fail. In contrast, there were tests that passed previously, but actually fail. R=japhet@chromium.org BUG=576261 Review-Url: https://codereview.chromium.org/2269653002 Cr-Commit-Position: refs/heads/master@{#418746}
-
lshang authored
To prevent long search terms to go out of card-title bar. BUG=644229 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2318343004 Cr-Commit-Position: refs/heads/master@{#418745}
-
mostynb authored
The build should fail early if //device/media_transfer_protocol is included with dbus explicitly disabled. BUG=632297 Review-Url: https://codereview.chromium.org/2333573003 Cr-Commit-Position: refs/heads/master@{#418744}
-
thomasanderson authored
BUG=620169 R=dpranke@chromium.org Review-Url: https://codereview.chromium.org/2338373003 Cr-Commit-Position: refs/heads/master@{#418743}
-
agrieve authored
BUG=646165 Review-Url: https://codereview.chromium.org/2341903002 Cr-Commit-Position: refs/heads/master@{#418742}
-
mdjones authored
The "close all incognito tabs" notification can close tabs when chrome is not in the foreground. This action bypasses the animation that would ordinarily reset the normal button's opacity. In order to correctly reset this opacity, setIsIncognito will be called even if the button is not visible. BUG=642682 Review-Url: https://codereview.chromium.org/2335403004 Cr-Commit-Position: refs/heads/master@{#418741}
-
michaeln authored
BUG=584574 Review-Url: https://codereview.chromium.org/2333893002 Cr-Commit-Position: refs/heads/master@{#418740}
-
mdjones authored
BUG= Review-Url: https://codereview.chromium.org/2325623003 Cr-Commit-Position: refs/heads/master@{#418739}
-
littledan authored
BUG=chromium:646199 Review-Url: https://codereview.chromium.org/2340583004 Cr-Commit-Position: refs/heads/master@{#418738}
-
bpastene authored
Will switch to gce bot if nothing regresses. BUG= Review-Url: https://codereview.chromium.org/2338353002 Cr-Commit-Position: refs/heads/master@{#418737}
-
pdr authored
The PropertyTreeState does not include scroll information and should be renamed GeometryPropertyTreeState to reflect the real behavior. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2338373004 Cr-Commit-Position: refs/heads/master@{#418736}
-
gangwu authored
mplement SharedModelTypeProcessor::GetAllNodes for USS, so "Sync Node Browser" tab in chrome://sync-internals/ will show USS data. BTW, modelTypeWorker already ignore the root folder from server. BUG=645303 Review-Url: https://codereview.chromium.org/2319973003 Cr-Commit-Position: refs/heads/master@{#418735}
-
bnc authored
Minor cleanup after https://crrev.com/2217173002 to reduce code divergence. BUG=488484 Review-Url: https://codereview.chromium.org/2344613002 Cr-Commit-Position: refs/heads/master@{#418734}
-
rdevlin.cronin authored
SyncExtensionFunctions, AsyncExtensionFunctions, ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are deprecated. Remove ChromeSyncExtensionFunctions from: - launcher_search_provider - hotword_private - i18n - identity - omnibox BUG=634140 Review-Url: https://codereview.chromium.org/2344653002 Cr-Commit-Position: refs/heads/master@{#418733}
-
mattm authored
This also removes the native hostname checking workarounds. BUG=570909,588789,621684 Review-Url: https://codereview.chromium.org/2101303005 Cr-Commit-Position: refs/heads/master@{#418732}
-
chrome://settingsmsw authored
Avoid Shell and PowerStatus access for display/power options. BUG=646558,548429,644348 TEST=No crash accessing chrome://settings in chrome --mash. R=stevenjb@chromium.org Review-Url: https://codereview.chromium.org/2341783005 Cr-Commit-Position: refs/heads/master@{#418731}
-
mariakhomenko authored
Adds new color for the launch button and changes star assets to match. Also changes to the new Play logo. BUG=646929 Review-Url: https://codereview.chromium.org/2335153003 Cr-Commit-Position: refs/heads/master@{#418730}
-
steel authored
This CL changes the extensions build to have BUILD.gn's in (almost) all leaf directories. This accomplishes several things, a.) Makes it very clear of what files belong to which component/API. For example, to see which files exist in the audio API, one needs to parse the massive single //extensions/browsers/BUILD.gn to find the main API source list, then look if any of the exception conditions (is_chromeos, is_linux, etc) also contain any of the audio API files. This is now all in one //extensions/browser/api/audio/BUILD.gn, making it easier to parse and understand the build of each component. b.) It makes dependencies clearer. Currently we have no idea which dependency in the huge dependency list in //extensions/browser/BUILD.gn is needed by which API. With individual build files, we can now specify dependencies for just the component that needs them. This CL tries to do this but some dependencies are used by enough components that we've just included them for all (//content/browser/public, //skia). This is not ideal but at worst, it is still much better than the current build. Since we're now moving APIs over from //chrome/browser/extensions over to //extensions/browser, this becomes even more important. All APIs that get moved over now can use this new format for their build files. jamescook@, rockot@, xiyuan@ - FYI R=rdevlin.cronin@chromium.org BUG=641155 Review-Url: https://codereview.chromium.org/2336843002 Cr-Commit-Position: refs/heads/master@{#418729}
-
rch authored
Review-Url: https://codereview.chromium.org/2347433003 Cr-Commit-Position: refs/heads/master@{#418728}
-
tedchoc authored
TEST=Actually use the feature. Turn on "Don't keep activities", leave a CCT, click on it from recents. See that your final page is visible. BUG=606513 Review-Url: https://codereview.chromium.org/2336413002 Cr-Commit-Position: refs/heads/master@{#418727}
-