- 19 Sep, 2018 40 commits
-
-
Antonio Gomes authored
Follow up of [1], that introduces TestURLLoaderFactory::GetPendingRequest. TBR=droger@chromium.org [1] https://crrev.com/c/1234133 BUG=879774 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I234df7faf00625986e741a5bd3e1b52f34b7191e Reviewed-on: https://chromium-review.googlesource.com/1234554 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#592477}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1bbc63df5b82..2d4aa9279134 git log 1bbc63df5b82..2d4aa9279134 --date=short --no-merges --format='%ad %ae %s' 2018-09-19 primiano@google.com Merge "trace_processor: Make randomness deterministic" 2018-09-19 lalitm@google.com Merge "trace_processor: Parse systrace counter events" Created with: gclient setdep -r src/third_party/perfetto@2d4aa9279134 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Idc7ad658ccaeebc56f17866a49b9c9e586dfddb3 Reviewed-on: https://chromium-review.googlesource.com/1234573Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592476}
-
liberato@chromium.org authored
While MCVD requests bitstream conversion, AVDA still provided the CSD in the codec config. This CL makes MCVD do that also. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Id27e8833a8d266d5b401bf5c14003ca025bce7b4 Reviewed-on: https://chromium-review.googlesource.com/1228958 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#592475}
-
dpapad authored
Basically eliminating usage of /deep/ selectors. Bug: 875449,860069 Change-Id: I7e53055b712ee6701f240ba6f50c9eb1918d88b1 Reviewed-on: https://chromium-review.googlesource.com/1233113Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#592474}
-
Greg Thompson authored
To prevent users from accidentally restarting or dismissing the dialog if they happen to be typing when it appears. BUG=884831 R=bsep@chromium.org Change-Id: I91c31bd5b122632a3a2ceb13214aac266dfc6020 Reviewed-on: https://chromium-review.googlesource.com/1233576Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#592473}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/eaac597484d5..e5b1844cce9d Created with: gclient setdep -r src-internal@e5b1844cce9d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I63a5386ec820edbc696fcf752ae6f3b29db37ea3 Reviewed-on: https://chromium-review.googlesource.com/1234574Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592472}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0ff03808e344..c2d0fb17deef git log 0ff03808e344..c2d0fb17deef --date=short --no-merges --format='%ad %ae %s' 2018-09-19 halcanary@google.com include: whitespace changes for clang-format 2018-09-19 mtklein@google.com Revert "Reland "implement SkPixmap::getPixel() with this->readPixels()."" 2018-09-19 halcanary@google.com IWYU: three files 2018-09-19 bsalomon@google.com Revert "Revert "Reland "Add ability to specify different GP textures for each mesh in a draw.""" 2018-09-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 dc8fb9374e0a..5c72f28d1a3f (1 commits) Created with: gclient setdep -r src/third_party/skia@c2d0fb17deef The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: I1f07b6b0a733e83cee0d7872c503c8a0f6edff92 Reviewed-on: https://chromium-review.googlesource.com/1233994Reviewed-by:
-
Yuly Novikov authored
TBR=kbr@chromium.org Bug: 883500 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Idfe7f4fe14a9ef18a08a511fcf825862f4f44142 No-try: True Reviewed-on: https://chromium-review.googlesource.com/1234315 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#592470}
-
Antonio Gomes authored
Follow up of [1], that introduces TestURLLoaderFactory::GetPendingRequest. TBR=rdevlin.cronin@chromium.org (straightforward switch after [1]). [1] https://crrev.com/c/1234133 BUG=844928 Change-Id: If14f43964ddc21616cccadc337a8335099567c23 Reviewed-on: https://chromium-review.googlesource.com/1234633Reviewed-by:
-
Ken Rockot authored
Updates Content Service mojom and implementation to tolerate null response headers on navigation completion events. This diff was meant to be part of https://chromium-review.googlesource.com/c/chromium/src/+/1212023 but its boneheaded author failed to upload a new patchset. Bug: 854367 Change-Id: I908badb9103a9da5d5d91ae95019689b286b4ee6 Reviewed-on: https://chromium-review.googlesource.com/1231159Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#592468}
-
yileili authored
Bug: b:114756954 Test: Manual Change-Id: I1d58906771ad789232d8c01f6de06ea44ad8e3f8 Reviewed-on: https://chromium-review.googlesource.com/1226527 Commit-Queue: Yilei Li <yileili@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#592467}
-
dpapad authored
Enabling the following tests: CrSettingsChromeCleanupPageTest.All (Removed usage of /deep/) CrSettingsMultidevicePageContainerTest.All (already passing) Also fixing some overlapping inclusion and exclusion patterns (they should not exist). Bug: 875452,860069 Change-Id: Iba0546d24f032af0bfa4c3fb15b383e2ef938269 Reviewed-on: https://chromium-review.googlesource.com/1227479Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#592466}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e4c6d03d..0b5eefe8 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia06993a4dead0ca406a6640e77dff9b72a8cc801 Reviewed-on: https://chromium-review.googlesource.com/1233188Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592465}
-
Doug Arnett authored
Also add check on feature being enabled to also gate instantiating the server blacklist plus a couple tests. Bug: 864640 Change-Id: I332fa10e1fa6711c38a43cef3d179e63b14a5a46 Reviewed-on: https://chromium-review.googlesource.com/1225860 Commit-Queue: Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#592464}
-
Ned Nguyen authored
These benchmarks are handy for integration testing our pipeline & to dogfood new big features launch, so keeping them around. *This is part of the effort to add bug components for all perf benchmarks. Change-Id: Id8d8dee935ccc8b58186b2c6f3ec9ea6e5711397 BUG: 886965 Reviewed-on: https://chromium-review.googlesource.com/1234314 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Simon Hatch <simonhatch@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#592463}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/274a6922da39..c57ca0ea3af6 git log 274a6922da39..c57ca0ea3af6 --date=short --no-merges --format='%ad %ae %s' 2018-09-19 stevenjb@chromium.org cros_vm: Do not use sudo for creating VM dir 2018-09-19 manojgupta@google.com chrome_util: Make widevine cdm optional for ARM64. 2018-09-19 achuith@chromium.org cros_vm: Handle SSH port clash better. Created with: gclient setdep -r src/third_party/chromite@c57ca0ea3af6 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ibe8f58d3e1350b60e6cf71429942c04d150591dd Reviewed-on: https://chromium-review.googlesource.com/1233996Reviewed-by:
-
Raphael Kubo da Costa authored
Shaderc was dropped altogether from the tree in commit 7f7dd90b ("Remove Shaderc"), but the code was still being checked out for no reason. Additionally, having third_party/shaderc/src with no accompanying README.chromium causes tools/licenses.py to fail: licenses.LicenseError: missing README.chromium or licenses.py SPECIAL_CASES entry in third_party/shaderc Bug: 39240, 852620 Change-Id: Ic5e98407149ebccf320a976f2810c93f71ee6658 Reviewed-on: https://chromium-review.googlesource.com/1228053Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Chris Blume <cblume@chromium.org> Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#592461}
-
Sam Maier authored
These are being copied over before the originals are removed to accommodate downstream. TBR=agrieve@chromium.org Bug: 825947 Change-Id: I29a9db48c9d51d80cac8fd2c2d0287844ab8ff75 Reviewed-on: https://chromium-review.googlesource.com/1233718 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#592460}
-
Robbie McElrath authored
This migrates SyncSchedulerImpl from NetworkChangeNotifier to NetworkConnectionTracker, which works with the network service enabled. Bug: 883126 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I3482c04e6943df0b928eaebd48d9b511c6cb913a Reviewed-on: https://chromium-review.googlesource.com/1222699Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#592459}
-
Daniel Cheng authored
Bug: 742517 Change-Id: Id5ce54250468e9172f65f5dd79b522d08306e086 Reviewed-on: https://chromium-review.googlesource.com/1233121Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#592458}
-
mrefaat authored
Create a field trail entry before experimenting with 50% Beta Bug: 847550 Change-Id: I427bb6d9d798dfe9bd7fa9df8040d790cfa23c44 Reviewed-on: https://chromium-review.googlesource.com/1224797Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#592457}
-
Xiaohui Chen authored
This is a reland of 31a94c76 Original change's description: > assistant: turn on build for chromeos > > Bug: 114082902 > Test: locally build > Change-Id: Id29bb95768d2a6da75b649e4a32b4e37c74a6897 > Reviewed-on: https://chromium-review.googlesource.com/1226263 > Reviewed-by: Mike Frysinger <vapier@chromium.org> > Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#591540} Bug: 114082902 Change-Id: If33405de3b7bb07d3cb048fbb7cd42401a83391a Reviewed-on: https://chromium-review.googlesource.com/1232194Reviewed-by:
Mike Frysinger <vapier@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#592456}
-
Sammie Quon authored
Do not allow app list or its childrens to process events during swipe to close. Cancel swipe to close non scroll/fling event on shelf is seen. Search box widget can still take events on app list, this does not seem to cause any problems, but may need investigating. Also added a test to check local variables get reset after swiping in HomeLauncherGestureHandler. Test: ash_unittest *HomeLauncher*GestureHandlerTest* Bug: 881131 Change-Id: Id0e49e8fc246837900dc1145af12608b5e507874 Reviewed-on: https://chromium-review.googlesource.com/1233193 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
-
Xianzhu Wang authored
The result in BGPT mode is a progression. Bug: 879169 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ide0e2405c04d5b245294679e71a1dd3f4954e975 Reviewed-on: https://chromium-review.googlesource.com/1229179Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#592454}
-
Yves Gerey authored
Mimic what was done for metrics (819be2e0). This CL doesn't change anything for Chromium build, but make it easier to pick Chromium's implementation of field_trial by external targets. Bug: webrtc:9631 Change-Id: I88ff9580200f711eabe13f597a3095ebc8d27c6f Reviewed-on: https://chromium-review.googlesource.com/1233838Reviewed-by:
Henrik Grunell <grunell@chromium.org> Commit-Queue: Yves Gerey <yvesg@google.com> Cr-Commit-Position: refs/heads/master@{#592453}
-
Mike Dougherty authored
Calling supressNextClick is no longer necessary (as of at least iOS 10.0) to prevent navigation in the web view when presenting a context menu. |suppressNextClick| was incorreclty disabling the next touch after a context menu was canceled. TEST=No side effects after showing context menu Bug: 806737 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I40bd1e58a41a2fcab9985a436711da626800e718 Reviewed-on: https://chromium-review.googlesource.com/1228501Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#592452}
-
Michael Spang authored
Vulkan is enabled by default on Linux desktop (X11) builds. Enable it on ozone as well to make sure we have build coverage. Bug: 861853 Test: compile Change-Id: I7c15e365b2a4cfc7160847457ce9bf46a3f12f1e Reviewed-on: https://chromium-review.googlesource.com/1229233 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
-
Zach Helfinstein authored
Bug: 826215 Change-Id: Ia7dc94085d74519e6ecaea09dd9f3b4dcb8104ec Reviewed-on: https://chromium-review.googlesource.com/1227594Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> Cr-Commit-Position: refs/heads/master@{#592450}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/be50d76e46ea..eaac597484d5 Created with: gclient setdep -r src-internal@eaac597484d5 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I7aa9fea0103efe639ed0335be8b0a89f52396a1f Reviewed-on: https://chromium-review.googlesource.com/1233995Reviewed-by:
-
Xi Cheng authored
Bug: 886957 Change-Id: I53e8736e548c96ff623b4543376bface5d6eb013 Reviewed-on: https://chromium-review.googlesource.com/1232526 Commit-Queue: Xi Cheng <chengx@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#592448}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4544f3711024..1bbc63df5b82 git log 4544f3711024..1bbc63df5b82 --date=short --no-merges --format='%ad %ae %s' 2018-09-19 primiano@google.com Merge "Add bionic/ to buildtools gitignore" 2018-09-19 taylori@google.com Merge "trace_processor: Flatten CPU freq storage and remove cycles" Created with: gclient setdep -r src/third_party/perfetto@1bbc63df5b82 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ia0714e522b5e8531c345360b7b43b1d483cfabe9 Reviewed-on: https://chromium-review.googlesource.com/1234313Reviewed-by:
-
Sky Malice authored
Also added DCHECKs to show our assumptions about callbacks and state when various methods are invoked. Bug: 885122 Change-Id: I4d9d96ffe300ddf7a650dc4421934b2639c3e6ac Reviewed-on: https://chromium-review.googlesource.com/1232481Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#592446}
-
Etienne Pierre-doray authored
This CL uses ScopedBlockingCall to mark blocking calls in /device/bluetooth. This CL was created by replacing calls to AssertBlockingAllowed() with instantiations of ScopedBlockingCall(MAY_BLOCK). I kindly ask the reviewer to make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). This CL was uploaded by git cl split. R=ortuno@chromium.org Bug: 874080 Change-Id: Ib9d437546b43da34663eb96562becc94d6655989 Reviewed-on: https://chromium-review.googlesource.com/1191795Reviewed-by: -
Aaron Colwell authored
Change-Id: I44dd0a6c1cf0168e7934378b0b3b4e900adf4f8d Reviewed-on: https://chromium-review.googlesource.com/1232213Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#592444}
-
Jun Cai authored
Bug: 843384 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ib5d7677cbba9a715fbe295c530dea58135a79250 Reviewed-on: https://chromium-review.googlesource.com/1222291Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#592443}
-
Varun Khaneja authored
Bug: 886952 Change-Id: Iffbd7918ba24f9e6447baa424a108b5736b6659d Reviewed-on: https://chromium-review.googlesource.com/1233123 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Adrienne Porter Felt <felt@chromium.org> Cr-Commit-Position: refs/heads/master@{#592442}
-
Kyle Horimoto authored
Previously SetHostDevice() accepted a public key as a parameter, but that parameter was changed to a device ID in https://chromium-review.googlesource.com/c/chromium/src/+/1149328. The actual implementations of the MultiDeviceSetup interface (e.g., MultiDeviceSetupImpl) were changed correctly, but the *.mojom file was not. Change-Id: I1687d98d09a1dfe69a01e9eb77e2d092375ef0b0 Reviewed-on: https://chromium-review.googlesource.com/1232527Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#592441}
-
Adithya Srinivasan authored
As per discussion in the associated bug, we call EnsurePaintLocationDataValidForNode, which ensures that the document lifecycle is advanced to kCompositingInputsClean for sticky elements in order to correctly calculate its position. Bug: 850380 Change-Id: I27665028393cee6f330fda747b4a344e994fe8fe Reviewed-on: https://chromium-review.googlesource.com/1231378Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#592440}
-
edchin authored
This CL: 1) Notifies observers when the SnapshotCache removes a snapshot. This approach gives symmetry since observers are notified when a snapshot is added. 2) Adds a unittest for notifying observers on setting and removing a snapshot. 3) Adds TabGridMediator as an observer. Bug: 739840 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ib6fa854670537a1d225f92adbc51a361a1714623 Reviewed-on: https://chromium-review.googlesource.com/1231897Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#592439}
-
Sadrul Habib Chowdhury authored
Some of the discrepancy_ and mean_ metrics have been removed in crrev.com/c/1228794 and crrev.com/c/1229335. Update the tests accordingly. BUG=884950, 886913 Change-Id: If47fa9231e55fe52d6511b71cbcce1776cef4d60 Reviewed-on: https://chromium-review.googlesource.com/1234015Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#592438}
-
