- 03 Sep, 2016 32 commits
-
-
dalecurtis authored
This change rolls in a few changes: - Removes DelegateState::PAUSED_BUT_NOT_IDLE state. - Removes all blocks against suspending prior to kHaveFutureData. - If suspended, triggers resume when prior to have kHaveFutureData if the didLoadingProgress() timer reports true. - Always notifies the delegate of DelegateState::GONE; this ensures the idle timer is always restarted if we didn't quite get enough data to reach kHaveFutureData. - Fixes pause timer to handle newly supported background video; which doesn't set a state of DelegateState::GONE BUG=612909, 643383 TEST=new and updated unittests. Review-Url: https://codereview.chromium.org/2289543005 Cr-Commit-Position: refs/heads/master@{#416431}
-
pfeldman authored
BUG=598073, 504347 Review-Url: https://codereview.chromium.org/2302873005 Cr-Commit-Position: refs/heads/master@{#416430}
-
pdfium-deps-roller authored
https://pdfium.googlesource.com/pdfium.git/+log/fc1d16f76f17..d21f22e2c07d $ git log fc1d16f76..d21f22e2c --date=short --no-merges --format='%ad %ae %s' 2016-09-02 tsepez Make CPDF_ClipPath have a CPDF_ClipPathData rather than inheriting. 2016-09-02 tsepez Remove CFX_Matrix::Copy() in favor of assignment 2016-09-02 tsepez Make CPDF_GeneralStateData private. TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2305173002 Cr-Commit-Position: refs/heads/master@{#416429}
-
agrieve authored
And tidy up proguard_config -> proguard_preprocess_config rename Verified locally that ChromePublic.apk had no size change from this patch. BUG=640836 Review-Url: https://codereview.chromium.org/2310473002 Cr-Commit-Position: refs/heads/master@{#416428}
-
aluo authored
BUG=641594 Review-Url: https://codereview.chromium.org/2286883003 Cr-Commit-Position: refs/heads/master@{#416427}
-
dalecurtis authored
CancelPendingSeek() was called from the render thread, but the WeakFactory in FFmpegDemuxer is for use on the media thread. BUG=643441 TEST=none Review-Url: https://codereview.chromium.org/2305923002 Cr-Commit-Position: refs/heads/master@{#416426}
-
pkasting authored
* Improve comments * Eliminate -webkit-transition that seems to do nothing * Group related CSS selectors near each other in preparation for combining/modifying them * Don't use RTL folder images on Mac (see https://cs.chromium.org/chromium/src/chrome/browser/resource_delegate_mac.mm?rcl=0&l=50 ) * Use "x .y" instead of "x > * > .y" when the two will select the same elements, for brevity * Remove unnecessary size arg to getFaviconImageSet() (matches default value) * Don't use the name "scale_factor" for floats relating to scale, as "scale" and "scale factor" are distinct concepts. Use "scale" when that's what is meant. * Avoid unnecessary using directives. * Use a helper function to avoid repeating the same multi-part conditional * NULL -> nullptr * Improve function and variable names * Eliminate NOTREACHED() that can, in fact, be reached BUG=none TEST=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2278423002 Cr-Commit-Position: refs/heads/master@{#416425}
-
brettw authored
Delete corresponding GYP files. TBR=dpranke CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2304303002 Cr-Commit-Position: refs/heads/master@{#416424}
-
cfroussios authored
OSCrypt can now save its encryption password in gnome-keyring, where that library exists. BUG=602624 Review-Url: https://codereview.chromium.org/2297573002 Cr-Commit-Position: refs/heads/master@{#416423}
-
pdfium-deps-roller authored
https://pdfium.googlesource.com/pdfium.git/+log/bbee445c5a77..fc1d16f76f17 $ git log bbee445c5..fc1d16f76 --date=short --no-merges --format='%ad %ae %s' 2016-09-02 tsepez Make CPDF_Path have a CFX_Path rather than inheriting TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2302743005 Cr-Commit-Position: refs/heads/master@{#416422}
-
stevenjb authored
BUG=609156 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2306183002 Cr-Commit-Position: refs/heads/master@{#416421}
-
wkorman authored
invalidateCaret() once had another caller, but that day is long gone, as in, yesterday. Review-Url: https://codereview.chromium.org/2306813004 Cr-Commit-Position: refs/heads/master@{#416420}
-
spqchan authored
Made changes so that MacViews can accept drops from other applications. BUG=599585 Review-Url: https://codereview.chromium.org/2307633002 Cr-Commit-Position: refs/heads/master@{#416419}
-
brettw authored
This inlines the .gypi variables and deletes the obsolete files. TBR=dpranke Review-Url: https://codereview.chromium.org/2308173002 Cr-Commit-Position: refs/heads/master@{#416418}
-
mattm authored
BUG=635203 Review-Url: https://codereview.chromium.org/2272493002 Cr-Commit-Position: refs/heads/master@{#416417}
-
qiankun.miao authored
When building midi_manager_winrt.cc, following warning is raised: warning C4467: usage of ATL attributes is deprecated. Attributed ATL code has been deprecated. New code style can be found in https://msdn.microsoft.com/en-us/library/mt723604.aspx. BUG=512433 Review-Url: https://codereview.chromium.org/2301523008 Cr-Commit-Position: refs/heads/master@{#416416}
-
yuweih authored
This CL adds RenderStub and RenderCallback interface for GlDisplay in preparation of moving render controlling logic out of DesktopView and removing GlDesktopView. BUG=641123 Review-Url: https://codereview.chromium.org/2282783003 Cr-Commit-Position: refs/heads/master@{#416415}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/39f7a10a04a9..54682e856cb6 $ git log 39f7a10a0..54682e856 --date=short --no-merges --format='%ad %ae %s' 2016-09-02 msarett Delete SkColorSpace::kUnknown_Named, remove fNamed field CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=bsalomon@google.com Review-Url: https://codereview.chromium.org/2307183002 Cr-Commit-Position: refs/heads/master@{#416414}
-
mcchou authored
This adds IsAttributePresented which checks the present of an attribute by the given attribute ID. BUG=b:29314637 TEST=call IsAttributePresented on a predefined service record Review-Url: https://codereview.chromium.org/2302963002 Cr-Commit-Position: refs/heads/master@{#416413}
-
dtrainor authored
Make sure Tab gets notified of Blimp start and stop loading states so that it can decide whether or not to show NativePages or BlimpContents. BUG= Review-Url: https://codereview.chromium.org/2300103004 Cr-Commit-Position: refs/heads/master@{#416412}
-
thomasanderson authored
CL ca3656dc added the --wm-user-time-ms command line argument so that window activation would be more reliable. However, its implementation was awkward and complex, and is no longer needed now that X11EventSource::GetTimestamp() provides the correct functionality. Explanation: X11EventSource::GetTimestamp() gives the timestamp of the event currently being dispatched. If there's no event being dispatched, or the event does not have a timestamp, we fall back on making a round trip. Simply using last_seen_server_time like we did with activation before ca3656dc meant that the timestamp we used could be out of date if we were activating in response to anything other than a user input event. This is what led to the --wm-user-time-ms hack. Review-Url: https://codereview.chromium.org/2287583003 Cr-Commit-Position: refs/heads/master@{#416411}
-
joedow authored
This change addresses comments left on https://codereview.chromium.org/2277553002/ after it was checked in. The comments were around improvements to the switch used to set the current authenticator state. I addressed them by removing the default case (and leaving a comment on why) and moving the success case into the switch. BUG=617185 Review-Url: https://codereview.chromium.org/2308133002 Cr-Commit-Position: refs/heads/master@{#416410}
-
chili authored
BUG=640294 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2274733002 Cr-Commit-Position: refs/heads/master@{#416409}
-
juncai authored
With more functionalities added to BluetoothChooserController, it is necessary to add unit test to it. BUG=639163 Review-Url: https://codereview.chromium.org/2275173002 Cr-Commit-Position: refs/heads/master@{#416408}
-
agrieve authored
Revert of Quic: add unittests for reduced PING Timeout (patchset #2 id:20001 of https://codereview.chromium.org/2307933003/ ) Reason for revert: Broke cronet compile: https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20Lollipop%20Builder/builds/1164 ../../net/quic/core/quic_connection_test.cc:2980:8: error: redefinition of 'class net::test::{anonymous}::QuicConnectionTest_ReducedPingTimeout_Test' TEST_P(QuicConnectionTest, ReducedPingTimeout) { ^ ../../testing/gtest/include/gtest/internal/gtest-internal.h:1211:3: note: in definition of macro 'GTEST_TEST_CLASS_NAME_' test_case_name##_##test_name##_Test ^ ../../net/quic/core/quic_connection_test.cc:2980:1: note: in expansion of macro 'TEST_P' TEST_P(QuicConnectionTest, ReducedPingTimeout) { ^ ../../net/quic/core/quic_connection_test.cc:2935:8: error: previous definition of 'class net::test::{anonymous}::QuicConnectionTest_ReducedPingTimeout_Test' TEST_P(QuicConnectionTest, ReducedPingTimeout) { ^ ../../testing/gtest/include/gtest/internal/gtest-internal.h:1211:3: note: in definition of macro 'GTEST_TEST_CLASS_NAME_' test_case_name##_##test_name##_Test ^ ../../net/quic/core/quic_connection_test.cc:2935:1: note: in expansion of macro 'TEST_P' TEST_P(QuicConnectionTest, ReducedPingTimeout) { ^ Original issue's description: > Quic: add unittests for reduced PING Timeout > > BUG= > > Committed: https://crrev.com/df9cb098cf816fb589e0ad6627012b524c78e9eb > Cr-Commit-Position: refs/heads/master@{#416401} TBR=rch@chromium.org,zhongyi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2296393005 Cr-Commit-Position: refs/heads/master@{#416407}
-
jdufault authored
This avoids some issues with showing multiple palettes at the same time since each palette tool has some state that needs to be synchronized across each instance. TEST=ash_unittests BUG=642887 Review-Url: https://codereview.chromium.org/2297393002 Cr-Commit-Position: refs/heads/master@{#416406}
-
lgarron authored
This is in its own commit so that the commits for the two Page Info sections are easier to understand. BUG=512442 Review-Url: https://codereview.chromium.org/2283753003 Cr-Commit-Position: refs/heads/master@{#416405}
-
ojars authored
The purpose of this CL is to remove unnecessary blocking on UI thread which happens when BrowserViewRenderer sends a synchronous IPC message to get the next hardware frame. This new implementation instead sends an async message and receives the frame with another async message from render thread. This change alone is not sufficient as it causes scroll latency. The async implementation is turned on by command line param. Review-Url: https://codereview.chromium.org/2174203002 Cr-Commit-Position: refs/heads/master@{#416404}
-
rch authored
Also move the list of quic flags and their values into quic_flags_list.h which can be #included elsewhere. Review-Url: https://codereview.chromium.org/2306173003 Cr-Commit-Position: refs/heads/master@{#416403}
-
sunnyps authored
Reland of Default enable main frame before activation and remove finch experiment. (patchset #1 id:1 of https://codereview.chromium.org/2170233002/ ) Reason for revert: Relanding after fixing android webview issues Original issue's description: > Revert of Default enable main frame before activation and remove finch experiment. (patchset #1 id:1 of https://codereview.chromium.org/2159103008/ ) > > Reason for revert: > Speculative revert for failing WebView tests on Lollipop: > > https://build.chromium.org/p/chromium.android/builders/Lollipop%20Phone%20Tester/builds/5794 > https://build.chromium.org/p/chromium.android/builders/Lollipop%20Tablet%20Tester/builds/4054 > > Both phone and tablet started failing and this is the most "suspicious" change. boliu@ can help investigate further assuming this holds true. > > Original issue's description: > > Default enable main frame before activation and remove finch experiment. > > > > The finch experiment hasn't revealed any regressions other than in page > > load times which has been deemed a blink scheduler issue (see > > crbug.com/614482). > > > > R=piman@chromium.org,rkaplow@chromium.org > > BUG=612596 > > > > Committed: https://crrev.com/45041a7e286c665ab14d8ae0b182e1c11cef65ed > > Cr-Commit-Position: refs/heads/master@{#406916} > > TBR=piman@chromium.org,rkaplow@chromium.org,sunnyps@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=612596 > > Committed: https://crrev.com/2863590ee8e57543f646f4308130765afb02bd44 > Cr-Commit-Position: refs/heads/master@{#407003} TBR=piman@chromium.org,rkaplow@chromium.org,tedchoc@chromium.org BUG=612596 Review-Url: https://codereview.chromium.org/2184243003 Cr-Commit-Position: refs/heads/master@{#416402}
-
zhongyi authored
BUG= Review-Url: https://codereview.chromium.org/2307933003 Cr-Commit-Position: refs/heads/master@{#416401}
-
zhongyi authored
BUG= Review-Url: https://codereview.chromium.org/2307933003 Cr-Commit-Position: refs/heads/master@{#416400}
-
- 02 Sep, 2016 8 commits
-
-
asvitkine authored
BUG=416479 TBR=jam@chromium.org Review-Url: https://codereview.chromium.org/2303653005 Cr-Commit-Position: refs/heads/master@{#416399}
-
brettw authored
Remove obsolete GYP files. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=dpranke@chromium.org Review-Url: https://codereview.chromium.org/2310613002 Cr-Commit-Position: refs/heads/master@{#416398}
-
sandersd authored
Revert of Add testing config for OverlayFullscreenVideo. (patchset #1 id:1 of https://codereview.chromium.org/2291413002/ ) Reason for revert: Turns out we shouldn't do this for optimization experiments, since we don't actually want this enabled for all dev builds. Original issue's description: > Add testing config for OverlayFullscreenVideo. > > BUG=642571 > > Committed: https://crrev.com/99fce27763b037227011e357502b1c700477d153 > Cr-Commit-Position: refs/heads/master@{#415825} TBR=asvitkine@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=642571 Review-Url: https://codereview.chromium.org/2306233002 Cr-Commit-Position: refs/heads/master@{#416397}
-
chenwilliam authored
I uploaded the latest LTS node.js version to a google storage bucket and updated the buildbot/node.py script. Hopefully since this is LTS, we won't need to bump this node version too often. BUG=642046 Review-Url: https://codereview.chromium.org/2303273003 Cr-Commit-Position: refs/heads/master@{#416396}
-
dtrainor authored
Make sure to build a BeginFrameSource when binding to the OutputSurfaceClient. Without this the compositor doesn't push frames. This was broken by https://codereview.chromium.org/2083423006 because BlimpLayerTreeSettings sets use_output_surface_begin_frame_source but one wasn't provided by the DelegatedOutputSurface. Infrastructure to add a Blimp test for this is almost complete and will be added in a follow up CL! BUG= Review-Url: https://codereview.chromium.org/2308143002 Cr-Commit-Position: refs/heads/master@{#416395}
-
riajiang authored
Also switching back to listen for move events in touch hud app. BUG=643396 TEST=manual Review-Url: https://codereview.chromium.org/2296763009 Cr-Commit-Position: refs/heads/master@{#416394}
-
mattreynolds authored
Adds a WebUI page that receives a list of URLs broadcast by nearby devices along with associated page metadata and displays them as a list of clickable items. BUG=630769 Review-Url: https://codereview.chromium.org/2248913007 Cr-Commit-Position: refs/heads/master@{#416393}
-
boliu authored
BUG=643660 Review-Url: https://codereview.chromium.org/2298093008 Cr-Commit-Position: refs/heads/master@{#416392}
-