- 23 Apr, 2018 40 commits
-
-
Darren Shen authored
Small change to make the code cleaner. Change-Id: I6203bc934b0d4c2762670a48445a5d2b67964611 Reviewed-on: https://chromium-review.googlesource.com/1023519Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#552882}
-
Sergey Berezin authored
This should be enough for printing traces, and will save some precious disk space on the bots. R=justincohen@chromium.org Bug: 834527 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I0ff1210c48aeba8abb4639eba6a334559085fda7 Reviewed-on: https://chromium-review.googlesource.com/1018497Reviewed-by:
smut <smut@google.com> Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org> Cr-Commit-Position: refs/heads/master@{#552881}
-
https://chromium.googlesource.com/catapult.git/+log/219bbf110903..6fd1dbd39dac $ git log 219bbf110..6fd1dbd39 --date=short --no-merges --format='%ad %ae %s' 2018-04-19 simonhatch Dashboard - Remove MR code. 2018-04-19 simonhatch Dashboard - Remove unused layered_cache.Prewarm() Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I104bec71aa6b32cd4e8fc3b08709a8e38b096128 Reviewed-on: https://chromium-review.googlesource.com/1024797 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#552880}
-
Alexey Kozyatinskiy authored
After V8 roll this test will behave properly. TBR: luoe@chromium.org Bug: chromium:810176 Change-Id: Ieb64794bde43bca4c345220c70b83f02996c00c2 Reviewed-on: https://chromium-review.googlesource.com/1025033Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#552879}
-
Fabrice de Gans-Riberi authored
This is a preliminary change to remove the posix source exclusion filter in a future commit. Bug: 835405 Change-Id: I80edca54856078335d6e09303738a63bed451d18 Reviewed-on: https://chromium-review.googlesource.com/1022129 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#552878}
-
Esmael El-Moslimany authored
Bug: 781703 Change-Id: I716d1e0fcf7e6023e6b516e195171ee8c0a0feee Reviewed-on: https://chromium-review.googlesource.com/1022318 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#552877}
-
Gabriel Charette authored
These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=dgozman@chromium.org Bug: 825327 Change-Id: Ib4b771dcae94fc61abc5a49deffb45bb068f7c7c Reviewed-on: https://chromium-review.googlesource.com/1024807 Commit-Queue: Gabriel Charette <gab@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#552876}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c78c94ca..6267b449 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I58629a33a390a31ce2ee2170ecfa77eeca26def7 Reviewed-on: https://chromium-review.googlesource.com/1024379Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#552875}
-
https://chromium.googlesource.com/angle/angle.git/+log/af2b33be5a3a..b3474d9d77de $ git log af2b33be5..b3474d9d7 --date=short --no-merges --format='%ad %ae %s' 2018-04-20 oetuaho Clean up ClipRectangle 2018-04-23 oetuaho Restrict BlitFramebuffer dimensions in WebGL mode Created with: roll-dep src/third_party/angle BUG=chromium:830046,chromium:830046 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Ia3181cdc2541c174f2c8b7f5fd3001448ec2b470 Reviewed-on: https://chromium-review.googlesource.com/1024535Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#552874}
-
crystallambert@chromium.org authored
Current use of background page and event page is confusing. This document updates the terminology to Background Scripts with an option to use it as a page in the manifest. All background scripts should be persistent false, with little to no exceptions. This update had a huge focus on how to create effective non-persistent background scripts. Change-Id: I985caa739104d3608157c5e39119f9e27d57442e Reviewed-on: https://chromium-review.googlesource.com/677735 Commit-Queue: Crystal Lambert <crystallambert@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#552873}
-
mark a. foltz authored
Further replacement of a content:: enum with a blink::mojom enum for the Presentation API. No behavioral changes. Bug: 817903 Change-Id: I66fc39db2e8f1e2220aa293e81a77b61d1f69c03 Reviewed-on: https://chromium-review.googlesource.com/1015289 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#552872}
-
Brian Osman authored
This was only used in unit tests. Add a simpler bool accessor to ColorSpace that indicates if the parametric approximation is accurate, and use that to continue testing specific profiles. This makes the test logic more accurately reflect the actual logic used at runtime around caching of profiles. Change-Id: I5b73f13e7912ad9c7903b83af823e8bf9ac9da29 Reviewed-on: https://chromium-review.googlesource.com/1022633Reviewed-by:
Mike Klein <mtklein@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com> Cr-Commit-Position: refs/heads/master@{#552871}
-
Gabriel Charette authored
These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=sky@chromium.org Bug: 825327 Change-Id: If9302ab0bd2df5e0bb6926ff2c0a784e45442bb0 Reviewed-on: https://chromium-review.googlesource.com/1024809 Commit-Queue: Gabriel Charette <gab@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#552870}
-
Joy Ming authored
Some clean-up UI/string changes: * Change "No SD card found" to "SD card not found" in case the user had another SD card but we weren't able to find one of them. * Include a "No available download locations" message to be shown on the settings page in the corner case where the user has no download options. * Increase the size of the title text for the download location spinner preference (same as other preferences). Bug: 792775 Change-Id: I8c0a972f793b263ce59c090906e64192477c67b4 Reviewed-on: https://chromium-review.googlesource.com/1022521Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Joy Ming <jming@chromium.org> Cr-Commit-Position: refs/heads/master@{#552869}
-
Amirhossein Simjour authored
Floating flag should be set to false when a Dialog is not anchored to the main content. Bug: 833466 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: Idad148d25bc1d51e6ba2b764426d2b8dc6b380a4 Reviewed-on: https://chromium-review.googlesource.com/1024231Reviewed-by:
Biao She <bshe@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#552868}
-
Gabriel Charette authored
These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=sergeyu@chromium.org Bug: 825327 Change-Id: I77c3da772302e295b6fee6f973b386e8dfac24f9 Reviewed-on: https://chromium-review.googlesource.com/1024763 Commit-Queue: Gabriel Charette <gab@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#552867}
-
Sorin Jianu authored
Bug: 832230 Change-Id: I31ee1843106eb158e5422a86941832e0f0e45fe7 Reviewed-on: https://chromium-review.googlesource.com/1011598 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#552866}
-
Lei Zhang authored
BUG=835774 TBR=clamy@chromium.org NOTRY=true Change-Id: Id7e5be2e8f423430d5b8aaf99970a1b8ef205e3c Reviewed-on: https://chromium-review.googlesource.com/1025113Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#552865}
-
https://webrtc.googlesource.com/src.git/+log/25acef756b46..9b20677c4e71 $ git log 25acef756..9b20677c4 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:None,chromium:794608,chromium:None,chromium:None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I22b580b563ed372ef59f62ef133432c79920d755 Reviewed-on: https://chromium-review.googlesource.com/1024397 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#552864}
-
Raymond Toy authored
The algorithm to determine if a setTargetAtTime automation converged to the target value incorrectly said the algorithm converged when it had not. Adjust the algorithm, simplifying it. There are now three simple criteria: 1. 10 time constants have passed since the start of the event 2. If the target is 0, the current value is less than exp(-10) 3. If the target is not 0, the relative error between the target and the current value must be less than exp(-10). Bug: 835298 Test: AudioParam/audioparam-setTargetAtTime-limit.html Change-Id: Iffc137b40929dc6542ad647a4e974ae11271157f Reviewed-on: https://chromium-review.googlesource.com/1022515 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#552863}
-
Gabriel Charette authored
These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=dimich@chromium.org Bug: 825327 Change-Id: I46637a8fbfb45f7c93cc189c974b0c7aedbc8a4d Reviewed-on: https://chromium-review.googlesource.com/1024631 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#552862}
-
Gabriel Charette authored
These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=peter@chromium.org Bug: 825327 Change-Id: Ieb5a440e5b0859d571594ecadfe1602ef0f3aa31 Reviewed-on: https://chromium-review.googlesource.com/1024658 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
-
Gabriel Charette authored
These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=sky@chromium.org Bug: 825327 Change-Id: I7be1ff97076aa234b31b3b3320bd7f6f3adfce63 Reviewed-on: https://chromium-review.googlesource.com/1024802 Commit-Queue: Gabriel Charette <gab@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Peter Boström authored
Provides extra badging in incognito mode. Bug: chromium:822070 Change-Id: Ifce0eee2192a5bb4a34f66e77fd7f8db4e61c383 Reviewed-on: https://chromium-review.googlesource.com/1024889 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#552859}
-
bsheedy authored
Fixes the VR bisect script refusing to work with --bisiect-repo if either --good-value or --bad-value was 0 due to Python's implicit booleans. Change-Id: I1e24514f944d0020f64c9d87435d04039224c566 Reviewed-on: https://chromium-review.googlesource.com/1024950Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#552858}
-
Eugene But authored
This change fixes computing "same_document_navigation" boolean by using "last committed item" instead of "current item" as a source navigation item. "current item" can pe pending or transient and it's never correct to assume that same document navigation happens from pending or transient item. Bug: 832734 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia2c26f29a898f69be3352e04f46fdb4498413a7f Reviewed-on: https://chromium-review.googlesource.com/1021659Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#552857}
-
Christopher Cameron authored
In crrev.com/549621, the RenderWidgetHostViewCocoa method firstRectForCharacterRange was changed from doing an early-out if !renderWidgetHostView_->GetFocusedWidget() to doing an early-out if clientWasDestroyed_. These are not the same thing -- clientWasDestroyed_ is equivalent to checking host(). Now we're seeing crashes downstream because OnNSViewSyncGetFirstRectForRange is getting called when renderWidgetHostView_->GetFocusedWidget() is nullptr. Fold firstViewRectForCharacterRange into firstRectForCharacterRange, (since it had no other callers), and update the synchronous method OnNSViewSyncGetFirstRectForRange to query GetFocusedWidget() and return a success parameter indicating if it is non-nullptr. Bug: 835272, 821651 Change-Id: I5063ed3c154cc1c1efc1f1e903153efc9aef66d1 Reviewed-on: https://chromium-review.googlesource.com/1024411 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#552856}
-
Gabriel Charette authored
These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=derat@chromium.org Bug: 825327 Change-Id: I782505eb512323fd6c5fabcb81ca522e6b530d97 Reviewed-on: https://chromium-review.googlesource.com/1024714 Commit-Queue: Gabriel Charette <gab@chromium.org> Commit-Queue: Dan Erat <derat@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#552855}
-
Lei Zhang authored
It is crashing in a flaky manner. BUG=832389 TBR=yoichio@chromium.org NOTRY=true Change-Id: Ic8b28082b990c85942aea6e6d90cd98d53b01dba Reviewed-on: https://chromium-review.googlesource.com/1024736Reviewed-by:
-
kapishnikov authored
BUG=834401 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I431f280cb95db8b924a826740590eeb8fb1c4399 Reviewed-on: https://chromium-review.googlesource.com/1021600Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Andrei Kapishnikov <kapishnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#552853}
-
Gabriel Charette authored
These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=morlovich@chromium.org Bug: 825327 Change-Id: Ifa8b9ebe79cbad2e11d0bb56b9a25326ba675df3 Reviewed-on: https://chromium-review.googlesource.com/1024870 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#552852}
-
Gabriel Charette authored
These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=reveman@chromium.org Bug: 825327 Change-Id: Iade137d4c95f81821e99e5ac1c0c51cdf93dff50 Reviewed-on: https://chromium-review.googlesource.com/1024670 Commit-Queue: Gabriel Charette <gab@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#552851}
-
Benjamin Shaya authored
Bug: None Test: None Change-Id: I6550ddb82e339091dc75df1cd45792b999fb5f71 Reviewed-on: https://chromium-review.googlesource.com/1024480Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Benjamin Shaya <bshaya@chromium.org> Cr-Commit-Position: refs/heads/master@{#552850}
-
Sean Topping authored
This facilitates mocking for unit tests without having to pull in all of chromecast/browser. Bug: None Test: CQ Change-Id: Ifeafdfeeffcdbf152a4d694f7cfc280cd5887e37 Reviewed-on: https://chromium-review.googlesource.com/1015960 Commit-Queue: Sean Topping <seantopping@chromium.org> Reviewed-by:
Stephen Lanham <slan@chromium.org> Reviewed-by:
-
Erik Chen authored
Change-Id: I5db3464c086b7763afd4bccdc7242f462ffd7c1b Reviewed-on: https://chromium-review.googlesource.com/1014706 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#552848}
-
Qiang Xu authored
Changes: Introduce callback for GetContextMenu in ash::ShelfItemDelegate so that chrome's implementation could pass this callback further to wait asynchronous getting menu items, such as getting menu items from Android. For ARC++ app shortcuts project, we could bind GetAppShortcutItems callback and run this introduced callback when android runs GetAppShortcutItems callback. AppListItem side change: crrev.com/c/1023064. Bug: 803291 Test: covered by tests. Change-Id: I4d1e25ff8dfcf6572bb483fe4be3bd3eddba367e Reviewed-on: https://chromium-review.googlesource.com/1023161 Commit-Queue: Qiang Xu <warx@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#552847}
-
W. James MacLean authored
One possible crash mechanism for this crash is if we return base::nullopt when the touch_id == 0, cf. DispatchTouchscreenGestureEvent(). Bug: 824774 Change-Id: I20e3c01bb4b8cbac8c5dbe3ad41d28a6b6843b78 Reviewed-on: https://chromium-review.googlesource.com/1024651Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#552846}
-
Steven Holte authored
Bug: 793917 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I80bcead4276b5be658588d5b32ab09ebf9e952dc Reviewed-on: https://chromium-review.googlesource.com/1008406Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#552845}
-
Dmitry Gozman authored
Public typemaps may use non-wtf types, since they are consumed by embedder. Generating blink variant for them fails. One example would be a manifest typemap which currently resides in content, but will be moved to blink. Those typemaps which can be used inside blink (and are used already) are added to blink_typemaps instead. These are usually enum typemaps and can be shared verbatim between variants. Bug: none Change-Id: Ifd969c6de92e6e0507b40b2426e0b33119ea599b Reviewed-on: https://chromium-review.googlesource.com/1015228Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#552844}
-
Gabriel Charette authored
Migrate MessageLoop::current() to MessageLoopCurrent in /chrome/browser/safe_browsing/incident_reporting These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=caitkp@chromium.org Bug: 825327 Change-Id: Id8cdae2fc85f60f7cd66d5d88fd404128ba723ac Reviewed-on: https://chromium-review.googlesource.com/1024241 Commit-Queue: Cait Phillips <caitkp@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Cr-Commit-Position: refs/heads/master@{#552843}
-
