GitLab

https://skia.googlesource.com/skia.git/+log/09523b43fc28..d437c79ed036


git log 09523b43fc28..d437c79ed036 --date=short --no-merges --format='%ad %ae %s'
2018-11-28 reed@google.com Revert "don't trust convexity with affine transforms"
2018-11-28 reed@google.com Reland "Don't let neighboring radii in GrAAFillRRectOp get too close"
2018-11-28 reed@google.com Revert "Don't let neighboring radii in GrAAFillRRectOp get too close"
2018-11-28 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset
2018-11-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 b980c5630eb5..83b2f0e8a2e0 (7 commits)
2018-11-28 csmartdalton@google.com Revert "Disable instanced rendering on Skylake"
2018-11-27 rmistry@google.com [Android compile bots] Make lunch target part of the GS file name
2018-11-27 scroggo@google.com SkWuffsCodec: fix dependent frames
2018-11-27 herb@google.com Move path building logic to SkGlyph
2018-11-27 mtklein@google.com workaround black screen in viewer on Mac 10.14
2018-11-27 bungeman@google.com Add support for fallbackFor in Android parser.
2018-11-27 reed@google.com don't trust convexity with affine transforms
2018-11-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 471b8d4c7383..b980c5630eb5 (3 commits)
2018-11-27 kjlubick@google.com [canvaskit] Add shadow and save/restore support
2018-11-27 halcanary@google.com SkShaper->SkFont
2018-11-27 bsalomon@google.com Clamp GL_TEXTURE_MAX_LEVEL to 1 on Android.
2018-11-27 herb@google.com Add explicit to ctor
2018-11-27 rmistry@google.com Add new Android compile bot to CQ
2018-11-27 csmartdalton@google.com Don't let neighboring radii in GrAAFillRRectOp get too close
2018-11-27 reed@google.com Revert "Revert "migrate to passing paint/ctm for bounds""


Created with:
  gclient setdep -r src/third_party/skia@d437c79ed036

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:899689,chromium:899689
TBR=borenet@chromium.org

Change-Id: Ic581d5d0364a961f22654c53a06f82bc46fcdabf
Reviewed-on: https://chromium-review.googlesource.com/c/1351487Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#611717}

This is a reland of abcd4da5

Original change's description:
> [LayoutNG] Fix text-transform for 8-bit text
>
> Fix a bug in CaseMappingHarfBuzzBufferFiller where 8-bit strings weren't
> up-converted to 16-bit in cases were the original and case mapped string
> differed in length which hit a CHECK in the String::Characters16 method.
>
> Bug: 899876, 899868
> No-Try: true
> Change-Id: I5de8fbaabbc08932904846ffa4674129263f50aa
> Reviewed-on: https://chromium-review.googlesource.com/c/1330723
> Commit-Queue: Emil A Eklund <eae@chromium.org>
> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
> Reviewed-by: Stefan Zager <szager@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#607106}

Bug: 899876, 899868
Change-Id: I6b35a8335ab77fc700040a37f23278b67ec4eda5
Reviewed-on: https://chromium-review.googlesource.com/c/1331138
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611716}

MessageLoop will go away, eventually.

BUG=891670

Change-Id: I7cb468ba37b76d5765f9941a6101d8115d3f73de
Reviewed-on: https://chromium-review.googlesource.com/c/1352768Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Carlos Caballero <carlscab@google.com>
Cr-Commit-Position: refs/heads/master@{#611715}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/dab634da93d3..703305b1a5a2


git log dab634da93d3..703305b1a5a2 --date=short --no-merges --format='%ad %ae %s'
2018-11-28 dj2@everburning.com Fixup BUILD.gn file (#2129)
2018-11-28 dj2@everburning.com [ndk-build] Make SPIRV-Headers location configurable (#2126)
2018-11-27 zoddicus@users.noreply.github.com Move OpExtInst validation into validate_extensions.cpp (#2124)
2018-11-27 33432579+alan-baker@users.noreply.github.com Validate pointer variables (#2111)
2018-11-27 zoddicus@users.noreply.github.com Ensure that imported extended instructions for WebGPU are only "GLSL.std.450" (#2119)


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@703305b1a5a2

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I3d40e21aa082471d305c7a394c5231a60706b5c0
Reviewed-on: https://chromium-review.googlesource.com/c/1352986Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#611714}

Experiment discussion:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/hE2B1iItPDk

Bug: chromium:904764
Change-Id: Ifaa3df3dffaa9266f55a36840b9f26b323e50478
Reviewed-on: https://chromium-review.googlesource.com/c/1352752
Commit-Queue: Jakob Ivarsson <jakobi@google.com>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611713}

- We don't do unnecessary calls to the browser process.
- We can restore elements which were changed by JS.

It's an implementation of the first step from the one-pager

Bug: 898109
Change-Id: I9caf5bce5e94981b7bd809db2c8ec7a3ec0f0e0e
Reviewed-on: https://chromium-review.googlesource.com/c/1306497Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Uladzimir Miniailau <miniailau@google.com>
Cr-Commit-Position: refs/heads/master@{#611712}

Save the dino game highscore into a preference in the user's profile.
The highscore will persist across sessions and sync across devices.

Adds a mojo interface that allows setting the highscore preference from
the renderer. NetErrorPageController / NetErrorHelper expose new
functionality to provide the saved score to the error page and update
the saved score when a new highscore is reached.

Also ensures that the maximum high score is chosen on sync conflicts by
extending PrefModelAssociatorClient to allow the embedder to choose the
merging strategy for conflicting preference values.

TBR=sdefresne@chromium.org

Bug: 568093
Change-Id: Ia6485cbbf03ea210cba11dd3bd5f8be2518997d7
Reviewed-on: https://chromium-review.googlesource.com/c/1347283Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Edward Jung <edwardjung@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611711}

This reverts commit 198eca95.

Reason for revert: breaking GPU Linux Builder

Original change's description:
> Migrate consumers of SigninManager::IsAllowedUsername()
> 
> Use identity::IsUsernameAllowedByPattern() instead so that we can migrate
> those consumers entirely to the IdentityManager in follow-up patches.
> 
> Also, in order to make it explicit that this API should not be used any
> more, make SigninManager::IsAllowedUsername() a private method and friend
> it with the relevant test cases from SigninManagerTest, so that it can
> only be used from there. And while at it, also remove some stale lines
> "friending" SigninManager with test cases that no longer exist.
> 
> Bug: 890794, 890815, 906085
> Change-Id: Id8a72b0efd89818e02c6d1e73aac1451207b9625
> Reviewed-on: https://chromium-review.googlesource.com/c/1346409
> Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
> Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#611704}

TBR=blundell@chromium.org,msarda@chromium.org,sdefresne@chromium.org,mario@igalia.com

Change-Id: I8172674e32d7671868fa5374a9457abd6413321e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 890794, 890815, 906085
Reviewed-on: https://chromium-review.googlesource.com/c/1354121Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#611710}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/94c524df..03ba418f

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I47c482c11de7f20552b1bf3de83c1f259398cce1
Reviewed-on: https://chromium-review.googlesource.com/c/1352985Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#611709}

There are a few TODOs in the code related to tab specific settings
left from the time of componentising them. Those TODOs were related to
planned structural changes in the code, which did not happen in the
end and did not block the componentisation.

Those TODOs are unlikely to provide any value in the future, so this
CL removes them.

Bug: 387075, 908813
Change-Id: Iba5f2600d1a025cf4531c5ca0dbfb6b3fd269789
Reviewed-on: https://chromium-review.googlesource.com/c/1352352Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611708}

MessageLoop will go away, eventually.

BUG=891670

Change-Id: Icd3016627e9c59f8e16e7f8031131b17b3d44eaa
Reviewed-on: https://chromium-review.googlesource.com/c/1352765Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Carlos Caballero <carlscab@google.com>
Cr-Commit-Position: refs/heads/master@{#611707}

Sometimes BrowsingDataTest.testCookiesDeleted fails because it gets a
result that doesn't contain number.
This can happen if the BrowsingDataCounter result isn't calculated
within 140ms and the counter responds with "Calculating...".
To fix test flakiness, we have to ignore these messages.

Bug: 909690
Change-Id: I087280bd98b8e5604a352692e3f0740e30eb4f02
Reviewed-on: https://chromium-review.googlesource.com/c/1353923
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611706}

Allow overriding document.lastModified for standalone Documents.

Behavior matches Firefox.

Bug: 765116

Change-Id: I10006622f8866b5aa785e91cc17d2147f884950b
Reviewed-on: https://chromium-review.googlesource.com/c/1344137Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Rob Buis <rbuis@igalia.com>
Cr-Commit-Position: refs/heads/master@{#611705}

Use identity::IsUsernameAllowedByPattern() instead so that we can migrate
those consumers entirely to the IdentityManager in follow-up patches.

Also, in order to make it explicit that this API should not be used any
more, make SigninManager::IsAllowedUsername() a private method and friend
it with the relevant test cases from SigninManagerTest, so that it can
only be used from there. And while at it, also remove some stale lines
"friending" SigninManager with test cases that no longer exist.

Bug: 890794, 890815, 906085
Change-Id: Id8a72b0efd89818e02c6d1e73aac1451207b9625
Reviewed-on: https://chromium-review.googlesource.com/c/1346409Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#611704}

The test PersistProgressMarkerOnRestart used to fail for USS Bookmarks
because the metadata weren't persisted properly.

This CL makes sure that the processor would outlive the bookmark model
such that the metadata is available at the time when the model is
getting destructed and persisted on disk.

Bug: 816866
Change-Id: Ief259bd75ee66a6f9bb1dd70fc2ef6a446ebbd7a
Reviewed-on: https://chromium-review.googlesource.com/c/1349314
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611703}

Parallelize processing of each entry in the zip (jar) file. This also
preserves build determinism since we wait on each future in sequence.

Estimated total savings on an incremental build: 1.6 seconds.

Bug: 906803
Change-Id: Iec0cfcc4511bf090a6f50a3d64eea3f8b3459778
Reviewed-on: https://chromium-review.googlesource.com/c/1351458
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611702}

https://android.googlesource.com/platform/external/perfetto.git/+log/f16618125056..5403e4fde106


git log f16618125056..5403e4fde106 --date=short --no-merges --format='%ad %ae %s'
2018-11-28 primiano@google.com Roll clang and libcxx to match chromium revisions


Created with:
  gclient setdep -r src/third_party/perfetto@5403e4fde106

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: Ie75875424109a4f955c1bd5f8cf9ac8fcd7b62a9
Reviewed-on: https://chromium-review.googlesource.com/c/1352861Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#611701}

https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/fb0d66d04c4d..3dd4e76b19f3

$ git log fb0d66d04..3dd4e76b1 --date=short --no-merges --format='%ad %ae %s'
2018-11-27 apodtele * builds/windows/vc2010/freetype.vcxproj: Simplify.
2018-11-27 chris.liddell [type1,cff] Add FT_{Set,Get}_MM_WeightVector API calls.
2018-11-27 bungeman [cff] Fix compiler warning (#55105).
2018-11-27 bungeman [truetype] Fix numeric overflow (#55103).
2018-11-25 apodtele [builds] Belated DLL support with vc2002-vc2008.
2018-11-22 prince.cherusker * src/cff/cffparse.c: Please the compiler.
2018-11-22 prince.cherusker [cff] Fix memory overflow.
2018-11-18 apodtele * builds/windows/{visualc,vc2005,vc2008}/freetype.vcproj: Fix it.
2018-11-10 apodtele Clarification.
2018-11-10 apodtele [smooth] Placeholder only for library-enabled LCD filtering.
2018-11-09 wl [psaux] Add safety guard (#54985).
2018-11-08 apodtele * builds/unix/configure.raw: Require `windows.h' for windres.
2018-11-08 apodtele [ftstroke] Fix unpredictable failures (#54986).
2018-11-08 apodtele [ftstroke] Fix unpredictable failures (#54976).

Created with:
  roll-dep src/third_party/freetype/src
R=bungeman@chromium.org,drott@chromium.org

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng

PDFium-Issue: pdfium:1196
Bug: 907670
Change-Id: Ic23ebcc22837b6d4b85d19b4b84159faffedd66d
Reviewed-on: https://chromium-review.googlesource.com/c/1353890
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Reviewed-by: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611700}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/62103075707c..c0d86a6b9d74


Created with:
  gclient setdep -r src-internal@c0d86a6b9d74

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ie36cd95b09f1980e280780ee7b497a9617dfcd96
Reviewed-on: https://chromium-review.googlesource.com/c/1351488Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#611699}

No need to zip up the generated source just to unzip it again :P

This reverts commit 61c12ee7.

Reason for reland: Fix missing deps for realz

TBR=pauljensen@chromium.org,agrieve@chromium.org

Bug: 908479
Change-Id: Ib3108f01ad49a68aa1a2d6de303aaa79d899ec8f
Reviewed-on: https://chromium-review.googlesource.com/c/1352520
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611698}

Bug: 909722
TBR=rogerta@chromium.org

Change-Id: I09108bc16d2f2e470b90fa8a1ff602eaea36087d
Reviewed-on: https://chromium-review.googlesource.com/c/1353959Reviewed-by: Tim Schumann <tschumann@chromium.org>
Commit-Queue: Tim Schumann <tschumann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611697}

Channels are uint32_t in the javascript API there is no need for them
to be index as 64 bit integers.

BUG=879657

Change-Id: I21d2d0568a7cffe3cb275df11f642b9222f29c1d
Reviewed-on: https://chromium-review.googlesource.com/c/1349463Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611696}

base::AssertBlockingAllowedDeprecated is deprecated in favor of
ScopedBlockingCall, which serves as a precise annotation of
the scope that may/will block.

Please make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation:
      MAY_BLOCK: The call might block (e.g. file I/O that might hit in memory cache).
      WILL_BLOCK: The call will definitely block (e.g. cache already checked and now pinging
        server synchronously).
    See BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().
  - Calls to blocking //base APIs don't need to be annotated
    with ScopedBlockingCall. All blocking //base APIs (e.g. base::ReadFileToString, base::File::Read,
    base::SysInfo::AmountOfFreeDiskSpace, base::WaitableEvent::Wait, etc.) have their
    own internal annotations.

Refer to the top-level CL if necessary :
https://chromium-review.googlesource.com/c/chromium/src/+/1338391

Please CQ if LGTY!

This CL was uploaded by git cl split.

R=davidben@chromium.org

Bug: 903957
Change-Id: I7264546a54917ab0f7be6931219aad84091582aa
Reviewed-on: https://chromium-review.googlesource.com/c/1338486Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611695}

Type was a char but should be a char[]

BUG=909692

Change-Id: I2151ab95a0ec0bbefd913f32de1b3e4d51cce6f8
Reviewed-on: https://chromium-review.googlesource.com/c/1354058Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611694}

Note that the CL is able to use gaia IDs from AccountInfo, rather than hardcode them.

BUG=903878

Change-Id: I03dd2f0bd271e969be00aa23005a6bd8960062e0
Reviewed-on: https://chromium-review.googlesource.com/c/1351157
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611693}

Change OnDisplayMetricsChanged to create new ManagedDisplayInfo for
display if OnDisplayAdded was never called for the display.
This is needed for the initial display on cast.

Bug: 896710
Test: None
Change-Id: I3b7d4829874b61b2115d25071a0de7bb74dba246
Reviewed-on: https://chromium-review.googlesource.com/c/1329859
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611692}

Merge internal change: 223015666
Merge internal change: 223024889
Merge internal change: 223044144

R=rch@chromium.org

Change-Id: I83e3a5662499e716bd02698fd95488edc14593b3
Reviewed-on: https://chromium-review.googlesource.com/c/1351102
Commit-Queue: Victor Vasiliev <vasilvv@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611691}

This is in preparation for supporting manual interactions on testdriver.
By setting this field to true, unimplemented APIs will fail early rather
than waiting for user input (and timing out).

https://github.com/web-platform-tests/wpt/pull/11173

Change-Id: Ie409b683755358fb7978989bf3894e7b45b05239
Reviewed-on: https://chromium-review.googlesource.com/c/1352571
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611690}

MessageLoop will go away, eventually.

BUG=891670

Change-Id: I6d254d90004514c867f66f3f49465a25c717a212
Reviewed-on: https://chromium-review.googlesource.com/c/1352754Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Carlos Caballero <carlscab@google.com>
Cr-Commit-Position: refs/heads/master@{#611689}

Bug: 903276
Change-Id: Id679d9ae73535fa4f5f168c2745cdd65991c66cc
Reviewed-on: https://chromium-review.googlesource.com/c/1352311
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611688}

Reland "[TaskScheduler]: Migrate off of ScopedAllowWait in /base/profiler/stack_sampling_profiler.cc"

This is a reland of 50b50793

This CL changes ScopedAllowBaseSyncPrimitives to ScopedAllowBaseSyncPrimitivesOutsideBlockingScope
in StackSamplingProfiler.

Original change's description:
> [TaskScheduler]: Migrate off of ScopedAllowWait in /base/profiler/stack_sampling_profiler.cc
>
> base::ThreadRestrictions::ScopedAllowWait is deprecated in favor of its more
> explicit counterpart.
>
> It should have been replaced by :
>  * base::ScopedAllowBaseSyncPrimitivesForTesting in test files.
>  * base::ScopedAllowSyncPrimitives in non-test files
>  * base::ScopedAllowSyncPrimitivesOutsideBlockingScope when it's used on threads
>    that don't allow blocking
> The last one is strongly frowned upon but this CL aims to document existing
> behavior rather than address it. Owners are encouraged to follow-up by fixing
> unnecessary waits and more particularly unnecessary waits
> outside-blocking-scope.
>
> Note: The non-for-testing versions require friend'ing in thread_restrictions.h
> but care was taken to add these friends ahead of git cl split (since it wasn't
> possible to do a line-by-line associated CL split).
> Refer to the top-level CL if necessary :
> https://chromium-review.googlesource.com/c/chromium/src/+/1288533
>
> Please CQ if LGTY!
>
> This CL was uploaded by git cl split.
>
> R=wittman@chromium.org
>
> Bug: 766678
> Change-Id: I2c45612b77a49ca5720da95093b0cdd8845b6f03
> Reviewed-on: https://chromium-review.googlesource.com/c/1325191
> Reviewed-by: Mike Wittman <wittman@chromium.org>
> Commit-Queue: Mike Wittman <wittman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#606478}

Bug: 766678, 907177
Change-Id: I45b48e57040721e5ff3c2bdaac62237ed7ae429e
Reviewed-on: https://chromium-review.googlesource.com/c/1349633Reviewed-by: Mike Wittman <wittman@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611687}

The code previously looked like this:

  #if defined(COMPILER_GCC) && defined(_FORTIFY_SOURCE)
      if (!__builtin_constant_p(dst_end - dst) || (!(dst_end - dst)))
        memset(dst, val, dst_end - dst);
  #else
      memset(dst, val, dst_end - dst);
  #endif

The #ifdef was added a long time ago, in http://crrev.com/7728f5076b20 with the
motivation:

> There is a warning in memset in glibc that gets triggered through a
> warndecl when the fill-value of memset is a non-zero constant and the
> size is zero. This warning is enabled when building with
> -D_FORTIFY_SOURCE=2. This patch fixes the warning.

The idea was presumably to skip the memset if the size is a constant zero.
However, that's not what the code is doing. It's skipping the memset if the
size is constant *non-zero*.

How did this ever work?

I don't know about GCC, but until recently, Clang would not return true for the
__builtin_constant_p expression, so the memset would always run. However, Clang
gained support for this in r347417, and now webkit_unittests started failing in
builds that use FORTIFY_SOURCE.

The desired code would be:

  if (!__builtin_constant_p(dst_end - dst) || (dst_end - dst != 0))
    memset(dst, val, dst_end - dst);

But since I couldn't reproduce any warning about memset getting called with
zero size, I think it's better to drop the whole thing and simplify the code.

Bug: 908372
Change-Id: I166b88af27ca8beacba746892d5fde09ecf1c326
Reviewed-on: https://chromium-review.googlesource.com/c/1352363
Commit-Queue: Hans Wennborg <hans@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611686}

This patch adds the serial number to base::SysInfo::HardwareInfo on
Windows only, where it represents the BIOS serial number. This is
grabbed through a WMI call.

Other platforms will follow.

Bug: 907518
Change-Id: I1b2b23c00cda286f325a0a09722dbfc5e974eb77
Reviewed-on: https://chromium-review.googlesource.com/c/1346869Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Georges Khalil <georgesak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611685}

According to the flakiness dashboard it got flaky on all platforms except Mac.

TBR=lazyboy@chromium.org

Bug: 909570
Change-Id: I404a5d2ba392aa521fdf99c6892580f208086775
Reviewed-on: https://chromium-review.googlesource.com/c/1352193Reviewed-by: Tim Schumann <tschumann@chromium.org>
Commit-Queue: Tim Schumann <tschumann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611684}

This CL moves the existing AutofillDataItem to legacy and creates a new
item compatible with UITableView.

Bug: 894791
Change-Id: Id3d7af497b08e99d8977e2f77385ea5e55f5c22b
Reviewed-on: https://chromium-review.googlesource.com/c/1350953
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611683}

Bug: 907720
Change-Id: Id3ec824af0023ba9fa4bb053717741c345c15b45
Reviewed-on: https://chromium-review.googlesource.com/c/1352052Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611682}

https://android.googlesource.com/platform/external/perfetto.git/+log/af0c7c5e6e24..f16618125056


git log af0c7c5e6e24..f16618125056 --date=short --no-merges --format='%ad %ae %s'
2018-11-28 primiano@google.com Merge "Add support for periodic flushes"


Created with:
  gclient setdep -r src/third_party/perfetto@f16618125056

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I69643914963df59545d102d6588dd694fe6df37b
Reviewed-on: https://chromium-review.googlesource.com/c/1351486Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#611681}

TBR=yosin@chromium.org

Bug: 909694
Change-Id: Ie6fd36ef024ce524152d5b718fbbc848b1735f05
Reviewed-on: https://chromium-review.googlesource.com/c/1353958
Commit-Queue: Tim Schumann <tschumann@chromium.org>
Reviewed-by: Tim Schumann <tschumann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611680}

This is a reland of 30e1dd18

Adding feature flags to slimnav.
Revert bug: https://bugs.chromium.org/p/chromium/issues/detail?id=908970

Original change's description:
> [ios] add credit card test for manual fallback
>
> Also adds AutofillManualFallbackPhaseTwo to test bots.
>
> Bug: 845472
> Change-Id: I6bd05781c09c24c0768e24acfe59efa7ce1da05d
> Reviewed-on: https://chromium-review.googlesource.com/c/1337347
> Reviewed-by: Rohit Rao <rohitrao@chromium.org>
> Reviewed-by: Ben Pastene <bpastene@chromium.org>
> Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
> Commit-Queue: David Jean <djean@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#611171}

TBR=rohitrao@chromium.org

Bug: 845472,908970
Change-Id: I2cc0cddf0be8cea447f45f69457afbe19c840f29
Reviewed-on: https://chromium-review.googlesource.com/c/1352328
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611679}

So the user doesn’t unlock a card through CVC just to be told that it cannot be injected in current field.

Bug: 908789
Change-Id: Ie255d36f794c94d90b0fd1e01bf80d608ef757f6
Reviewed-on: https://chromium-review.googlesource.com/c/1352759
Commit-Queue: David Jean <djean@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611678}