- 03 Jun, 2020 40 commits
-
-
Victor Hugo Vianna Silva authored
It seems over time, different features added to passwords settings ended up implementing the check of whether there are saved passwords resulting in hasSome_, hasStoredPasswords_ and hasPasswords_ (e.g. crrev.com/c/1047867, crrev.com/2107524). This CL summarizes these in a single hasSavedPasswords_ property, reflecting the name of the corresponding array. The same is done for the array of exceptions. The motivations here are: a) Keep simplifying the PasswordsSection code; b) Avoid the use of hasStoredPasswords_ in setSavedPasswordsListener, allowing to extract that code into a new behavior in the next CL. Bug: None Change-Id: Ib39c29f3cc5fd90bde3313971eb95d17b3ed9fe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225905 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#774589}
-
Antonio Sartori authored
https://crrev.com/770126 introduced a regression in memory usage. I think this regression was due to storing the whole redirect chain of a ResourceRequestHead alongside with it. Although this seemed like a clean idea from the code point of view, this causes heap allocation for information which we do not really need. In this change I get rid of it and only store the first and previous urls in the ResourceRequestHead. Change-Id: I2ee5c122142d732d1496e6606615d83e028581f4 Bug: 1084972 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214542 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#774588}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c1150db5e1ce..93f1a38fb5b9 2020-06-03 kjlubick@google.com [canvaskit] Add flexibility to setColor API 2020-06-03 kjlubick@google.com [canvaskit] Change Malloc to return object instead of TypedArray If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tdenniston@google.com Change-Id: I98e091e00156b148a67654a9b27fc2849a7f2724 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228904Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774587}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 497ef2a5. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I2cbad6165a096562e1e51e037bbc6a9312df5fdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228573Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774586}
-
Andrei Salavei authored
To make the IdentityManager's constructor easily extendable for different platforms, use a dedicated struct - |IdentityManager::InitParameters|. It helps in passing platform specific fields to IdentityManager, like |chromeos::AccountManager|. Bug: 1068240 Change-Id: I48eb10cb6f32c447692a9af045cfcedd66b4052d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212050 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#774585}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I72b511a4b3ce9efb0c65036eee91c5c7e47ec188 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228131Reviewed-by:
-
Viktor Semeniuk authored
This change adds BulkLeakCheckServiceInterface and TestBulkLeakCheckService which can be used by unit tests. Bug: 1087314 Change-Id: Ia7d80efe1b09a107c8cf1241f2b7fbd1a6a3de19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218174 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
-
Yunke Zhou authored
Bug: 1052281 Change-Id: Iaebf9fcb383de713f37ac7168e0bf20768a26044 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225899 Commit-Queue: Yunke Zhou <yunkez@google.com> Reviewed-by:
Renato Silva <rrsilva@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#774582}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0f116b95..d77fdbe0 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib15955733a87d1b61cf204cefa6f24fc9bd453b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228938Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774581}
-
Travis Skare authored
Reduces dialog width and space below download button to spec. Matches eligibility logic to send-tab-to-self (http-or-https) Matches focus hide/show to STTS. BUG=1077077,1082829 Change-Id: I0deee3f85d2ccc69190c2723e394584f8ee79588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218760Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Travis Skare <skare@chromium.org> Cr-Commit-Position: refs/heads/master@{#774580}
-
Caitlin Fischer authored
Bug: 1090424 Change-Id: I2c1fe5047360c23dbee12189e6411933ab4e9ccf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225847Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#774579}
-
Caitlin Fischer authored
This is accomplished by registering the FieldTrialsProvider last and by implementing FieldTrialsProvider::ProvideCurrentSessionData. This CL also adds a utility function to LogDecoder for decompressing data and parsing it to a proto. Bug: 1078795 Change-Id: Ic63afbc8fb3e92d6e98f80a3817bcfc3be1f2e83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208293 Auto-Submit: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#774578}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ia673010c88e4a426db58be73456ab8b77bbde991 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228901Reviewed-by:
-
Tim van der Lippe authored
Required for https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2215850 R=sigurds@chromium.org Bug: 1011811 Change-Id: I818c2e72be4151674a9bedf4d03935fec81296a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216251 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#774576}
-
Ravjit Singh Uppal authored
Bug: 1073883 Change-Id: I98964fe27b8a3f5bc247291e0b810e5e74c04a1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224863 Commit-Queue: Ravjit Singh Uppal <ravjit@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#774575}
-
Jonathan Mengedoht authored
Bug: 927473 Change-Id: I31dc7b4a96759cf7203452e926df2d74e8860716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226854Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1591156770-3a8b9ed3582dca859cc61c05847c60f8252d4d44.profdata to chrome-win32-master-1591170216-be28c2b4718a2f482f298b7a886d3f3e5fe30114.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I761c957b279738979103c8ebe3d7ce545fc3b76d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228488Reviewed-by:
-
Victor Hugo Vianna Silva authored
The CL replaces the "These passwords were not commited" message in the bubble with a more informative one. The CL also changes the text on the cancel button from "Cancel" to "Discard". The strings are moved to a .grd file but are still kept as non-translateable, since they are not final. Screenshot of new bubble strings: https://screenshot.googleplex.com/fzW2r5fnawV Bug: 1060132 Change-Id: Ifc630eec1e2b23ee4d43305e316ce7c01606a390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228839Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#774572}
-
Hitoshi Yoshida authored
Bindings is going to update IDL dictionaries to be strict about their members' existence. After the update, accessing a getter on a missing dictionary member will crash. This CL fixes the potential bug in Animatable.animate(). Bug: 839389 Change-Id: I305daff7130a2a26b5a7142f67fe7920910cead3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226483Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#774571}
-
Bartek Nowierski authored
https://google.github.io/styleguide/cppguide.html#0_and_nullptr/NULL says: "For pointers (address values), use nullptr, as this provides type-safety." Furthermore, NULL won't compile if we change |SomeClass*| to |CheckedPtr<SomeClass>|. See go/miracleptr for project details. Bug: 1080832 Change-Id: I75a25ed0ff64561cb68555f5a6622cbb5b9d723a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228741 Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Denis Kuznetsov authored
Bug: 1067228, 1073095 Change-Id: I00cc22cbc87eb2cc1641f2c40ab0630988c1f247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228610Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#774569}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9d83693a5ac5..890735b8c86d 2020-06-03 fmayer@google.com Fix RssHWM -> VmHWM in docs. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I10ceed42a0b05cd4e4603f9957aff2c576752fd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228898Reviewed-by:
-
Roman Aleksandrov authored
Avoid using custom C++ functions to call from JS part. Add new actions for all type of user actions which could happen in the UI. Refactor ScreenHandler to move business logic from UI-purposed file. Add user actions tracking. Bug: 1066606 Change-Id: I61fcbc952349418517e267c24f167c681ef2c016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169931 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/03e4d15d1fa0..8278fd0af106 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tnagel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: tnagel@google.com Change-Id: Ide598bfb0956006be8beddaf1b63c95876ee2103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228080Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774566}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1591156770-1c33a7333211aead2282df21d0f2c3fe491f2db6.profdata to chrome-mac-master-1591170216-219e7bf40eeb405c9bdb366afea32eceddcbc16f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ica6c425c9f5da754b8413baaab20e1787240d01f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228800Reviewed-by:
-
Alice Wang authored
This CL fixes one flaky NTP test with the new FakeAccountManagerFacade implementation and removes unused code in AccountManagerTestRule. Bug: 996716 Change-Id: Ifb6662bcc572ad8dab959d6b8aa18d4dae8578c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220050Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#774564}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 58d01c37. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I79c628cfc9fc302bea6876dade433ea43aaf1e63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228571Reviewed-by:
-
Maksim Moskvitin authored
DirectoryCryptographer is subject to remove and its usages should be replaced with CryptographerImpl or removed. This CL does it for all remaining USS tests. Bug: 1083924 Change-Id: Iedd4f6c039407cce0dfb502a4070ac42f4336c80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226753 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#774562}
-
Jinsuk Kim authored
The distinction between FullscreenManager and ChromeFullscreenManager got fuzzy over time, and there has not been any other concrete implementation. This CL merges the two classes into one. This is a part of the fullscreen manager clean up task that will split the role of browser controls positioning and HTML5 fullscreen API processing. Bug: 966272 Change-Id: Ie5cf76d6f1caf14b02b390bf6d3b40f52fe4183b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217679 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#774561}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6c1581646c46..086a04058cba 2020-06-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from f050cca7ec47 to 636f449e1529 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: If1b6c294ccd8553046103aceab9a0841d604f9cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228487Reviewed-by:
-
Roman Aleksandrov authored
Use new MaybeSkip method for skipping screen. Add tests for UMA stats. Bug: 1064561 Change-Id: Id47d1dbb35c5e4d38f3b9ecd478576e8c5f9f7d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166267 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
-
sandromaggi authored
This test was failing as a result of crbug/1090314. Re-enabling this test since the cause has been fixed. Bug: 1090215 Change-Id: I60ec44e694ef35a408712ee8d0d8e725b57a7e36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228838Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#774558}
-
Benoit L authored
This reverts commit 3288b2d9. Reason for revert: Newly added testImageSearch test breaks. crbug.com/1090697 Original change's description: > Reland "Fix image search from search activity" > > This is a reland of 91eda9e8 > > Original change's description: > > Fix image search from search activity > > > > SearchActivity did not handle image search data since image search need > > post data, so the fix is add the post data into intent to pass to chrome. > > > > Bug: 1078773 > > Change-Id: I04efdad0bba315508e0b05d3d9e444d8c1a5d955 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187191 > > Commit-Queue: Gang Wu <gangwu@chromium.org> > > Reviewed-by: Robert Sesek <rsesek@chromium.org> > > Reviewed-by: Ender <ender@google.com> > > Reviewed-by: Ted Choc <tedchoc@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#772335} > > Bug: 1078773 > Change-Id: I86f1fbab1cc27a66ceb5ad8ac987179b8f5e8e68 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220150 > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Gang Wu <gangwu@chromium.org> > Commit-Queue: Gang Wu <gangwu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#774036} TBR=tedchoc@chromium.org,gangwu@chromium.org,rsesek@chromium.org,ender@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1078773, 1090697 Change-Id: I96cdf063135e2d08e0ef05a24c8a84eef1a0b582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228532Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#774557}
-
Alan Cutter authored
This is a follow up CL to: https://chromium-review.googlesource.com/c/chromium/src/+/2224417 The previous CL removed a check for whether the current page is the install URL of an externally installed app that had a manifest with a start URL different from the install URL but doesn't have a manifest start_url anymore. This CL puts that check back. It was removed previously because I didn't notice LookupExternalAppId() was returning an AppId that I could use to check IsLocallyInstalled(). Bug: 1090182 Change-Id: I7e08f80cc4d64862015774ea0c04670829690bfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228014Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#774556}
-
Adenilson Cavalcanti authored
Use the set of portable code from zlib that shouldn't have extra dependencies (e.g. 'base'). Also allow building the tool for other targets (e.g. Linux, OSX, etc) as that allows easier testing and profiling. Compilation is disabled for Windows, see crbug.com/1090428. Bug: 1076580, 1087999 Change-Id: Id633b5aa287cd6b24c72af51a23c73d50617c68b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227312Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Reviewed-by:
David Turner <digit@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#774555}
-
Victor Hugo Vianna Silva authored
This CL introduces MultiStoreExceptionEntry, which is the analogous of MultiStorePasswordUiEntry (crrev.com/c/2202237) for exceptions. The common logic between these two classes is moved to a common base class. Future CLs will use the new class to deduplicate the passwordExceptions array in PasswordsSection. The CL also reorders some includes in settings_resources_v3.grdp that were not in alphabetical order. Bug: 1049141 Change-Id: Ibf64de15f49cf20c2f4b310f9a86341a41f6f3b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225408 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
-
Kent Tamura authored
This CL has no behavior changes in production. - Tests which should be fixed are listed in TestExpectations - overhang-*.html tests have notable changes. They are progressions. RubyNG allows to overhang on whitespace-only text nodes. - Other pixel results in this CL are due to differences between LayoutNG and the legacy layout. Bug: 1069817 Change-Id: I4a1b8953f984de2841bb4e964534354286a64fb3 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng_disabled Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228009 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#774553}
-
Alexey Baskakov authored
Implement backward compatibility uninstall of Web Apps via shadow Bookmark Apps. On a web app uninstall we also must uninstall the shadow bookmark app. All uninstall changes for the extensions registry get propagated to the sync server (syncer::ModelType::APPS) and to all devices where BMO is disabled. Design doc: go/chrome-bmo-migration. This is a re-land of https://chromium-review.googlesource.com/c/chromium/src/+/2162507 We do only legacy uninstalls in this CL to fix the bug. Bug: 1020037, 1086909 Change-Id: Ib65edc2762de38f050afedb00ffe06665845431b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228371 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#774552}
-
Harald Alvestrand authored
Bug: chromium:1030631 Change-Id: Idc0b9fe6d4c4db05741cd477ad25f98f83b554e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196165Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#774551}
-
Nigel Tao authored
I left this part out from the previous crrev.com/c/2222055, which added new code but forgot to delete the deprecated code. Bug: 1070409 Change-Id: Id84bab3ac58b8e0bab979a4fb8ffacbd5d7faa68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227941Reviewed-by:
-
