- 28 Nov, 2017 2 commits
-
-
Xiaohan Wang authored
Revert commit a62756b1 and reland 3294249d with fix. Original CL description: - DIR_COMPONENT_WIDEVINE_CDM is not used anymore. - Update WidevineCdmComponentInstallerPolicy::GetRelativeInstallDir() to use kWidevineCdmBaseDirectory instead of hardcoded string. TBR=waffles@chromium.org,thestig@chromium.org Change-Id: I802a9575076e4f93e9ac302d40197117108de4d6 Reviewed-on: https://chromium-review.googlesource.com/791934Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#519464}
-
Min Qin authored
This CL adds the throttling logic for navigation interception with Network service enabled. This matches the same logic used by DownloadResourceThrottle. It will prompt user for storage permission, and limiting the number of download requests per tab. BUG=715630 Change-Id: I88ad091972739e204ebf9b9720589bc10779eed4 Reviewed-on: https://chromium-review.googlesource.com/773483 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#519463}
-
- 27 Nov, 2017 38 commits
-
-
Stuart Langley authored
This should be the final CL for moving to nullptr in WebKit/Source/* I followed the instructions to run clang tidy at https://chromium.googlesource.com/chromium/src/+/master/docs/clang_tidy.md. I then ran the modernize-use-nullptr check on WebKit/Source/modules using the following command: $LLVM_HOME/tools/clang/tools/extra/clang-tidy/tool/run-clang-tidy.py \ -p ../.. \ -clang-tidy-binary $LLVM_BUILD/bin/clang-tidy \ -clang-apply-replacements-binary $LLVM_BUILD/bin/clang-apply-replacements \ -checks=-*,modernize-use-nullptr \ -header-filter=third_party/WebKit/Source/* \ -fix \ third_party/WebKit/Source Then ran "git cl format" on the result. Bug: 778942 Change-Id: I31f0cba131523034a7811bf46f8ef68110d11a3f Reviewed-on: https://chromium-review.googlesource.com/791410Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#519462}
-
Will Chen authored
My previous CL broke the test debugging workflow because it resulted in TestRunner.addResult causing a stack overflow: https://chromium-review.googlesource.com/c/chromium/src/+/780806 This fixes the issue by preserving original console functions when debugging tests. Bug: 788044 Change-Id: I06a93e674ee80d35460f12ba84a4168030c5a029 Reviewed-on: https://chromium-review.googlesource.com/791370Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Will Chen <chenwilliam@chromium.org> Cr-Commit-Position: refs/heads/master@{#519461}
-
Michael Lippautz authored
The stack address might point into the guard page at the end of a NormalPage. In this case the address is outside of the payload of the preceeding object. We assert that this can only be the case if the address is in the allocation point region which is not true in this case. The fix is to simply check for object payload in the beginning of FindHeaderFromAddress. Bug: chromium:788728,chromium:757440 Change-Id: I9cec5e9f0940ed1dcc1823484ced82308b054d8a Reviewed-on: https://chromium-review.googlesource.com/791351Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#519460}
-
Gyuyoung Kim authored
Issue 784653 removed isProtocolHandlerRegistered from a test that was ensuring it's not supported. So this CL restores it and removed expected result as well. Bug: 121825 Change-Id: I50609018d2349b584cccc4db1054ff4fe7447e43 Reviewed-on: https://chromium-review.googlesource.com/789712Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Cr-Commit-Position: refs/heads/master@{#519459}
-
Danyao Wang authored
The last use case of SetWebUsageEnabled(false) is to clear visited site data. It does so by removing the WKWebView due to a bug in WebKit (see crbug.com/557963). This breaks in WKBasedNavigationManager because it relies on WKWebView as the source of truth for session history. This CL fixes the issue by temporarily caching the session history in WebState and restoring it into the navigation manager when web usage is re-enabled. This fixes the LoadIfNecessaryTest.DisableAndReenableWebUsage test. Bug: 781916 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I6f7db84504603e624f5befa66ccb41c10433dd69 Reviewed-on: https://chromium-review.googlesource.com/789791 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#519458}
-
Gyuyoung Kim authored
Thgough IDL defined unregisterProtocolHandler with 2 arguments, unregister-protocol-handler.html has tested it with 3 parameters. Thus this CL removes the title parameter in the tests. - void unregisterProtocolHandler(DOMString scheme, USVString url); Spec: https://html.spec.whatwg.org/multipage/webappapis.html#custom-handlers Bug: None Change-Id: I544d0027f90a25d517b77633bf50a726ee1b364c Reviewed-on: https://chromium-review.googlesource.com/790018Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Cr-Commit-Position: refs/heads/master@{#519457}
-
David Bokan authored
When the user zooms into the page, scrolling should be proportionally reduced so the page appears to move at the same rate. This is currently done for various kinds of scrolling. An animated scroll that updates an existing scroll animation simply adjusts the animation curve's target delta. However, this path forgot to adjust by the page scale factor like the "new animation" and "non- animated" paths. This CL simply adds that in. Bug: 610021 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ic1a6421131915ad739d39ad3ef36792dd3be53aa Reviewed-on: https://chromium-review.googlesource.com/788134Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#519456}
-
Nicolas Pena authored
This CL takes advantage of the loop through text in LayoutText to store a variable indicating whether text contains only 'whitespace' or not. The main purpose of the loop is to compute widths but this seems like a reasonable place to also store this new information, to avoid an extra iteration over the text. Now, TextRun has a boolean variable indicating whether the text to be painted contains a whitespace or not. For now, the boolean is only changed in InlineTextBox::ConstructTextRun to prevent Font::DrawText from returning true. The return value of this method is only used to determine whether SetTextPainted() is called in GraphicsContext::DrawTextInternal. PaintController::SetTextPainted is the method that triggers First Contentful Paint (caused by text) on PaintTiming. We do not want it to be triggered on trivial whitespace text rendering. Test: Check whether FCP is observed on a document with just <div> </div> Also, this fix should allow landing the test in: https://chromium-review.googlesource.com/c/chromium/src/+/769929 Bug: 785344 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Id219eeaced4679eda9c26acde7fd4fdb0cb1e891 Reviewed-on: https://chromium-review.googlesource.com/786336Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#519455}
-
Eric Roman authored
Change-Id: Ie06e4592fdee3199466e0249592f64302f0bebd9 Reviewed-on: https://chromium-review.googlesource.com/782770Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#519454}
-
Vladimir Levin authored
This patch renames the async attribute to be the decoding attribute due to discussion on https://github.com/whatwg/html/issues/1920 This also adds wpt test for the decoding attribute R=chrishtr@chromium.org, domenic@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I0524b7e3849c9a922f358c0592d34c30a7fd8914 Reviewed-on: https://chromium-review.googlesource.com/770106 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#519453}
-
khmel authored
Bug: 788308 Test: Manually in multiple chrome://settings tabs Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3c63ad6e5c6de64054c1cb10db3c744e199cea08 Reviewed-on: https://chromium-review.googlesource.com/791931 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#519452}
-
Elliot Glaysher authored
ChromeNativeAppWindowViewsAuraAsh used to directly depend on the TabletModeController instead of the mojom client. This usage needed to be protected under mash. Now that we use TabletModeClient, remove this check so we update more state correctly. Bug: 766759 Change-Id: Ib4ace7c6bc9f1a39cbf08db7a340c58a48dca6df Reviewed-on: https://chromium-review.googlesource.com/764867Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Elliot Glaysher <erg@chromium.org> Cr-Commit-Position: refs/heads/master@{#519451}
-
Owen Min authored
When profile is loaded into memory and auth token verfication failed. All assoicated browser windows will be closed without countdown window notification. Bug: Change-Id: I61bf1cde63fdfe8bfd424b9a0e40b7f001c7f4d8 Reviewed-on: https://chromium-review.googlesource.com/777919Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#519450}
-
Trent Apted authored
I haven't been able to trigger this. I suspect there's some window not owned by Chrome being added as a child window of a window that Chrome does own. E.g. a popup window added via Services or the system "Share" options. This being destroyed could unexpectedly mutate [NSApp windows] while we are iterating over it and cause unstable behavior. Bug: 788271 Change-Id: I2a40507a6b93e1940a295c6edf3f156a4005ffb3 Reviewed-on: https://chromium-review.googlesource.com/788646Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#519449}
-
Sam McNally authored
ManifestManager will be moved from content/renderer into blink. Once this is done, its clients in the renderer will no longer be able to access it directly, instead using mojo. In preparation for this, migrate ManifestDebugInfo to be a mojo struct, add it to the mojo interface and migrate the in-process clients to use the mojo interface. Change DevToolsAgent to use the manifest URL returned by the ManifestManager instead of looking up the manifest URL from the document, avoiding the possibility of reporting a newer manifest URL not matching the reported manifest debug info. Bug: 704441 Change-Id: Ib95ab9370f657987811cb85c9287d2de7f38e125 Reviewed-on: https://chromium-review.googlesource.com/749565Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#519448}
-
Xianzhu Wang authored
This prepares for https://chromium-review.googlesource.com/c/chromium/src/+/780376 which will use OffsetFromLayoutObject for layer states of composited scrollbars and scroll corners. Set OffsetFromLayoutObject for composited scrollbars and scroll corners to their coordinates in the containing box. For SPv1, use the value to generate a transform around the paintings which are the box coordinates. For SPv175+, https://chromium-review.googlesource.com/c/chromium/src/+/780376 will generate layer offset which will generate the transform equivalent to the SPv1 transform. Bug: 771643 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I8b7d7f7b1a9efdc889073719097a76b1883f1d5a Reviewed-on: https://chromium-review.googlesource.com/786130 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#519447}
-
Ke He authored
In this CL we remove the GeolocationDelegate but keep its functionality by inject a GetCustomeSystemLocationProviderCallback to constructor of the Device Service. 1) Add the GetCustomSystemLocationProvider() in ContentBrowserClient for embedder to override, and inject it to DeviceService constructor. 2) Move the location_provider.h to public/cpp. 3) Change the unittest of LocationArbitrator accordingly. BUG=725057 Change-Id: I605d282cac2082f69526675a8e7dff3a46bafd74 Reviewed-on: https://chromium-review.googlesource.com/768614Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Ke He <ke.he@intel.com> Cr-Commit-Position: refs/heads/master@{#519446}
-
Danyao Wang authored
Added a new inttest, onload_replacestate_reload.html that triggers 3 separate latent race conditions in CRWWebController: 1. crbug.com/788452: JS completion block from |webViewURLDidChange| fires too late and a different-document provisional navigation already started. 2. crbug.com/788231: JS completion block from |updateHTML5HistoryState| fires too late and clobbers _lastRegisteredRequestURL. 3. crbug.com/788464: window.history.didReplaceState message arrives too early and updates _lastRegisteredRequestURL that conflicts later with |webView:didFinishNavigation|. The root cause is that the web process is separate from the UI process, so we cannot assume specific ordering between KVO notifications, JS completion blocks and webkit.postMessage messages. The fixes are not perfect. I tried to detect the race condition and abort the second half of the async processing. A better longer term fix after WKBasedNavigationManager launches is to simplify history state handling and reduces async use cases in CRWWebController. Bug: 788464,788231,788452 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I69d788fc040371247cfac29e02e80dadb7821148 Reviewed-on: https://chromium-review.googlesource.com/788185 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#519445}
-
Troy Hildebrandt authored
Adds a feature flag and field trial config for the expansion of the Chrome Home bottom sheet after some delay. The current delay is three hours, but this allows us to experiment with enabling/disabling the feature and changing the delay before we show an expanded bottom sheet. Bug: 772919 Change-Id: I757c312e8177c01ff74a2e513dea7a010b2dc3a8 Reviewed-on: https://chromium-review.googlesource.com/779303Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Cr-Commit-Position: refs/heads/master@{#519444}
-
Biao She authored
Metrics that are added in this CL: 1. Number of times voice search is started during one VR session. 2. Aggregated data on voice search end state (open a search page, cancel or try again). 3. Aggregated data on how likely user chose to not give audio permission to voice search. Bug: 788013 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I8d4cc29b908059efb2c6a2a6cb60641edbfd2e51 Reviewed-on: https://chromium-review.googlesource.com/786610 Commit-Queue: Biao She <bshe@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#519443}
-
Albert J. Wong authored
This is a mechanical refactor moving all free functions in partition_alloc.h that primarily operate on PartitionPage into the PartitionPage struct. There are also functions inside partition_alloc.cc which are effectively private methods. Those have not been moved yet though because it's unclear if the symbol hiding within the translation unit and the "inilne" tags may or may not be disrupted if the declaration is hoisted into a struct that is shared in multiple translation units. It probably won't, but might as well do it in a separate CL. See related bug for more details on methodology. Bug: 787153 Change-Id: I3363ad12675bf674f4397e67f9dcc26ec384018d Reviewed-on: https://chromium-review.googlesource.com/786510 Commit-Queue: Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#519442}
-
Will Chen authored
Bug: 778817 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I132ebf5b4fc2b56d68cadf1adb1c06c83eaa2da0 Reviewed-on: https://chromium-review.googlesource.com/767749 Commit-Queue: Will Chen <chenwilliam@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#519441}
-
Greg Kerr authored
This reverts commit 49c07418, to see how the performance histograms respond without cfprefs access. Tbr: rsesek@chromium.org Bug: 689306 Change-Id: I195a729e611c964b6221ec0e98ccde04444dc78f Reviewed-on: https://chromium-review.googlesource.com/792092 Commit-Queue: Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#519440}
-
khmel authored
Clicking need migration notification should cause session exit. We had only handle for old style notifications. This suppors new style as well. Clicking on migration completed notification should start OptIn flow. Test: Manually for both cases. Bug: b/69622523 Change-Id: If2a56ec81b5e9cba797e081a4c97babd8d00951c Reviewed-on: https://chromium-review.googlesource.com/783832 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#519439}
-
jdoerrie authored
This change fixes the undo toast so that navigating away from the password settings page will hide it if shown. Bug: 779945 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0e10f352701c7caf356e070f2b4c6f7cd8b59b41 Reviewed-on: https://chromium-review.googlesource.com/779200Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#519438}
-
Peng Huang authored
Bug: 765393 Change-Id: I5c83d87c259b1f4884e91f9cc0f4bc3a1baf4d36 Reviewed-on: https://chromium-review.googlesource.com/772398 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#519437}
-
Ian Vollick authored
This CL formats the WebVR timeout UI to match the design. It also contains an update to the button API to propagate size changes to its constituent elements. Bug: None Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ied5d8c85c6c2e5439c64cc1056d021474c7eeedb Reviewed-on: https://chromium-review.googlesource.com/789418Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Biao She <bshe@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#519436}
-
Shanfeng Zhang authored
Bug: Change-Id: Id706ff7666dde88a68381897af5cdc8370e8efb6 Reviewed-on: https://chromium-review.googlesource.com/786637 Commit-Queue: Shanfeng Zhang <szhangcs@google.com> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#519435}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6bccad8c..a6639fb9 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I4763f7cbcdeab4ca83ddd46db179f033e4190ba9 Reviewed-on: https://chromium-review.googlesource.com/791270Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#519434}
-
Dave Tapuska authored
We've shipped coalesced events API for a number of releases remove the setting. BUG=656781 Change-Id: I0dc8d10833a99cefbc4f4361349d1be83d1e6142 Reviewed-on: https://chromium-review.googlesource.com/790936Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#519433}
-
James Wallace-Lee authored
(Part 2 of a 3-sided patch.) Depends on crrev.com/i/502732 Downstream, we are moving static SafeBrowsing methods into PlatformServiceBridge. This CL replaces upstream calls to SafeBrowsing methods, which previously used reflections, with calls to new instance methods in PlatformServiceBridge. BUG=682070 Change-Id: Id457a6065aa1d16b2acb8404a2fea4070b0879be Reviewed-on: https://chromium-review.googlesource.com/765092Reviewed-by:
Paul Miller <paulmiller@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Cr-Commit-Position: refs/heads/master@{#519432}
-
Tao Bai authored
Bug: 788823 Change-Id: I5c38b6b71eea2000d284d42687a95748f5654265 Reviewed-on: https://chromium-review.googlesource.com/791317Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#519431}
-
Andrey Kraynov authored
Code in iterators/ never calls any non-const methods and it is possible to make all Node/LayoutObjects objects const. No behavour changes. Bug: 766448 Change-Id: I344643ab0d5cf30285ef20c93dc4692dd082f2be Reviewed-on: https://chromium-review.googlesource.com/785696Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Andrey Kraynov <iceman@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#519430}
-
Hans Wennborg authored
There are three pieces to this puzzle: 1) Passing the -finstrument-functions-after-inlining flag to all compiler invocations. 2) Implementing the __cyg_profile_func_enter function. 3) Making all .exe and .dll targets link in the library that provides that function. This patch implements those three, losely modeled on how the Android build works, and adds documentation on how to use this to update the order files. Bug: 728324 Change-Id: I778bc8c0c2800244b8f18037197d62223ef92203 Reviewed-on: https://chromium-review.googlesource.com/783830 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Reviewed-by:
Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#519429}
-
Yuwei Huang authored
|audio_stream_consumer_| can be deleted before validity before using it. AudioStreamConsumerProxy: :Core is deleted, so we need to check its Change-Id: Ic979f5ef1690fce242dc48c84ff18dd07a22fb11 Reviewed-on: https://chromium-review.googlesource.com/776235Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#519428}
-
Francois Doray authored
OnWindowBoundsChanged() is called when the bounds of a window change. OnWindowOpacityChanged() and OnWindowTransformed() are called when the opacity or transform of a window is set, even if it didn't change. The reason for this difference is that the opacity and transform can be animated on the impl side of cc. cc sets the property value on the ui::Layer before the first frame of the animation is rendered and when the animation ends, but not during the animation. Most of the time, the value set before the first frame of the animation is rendered is the same as the existing value. We want to notify WindowObservers even if the value didn't change yet so that they are aware that an animation started. This CL also renamed OnWindowOpacityChanged -> OnWindowOpacitySet. Bug: 738387 Change-Id: I75c7c449ae5d20ae5b76e3ca0b6bb041ce8b1439 Reviewed-on: https://chromium-review.googlesource.com/775822 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#519427}
-
Sammie Quon authored
The icons now match the ones show on the chrome media router interface. They used to just show a generic TV for all types. Some of the icons change depending on if the build is chrome branded, this is also to match the media router interface. Test: manual Bug: 682575 Change-Id: Ib410e42afbe78e1c4c72ab3794d44d26fa69cf13 Reviewed-on: https://chromium-review.googlesource.com/777462 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#519426}
-
Lei Zhang authored
Use NOTIMPLEMENTED_LOG_ONCE(), as having the same NOTIMPLEMENTED() message 20 times in a row on startup is not helpful. Change-Id: I008e2eabb959e5d0477d08e4f9cdd8e0af046f5a Reviewed-on: https://chromium-review.googlesource.com/791431Reviewed-by:
Elliot Glaysher <erg@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#519425}
-