- 20 Jul, 2017 40 commits
-
-
Geoff Lang authored
Add a 'debug_x64' and 'release_x64' build type for the Windows bots. BUG=735483 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I71adf860a39fb14600c044dca9aeb8bd3bfb33fd Reviewed-on: https://chromium-review.googlesource.com/579574 Commit-Queue: Geoff Lang <geofflang@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#488302}
-
Jonathon Kereliuk authored
This is a WIP for implementing the actions API I am planning to break up my CLs into logical small chunks and this is the start Change-Id: I94bd3b0b7cbd7a727bbb6bd7e02f52651fe8d1d8 Reviewed-on: https://chromium-review.googlesource.com/578475Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Jonathon Kereliuk <kereliuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#488301}
-
Michael Thiessen authored
Unfortunately we have to check focus twice before sending it to a VrDisplay, once in the browser to do view-level focus, then again in the renderer to do frame-level focus. This CL ensures browser-side focus before sending displayactivate events or head pose information to the WebVR page. This CL adds an argument to OnWebContentsFocused to let observers know which RenderWidgetHost gained/lost focus. It also implements GotFocus for Android, meaning OnWebContentsFocused will now be called on Android where it previously wasn't. LostFocus will now be called significantly less, as I've made it symmetric with GotFocus (which involved adding the fullscreen restriction to WebContentsImpl::RenderWidgetLostFocus that's present in WebContentsImpl::RenderWidgetGotFocus) Bug: 687411, 738239 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: Ibeee427d602d7fef8ce533669b45d9cc5f8ffa03 Reviewed-on: https://chromium-review.googlesource.com/565760 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Bo Liu <boliu@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#488300}
-
tdresser authored
BUG=None Review-Url: https://codereview.chromium.org/2973213002 Cr-Commit-Position: refs/heads/master@{#488299}
-
Kent Tamura authored
Difference from the reverted CL: Renames JSONObject::GetObject to GetJSONObject to avoid a Windows build issue. Change-Id: I3ec8abedaa63b4d38fc9c9d3a53f7826de6b5392 Reviewed-on: https://chromium-review.googlesource.com/578633 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#488298}
-
Bin Zhao authored
Move IconType class out of MediaSink class in media_sink.h and media_router.mojom Bug: 694841 Change-Id: I710adea06557c63e061bb428dbaed7038eb8d956 Reviewed-on: https://chromium-review.googlesource.com/574900Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Bin Zhao <zhaobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#488297}
-
Hayley Ferr authored
Added an UMA_HISTOGRAM_BOOLEAN to report how often a gesture event is or is not dropped based on the current touch action state not matching the gesture event. Bug: 745718 Change-Id: Ib1c9f91cfcaa846f3e8bba9a7b1c87f698b2a962 Reviewed-on: https://chromium-review.googlesource.com/575071 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#488296}
-
Alex Moshchuk authored
NOTRY=true Bug: 710098, 623268, 623210, 680307 Change-Id: I3b086fb6310ba8216cbade6cae6de08e689d460d Reviewed-on: https://chromium-review.googlesource.com/579891Reviewed-by:
Lukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#488295}
-
Alexei Filippov authored
Bug: 734239 Change-Id: Ia815aa693ab6719a0a26d65231db1a04c26a2c4d Reviewed-on: https://chromium-review.googlesource.com/578513 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#488294}
-
Catherine Chung authored
To use the FeatureEngagementTracker to observe the New Tab and related actions, the NewTabFeatureEngagementTracker class was created. Things that were changed in this CL: * Added the NewTabInProductHelp trial to the fieldtrial json * Added a pref to track the user's total active session time * Created a NewTabFeatureEngagementTracker class, which contains methods to notify the IPH server when events happen and if the help UI should be triggered. Related CLs: * The Observer for DesktopSessionDurationTracker http://crrev.com/d69292f * Event constants that are used in NewTabFeatureEngagementTracker http://crrev.com/bdf5c97 * Using the NewTabFeatureEngagementTracker https://chromium-review.googlesource.com/c/549074/ * Addition to fieldtrial_testing.json https://chromium-review.googlesource.com/c/566335/ Bug: 734132 Change-Id: I8654ef001f3fb50fbd8bb8c4f215dffcfe403762 Reviewed-on: https://chromium-review.googlesource.com/549057 Commit-Queue: Catherine Chung <catherinechung@google.com> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Pam Greene <pam@chromium.org> Reviewed-by:
Anthony Vallee-Dubois <anthonyvd@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#488293}
-
Scott Violet authored
This is a reland of b650c38e Original change's description: > chromeos: fix DCHECK in ~WindowTreeHostManager > > The DCHECK is because on observer is being added but not > removed. Specifically exo's WmHelper installs an observer on > WindowTreeHostManager but WmHelper never removes itself (because > WindowTreeHostManager is deleted before WmHelper). This patch makes > WmHelper be destroyed before WindowTreeHostManager by way of making > ChromeBrowserMainExtraPartsAsh create exo related functionality. > > BUG=none > TEST=none > > Change-Id: I84e7209c817e4687017edbc14db7f75cb1054fbb > Reviewed-on: https://chromium-review.googlesource.com/572427 > Commit-Queue: Scott Violet <sky@chromium.org> > Reviewed-by: David Reveman <reveman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#487556} Bug: none Change-Id: I486d68e9a2af654facd50ccb0512bdca217520a8 Reviewed-on: https://chromium-review.googlesource.com/578287Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#488292}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/2c4a805ac3d6..dc11ec85ebf6 $ git log 2c4a805ac..dc11ec85e --date=short --no-merges --format='%ad %ae %s' 2017-07-20 dsinclair Cleanup CPWL_Icon AppStream generation 2017-07-20 dsinclair Consolidate Appearance Stream code in CPWL_AppStream. Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: Ie3725d5399bcdedd7508c40cca545187daa0f6dc Reviewed-on: https://chromium-review.googlesource.com/579577 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#488291}
-
mfomitchev authored
If navigation isn't possible when GestureNavSimple::OnOverscrollModeChange is called, we don't show the affordance. In this case, we shouldn't attempt to navigate again when GestureNavSimple::OnOverscrollComplete is called (even if we can). BUG=NONE Review-Url: https://codereview.chromium.org/2983893002 Cr-Commit-Position: refs/heads/master@{#488290}
-
Yusuf Ozuysal authored
- Adds a request setter for the callback. Set to false by default. - Starts sending the callback from bottom bar delegate only when completely hidden or shown. - If the bottom bar is not set, use the toolbar values to send the same signal, so that bottom bar can be set as desired BUG=746648 Change-Id: I6f60dde5e39354b33503ce9553b67cf953a9b533 Reviewed-on: https://chromium-review.googlesource.com/578392 Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#488289}
-
Mark Cogan authored
Bug: 738881 Change-Id: If191e9f0a32a0948844ee123a323781143127b27 Reviewed-on: https://chromium-review.googlesource.com/576097 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#488288}
-
Becky Zhou authored
This reverts commit 28b06e6b. Reason for revert: <INSERT REASONING HERE> Original change's description: > Add animation to history info header > > + Make DateDividedAdapter support multiple header items so that > privacy disclaimers and clear browsing data button can be seperate > items in recycler view to support show/hide animation. > + Hide info button when info header is not visible on scrolling down > in both history and downloads. > + Remove header when history items are all deleted. > > BUG=689322 > > Change-Id: Idbcae648ba277eb82b87bbe5a0667373bb09fc1a > Reviewed-on: https://chromium-review.googlesource.com/560672 > Commit-Queue: Becky Zhou <huayinz@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#488031} TBR=tedchoc@chromium.org,twellington@chromium.org,huayinz@chromium.org Change-Id: Iae0a049dfa302ca835a927e7cbd6e20c5f78fff3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 689322 Reviewed-on: https://chromium-review.googlesource.com/580028Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#488287}
-
galinap authored
It is currently at the top of the bottom sheet. It displays suggestions in a recycler view. The SuggestionsCarouselAdapter fetches the suggestions and constructs a ContextualSuggestionsCardViewHolder for each one. Bug: 715477 Change-Id: Ic88bdac6a80d23a4c45c81a04b20a35e90a3d4cd Reviewed-on: https://chromium-review.googlesource.com/570427 Commit-Queue: Galia Peycheva <galinap@google.com> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Nicolas Dossou-Gbété <dgn@chromium.org> Cr-Commit-Position: refs/heads/master@{#488286}
-
Koji Ishii authored
BUG=636993 TBR=eae@chromium.org NOTRY=true Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ibdf9bc40c3fc1a523405bfb8406a437d892a59dc Reviewed-on: https://chromium-review.googlesource.com/580047 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#488285}
-
Nico Weber authored
This was used long ago for testing with custom SDKs. Nowadays, most SDK references are inside a .gn file, and this script here only adds platform-tools/ and tools/ from the SDK to PATH. People can just set PATH to their custom SDK if they want. Bug: 330631 Change-Id: I1a88c0f18289b418c2299523b7f6a0099d660233 Reviewed-on: https://chromium-review.googlesource.com/579951Reviewed-by:
-
Michael Thiessen authored
Refactors some code from CTAs back button flow to be reusable by VR to know in advance whether clicking the back button will backgroud chrome (or try to show Chrome Home when that's enabled, which isn't supported in VR anyways). Bug: 732475 Change-Id: Ife41c456fac880f55ba3190f257fa7ed340d00e0 Reviewed-on: https://chromium-review.googlesource.com/571289 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yash Malik <ymalik@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#488283}
-
Nico Weber authored
We've been off gyp for a while, and even when we still were on gyp people weren't supposed to use android_gyp. https://codereview.chromium.org/234223002 added this compat fix for "3-4 weeks", those have by now passed as well. Bug: 330631 Change-Id: I25e0145a43771a42bcacde113b0154523da5c017 Reviewed-on: https://chromium-review.googlesource.com/579934Reviewed-by:
-
Koji Ishii authored
This patch creates Source/core/layout/ng/inline/README.md and move inline layout content from its parent directory. Our policy recommends each directory to have one README.md, and inline layout document should grow more. BUG=636993 TBR=eae@chromium.org NOTRY=true Change-Id: I528ee305034377697dc5a29d3015a321af691176 Reviewed-on: https://chromium-review.googlesource.com/579888Reviewed-by:
-
James Cook authored
The class is deprecated, so make a note of that. TBR=stevenjb@chromium.org Bug: none Test: none Change-Id: I77e1125dd0ef8d221638b82b99df5cbf4bbb8654 Reviewed-on: https://chromium-review.googlesource.com/579658Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#488280}
-
Mathieu Perreault authored
Bug: 746949 Test: browser_tests Change-Id: I7f80fb7102bd8dd413864ec74e5084587d74744c Reviewed-on: https://chromium-review.googlesource.com/579569 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#488279}
-
proberge authored
on-tap="toggleExpandButton_" had a line break in it, preventing the handler from being properly registered. TBR=tommycli@chromium.org Bug: 690020 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I14ab6338e5c81ef798fa2fce0749999f6e10978d Reviewed-on: https://chromium-review.googlesource.com/579654Reviewed-by:
proberge <proberge@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#488278}
-
Hyemi Shin authored
No intended behavior change. BUG=578344 TEST=none Change-Id: I155fff54d128dea6f44fc50c75daad0d86d474db Reviewed-on: https://chromium-review.googlesource.com/568066Reviewed-by:
Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#488277}
-
Justin Carlson authored
This change brings SyncedPrintersManager closer to PrinterDetector style interfaces, and aligns function names/styles with the design doc for CUPS printers management. It also removes a bunch of unique_ptr wrapping of printers that are passed around, since these are not at all performance critical and the unique_ptr stuff hampers readability (and leads to subtle bugs when unique_ptrs are both used in a bind and passed as a parameter at the same time). Also convert it to the factory-function pattern while I'm mucking with stuff and clean up the header. Bug: 742487 Change-Id: Ibc9dd0a2f94dad8cb7a1f4adb1897668800311bf Reviewed-on: https://chromium-review.googlesource.com/575289Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Justin Carlson <justincarlson@chromium.org> Cr-Commit-Position: refs/heads/master@{#488276}
-
Xida Chen authored
This test was originally put under canvas-experimental/webgl/ folder. We already have a webgl/ folder under canvas/. So this CL moves the test to canvas/webgl/. Bug: 725651 Change-Id: I790ccdf303f64116811a4159bdaf24a35dbae61e Reviewed-on: https://chromium-review.googlesource.com/579150 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#488275}
-
chrome://suggestionsColin Blundell authored
This WebUI is already present on other platforms. It will be useful for testing upcoming refactoring of the suggestions component. Change-Id: I303b02c04b0f90c34dd72bf0157199a60a26eb97 Reviewed-on: https://chromium-review.googlesource.com/574592Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#488274}
-
Fadi Meawad authored
This happens only when able to fastkilling renderers due to only running the tab being discarded. This also sorts tabs with beforeunload handlers before other tabs, as that state tends to signify tabs with unsaved user state. (ChromeOS only, for now) This is an ownership transfer of the CL: https://chromium-review.googlesource.com/c/537072/ based on oysteine's request since he is OOO. First patch is his CL + Rebase R=chrisha CC=oysteine BUG: chromium:731264,chromium:123049 Change-Id: If736141c2bb925453b7fa2c48179c1e481591032 Reviewed-on: https://chromium-review.googlesource.com/558007 Commit-Queue: Fadi Meawad <fmeawad@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#488273}
-
xdai authored
This is a reland of https://codereview.chromium.org/2955203002/. The original CL broke ash_unittests. Wire up the SplitViewController with the overview mode. It's a following up CL of https://codereview.chromium.org/2960843004/. Changes in this CL: 1. The split view mode can be initiated by dragging the window in overview mode to the side of the screen 2. After one window is snapped to one side of the screen, all the other overview windows will display in the other side of the screen, allowing the user to select another window to snap. When two windows are snapped to both sides of the screen, the overview mode will be ended. 3. The first snapped window will remain snapped until the user explicitly exit the split view mode. All the other windows (incluing newly created window) will be open in the other side of the screen. Clicking/Tapping on the overview button also open the overview windows in the other side of the screen. Not covered in this CL: 1. The highlighted region showing where split will occur is not implemented in this CL. 2. The split divider is not implemented in this CL. BUG=725683 TBR=oshima@chromium.org, varkha@chromium.org Change-Id: I307ac438bb45c0df5e347be296964375782ef3e7 Reviewed-on: https://chromium-review.googlesource.com/578490 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#488272}
-
Lei Zhang authored
- Check for missing fields in base::ParseProcVmstat() and return false in that case. Add unit tests to test for failure. - Change SystemMetricsTests to use const char arrays instead of std::string when possible. - Refactor a block of ChromeOS-only code in base::GetSystemMemoryInfo() into its own function. - Clang format the modified files. Change-Id: Ie70695d7a8efdfe1d951a980bebc21133b4b2da2 Reviewed-on: https://chromium-review.googlesource.com/578789Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#488271}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 12389500. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/347 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hta@chromium.org: external/wpt/webrtc TBR=qyearsley@chromium.org No-Export: true Change-Id: Iabc0b91eb0c0d297341ea773b2f58a49eaa7a020 Reviewed-on: https://chromium-review.googlesource.com/579149 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#488270}
-
Matt Falkenhagen authored
It'd be useful to know warm vs cold start ratio. Change-Id: Ic25b5ed997e2f5e81e8c18015ed71105d584b120 Reviewed-on: https://chromium-review.googlesource.com/578909Reviewed-by:
-
Matthew Jones authored
This change forces the toolbar to be shown in cases where it is hidden and the bottom sheet is opened. BUG=741320 Change-Id: Iad9ff71e0e71ae15c50f6db02bf194db4d97131b Reviewed-on: https://chromium-review.googlesource.com/576198Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#488268}
-
Christopher Grant authored
The Scene is meant to hold state supplied by the SceneManager, and consumed by the rendering subsystem. Scene shouldn't know about modes, prompts, etc. This CL tries to banish any such state. BUG= Change-Id: I5cab334aac5150b725ab6408625367d0554bdabf Reviewed-on: https://chromium-review.googlesource.com/576471 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#488267}
-
Tim Volodine authored
Add fallback to accelerometer + magnetometer for absolute device orientation (ondeviceorienationabsolute) when ROTATION_VECTOR is not available. The ROTATION_VECTOR is not available on some devices (e.g. Samsung Galaxy A7, see crbug.com/682535). The fallback approach is similar to what already happens for relative device orientation. BUG=682535 TEST=http://timvolodine.github.io/deviceorientation-test/ Change-Id: I7b01f803b1edfd3d7062f5f165c75796a59ca070 Reviewed-on: https://chromium-review.googlesource.com/574491 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#488266}
-
Matt Menke authored
Gerrit is too spammy, and there looks to be no plan to fix this. Getting dozens of emails before an issue is even sent out for review is just too much of a waste of time. Bug: none Change-Id: I338b7c51c18aa07a725cd481d19b254516d5bb74 Reviewed-on: https://chromium-review.googlesource.com/579688Reviewed-by:
Randy Smith <rdsmith@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#488265}
-
Vaclav Brozek authored
Most of the tests in passwords_settings_egtest.mm clear PasswordStore at the end. It does not hurt to clear it in the rest of the tests either, because clearing an empty store keeps it empty. To reduce boilerplate, this CL moves the call to clear PasswordStore from individual last lines of tests into the tearDown method of the fixture. Bug: 744058 Change-Id: I350f73cef271534d01390d2e032b06e00afca0fb Reviewed-on: https://chromium-review.googlesource.com/573542 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
-
Leslie Watkins authored
Rename TrayDetailsView::InfoLabel to TrayInfoLabel and moved it to its own file. It also now subclasses ActionableView instead of View, so it can be clickable. TrayInfoLabel::Delegate keeps track of whether or not the label is clickable, and handles clicks. Reland of https://codereview.chromium.org/2957043002/ This reverts commit fc8ab64a. Bug: 672263, 735642, 740671 Change-Id: I7957bc934e01e226ee588939a21d1fc4afc0bdb3 Reviewed-on: https://chromium-review.googlesource.com/578142 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
