GitLab

It turns out that JS -> base::Value conversion there produces doubles
while the code expected it to produce ints, like desktop/android do.

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I18c255597250956fbd1a224986fb806b3bb9fa11
Reviewed-on: https://chromium-review.googlesource.com/1052090
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557308}

This reverts commit 3c79bfc0.

In addition to the original CL bd3d1ea0, this includes a fix to the crash
when relaunching after changing about:flags.

Bug: 841006
Change-Id: I04c82074bb83da7ba5854b783862ec689d7a36e0
Reviewed-on: https://chromium-review.googlesource.com/1050976Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557307}

This reverts commit c0e58526.

Reason for revert: speculative attempt to fix http://crbug.com/840988

Original change's description:
> Update V8 to version 6.8.184.1 (cherry-pick).
> 
> Summary of changes available at:
> https://chromium.googlesource.com/v8/v8/+log/e3f3bcb2..9ef8a461
> 
> Please follow these instructions for assigning/CC'ing issues:
> https://github.com/v8/v8/wiki/Triaging%20issues
> 
> Please close rolling in case of a roll revert:
> https://v8-roll.appspot.com/
> This only works with a Google account.
> 
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
> 
> TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org
> 
> Change-Id: I1c65bbcf6ce40050b917cb288293b9226d1563ab
> Reviewed-on: https://chromium-review.googlesource.com/1049367
> Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#556739}

TBR=v8-autoroll@chromium.org,machenbach@chromium.org,hablich@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I7108d2aecebef1e7ca0355bca571e85d1cc01499
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1052527
Commit-Queue: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557306}

This CL adds an infobar to show the download progress. The actual
triggering logic of the infobar will be added in a subsequent CL.

Bug: 830814
Change-Id: If64cc1939ee4479f919a679d6cc9bf648657ada2
Reviewed-on: https://chromium-review.googlesource.com/1003754
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557305}

https://chromium.googlesource.com/angle/angle.git/+log/e95a7f077e8b..ce07f967c21e

$ git log e95a7f077..ce07f967c --date=short --no-merges --format='%ad %ae %s'
2018-05-09 geofflang Merge the Framebuffer onDestroy and onDestroyDefault methods.
2018-05-09 geofflang Pass a context pointer to Framebuffer[Impl]::getSamplePosition
2018-05-09 lucferron Vulkan: Clear to opaque black instead of transparent
2018-05-08 lucferron Vulkan: Support EXT_texture_storage
2018-05-07 oetuaho Issue a clearer warning about negative modulus operands

Created with:
  roll-dep src/third_party/angle
BUG=chromium:839468


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=fjhenigman@chromium.org

Change-Id: I364e15878f2c36d45e308f81659df42bdc43f354
Reviewed-on: https://chromium-review.googlesource.com/1052680Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#557304}

Should help with keeping the vm image warm in the bots' caches.

Currently 20 bots in the pool. Will scale up if needed.

TBR=dpranke@chromium.org

Bug: 840967, 832374
Change-Id: Ia09fdde0a94d0d798cd1c5073f0651b1ec92ac66
Reviewed-on: https://chromium-review.googlesource.com/1052824Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557303}

Currently, only Android Chrome Java tests are run with --verbose switch.
Adding this switch to desktop Chrome Java tests, to ease debugging.

TBR=kereliuk@chromium.org

Change-Id: Ifd9523272ee52f1bcee0642f4267339f4b78e857
Reviewed-on: https://chromium-review.googlesource.com/1050567Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557302}

This maintains consistency with other code.

Bug: 806965
Bug: internal b/79377657
Test: CQ
Change-Id: Iae3487bf573fcd704b0a9fda44ce1aaffe42d7a5
Reviewed-on: https://chromium-review.googlesource.com/1050694Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Stephen Lanham <slan@chromium.org>
Commit-Queue: Sean Topping <seantopping@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557301}

Add mock user data to "Local State" and create user profile
before hand so that the crash-n-restore test runs more like
in production.

Bug: None
Change-Id: I2e717e8876333fe0bd9e6015273d9c95b0639f48
Reviewed-on: https://chromium-review.googlesource.com/1052217Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557300}

Re-enable the following tests on Android Chrome stable:
* PageLoadingTest.testShouldBeAbleToGetAFragmentOnTheCurrentPage:
  PlzNavigate issue, already fixed in m65.
* CorrectEventFiringTest.testShouldReportTheXAndYCoordinatesWhenClicking:
  Originally disabled in m64, and no failure observed in later versions.
* CorrectEventFiringTest.testShouldEmitClickEventWhenClickingOnATextInputElement:
  Same as above.

TBR=kereliuk@chromium.org

Bug: chromedriver:2025 chromedriver:2076 chromedriver:2077
Change-Id: I283b48f5ba6e6e905a21dd9b6e53d5f0c26399c8
Reviewed-on: https://chromium-review.googlesource.com/1050808Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557299}

Bug: 836988
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iedcac22a68cb73f68f314f35b1e1c771ab52c8ad
Reviewed-on: https://chromium-review.googlesource.com/1036199
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557298}

This fuzzer is testing the LZW decompressor implementation in the GIF
codec, so its inclusion/exclusion from builds should be coupled with
the GIF codec's.

BUG=pdfium:1080

Change-Id: I0ead2c6b3f7d109f71dd9402eae49e0e157f2dd5
Reviewed-on: https://chromium-review.googlesource.com/1052223Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557297}

Instead of using nothing, which causes some weird effects when launching
chromium (e.g. XWindow initialized with data from the front buffer), while
the first expose event is not attended, define instead a solid colour
for the background so that at least the startup experience is consistent.

If possible, we'll use the content window's background color to fill that
void, falling back to white pixels when that's not feasible. The downside
of this is that it has the side effect of making resizing quite disturbing,
since the background is quite visible while resizing due to the slow
rendering process. So make sure that the XWindow's background is unset
(set to None) once the window has been Mapped, thus ensuring the
resizing experience does not regress. Wait until the first SwapBuffers
before resetting XWindow's background pixmap as a temporary workaround
for part of the screen being filled in white and the rest black on startup.

Bug: 554008
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I08ba276c115bb310ab47199745299b2766b24bd9
Reviewed-on: https://chromium-review.googlesource.com/1049805
Commit-Queue: Antoine Labour <piman@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557296}

https://chromium.googlesource.com/catapult.git/+log/483449aa724f..35d1268e4901

$ git log 483449aa7..35d1268e4 --date=short --no-merges --format='%ad %ae %s'
2018-05-09 eakuefner [Dashboard] Accept compressed uploads in add_histograms

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: I6eaad919606d213f5fcd9bed9d32dc9cba2f16ae
Reviewed-on: https://chromium-review.googlesource.com/1052819
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#557295}

Using wpt-import in Chromium 6ed80043.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17192

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org:
  external/wpt/fetch

TBR=danyao

No-Export: true
Change-Id: I00b4193e4d0769d2f3272543b97b7d054fa6c549
Reviewed-on: https://chromium-review.googlesource.com/1052429
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557294}

[Video Capture Service] Add unit test case for client releasing device handle during CreateDevice call

This is just to cover/clarify a situation that was not yet covered.

Bug: None
Change-Id: I5f5da1bf23cd847d711191cda95949d348d97ce8
Reviewed-on: https://chromium-review.googlesource.com/1038785Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557293}

This removes the last raster asset in ash_resources.grd, so remove that
file and the associated build target.

Bug: 840509,505953
Change-Id: I43ec69b5b8b9fc34aa71a1b65f204447e73b133c
Reviewed-on: https://chromium-review.googlesource.com/1050523
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557292}

This CL brings in a chromecast version of the extension
api permissions that will have to be registered for
ChromeVox.  Most of the APIs will end up being stubbed.

Bug: 73383411
Test: None
Change-Id: I6d847a9d3d6d19a016274c1498eb9a5f45c793fc
Reviewed-on: https://chromium-review.googlesource.com/1049956
Commit-Queue: Randy Rossi <rmrossi@chromium.org>
Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557291}

Bug: 777996
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: If13acb466acee907750147164613f31929c03b96
Reviewed-on: https://chromium-review.googlesource.com/1052370
Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557290}

std::make_unique<Type>(...) and base::WrapUnique<new Type(...)) are
equivalent but std::make_unique should be preferred, because it is
harder to use unsafely than base::WrapUnique.

Ref:
 https://www.chromium.org/developers/coding-style/cpp-dos-and-donts#TOC-Prefer-MakeUnique-to-WrapUnique

Bug: None
Change-Id: I6b8c379a74856162ae2f1f1faa772554bfc4fbb4
Reviewed-on: https://chromium-review.googlesource.com/1034049Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557289}

Set cursor:pointer for link element on svg.css

Bug: 841146
Change-Id: Idebace4d6ec4f3bd4b65ea12a52213289ebbf69e
Reviewed-on: https://chromium-review.googlesource.com/1052213Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557288}

This CL extends FaviconCache to be able to handle favicons fetched by
an icon's URL. It previously could only handle fetching favicons by
a page's URL.

We use this newly extended FaviconCache as a synchronous cache for
ChromeOmniboxClient's default search provider favicon fetching.

Note one caveat: Previously ChromeOmniboxClient would drop all but the
most recent request for the default search provider favicon. That
optimization was dropped in this CL, but I now think it was a premature
optimization anyways.

Bug: 823535
Change-Id: I01760a8937d1f0eb99548599006091409f749dd9
Reviewed-on: https://chromium-review.googlesource.com/1048973
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557287}

This is a reland of f4a598ff

Windows cannot resolve #!/usr/bin/env python depending on how it is
configured. To fix this explicitly use python in the subprocess call.

Interestingly, the Tryjobs didn't catch this and only the official
build waterfall does...

Original change's description:
> [Zucchini] (raw) Apply fuzzer
>
> This is part of a series of Fuzzers to be added to Zucchini for
> security review. This tests the raw data patch application logic
> exercising the patch reader and apply process. It only covers ~20%
> of code in 100000 executions as the bulk of the remaining code is
> associated with the much more complex and expensive to fuzz reference
> related code.
>
> With the supplied seed corpus the fuzzer reaches approximately 11000
> execs/s.
>
> This found a couple bugs which are fixed in:
> https://chromium-review.googlesource.com/c/chromium/src/+/1028575
>
>
> Bug: 835341
> Change-Id: Idc1d862bfaa6eb6313f39e10536f4750c05ab863
> Reviewed-on: https://chromium-review.googlesource.com/1028570
> Commit-Queue: Calder Kitagawa <ckitagawa@google.com>
> Reviewed-by: Samuel Huang <huangs@chromium.org>
> Reviewed-by: Greg Thompson <grt@chromium.org>
> Reviewed-by: Max Moroz <mmoroz@chromium.org>
> Reviewed-by: Jonathan Metzman <metzman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#557185}

Bug: 835341
Change-Id: I24e94dd0c2035d84c84636f0a0a30756ae7f0c36
Reviewed-on: https://chromium-review.googlesource.com/1052567
Commit-Queue: Calder Kitagawa <ckitagawa@google.com>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557286}

https://pdfium.googlesource.com/pdfium.git/+log/27924e6c9d43..575ceba24463

$ git log 27924e6c9..575ceba24 --date=short --no-merges --format='%ad %ae %s'
2018-05-09 thestig Make memory usage in CJBig2_HTRDProc::DecodeImage() O(1).

Created with:
  roll-dep src/third_party/pdfium
BUG=chromium:840728


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Iab49d82532675af46bcca01200b2aabdc6f45245
Reviewed-on: https://chromium-review.googlesource.com/1052681
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#557285}

ClusterFuzz routinely uses this to create fake bugs and there's only
three tests which use this:
- controls-repaint-for-network-change.html, which is a broken test and
tests nothing (i.e. breaking it still passes)
- media-play-promise.html #playDecodeError, which doesn't need to; it
can just use a real corrupt file.
- media-play-promise.html #playNetworkError, which is also a broken
test and with the addition of a true test reveals that the underlying
behavior being tested is underspecified. Filed http://crbug.com/841063

Code has been added to test network errors via MSEs ability to force a
network error on EOS, but as mentioned the underlying behavior being
tested by the test is broken. For now the test is commented out.

BUG=839288, 841063
TEST=existing tests pass.

Change-Id: I0c48f305d24760c6bace7113297423b44e93728b
Reviewed-on: https://chromium-review.googlesource.com/1043493Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557284}

Touch release events in cast system gesture margin were being eaten
when dragging from right, causing the first subsequent touch event to
be ignored.

Bug: internal b/78461207
Test: manual
Change-Id: Idb158ae6496feb3d096319de17a76b5118008290
Reviewed-on: https://chromium-review.googlesource.com/1052907Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Commit-Queue: Alex Sakhartchouk <alexst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557283}

Clearance inhibits margin collapsing and thus makes it possible to
resolve the BFC offset of its parent. In that regard we sometimes
incorrectly assumed that a child would get clearance. The only case
where we can tell for sure up front, is when there are adjoining floats
that match the value of the 'clear' property. In all other cases, we
first need to calculate the block-start border edge of the child.

Added a few new tests. Only two of them failed in NG prior to this CL,
but coverage seemed low, so I added them anyway. Two of them fail in the
legacy engine.

Move the code that detects pending child floats a bit further down, to
give HandleInflow() an opportunity to re-layout the child without
aborting container layout. Otherwise clearance on an empty block will
be lost when positioning the float. Added two tests for this
(second-float-inside-empty-cleared-block*), since nothing except a
multicol test (that happened to do complicated clearance stuff)
regressed.

Removed now unused bits from NGExclusionSpace.

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I73b4aa02e5e88d1063f345db271cde1ad31ea9f5
Reviewed-on: https://chromium-review.googlesource.com/1049974
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557282}

https://crrev.com/5ed7b147c2631389d601d99c831b56f17e0511be made
scrollbars appear in this test and removed the expectation but the
clipping is incorrect so the test fails.

Bug: 841342
Change-Id: Ic4efa5b648b288857c8b47878da1c57060303453
Reviewed-on: https://chromium-review.googlesource.com/1052212
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557281}

Bug: 838811
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I98804e49d7b50d7f192e54806a00669dc843a1ae
Reviewed-on: https://chromium-review.googlesource.com/1048970
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557280}

This cleans up multi-platform code paths selection and prepares for
the removal of OS_POSIX for the Fuchsia build.

Bug: 836416
Change-Id: Ie49af916b267bc49d4385bf2a1eeadaed860fa16
Reviewed-on: https://chromium-review.googlesource.com/1033954Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557279}

After ~M44 a handful of MobileStartup.* histograms are only recorded
with a suffix corresponding to the activity type (ChromeTabbedActivity,
CustomTabbedActivity, DocumentActivity). Unsuffixed histograms are not
recorded since then.

It seems that there is no way to mark a prefix as obsolete and leave
suffixes showing up on the dashboard. However, since the
suffix-ification happened a while ago, we can mark the common prefix as
"partial name" today. It will remove auto-suggest for old versions (not
too bad), and would avoid the confusion of finding the unsuffixed
versions on the dashboard without samples from modern Chrome versions.

In other words, this change adds base="true" to those histograms.

Bug: None
Change-Id: Ie5c9a3755c6fe187cdfe2d00af6d3b2771131037
Reviewed-on: https://chromium-review.googlesource.com/1052470Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557278}

CanvasResourceGpuMemoryBuffer always uses GL_TEXTURE_RECTANGLE_ARB as texture
target [0] when it should use gpu::GetPlatformSpecificTextureTarget() (which
boils down to the said GL_TEXTURE_RECTANGLE_ARB on Mac [1] which is the only
enabled platform [2]).  This change is needed to use CanvasResourceGMBs on
CrOs.

Unittests extended (I just wanted to mock & expect BindTexture but somehow
that needed adding other expectations).

[0] https://cs.chromium.org/chromium/src/third_party/blink/renderer/platform/graphics/canvas_resource.cc?type=cs&q=canvas_resource.cc+GL_TEXTURE_RECTANGLE_ARB&sq=package:chromium&l=207
[1] https://cs.chromium.org/chromium/src/gpu/command_buffer/common/gpu_memory_buffer_support.cc?type=cs&q=GetPlatformSpecificTextureTarget&sq=package:chromium&l=169
[2] https://cs.chromium.org/chromium/src/content/child/runtime_features.cc?dr=CSs&q=runtime_features.cc&sq=package:chromium&l=154

Bug: 839970
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Iaa1150e95f83d8ab91464b0d8d385556ba5a9ed6
Reviewed-on: https://chromium-review.googlesource.com/1049832Reviewed-by: Justin Novosad <junov@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557277}

Bail out on zeroed memory for HeapVectorBacking<Member<T>> instead
of further dispatching through TraceTraits to Visitor.

Bug: chromium:840696
Change-Id: I071858b597d3de82710b89990bd2fa942acb964e
Reviewed-on: https://chromium-review.googlesource.com/1051988
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557276}

Bug: 841212
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I4cdfef554f257a7bd920aa9efba184ae8d4126ba
Reviewed-on: https://chromium-review.googlesource.com/1052549Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557275}

Extensions: Disable ExtensionWebRequestApiTest.WebRequestClientsGoogleComProtection with network service.

r548673 enabled the WebRequestApiTest.WebRequestClientsGoogleComProtection test
for network service. To make a network request from the browser, the test
replaced the usage of URLFetcher with SimpleURLLoader. However this network
request never reaches the WebRequest API layer, hence defeating the purpose of
the test. To sanity check that a browser request is intercepted by extension,
this CL makes another browser request. This causes the test to fail with the
network service.

BUG=721414

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I6b18ed906b3f01c10521fd89a24414e9a4351edd
Reviewed-on: https://chromium-review.googlesource.com/1049276Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557274}

TBR=vitalii@chromium.org,nednguyen@google.com

Bug: 841189,812051
Change-Id: Ifddff5dca063ebebe2567f62c0f8257daaddee54
Reviewed-on: https://chromium-review.googlesource.com/1052224Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557273}

This change adds a WorkerNavigatorUSB supplement for WorkerNavigator.
The WorkerNavigatorUSB interface contains a usb attribute that returns
a USB object. The constructor for this USB object was also changed to
use an ExecutionContext* parameter to allow a worker to properly
initialize the object.

This change also updates the global interface listing tests to reflect
the new attribute that WorkerNavigator contains and adds web platform
tests to check that the WorkerNavigator does indeed have the usb
attribute defined in the supported contexts.

Due to a bug (https://crbug.com/839117) with the WebIDL bindings
generator, the global-interface-listing-service-worker.html test
exposes the usb attribute of WorkerNavigator. Therefore, a check is
performed in WorkerNavigatorUSB to return a null pointer if the
execution context is a ServiceWorkerGlobalScope. Since the intended
behavior for navigator.usb in a service worker is to be undefined, the
web platform test for this checks that condition instead.

Bug: 837414
Change-Id: I3ca63c9ae0b85e5425134024d2fdd9b29ef7d8c3
Reviewed-on: https://chromium-review.googlesource.com/1024724
Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Chong Zhang <chongz@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557272}

This is effectively applying MD refresh toggle style, as well
as preparing for removing paper-toggle-button from third_party/polymer.

Bug: 768073
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I90c3eb4098304b3ca707665d52bb6b54e67bdce6
Reviewed-on: https://chromium-review.googlesource.com/1048167
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557271}

They're unneeded (esp now that the parent class is excluded), and
have the potential to overlap with cronet_test_java.jar classes.

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: I14b884c9b3c2e66ac0dd93007ed668c1ff22db79
Reviewed-on: https://chromium-review.googlesource.com/1040546Reviewed-by: Misha Efimov <mef@chromium.org>
Commit-Queue: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557270}

Bug: 840523
Change-Id: I4676c3ee4f5b812173193b45a02a88291afac8ab
Reviewed-on: https://chromium-review.googlesource.com/1048403Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557269}