- 07 Sep, 2018 40 commits
-
-
Joel Hockey authored
Created static FileManagerPrivateStrings::GetStrings() which is called by fileManagerPrivate.getStrings() extension function, and can now also be called by utility executable to generate strings.js file for testing rather than having strings duplicated. Bug: 813477 Change-Id: Ife2ac1b018660451a8c32180e5260f1d9fb6baf2 Reviewed-on: https://chromium-review.googlesource.com/1208993 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#589442}
-
Nicholas Verne authored
It is possible for Crostini apps to be disallowed by policy. This can change at any time for a give machine, so we always need to check. While the pinning bug is still happening, we also need this as a failsafe. Bug: 881681 Change-Id: I2e2497ef9cdaee7f989d38931a88886d52535cf9 Reviewed-on: https://chromium-review.googlesource.com/1212373Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#589441}
-
Rakina Zata Amni authored
Adds a new level of "invisible" attribute: "static", which prohibits custom element upgrade inside invisible-static subtree unless authors explicitly call CustomElementRegistry.upgrade() See design doc at https://goo.gl/sEJt3e I2I: https://groups.google.com/a/chromium.org/d/msg/blink-dev/Icw_sU6PqVA/8hwXw0jTDwAJ Bug: 873057 Change-Id: I5c2a88446ca3a758b28917fcae349c5cdadd0132 Reviewed-on: https://chromium-review.googlesource.com/1204373Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#589440}
-
Nicholas Verne authored
Tremplin now sends a signal indication percent downloaded for a container. This is bounced to the appropriate observers (in this case, the CrostiniInstallerView). The install progress bar now indicates install progress based on download percent and estimated time for each stage. Bug: 860094 Change-Id: Iaa4dfe3464e30931d8ae1fce15a46f2d5ffbe7b5 Reviewed-on: https://chromium-review.googlesource.com/1201647Reviewed-by:
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ea8b6f95c763..7cd2a9514837 git log ea8b6f95c763..7cd2a9514837 --date=short --no-merges --format='%ad %ae %s' 2018-09-07 buildbot@webrtc.org Roll chromium_revision 450316ff..d03e9be2 (589248:589368) 2018-09-06 emircan@webrtc.org Multiplex codec cleanups 2018-09-06 peah@webrtc.org AEC3: Parametrize the delay estimator to leverage strong echo paths 2018-09-06 benwright@webrtc.org Updated FrameEncryptorInterface and FrameDecryptorInterface with status code. 2018-09-06 sukhanov@webrtc.org Interface for media transport 2018-09-06 buildbot@webrtc.org Roll chromium_revision fcd25fc0..450316ff (589073:589248) Created with: gclient setdep -r src/third_party/webrtc@7cd2a9514837 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium: 880686,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I056a13c149b75fb27ccef3358e6fdbac8f772e85 Reviewed-on: https://chromium-review.googlesource.com/1212563Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589438}
-
Trent Apted authored
The //ui/file_manager/common/js:util target has a dependency on the file_manager_private extern. Break out that extern to a separate target to bundle its hidden dependencies together, since multiple things depend on it. Bug: 860355 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Icfa65dff5c692b6bd415f9f2d5c67b14a0db0ef6 Reviewed-on: https://chromium-review.googlesource.com/1212706Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#589437}
-
Alan Cutter authored
Change-Id: I35304eb77e8e09d971b1854416c121bc5ec0935e Reviewed-on: https://chromium-review.googlesource.com/1212369Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#589436}
-
Rune Lillesveen authored
Runtime flag is now removed so adjusted comment accordingly. IsActiveV0InsertionPoint required pulling in v0_insertion_point.h, so dropped doing that. Change-Id: I914c1567c6a90473b53b470ff34d35b32b2530d2 Reviewed-on: https://chromium-review.googlesource.com/1209502Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#589435}
-
Yutaka Hirano authored
This is a reland of 074455de Original change's description: > Strengthen requirements on CORS-safelisted request-headers > > With this CL, some request headers that used to be treated as > CORS-safelisted are not CORS-safelisted any more. Specifically, > > - "accept", "accept-language" and "content-language" have a stronger > check on its value > - All headers whose value exceeds 128 bytes are treated as not > CORS-safelisted > - If the sum of value length of CORS-safelisted headers exceeds 1024, > then all of them are treated as not CORS-safelisted. > > This CL also implements > https://fetch.spec.whatwg.org/#no-cors-safelisted-request-header. > > This is for https://github.com/whatwg/fetch/pull/736. > > Bug: 824130 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: Ib12a7dbff6367717a43130ae59304dca55b7bf4e > Reviewed-on: https://chromium-review.googlesource.com/1196563 > Commit-Queue: Yutaka Hirano <yhirano@chromium.org> > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589153} Bug: 824130 Change-Id: Ia5caad12a51ee44713cf4cf11f42b1fc9ab831a9 Cq-Include-Trybots: luci.chromium.try:linux_mojo Tbr: toyoshim@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1212425 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#589434}
-
Mike Dougherty authored
Fixes for comments on crrev.com/c/1192424 after merge. Bug: 851636 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Id742b36e6f46a647b510f81307f371b51bac7b3f Reviewed-on: https://chromium-review.googlesource.com/1208463 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#589433}
-
Francois Doray authored
The function is renamed from CanIncreaseCurrentThreadPriority() to CanIncreaseThreadPriority() so it's clear that it doesn't return a per-thread value. Also, a ThreadPriority argument is added to allow implementations to return a different value depending on the target priority. On Linux for example, a priority increase should succeed if the target priority is within the range allowed by RLIMIT_NICE. This is a no-op CL from an execution point of view. Bug: 816389 Change-Id: I98cb640527cc2cccb85db45395210e41d6bc5f64 Reviewed-on: https://chromium-review.googlesource.com/1187506 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#589432}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/dd2c588e3811..515e7fe03790 git log dd2c588e3811..515e7fe03790 --date=short --no-merges --format='%ad %ae %s' 2018-09-07 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@515e7fe03790 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I7225adeec45924aad4c223b18c7fb0a05d633502 Reviewed-on: https://chromium-review.googlesource.com/1212562Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589431}
-
Chromium WPT Sync authored
Using wpt-import in Chromium bfbc8215. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24205 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: I59e21a19eda15b910d8b482231dd98a93d76aac4 Reviewed-on: https://chromium-review.googlesource.com/1212354 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#589430}
-
Nigel Tao authored
N SimulateEtc methods were replaced with 1 method. Change-Id: I0b9b0701959de1cbc0c8b273cd5f59a929766de7 Reviewed-on: https://chromium-review.googlesource.com/1208990Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#589429}
-
Oksana Zhuravlova authored
This change updates the service_manager::Instance code to reference its options_.can_connect_to_other_services_with_any_instance_name value instead of "service_manager:instance_name" in the "required" section of its interface provider specs. Tests and existing manifests were updated accordingly. Bug: 866967 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I7811919f86470cb098d588710e9aa3f2dd497e32 Reviewed-on: https://chromium-review.googlesource.com/1208710Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#589428}
-
Yuzu Saijo authored
This CL adds a parameter to fieldtrial_testing_config to test a new feature of Oomintervention in finch now that canary/dev results look good. Bug: 879026,764481 Change-Id: I44f0c472db191ce92404a714ef33304992e251b4 Reviewed-on: https://chromium-review.googlesource.com/1183043 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#589427}
-
Pin-chih Lin authored
BUG=b:112181526 BUG=881669 TEST=build Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ife2de572cad1a47c0e98a6b9f792cfd962af96f0 Reviewed-on: https://chromium-review.googlesource.com/1212204 Commit-Queue: Pin-chih Lin <johnylin@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#589426}
-
Chris Hall authored
Bug: 877724 Change-Id: Iaa71eda0e0fa94f9d23c9bc71b12d2abd3ec4224 Reviewed-on: https://chromium-review.googlesource.com/1209001 Commit-Queue: Chris Hall <chrishall@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#589425}
-
Chris Harrelson authored
The situation should never happen, but nevertheless seems to. Bug: 880930 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1dec6cdb3cb2c004511646a7133c4564a5a4f4ca Reviewed-on: https://chromium-review.googlesource.com/1211872 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#589424}
-
Yuki Shiino authored
This reverts commit ebe80ad0. Reason for revert: Suspicious to break MSan Tests. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20MSan%20Tests/11452 Original change's description: > Wait for ukm entry in TryAutoplay > > The test fails due to a race of UkmRecorder::AddEntry with DOMMessageQueue::Observe: > https://cs.chromium.org/chromium/src/services/metrics/public/cpp/delegating_ukm_recorder.cc?q=src/services/metrics/public/cpp/delegating_ukm_recorder.cc&sq=package:chromium&g=0&l=137 > > Bug: 880217 > Change-Id: Icf099c3eb1094d8a571dc6f87b152e3c838807dc > Reviewed-on: https://chromium-review.googlesource.com/1204011 > Reviewed-by: Tommi <tommi@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Commit-Queue: Steven Holte <holte@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589317} TBR=tommi@chromium.org,holte@chromium.org,jochen@chromium.org,rkuksin@yandex-team.ru Change-Id: I2c930e1d9ac74bd63ab876f06e494824fd4524d2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 880217 Reviewed-on: https://chromium-review.googlesource.com/1212245Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#589423}
-
Sammie Quon authored
Test: ash_unittests ShelfLayoutManagerTest.VisibleInOverview Bug: 881153 Change-Id: I2b5b8122831b5c71bc4ee4fcf4360d7626e11f0b Reviewed-on: https://chromium-review.googlesource.com/1211741 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#589422}
-
Hitoshi Yoshida authored
This reverts commit da27378f. Reason for revert: This CL caused many crashes in the wild. (crbug.com/881348) Original change's description: > Split implementation of EventListener and EventHandler > > This CL add new class blink::V8EventListenerImpl which implements > ONLY EventListener (not EventHandler). It has a blink::V8EventListener > which inherits blink::CallbackInterfaceBase. As a result, EventListener > will start to handle incumbent realm. EventHandler will still be > offered by blink::V8AbstractEventListener (this class is renamed to > blink::V8AbstractEventHandler in this CL) after this CL submitted. > Also, entry realm was set to wrong one (event target's one) with > blink::V8AbstractEventLisntener so this CL set it to listener's one as > defined in standard. > > Regarding crbug.com/872138 : > Current blink::V8AbstractEventListener implements both of EventListener > and EventHandler, so I am trying to implement new class for > EventListener first to separate these. EventHandler will be modified in following CLs. > > Regarding crbug.com/878658 : > This CL modifies expectation file for layout test: > fast/events/touch/gesture/gesture-tap-frame-removed.html > This is because event listener starts to remember incumbent realm after > this CL and it results in incorrect behavior as explained in the BUG. > This is not a regression, but have to be resolved in following CLs. > > Bug: 872138, 878658, 606900, 849236 > Change-Id: I4bf7fe2f4fd51287f873c2377edfd57e4bb2a54a > Reviewed-on: https://chromium-review.googlesource.com/1172234 > Commit-Queue: Yuki Yamada <yukiy@google.com> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Hayato Ito <hayato@chromium.org> > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > Cr-Commit-Position: refs/heads/master@{#588748} TBR=peria@chromium.org,yukishiino@chromium.org,hayato@chromium.org,haraken@chromium.org,yukiy@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 872138, 878658, 606900, 849236, 881348 Change-Id: Ie981df66657c8868c769cb8d18bf799605cfd004 Reviewed-on: https://chromium-review.googlesource.com/1212202 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#589421}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=amineer@chromium.org Change-Id: Ibfab68882fda3e5eb65b90a02a48246c2549d20f Reviewed-on: https://chromium-review.googlesource.com/1212007Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#589420}
-
Kouhei Ueno authored
This should fix crash/caab6eb137e58385 This CL addresses the unhandled case in crrev.com/582126 TBR=falken@chromium.org Bug: 881126, 868592 Change-Id: I906eecc3bf21aa9900355b1f312bd5025375fa8d Reviewed-on: https://chromium-review.googlesource.com/1207781 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#589419}
-
Timothy Loh authored
This CL changes the CrostiniManager from being a global singleton to a profile keyed service. This tidies up the implementation as we can now assume that we have a valid Profile, so don't need to sanity check the owner_id/cryptohome_id arguments that used to be passed into arguments, and also simplify the members by dropping the owner_id keys. Tests will now use individual CrostiniManager objects instead of re-using the same CrostiniManager, avoiding test runs influencing other test runs. This CL also removes the CrostiniRestarterServiceFactory, and moves the functionality of CrostiniRestarterService into the CrostiniManager. One side-effect of this CL is that the on-login component update will occur on each (primary profile) log-in, instead of once per Chrome restart. Change-Id: If76895cfc3994cb0bda3504e09bae452955dbe6b Reviewed-on: https://chromium-review.googlesource.com/1201646Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#589418}
-
Chris Hall authored
Bug: 856209 Change-Id: Ifcb55f5e3f7e50ff94ebfe1a6e607e06c22d4add Reviewed-on: https://chromium-review.googlesource.com/1212363Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#589417}
-
Mathieu Perreault authored
Bug: 881650 Test: Run chrome with --force-variations-ids=12345, look for the headers in the request to translate in chrome://net-internals Change-Id: I51cc33d4d7b0cf9d6a74a433b277f0890b990b01 Reviewed-on: https://chromium-review.googlesource.com/1212403 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Michael Martis <martis@chromium.org> Cr-Commit-Position: refs/heads/master@{#589416}
-
Christopher Cameron authored
Update NativeWidgetMacNSWindow to use the mojo BridgeNativeWidgetHost interface instead of directly dereferencing views structures. Make similar changes to ViewsNSWindowDelegate. Update the mojo interfaces to include these functions. Remove the nativeWidgetMac property from ViewsNSWindowDelegate. Replace it with an "id" uint64_t on NativeWidgetMacNSWindow, which can be used to look up a corresponding - BridgedNativeWidgetImpl (in the app/viewer process) - BridgedNativeWidgetHostImpl (in the browser process) - a follow-on patch will add a "shadow" NativeWidgetMacNSWindow in the browser process which will use this id - that window will not be visible, but will be used for state tracking and bounds computations Bug: 859152 Change-Id: I9f62aefa1d4eba9961f691b5bd9247871e121355 Reviewed-on: https://chromium-review.googlesource.com/1205477Reviewed-by:Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#589415}
-
Mina Almasry authored
Test: on audio-only device, video device, cast_media_unittests Change-Id: Ifa00a3464b84d9f95816d3b7279db5e5954ee4c9 Reviewed-on: https://chromium-review.googlesource.com/1211945 Commit-Queue: Mina Almasry <almasrymina@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#589414}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/106d04e907c1..b090b2b26803 git log 106d04e907c1..b090b2b26803 --date=short --no-merges --format='%ad %ae %s' 2018-09-07 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 dff32a0da1de..801719235b13 (3 commits) Created with: gclient setdep -r src/third_party/skia@b090b2b26803 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I5f43b700df646a1702ea9f1fbe1cd58e2a2de801 Reviewed-on: https://chromium-review.googlesource.com/1212502Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589413}
-
Aaron Leventhal authored
The live region changed events are needed by current versions of JAWS, which do not process the text inserted events fired by Chrome in all modes. Specifically, current versions of JAWS processes text inserted events in virtual cursor mode but not in focus mode. This may change in future versions of JAWS, and so at some point the live region changed events may truly become redundant with the text inserted events. NOTRY=true Bug: 878929 Change-Id: I3286c84d1d6366735a38af19e68f4c526658b68b Reviewed-on: https://chromium-review.googlesource.com/1211508 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#589412}
-
Azeem Arshad authored
This change adds logic to retrieve and listen for changes in multidevice feature state and enables/disables establishing background connection from service worker approriately. Bug: 876163 Change-Id: I593a27f46a793678039ca40a1d0e49e97152c616 Reviewed-on: https://chromium-review.googlesource.com/1208143Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#589411}
-
Jinsuk Kim authored
Now that TabBrowserControlsOffsetHelper object can now be obtained from TabBrowserControlsOffsetHelper.from(Tab), this CL removes the API from Tab class. Also, |FullscreenManager.setTab()| takes over the task of updating the offsethelper from Tab. Tab still has a reference to offset helper object, which will go away in a couple of more CLs that move all the related tasks out of Tab. Bug: 877878 Change-Id: I416230b59ca5704c055fca6b5eb89561f62d4a07 Reviewed-on: https://chromium-review.googlesource.com/1205971Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#589410}
-
Kyoko Muto authored
In this Cl, we reuse the "backend" of the imperative Shadow DOM Distribution API for a new custom element, <my-detail>/<my-summary>. In addition, we add reftest and perftests to compare the custom element, <my-detail>/<my-summary> to built-in custom element, <detail>/<summary>. perftest result: built-in element (ave)0.635 ms/new element (ave)1.030 ms Bug: 869308 Change-Id: If3304c65382bc5ad57f4cfe59b1d1a623a22c471 Reviewed-on: https://chromium-review.googlesource.com/1192783 Commit-Queue: Kyoko Muto <kymuto@google.com> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#589409}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/bb081a62dc30..ea8b6f95c763 git log bb081a62dc30..ea8b6f95c763 --date=short --no-merges --format='%ad %ae %s' 2018-09-06 benwright@webrtc.org Adds the Java interface points for FrameEncryptor/FrameDecryptor. 2018-09-06 mbonadei@webrtc.org Fix no_global_constructors in congestion_controller/pcc. 2018-09-06 mbonadei@webrtc.org Fix no_global_constructors in congestion_controller/bbr. 2018-09-06 mbonadei@webrtc.org Fix no_global_constructors in congestion_controller/goog_cc. 2018-09-06 andersc@webrtc.org Fix paths for macOS framework’s copy actions. 2018-09-06 jonasolsson@webrtc.org Remove simple stringstream usages. 2018-09-06 mbonadei@webrtc.org Enable -Wexit-time-destructors and -Wglobal-constructors. 2018-09-06 mbonadei@webrtc.org Partial revert of: 'Bump xcode versions for WebRTC bots.' 2018-09-06 nisse@webrtc.org Reland "Refactor TestAudioDeviceModule to not depend on EventTimerWrapper." 2018-09-06 srte@webrtc.org Adds maximum burst length to InterArrival class. 2018-09-06 jonasolsson@webrtc.org Remove std::stringstream from the RTC_CHECK implementation. 2018-09-06 asapersson@webrtc.org Remove unimplemented function declarations VCMGenericDecoder::External and VCMTimestampMap::Reset. 2018-09-06 danilchap@webrtc.org Cleanup RtpPacketizerGeneric 2018-09-06 jonasolsson@webrtc.org Add a LOG macro with customizable file name and line number. 2018-09-06 nisse@webrtc.org Reland "Explicitly wrap main thread in test_main.cc." Created with: gclient setdep -r src/third_party/webrtc@ea8b6f95c763 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:none TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I22406073527ccc94e0a2e672218156896be08832 Reviewed-on: https://chromium-review.googlesource.com/1211866Reviewed-by:
-
Kyle Qian authored
SecureChannel previously had no handlers for when the BluetoothAdapter is disabled or removed while a connection request is pending. This CL adds observer methods to PendingConnectionRequestBase that will fire when device::BluetoothAdapter detects that the adapter has been disabled or removed, causing the request to be cancelled. Bug: 854366 Change-Id: Ice45c373f42a6e9065d8c3564988904e02e7fa9e Reviewed-on: https://chromium-review.googlesource.com/1195099 Commit-Queue: Kyle Qian <kyleqian@google.com> Reviewed-by:
-
Clark DuVall authored
The bypass_redirects_check bit used to be set from the return value of WillCreateURLLoaderFactory, because the WebRequest proxy was the only proxy that would cause that to be true. Now there is also a signin proxy which can return true, so pass in a separate bool* for bypass_redirects_checks that can be set based on WebRequest. Bug: 868545 Change-Id: I361a4d89393a72552954471c8c5566bc7b1d7a17 Reviewed-on: https://chromium-review.googlesource.com/1211808Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#589406}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/60e7f52377fd..dd2c588e3811 git log 60e7f52377fd..dd2c588e3811 --date=short --no-merges --format='%ad %ae %s' 2018-09-07 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@dd2c588e3811 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I7653852bdf13041899492b3722ebaf83f4348f68 Reviewed-on: https://chromium-review.googlesource.com/1212146Reviewed-by:
-
Findit authored
This reverts commit b60e5cc0. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 589389 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2I2MGU1Y2MwYmQ0YjM1MWM1ODk4ZGMzNjM3ZjUzN2MzNTU1NDZjMTEM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Cast%20Audio%20Linux/20069 Sample Failed Step: base_unittests Original change's description: > [PartitionAlloc] Add a flag to allow callers to zero-fill allocations. > > This enables callers to avoid doing it themselves (centralizing the `memset` in > 1 place, rather than duplicating it at every call site that wants it), and to > allow the PartitionAlloc implementation to avoid doing it itself if the > operating system has already zero'd the new page(s). > > Bug: 864462,680657 > Change-Id: Ibeae0bf7b9f20238334bf9bc022d0f243a77ef11 > Reviewed-on: https://chromium-review.googlesource.com/1162825 > Commit-Queue: Chris Palmer <palmer@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Albert J. Wong <ajwong@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589389} Change-Id: Ifd54700a2acb141c458df69304d7ccdce2719cc5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 864462,680657 Reviewed-on: https://chromium-review.googlesource.com/1212346 Cr-Commit-Position: refs/heads/master@{#589404}
-
Trent Apted authored
Metrics were added 5 years ago in r188357, but they lack metadata. Bug: 879446 Change-Id: I42daa58100bd8ed6c7c2d13542913e56d82f6f37 Reviewed-on: https://chromium-review.googlesource.com/1208999 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#589403}
-
