GitLab

Adding some missing #includes to autofill_messages.h.

BUG=362057

Review URL: https://codereview.chromium.org/233173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263119 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/233073003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263118 0039d316-1c4b-4281-b951-d872f2087c98

Skia roll was reverted.

> Fix GN Build after Skia roll.
> 
> Skia introduced a new define that is required to build.
> 
> TBR=djsollen@chromium.org
> 
> Review URL: https://codereview.chromium.org/234203002

TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/234283003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263115 0039d316-1c4b-4281-b951-d872f2087c98

Skia roll was reverted.

> Fix Skia link errors in the GN build
> 
> TBR=djsollen@chromium.org
> 
> Review URL: https://codereview.chromium.org/234123004

TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/234313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263114 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263113 0039d316-1c4b-4281-b951-d872f2087c98

Broke iOS Simulator (dbg):
http://build.chromium.org/p/chromium.mac/builders/iOS%20Simulator%20%28dbg%29/builds/15778

Ld /b/build/slave/iOS_Simulator__dbg_/build/src/xcodebuild/Debug-iphonesimulator/components_unittests.app/components_unittests normal i386
[...]
Undefined symbols for architecture i386:
  "SkSSE2ProcCoeffXfermode::SkSSE2ProcCoeffXfermode(SkReadBuffer&)", referenced from:
      SkSSE2ProcCoeffXfermode::CreateProc(SkReadBuffer&) in libskia_library.a(SkXfermode.o)
ld: symbol(s) not found for architecture i386

> roll skia DEPS to 14128
> 
> Chromium base revision: 262955 / 
> Old Skia revision: 14102 
> New Skia revision: 14128
> Control CL: https://codereview.chromium.org/233193002/
> 
> Bypassing commit queue trybots: 
> NOTRY=true
> 
> Review URL: https://codereview.chromium.org/232783004

TBR=bensong@google.com

Review URL: https://codereview.chromium.org/234103003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263112 0039d316-1c4b-4281-b951-d872f2087c98

In bionic, open, access and dup2 are wrappers of openat, faccessat and dup3 instead of real syscalls.

BUG=166704

Review URL: https://codereview.chromium.org/226923003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263107 0039d316-1c4b-4281-b951-d872f2087c98

TBR=djsollen@chromium.org

Review URL: https://codereview.chromium.org/234123004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263106 0039d316-1c4b-4281-b951-d872f2087c98

With the conversion of GetAllNodes in r262193, there are no longer any
uses of the Sync JS framework's request + reply framework.

The generic framework was useful when we could guarantee that the
requests would be handled in order, in the SyncManager, and on the sync
thread, but new requirements have forced us to re-implement much of this
functionality in other ways.

Since no one uses this code, and no one plans to use this code, and it
depends on some semi-deprecated concepts (WeakHandle), the best course
of action seems to be to delete it.  We can always fetch it from SVN
history and clean it up if we find another use for it.

BUG=328606,357821

Review URL: https://codereview.chromium.org/231013003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263105 0039d316-1c4b-4281-b951-d872f2087c98

Because the Animate() method was recently changed to pass the current
frame's tick time in r259735, getting the diff between it and the fling's
start time would often result in a negative time delta. This caused the
fling to report no scrolling and the scroll would stop. We still want to
start flinging immediately where possible so instead of letting Animate()
always set the startTime and losing a frame, we do it only for a
non-positive time delta.

This does not affect Android since its gesture fling ignores the passed
delta and uses gfx::FrameTime::Now().

BUG=360633

Review URL: https://codereview.chromium.org/232683003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263104 0039d316-1c4b-4281-b951-d872f2087c98

BUG=304341
TEST=modal dialogs still work

Review URL: https://codereview.chromium.org/229693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263103 0039d316-1c4b-4281-b951-d872f2087c98

BUG=297026
R=ben@chromium.org

Review URL: https://codereview.chromium.org/231733005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263101 0039d316-1c4b-4281-b951-d872f2087c98

Skia introduced a new define that is required to build.

TBR=djsollen@chromium.org

Review URL: https://codereview.chromium.org/234203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263100 0039d316-1c4b-4281-b951-d872f2087c98

Internal code gets around this by calling ContentView.hideSelectActionBar.
Remove the hop as the ContentView variant is going away.
BUG=360664
R=dtrainor@chromium.org

Review URL: https://codereview.chromium.org/232963004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263099 0039d316-1c4b-4281-b951-d872f2087c98

BUG=322664

Review URL: https://codereview.chromium.org/231313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263098 0039d316-1c4b-4281-b951-d872f2087c98

Per Matroska spec difference between frames timestamps must be used as
block duration when neither Duration nor DefaultDuration is specified.
Problem was that WebMClusterParser was waiting for the next frame
even when DefaultDuration is specified.

BUG=338529

Review URL: https://codereview.chromium.org/230173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263097 0039d316-1c4b-4281-b951-d872f2087c98

BUG=359550
TEST=browser_tests

Review URL: https://codereview.chromium.org/231853005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263096 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
R=rsesek@chromium.org, thestig@chromium.org

Review URL: https://codereview.chromium.org/231103003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263095 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263094 0039d316-1c4b-4281-b951-d872f2087c98

Chromium base revision: 262955 / 
Old Skia revision: 14102 
New Skia revision: 14128
Control CL: https://codereview.chromium.org/233193002/

Bypassing commit queue trybots: 
NOTRY=true

Review URL: https://codereview.chromium.org/232783004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263093 0039d316-1c4b-4281-b951-d872f2087c98

BUG=358713
TEST=Put system in dev mode, open Crosh, type `shell`, and run sudo.

Review URL: https://codereview.chromium.org/228783005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263092 0039d316-1c4b-4281-b951-d872f2087c98

The IsSchemeBitSet method was added in https://chromiumcodereview.appspot.com/12792005/#ps4001,
but removed during a refactor within the same CL. It was never used, so it can be removed.

Review URL: https://codereview.chromium.org/233293004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263091 0039d316-1c4b-4281-b951-d872f2087c98

On WriteMessageRaw failure we own the handles, which we might
want to log or keep but for correctness now we just close.

BUG=none
TBR=viettrungluu
TEST=none

Review URL: https://codereview.chromium.org/233073005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263090 0039d316-1c4b-4281-b951-d872f2087c98

BUG=360732
NOTRY=True

Review URL: https://codereview.chromium.org/232743004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263088 0039d316-1c4b-4281-b951-d872f2087c98

BUG=362239
TEST=links at the top of the output actually work.
NOTRY=true

Review URL: https://codereview.chromium.org/232703004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263087 0039d316-1c4b-4281-b951-d872f2087c98

Adds libjpeg and some global flags for Ozone from the GYP build.

Improves error messages for mismatched item types I noticed when writing this patch (changes in builder.cc).

BUG=
R=bradnelson@google.com

Review URL: https://codereview.chromium.org/224633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263086 0039d316-1c4b-4281-b951-d872f2087c98

PrefHashCalculator uses empty keys in developer builds. This fixes
Chrome startup in debug builds.

BUG=none

Review URL: https://codereview.chromium.org/231603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263085 0039d316-1c4b-4281-b951-d872f2087c98

 This is to mitigate the issue crbug.com/354775 by at least compiling wm_core_unittsts on bots.

BUG=354775
R=jamescook@chromium.org

Review URL: https://codereview.chromium.org/233733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263083 0039d316-1c4b-4281-b951-d872f2087c98

This makes the header checker and include iterator work from InputFiles (which basically just hold the file buffer) rather than just raw strings. This allows us to reference these files from Err.

Some extra line/char tracking is now in the include iterator so we can actually quote from and annotate the place in the source file where the bad include is, which looks much nicer than "the file blah included blah". It also makes it possible to write much shorter error messages that still make sense.

This adds visibility checking as previously documented in the help for "public" and a unit test for that.

This updates the documentation for "public" which was wrong (it referred to patterns which was not used).

R=scottmg@chromium.org
Reland of https://codereview.chromium.org/229423002/

Review URL: https://codereview.chromium.org/231813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263082 0039d316-1c4b-4281-b951-d872f2087c98

We are always in compositing mode now, so this flag is not valid and
we are deleting the code paths it would trigger.

R=fsamuel@chromium.org, piman@chromium.org
BUG=362164

Review URL: https://codereview.chromium.org/233393007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263080 0039d316-1c4b-4281-b951-d872f2087c98

* extracting CheckinRequest::RequestInfo to better manage checkin parameters
* adding G-services settings digest to RequestInfo of the checkin (will be sent with checkin request)
* extracting G-services settings from checkin response
* storing and loading of the G-services settings in GCM Store

This patch relands https://codereview.chromium.org/215363007/ after all
of the trybots, buildbots and CQ have been updated to run gcm_unit_tests

TBR=zea@chromium.org,jianli@chromium.org
BUG=359254

Review URL: https://codereview.chromium.org/233103003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263079 0039d316-1c4b-4281-b951-d872f2087c98

Scheme-and-host patterns are not persisted in the HostZoomMap and get cleared
on the next browser restart. Therefore, they are not so privacy sensitive and
don't need to be displayed in the content settings.

BUG=361575

Review URL: https://codereview.chromium.org/230503004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263078 0039d316-1c4b-4281-b951-d872f2087c98

Make BookmarksProvider set inline_autocompletion and
allowed_to_be_default_match.

This has no effect unless bookmarks are made to score more highly (and
so they'll empirically end up as the top-scoring match).

Includes unit tests.

In the process, fix whether trailing slashes are omitted, for consistency
with other providers.  This will reduce jank if bookmarks are
ever inlining.  Tested interactively.

Likewise, fix whether http:// is omitted.  Tested interactively.

Also, refactor a common piece of code from ShortcutsProvider
to URLPrefix.

Likewise, make a protected function in HistoryProvider public
for use elsewhere.  Mark it static (because it can be).

Also, fix a PreventInlineAutocomplete bug in ShortcutsProvider.
Adds a test for this.  These tests fail before this change.

Also, fix a PreventInlineAutocomplete bug in BuiltinProvider.
Didn't bother adding a test for this because no tests examine
inline_autocompletion here and I didn't want to bother adding
some just for this minor change.  Tested it interactively.
These tests fail before this change.

BUG=

Review URL: https://codereview.chromium.org/229733004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263077 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit http://crrev.com/238501 in favor  a simpler approach
which delays stream creation around suspend and resume events:
http://crrev.com/247026

Care must be taken to monitor the UMA stat for increases after this lands.
I'll also communicate with the YT team on the bug/ to ensure they provide
some assistance in testing.

BUG=160920
TEST=No stream hangs.

Review URL: https://codereview.chromium.org/190553004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263076 0039d316-1c4b-4281-b951-d872f2087c98

Move GetInstalledApp() to ExtensionSet::GetAppByURL().
- More accurately named.
- Forces callers to understand that they are only searching the given extension
  set (GetInstalledApp() implied it may have searched more than just enabled
  extensions).

Remove IsInstalledApp(), since this was used in only two places and can be substituted with GetAppByUrl() != NULL.

BUG=351891
TBR=dzhioev@chromium.org (c/b/chromeos/first_run/)
TBR=kinuko@chromium.org (c/b/sync_file_system/)
TBR=nick@chromium.org (c/b/task_manager/)
(All TBRs are for strictly mechanical changes)

Review URL: https://codereview.chromium.org/218683011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263075 0039d316-1c4b-4281-b951-d872f2087c98

Plumbing for Blink's containerCullingEnabled (experimental Skia culling
for containers).

R=jamesr@chromium.org,piman@chromium.org

Review URL: https://codereview.chromium.org/227593007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263074 0039d316-1c4b-4281-b951-d872f2087c98

This also tickled a bug in the generator because I named a variable
with "http". Which made the generator tests run on presubmit. Which
tickled a bug in the tests :-). So those are fixed here as an aside.

BUG=239656

Review URL: https://codereview.chromium.org/231243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263073 0039d316-1c4b-4281-b951-d872f2087c98

Seems to have busted Mac builds, e.g.,
http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%20Builder%20%28dbg%29&number=65094:

FAILED: cd ../../net; export BUILT_PRODUCTS_DIR=/Volumes/data/b/build/slave/Mac_Builder__dbg_/build/src/out/Debug; export CONFIGURATION=Debug; export PRODUCT_NAME=net_unittests_run; export SDKROOT=/Developer/SDKs/MacOSX10.6.sdk; export SRCROOT=/Volumes/data/b/build/slave/Mac_Builder__dbg_/build/src/out/Debug/../../net; export SOURCE_ROOT="${SRCROOT}"; export TARGET_BUILD_DIR=/Volumes/data/b/build/slave/Mac_Builder__dbg_/build/src/out/Debug; export TEMP_DIR="${TMPDIR}";python ../tools/isolate_driver.py check --isolated "../out/Debug/net_unittests.isolated" --isolate "net_unittests.isolate" --path-variable PRODUCT_DIR "../out/Debug " --extra-variable "version_full=36.0.1935.0" --config-variable "OS=mac" --config-variable "chromeos=0" --config-variable "component=shared_library" --config-variable "internal_gles2_conform_tests=0" --config-variable "icu_use_data_file_flag=1" --config-variable "libpeer_target_type=static_library" --config-variable "use_openssl=0" --extra-variable mac_product_name Chromium --ignore_broken_items
[------ Swarming Error ------]
File /Volumes/data/b/build/slave/Mac_Builder__dbg_/build/src/out/Debug/net_resources_target_net_resources_d558be7de16a8d003a6e7f7fae73e582 doesn't exist
Traceback (most recent call last):
  File "/Volumes/data/b/build/slave/Mac_Builder__dbg_/build/src/tools/swarming_client/isolate.py", line 1516, in main
    return dispatcher.execute(OptionParserIsolate(version=__version__), argv)
  File "/Volumes/data/b/build/slave/Mac_Builder__dbg_/build/src/tools/swarming_client/third_party/depot_tools/subcommand.py", line 242, in execute
    return command(parser, args[1:])
  File "/Volumes/data/b/build/slave/Mac_Builder__dbg_/build/src/tools/swarming_client/isolate.py", line 1082, in CMDcheck
    options, os.getcwd(), options.subdir, False)
  File "/Volumes/data/b/build/slave/Mac_Builder__dbg_/build/src/tools/swarming_client/isolate.py", line 888, in load_complete_state
    options.extra_variables, options.ignore_broken_items)
  File "/Volumes/data/b/build/slave/Mac_Builder__dbg_/build/src/tools/swarming_client/isolate.py", line 762, in load_isolate
    ignore_broken_items)
  File "/Volumes/data/b/build/slave/Mac_Builder__dbg_/build/src/tools/swarming_client/isolate.py", line 63, in expand_directories_and_symlinks
    indir, relfile, blacklist, follow_symlinks))
  File "/Volumes/data/b/build/slave/Mac_Builder__dbg_/build/src/tools/swarming_client/isolateserver.py", line 1450, in expand_directory_and_symlink
    relfile, symlinks = expand_symlinks(indir, relfile)
  File "/Volumes/data/b/build/slave/Mac_Builder__dbg_/build/src/tools/swarming_client/isolateserver.py", line 1358, in expand_symlinks
    todo = file_path.fix_native_path_case(done, todo)
  File "/Volumes/data/b/build/slave/Mac_Builder__dbg_/build/src/tools/swarming_client/utils/file_path.py", line 488, in fix_native_path_case
    os.path.join(native_case_path, raw_part))
OSError: File /Volumes/data/b/build/slave/Mac_Builder__dbg_/build/src/out/Debug/net_resources_target_net_resources_d558be7de16a8d003a6e7f7fae73e582 doesn't exist
[----------------------------]

> Make isolate_driver.py process build.ninja and extract dependencies.
> 
> This uses a few assumption:
> - This basically breaks non-ninja build for component builds. This never worked
>   anyway.
> - This assumes the file format of .ninja files. This will likely be quite
>   obvious when this breaks.
> - It makes some assumptions about the build steps, for example '.so.TOC' ->
>   '.so'.
> 
> On the other hand, it creates a deterministic dependency tree, which is awesome.
> Technically it would work as well for non-component builds but I don't want to
> go this far yet. But in the end, that's the goal that nobody has to enter the
> binary dependencies in the .isolate files.
> 
> R=csharp@chromium.org
> BUG=360223,333473
> 
> Review URL: https://codereview.chromium.org/228463003

TBR=maruel@chromium.org

Review URL: https://codereview.chromium.org/233743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263072 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263071 0039d316-1c4b-4281-b951-d872f2087c98

R=ronghuawu@chromium.org
BUG=

Review URL: https://codereview.chromium.org/233393004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263070 0039d316-1c4b-4281-b951-d872f2087c98