- 31 Oct, 2020 1 commit
-
-
Keren Zhu authored
Reported by A11y test team, the screenreader cannot traverse into the IPH bubble. This is because the bubble was marked as A11y tree leaf node. https://bugs.chromium.org/p/chromium/issues/detail?id=1128728#c71 Bug: 1121399, 1128728, 1144334 Change-Id: I6fbfc617bdffae827b53f5c7c9e55cff5bd0e2ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511590 Auto-Submit: Keren Zhu <kerenzhu@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#822883}
-
- 30 Oct, 2020 39 commits
-
-
Bartek Nowierski authored
Change-Id: Ie9eda8b5e696099cf080b8a3477267076185b936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502708 Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#822882}
-
Daniel Cheng authored
This allows RenderFrameHostImpl to make a stronger assertion about the expected state of its associated FrameTreeNode when creating a RenderFrameHostImpl with LifecycleState::kActive. Bug: 1069205 Change-Id: I3cee3c237fff1a79f32ced79c0bdd05106bb5848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509339Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#822881}
-
Bartek Nowierski authored
We want to protect it. It doesn't seem to cause crashes that we've seen in the past and perfornce doesn't regress with BRP. Bug: 1141567, 1069567 Change-Id: I29b05dfe188961c26287138009e1fdf70f871d92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509870Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#822880}
-
Mustaq Ahmed authored
Bug: 848778 Change-Id: If8b8f9e8ee29ac3d7acae751e2d062a7e838bf40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507512Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#822879}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/740ae9f60b00..142cb87f803d 2020-10-30 johnkslang@users.noreply.github.com Merge pull request #2387 from BNieuwenhuizen/nonuniform If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,geofflang@google.com Change-Id: Idb0a787532500b3b3f631c27366fd060332ebccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510785Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822878}
-
Akihiro Ota authored
This change fixes an issue where ChromeVox would interrupt itself when reading text content. The cause for this is that we previously restarted the nudge timer when a focus event fired. This works for buttons, but focus events do not fire when range moves between text content. Instead of restarting nudges when a focus event fires, do so when the current ChromeVox range changes. A test is also included to confirm behavior. Bug: 1141643 Change-Id: I8245e98b40398a1964bf33b1a14e16ff7e6889a9 AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503635Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#822877}
-
Michael Hansen authored
This updates the asset for the pulse animation on the send discovery page and the high visibility receive page with a new version that doesn't require cropping in CSS. Fixed: 1143308 Change-Id: I852dc10f997abbe2bf4c481cfd1d01a795a33018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510716Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Michael Hansen <hansenmichael@google.com> Cr-Commit-Position: refs/heads/master@{#822876}
-
Koji Ishii authored
This patch includes all block-fragmented fragments when computing visual overflow. When uniting, it should stitch the block offset, but this patch does not do that because the multicol container cannot compute visual overflow in the block direction. This is tracked in <crbug.com/1144203>. Eliminates one call to |CurrentFragment|. One more use to go, other than usages in tests. It will be in following patches. Bug: 1061423 Change-Id: Iaef43b93c8643f42929739dc2221a1eaf3226c3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509609 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#822875}
-
Shakti Sahu authored
This CL contains : 1- Hide video duration text if the duration is 0:00 (e.g. summary card) 2- Change close button style to match spec in night mode 3- Disable Try Now for download tutorial 4- Added some text for metrics 5- Some more tests in VideoPlayerViewBinder Change-Id: Ic435739b7f7d4c5052549aa68352fa66c03bcbf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508999Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#822874}
-
yilkal authored
This cl records the accepted edu coexistence terms of service version number in user pref. The stored pref is a dictionary mapping the secondary edu account's gaia id to the accepted terms of service version number. Bug: 1134682 Change-Id: I73cf4872c6bddec0f7a92663b9a5cacb0a014567 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510874Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#822873}
-
Mike Wittman authored
Changes the internal configuration representation within ThreadProfilerConfiguration to cleanly separate the configuration representation for the browser process from the one for child processes. The configuration state for the two does not overlap conceptually so it's not desirable for them to share the same representation. Also explicitly separates the browser process configuration state that governs whether to register a synthetic field trial from the state that says what group to use when registering. Bug: 1129939 Change-Id: I5d70be116e165e78c700db726f66f92230de514f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438479 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#822872}
-
Zentaro Kavanagh authored
Bug: None Test: None Change-Id: Ibcd365ff49083f783e53ca6c3f85dd55991db83b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511849 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Auto-Submit: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#822871}
-
Etienne Pierre-doray authored
Wasm wants to uses a CancelAndDetach + shared_ptr pattern that can cause CancelAndDetach to be called within GetMaxConcurrency(). This causes recursive lock errors. CancelAndDetach doesn't need a lock since state_ is atomic; making it lockless allows this use case. The current wasm alternative is to hold a vector of JobHandle until the renderer is teared down; this causes a growing 'live' leak. Change-Id: I50e220fc87136739bd3641a2a6d5fad1fe376f9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508335 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#822870}
-
Keishi Hattori authored
This broke some of the checked_ptr unit tests by removing the default parameter for PartitionOptions. https://chromium-review.googlesource.com/c/chromium/src/+/2507432 This CL adds the PartitionOptions param Change-Id: I5690fef518835d9379c8fd28e8dcced8d820c8f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507420Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#822869}
-
Joe Downing authored
This is the first CL needed to allow the Windows host to log w/o logman or sawbuck. Each process on Windows create an ETW trace provider with a well-known GUID, this is what logman/sawbuck use to capture a trace. With this feature, we will update the Windows host so that its log output can be redirected (likely to the Windows event log, could also be a human readable file or ETW file). In this CL, I am adding the class which is used to enable/disable ETW tracing. Future CLs will add the ETW consumer which listens for the events and the logic needed to parse and redirect the output to a new location. Bug: 1144185 Change-Id: I01affb28c01d01bde8649faffaf59a17c8a9cd67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509948Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Joe Downing <joedow@google.com> Cr-Commit-Position: refs/heads/master@{#822868}
-
Chris Sharp authored
Also slightly update the description for AllowFileSelectionDialogs Bug: 1139046 Change-Id: I89238aabb2f96c6d05b67ea4b74b873576ce6743 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507639 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#822867}
-
Haoyue Wang authored
https://quiche.googlesource.com/quiche.git/+log/29ce0bde7aa7..9c41f8ba2361 $ git log 29ce0bde7..9c41f8ba2 --date=short --no-merges --format='%ad %ae %s' 2020-10-30 fayang Use WriteOrBufferDataAtLevel to send crypto data. Such that existing WriteOrBufferData is used to send application data. 2020-10-30 quiche-dev Lazily initialize mapped varz counters before the first metric operation. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I87b8d4dc3c6462f5aaca110bf09da225cb902e78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510693 Commit-Queue: Haoyue Wang <haoyuewang@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: Haoyue Wang <haoyuewang@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#822866}
-
Yu Su authored
Change-Id: I225ba3286ccde54bc78eb01be1e4ea6cc8574f1f Bug: b/172074460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511489 Commit-Queue: Yu Su <yusuyoutube@google.com> Reviewed-by:
Ben Goldberger <benwgold@google.com> Reviewed-by:
Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#822865}
-
Michael Checo authored
Bug: 1059779 Test: browser_tests --gtest_filter=ScanningAppBrowserTest.All Change-Id: I7d03b13cf198d0fd12e61b860ea366a866aace0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510531 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#822864}
-
Patrick Noland authored
This removes the need to "poke" LocationBar when the url might have changed; instead LocationBarModel is poked and notifies its observers. LocationBarModel also triggers a URL change notification when a new tab is selected. Following the established pattern, the url is calculated lazily. Bug: 1142883 Change-Id: Ic7b2b85343d482389082d896321cb42130ab758d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507813 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#822863}
-
Dirk Pranke authored
A couple of the python2 action GN templates referenced the wrong (old) path to //build/util/python2_action.py. This CL fixes them. Bug: 1112471 Change-Id: Ifb1c35ef00275e79f6f63fe9b3afac28b24aa975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510990Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#822862}
-
Akihiro Ota authored
This change adds hints to headers in the tutorial so that users know what to do when each screen is shown. This change has been requested based on UXR findings. Also in this change: 1. Update the main tutorial heading 2. Focus the practice area instructions, as opposed to the title, when it is first opened. Fixed: 1142038, 1142047 AX-Relnotes: N/A Change-Id: I1930776d57d2b6e1d86ba5856390c2553cf3e0a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506516Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#822861}
-
Morten Stenshorne authored
We still use the legacy layout engine APIs when calculating offsets relative to some ancestor (needed by DOM APIs such as offsetLeft, offsetTop and getClientRects()). This means that we cannot use offsets relative to the containing box fragment. We need to make them relative to the containing LayoutBlockFlow instead, or machineries such as LayoutObject::MapLocalToAncestor() will fail when in block fragmentation. Also fixed an issue in the NG-to-legacy-writeback code. It was wrong for RTL, since we used the inline-size of the column (rather than that oof the column set) when converting between logical and physical offsets. This alone doesn't fix any existing tests, but it is needed by the new tests added in this CL, and also helps fix a couple of the existing tests that now pass. Also move one ContainingBlockFlowFragmentOf() call out of the way (we get nullptr when block-fragmented). Moved it into paint fragment-specific code, which was the only code that needed it. Bug: 829028 Change-Id: Ib19b11ecfdd47cdd77aed41c6935be86004fe166 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508590Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#822860}
-
yilkal authored
This cl provides the appropriate scope for consent logging. Bug: 1131174 Change-Id: I5f6c617cffbb007c588ac816fee208d5557a1c88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510743Reviewed-by:
Dan S <danan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#822859}
-
Peter Boström authored
Bug: None Change-Id: I9ab1b3baed360696fd9633f74d0f92309b9d9b34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511075 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#822858}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/17e0deaebaa6..5bee67fced90 2020-10-30 bclayton@google.com Add File & Range information to tint::Source If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: rharrison@google.com Change-Id: Id9f6c10c458d037e0b753b69da90ba37487815dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510667Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822857}
-
Thomas Lukaszewicz authored
Bug: None Change-Id: Ie704de6fb88fd7f91b1bfd5b0fd0eec92ab3a0b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511669Reviewed-by:
Yuheng Huang <yuhengh@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#822856}
-
Junbo Ke authored
Bug: b/172062828 Test: Build Change-Id: Ia17478fd5d2db2d7d4e0d55d70a465d5c1dc07a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510879Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Junbo Ke <juke@chromium.org> Cr-Commit-Position: refs/heads/master@{#822855}
-
Charlene Yan authored
Boiler plate setup to enable tests for TabStripRegionView with and without scrolling. Added one test for scrolling to ensure the TabStrip can grow larger than its parent. Bug: 1141674 Change-Id: I7ae9ba8a1f6b8f2f8f899002dcea51cc1c64edd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493483 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#822854}
-
Matthias Körber authored
Change-Id: Ie48947eb4686c46f110f0f033f16390c5cbcfd75 Bug: 1101280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506575 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#822853}
-
Dave Tapuska authored
This method is easy to move since there already exists a callback on the WebViewClient to control the history offset and length. Move the method to be implemented on WebViewImpl and call that callback. Remove plumbing for PageMsg in the various classes. BUG=993189 Change-Id: Iec57c5b797f3d7dba21a386e1a664c28425f3c8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503168 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#822852}
-
Jesse Schettler authored
The page number reported by lorgnette changed from being 0-indexed to 1-indexed. Use the page number as is instead of adding 1 to it. Bug: 1059779 Change-Id: Ieb52cef8edc25db90e1e13a839f4c2bbf657d471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511469Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#822851}
-
danakj authored
Because the input type to OnceCallback::Then() is a templated type as OnceCallback<U>, a RepeatingCallback does not bind and implicitly convert to a OnceCallback. This is because templated pattern matching does not try conversions, so it must match exactly. Add an overload of OnceCallback::Then() to receive a RepeatingCallback and cast it explicitly to a OnceCallback, forwarding it on to the original Then() method. R=dcheng@chromium.org Bug: 1140582 Change-Id: Ib571eb361922588a3f200e6aea5c045aad0f72d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510411 Commit-Queue: danakj <danakj@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#822850}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/4d14555787ce..cb2f21d0af42 2020-10-30 alexleung@google.com Import updated Cast Media Runtime Proto Definitions If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I8536a82b8d98892be25ba1c7b8fa4b4a77a3dbd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510783Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822849}
-
Demetrios Papadopoulos authored
Specifically when navigating the UI with VoiceOver using Ctrl+Alt+RightArrow, the label should be skipped, and the focus should go straight to the expand icon button, which already correctly points to the label with |aria-labeledby|. Bug: 1055829 Change-Id: I13f2bce30b6aaa11f518e68f779296c294dd30ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510131 Auto-Submit: dpapad <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#822848}
-
Andrew Grieve authored
This reverts commit c2bb3798. Reason for revert: Reverting to see what perf alerts fire. Original change's description: > Android: Remove -fprofile-sample-accurate from blink core > > This trades off some size for performance. > > Binary-Size: Trading size for speed > Bug: 1125115 > Change-Id: If18e8ef4449dec6aab4494fa7d04063d8d94b845 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491540 > Reviewed-by: George Burgess <gbiv@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819964} Bug: 1125115 Change-Id: Iebce1fffa79b590fd015d0054f9fe2da9e3bb3a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498088Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
George Burgess <gbiv@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#822847}
-
Wenbin Zhang authored
This reverts commit ecd51275. Reason for revert: Android builds started failing after this commit. CalledProcessError message is related gyp: FAILED: obj/clank/java/clank_java.turbine.jar gen/clank/java/clank_java.generated.srcjar /b/s/w/ir/cipd_bin_packages/cpython/bin/python ../../build/android/gyp/turbine.py --depfile=gen/clank/java/clank_java__header.d --generated-dir=gen/clank/java/clank_java/generated_java --jar-path=obj/clank/java/clank_java.turbine.jar --java-srcjars=\[\"gen/clank/java/clank_java__rjava_resources.srcjar\"\] --classpath=@FileArg\(gen/clank/java/clank_java.build_config:javac:interface_classpath\) --processorpath=@FileArg\(gen/clank/java/clank_java.build_config:javac:processor_classpath\) --processors=@FileArg\(gen/clank/java/clank_java.build_config:javac:processor_classes\) --turbine-jar-path ../../third_party/turbine/turbine.jar --generated-jar-path gen/clank/java/clank_java.generated.srcjar --java-version=1.8 --bootclasspath=@FileArg\(gen/clank/java/clank_java.build_config:android:sdk_interface_jars\) --chromium-code=1 --warnings-as-errors --jar-info-exclude-globs=\[\"\*/R.class\",\ \"\*/R\\\$\*.class\",\ \"\*/Manifest.class\",\ \"\*/Manifest\\\$\*.class\",\ \"\*/GEN_JNI.class\"\] @gen/clank/java/clank_java.sources Traceback (most recent call last): File "../../build/android/gyp/turbine.py", line 176, in <module> sys.exit(main(sys.argv)) File "../../build/android/gyp/turbine.py", line 172, in main output_paths=output_paths) File "/b/s/w/ir/cache/builder/src/build/android/gyp/util/md5_check.py", line 64, in CallAndWriteDepfileIfStale track_subpaths_allowlist=track_subpaths_allowlist) File "/b/s/w/ir/cache/builder/src/build/android/gyp/util/md5_check.py", line 155, in CallAndRecordIfStale function(*args) File "../../build/android/gyp/turbine.py", line 167, in <lambda> lambda: _OnStaleMd5(options, cmd, javac_cmd, files, options.classpath), File "../../build/android/gyp/turbine.py", line 51, in _OnStaleMd5 fail_on_output=options.warnings_as_errors) File "/b/s/w/ir/cache/builder/src/build/android/gyp/util/build_utils.py", line 272, in CheckOutput raise CalledProcessError(cwd, args, stdout + stderr) Original change's description: > Re-enabling aar .info file checker > > Bug: 1143257 > Change-Id: I88d02690152aa3dabeece3d6cd937d1e3f61a1a4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508329 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Sam Maier <smaier@chromium.org> > Commit-Queue: Sam Maier <smaier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#822760} TBR=agrieve@chromium.org,smaier@chromium.org Change-Id: I6b1265138408f289daa72ef13c48db6669e40c74 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1143257 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511730Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#822846}
-
dpapad authored
Previously scrollbars always appeared light, even if a WebUI page was otherwise respecting dark mode. The upcoming FormControlsDarkMode feature allows webpages to specify whether scrollbras should follow the system's theme, by specifying a new <meta name="color-scheme"> tag. In this CL updating WebUIs that do support dark mode, except for chrome://new-tab-page which needs to be investigated separately (styling breaks when the meta tag is added). Launch Chrome with the following flags to experience dark scrollbars. --enable-features=WebUIDarkMode,CSSColorSchemeUARendering \ --force-dark-mode Bug: 1142291 Change-Id: Ia2cece4b18c4f1c1453ce5dad7815881104fa1eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509690 Auto-Submit: dpapad <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#822845}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9d02bd39..96789f0a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7d637b5dd6bc5aa728087cc635426bc758d2a390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511069Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822844}
-