- 03 Mar, 2020 40 commits
-
-
Sorin Jianu authored
The empty line is due to git cl format. Change-Id: Ifd3d8f1d8f7b3290e8c839affe3d181732d3d4b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082022 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#746228}
-
Tetsui Ohkubo authored
This CL adds a method to explicitly close the virtual keyboard. It will be used from Tast's Chrome ResetState function. Tast side CL: https://crrev.com/c/2071552 TEST=tast run arc.ChromeVirtualKeyboard BUG=None Change-Id: Iffb9fb1f9b9e5059b38d3315f9d135d23624a479 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071549 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#746227}
-
Julian Watson authored
Bug: None Change-Id: I609cd25dbb3cf611dcd0f0a4c2d65e8e0ef50f43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083974 Commit-Queue: Julian Watson <juwa@google.com> Commit-Queue: Nic Hollingum <hollingum@google.com> Auto-Submit: Julian Watson <juwa@google.com> Reviewed-by:
Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#746226}
-
Hitoshi Yoshida authored
Drops a use case of Dictionary in IDL. This CL replaces it with object, thus now AlgorithmIdentifier becomes (object or DOMString). As a side effect, this CL drops support of having Dictionary type as a member of union types, and supports object type as a member of union types instead. Bug: 385376, 839389, 1047081 Change-Id: I24fd5813f6d7af742f46505f2b19cc2d212ec349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066385Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#746225}
-
Makoto Shimazu authored
TBR=nverne@chromium.org, jamescook@chromium.org No-Try: true Bug: 1056268 Change-Id: Ibdd6e0b9321301f53ab2fcb451740776c629d232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084189 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746224}
-
Aaron Leventhal authored
Fixes a copy and paste error that wasn't caught before. Bug: 1011067 Change-Id: Iaf7441a1820d7460eab19451b77d14d013e24c2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081522 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#746223}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Remove support of DEFINE_SVG_PROPERTY_TYPE_CASTS from blink. 2. Use new downcast helper for blink::SVGTransformList Bug: 891908 Change-Id: Ib5cff0f8a446a5379e0d994da54833196a91c2e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019751Reviewed-by:
-
Esmael El-Moslimany authored
Moving the scroll border code out of the customize dialog makes it easier to test. If there is a flake, it will also be easier to diagnose. This CL enables the ntp-customize-dialog unit tests which was previously disabled due to flakiness (due to the scroll borders tests). Bug: 1056688 Change-Id: Ic74f4b79c33c578f9a9d759d80ed569c93f12550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082901 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#746221}
-
James Cook authored
The labels can change based on the sync system status. Screenshots: http://screen/eRLqmmfD5WP - sync off http://screen/iJ6OT7Z8qti - sync on http://screen/QswdwERfXjv - sync system error Also remove the horizontal lines between sections. See bug for mock. TODO: Add the overlay icon with sync status on top of the avatar icon. Bug: 1057200 Test: added to browser_tests Change-Id: Ie68f9be162c38045dcea8bc9ee774d37e1f8ebd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080952 Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#746220}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/3ded65e8072e..6f92b9160b19 git log 3ded65e8072e..6f92b9160b19 --date=short --first-parent --format='%ad %ae %s' 2020-03-02 natlee@microsoft.com Also use ExternalImageDescriptor in D3D12 and Metal Backends 2020-03-02 rharrison@chromium.org Rolling 4 dependencies Created with: gclient setdep -r src/third_party/dawn@6f92b9160b19 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1036080 Tbr: cwallez@google.com Change-Id: I75b1bdf2abc9152cea69548741172bb781d335b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083859Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746219}
-
Bettina authored
Enhanced protection is a new profile pref. With a new profile pref, means that an enterprise policy may come where admins can control if all users will have enhanced protection, not have it, or allow users to enable it. Enhanced protection is the next level above standard Safe Browsing protection. Bug: 1056483 Change-Id: Ia98bd0a5a6d48d08a4963e91be942eedbee1f75f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076341 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#746218}
-
Adam Rice authored
Previously, when a redirect required a CORS preflight, the original request would be left pending until the preflight finished. Since the original request couldn't be reused, this tied up a socket unnecessarily. In extreme cases it could lead to deadlock. Instead, cancel the original request before issuing the preflight. BUG=1051357 Change-Id: I3f60a1cbfad2f6b6ff27ccad82b76a08ca747d00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079726Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#746217}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromium.org Change-Id: I596845f081419c3f459cea94d010f935c0e63a99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083687Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746216}
-
Dale Curtis authored
This reverts commit ae8d84f1. Reason for revert: https://crbug.com/1057531 Original change's description: > Roll src/third_party/dav1d/libdav1d/ 296d1dc00..d398da88c (9 commits) > > https://chromium.googlesource.com/external/github.com/videolan/dav1d.git/+log/296d1dc00641..d398da88c0b6 > > $ git log 296d1dc00..d398da88c --date=short --no-merges --format='%ad %ae %s' > 2020-02-17 janne-vlc fuzzing: link the fuzzing binaries as C++ > 2020-02-17 janne-vlc fuzzing: split the fuzzing targets to their own meson.build file > 2020-02-20 gramner x86: Add mc w_mask 4:4:4 AVX-512 (Ice Lake) asm > 2020-02-20 gramner x86: Add mc w_mask 4:2:2 AVX-512 (Ice Lake) asm > 2020-02-20 gramner x86: Add mc w_mask 4:2:0 AVX-512 (Ice Lake) asm > 2020-02-20 gramner x86: Add mc avg/w_avg/mask AVX-512 (Ice Lake) asm > 2020-02-14 victorien x86: optimize cdef_filter_{4x{4,8},8x8}_avx2 > 2020-02-12 victorien x86: add a seperate fully edged case to cdef_filter_avx2 > 2020-02-19 gramner checkasm: Improve the cdef input randomization algorithm > > Created with: > roll-dep src/third_party/dav1d/libdav1d > > TBR=tguilbert > > Change-Id: Ic1389410c6338ad343bfdffb132e8f4a38960845 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080893 > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Thomas Guilbert <tguilbert@chromium.org> > Commit-Queue: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#745691} BUG=1057531 TBR=dalecurtis@chromium.org,tguilbert@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ica0528ded63a977c649760d9eadabea9495d5f8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083604Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#746215}
-
chrome://media-appchrome://media-app-guestZain Afzal authored
Todate, we've only passed a single, simple message to open a file from media-app to media-app-guest. To better support our use-cases we need a bidirectional pipe, and some abstractions around the dispatching of messages. This CL introduces a MessagePipe class to encapsulate the communication channel and manage dispatch of requests and responses between the privileged and unprivileged JS contexts in chrome://media-app. It still requires explicit definitions of what messages either side can send and receive but allows for these messages to be defined and used with less friction. Bug: 996088, 1040328 Change-Id: I6179a5d176d74f0f37fa1809363e87a0ed2976e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049404 Commit-Queue: Zain Afzal <zafzal@google.com> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#746214}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: If2a77f14fc1908977109c0c71ea07e910ebb6d72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083929Reviewed-by:
-
Jeffrey Kardatzke authored
For trogdor, it doesn't support I420 input format, so when we run that test it needs to use the image processor to convert the format. To make the formats match what we use in reality, they should be either GMBs or STORAGE_MOJO_SHARED_MEMORY. This changes the tests and the V4L2VEA so the formats match. BUG=b:147411004 TEST=VEA SimpleEncode test passes on trogdor w/ I420 input Change-Id: I259c39f8c7632fb0d97d0baf1672ac05acbba6b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050895 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#746212}
-
Charles Zhao authored
(1) AppListController is expanded to have OnSettingsChange. (2) UserSettingsEventLogger calls OnSettingsChange when it logs some metrics in SendToUkm. (3) The log event then passed to AppListClientImpl where CrOSActionRecorder records it. Bug: 1012936 Change-Id: Iedea936a38883281b7d5bbae571431b02013a49f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078813 Commit-Queue: Charles . <charleszhao@chromium.org> Reviewed-by:Rachel Wong <wrong@chromium.org> Reviewed-by:
Charles . <charleszhao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#746211}
-
Yusuke Sato authored
The new test verifies that StartMini() succeeds even when stopping arcvm-server-proxy job fails. BUG=None TEST=try Change-Id: Iadb8c421b31299cf904978b7e487599969a4c11b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083406Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#746210}
-
Alan Cutter authored
Converting base::Callback in extensions/shell has several flow on effects in chrome/browser/devtools, chrome/browser/ui/apps, chromeos/components/tether and chromeos/network. Bug: 1007786 Change-Id: I9babe83c16cf14a4ed3af46578dad3809bf413e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076859 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#746209}
-
Jinho Bang authored
Currently, if disabling the feed feature with GN build flag, a lot of build errors occur. It is because that the dummy implementation wasn't updated with the latest changes (e.g. VisibleForTesting). Bug: none Change-Id: Ib780d4457d03427e78e6fe47d7872e77153a3f0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081712Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#746208}
-
Eric Willigers authored
BookmarkAppConfirmationView becomes WebAppConfirmationView. ShowBookmarkAppDialog becomes ShowWebAppDialog. SetAutoAcceptBookmarkAppDialogForTesting becomes SetAutoAcceptWebAppDialogForTesting. Not addressed in this CL: moving web app and pwa files from chrome/browser/ui/views/extensions/ to chrome/browser/ui/views/web_apps/ Bug: 953540 Change-Id: Ia06769c6af7d38d2bb32f35fe1743ea6165c1201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081724Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
-
Jiawei Shao authored
This patch adds the basic support of multiple GPUDevice in one WebGPU context. Currently, each GPUDevice will be assigned a device_client_id as its unique identifier in the current WebGPU context. One device_client_id will relate to one set of the following data structures in the client and server side of WebGPU command buffer: - Client: WebGPUCommandSerializer - Server: DawnDeviceAndWireServer (WGPUDevice, dawn_wire::WireServer and WireServerCommandSerializer) All APIs related to a DawnDevice are adapted to use device_client_id to refer the specific DawnDevice: - GetDefaultDevice (now it is renamed to GetDevice) - ReserveTexture - GetNewTexture - DawnCommands - DawnReturnCommandsInfo This patch also sends WGPUDeviceDescriptor with the c2s_buffer_ in the WebGPUCommandSerializer of each device instead of creating another new ScopedTransferBufferPtr. BUG=chromium:996713 Change-Id: Ib0c726881f17385afbc71f8fd932ebef197b9b5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038712Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Jiawei Shao <jiawei.shao@intel.com> Cr-Commit-Position: refs/heads/master@{#746206}
-
Hiroki Sato authored
In ARC++, input focus and a11y focus can be different. When the a11y focus and textEditHandler's node is different, CommandHandler.onEditCommand_ should not be applied. Bug: b/150341706 Bug: 859531 Test: Open "Go Read" app and navigation on login screen is correct. Change-Id: I3ab64b5a08315a1b44396167409538a90bad3fe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082666Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#746205}
-
Eugene But authored
Breakscrumbs (feature which attaches steps to reproduce to crashlogs) relies on not_user_triggered="true" to filter out non-interesting events. This CL adds not_user_triggered="true" attribute to all Signin_Impression as these action are logged during UI presentation, not when user perfrom an action. Bug: 1046231 Change-Id: I19eb632748c8f66c009a9fce119af4d23bee3137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081240 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#746204}
-
Simon Que authored
This is a reland of 765c53e1 Original change's description: > infra: Migrate builders to Goma RBE (iOS Week 1a) > > These are the two builders in webrtc.fyi: > - WebRTC Chromium FYI ios-device > - WebRTC Chromium FYI ios-simulator > > These builders are small. They are expected to have a peak traffic of > 15 QPS: > https://docs.google.com/spreadsheets/d/1-XKh-CqSoUcXEqCETVywjmIo1C18P0qEBDCY50ozBb0/edit#gid=1721756715 > > Schedule of migration: > https://docs.google.com/spreadsheets/d/1TZhpasm6iceYm7zqkyEtZ1wn9ZcpREfH4LV4cusICJA/edit#gid=0 > > R=agable@chromium.org, bpastene@chromium.org, jbudorick@chromium.org, tikuta@chromium.org > > Bug: 950413 > Change-Id: Id47cc7887bbefaf4dfe9f72275b80c8f04c428a7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043185 > Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com> > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Reviewed-by: smut <smut@google.com> > Commit-Queue: Simon Que <sque@chromium.org> > Cr-Commit-Position: refs/heads/master@{#739771} Bug: 950413 Change-Id: Idf2146ed92e80075675c15b79f9d65633458258f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074178Reviewed-by:
smut <smut@google.com> Reviewed-by:
Aaron Gable <agable@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#746203}
-
Hui Wang authored
This happens when the WebContents being destroyed. If the InterstitialPage is showing we only clear the reference to the native WebContentsAccessibility from InterstitialPage's BrowserAccessibilityManager, use-after-free will be happened when the |WebContents->GetMainFrame|'s BrowserAccessibilityManager destroyed. Change RawPtr of WebContentsAccessibilityAndroid to WeakPtr. Bug:1056882 Change-Id: Id1efea84aef6c7437a178f7006bc09035949bbcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063789 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746202}
-
Rakesh Soma authored
Bug: 1057855 Change-Id: I7a2ffbea114ffffefaaed2c011fb9de5fe7e1923 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084032 Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Auto-Submit: Rakesh Soma <rakeshsoma@google.com> Reviewed-by:
Yusuf Sengul <yusufsn@google.com> Cr-Commit-Position: refs/heads/master@{#746201}
-
Sammie Quon authored
TabletModeTransitionTest.EnterExit and HomeScreenTest.DragginPerformance are failing on Linux ASAN bots. We will probably be removing them sometime soon but for now, keep the bots happy by disabling. TBR=xiyuan@chromium.org Test: none Bug: 1057864 Change-Id: Ib434d6295289a0795dd25cc15ac6c150b57bde6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083939Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#746200}
-
Chris Mumford authored
Round sensor values to multiples of a reasonably small value to protect user privacy. This makes the readings slightly less accurate, but protects users from fingerprinting attacks which might allow a site to generate a unique id based on the sensor calibration data. The affected sensors are: 1. ACCELEROMETER. 2. LINEAR_ACCELERATION. 3. GYROSCOPE. 4. ORIENTATION (Euler & Quaternion, absolute & relative). Bug: 1018180, 1031190 Change-Id: Iafe84ec9fcf12cfdfde1898da011d63dd419bfa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003614Reviewed-by:
Vincent Scheib <scheib@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#746199}
-
Tomasz Wiszkowski authored
This change fixes bug introduced in https://crrev.com/c/2079298. Android views include view paddings when computing view size (both height and width), resulting in the padding being accounted for when comparing the resulting dimensions against minimum dimension hints. As an effect, the view becomes much more compact than originally intended. Bug: 1050813 Change-Id: Icffff1a6bbd4c4608fc77f25a4ba0c9708431835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083921Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#746198}
-
Hirokazu Honda authored
This is a reland of 95ad9e5a Original change's description: > media/gpu/vaapi: Create VAImage with va surface size on UploadVideoFrameToSurface() > > This is a workaround of the failure at 1080p video encoding > test on grunt. > > Originally vaCreateImage is created with a coded frame size. > However, it causes SEGV_MAPERR on vaPutImage, which copies > vaImage to vaSurface. > > As a result of experiments, the vaImage size needs to be the > same as va surface size. Since this is not stated in VA-API > document, so this might be a bug of AMD gallium driver. > > Besides of the workaround, this CL copies visible size area > of VideoFrame to the VAImage. > > Bug: 1048908 > Bug: 1050377 > Bug: b:148744040 > Test: video.EncodeAcel.* on grunt, eve and soraka > Test: camera.* on grunt, eve and soraka > Change-Id: I1ee853964387846d2452e72cfbd4c939f0a18f62 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041382 > Commit-Queue: Hirokazu Honda <hiroh@chromium.org> > Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#744953} TBR=andrescj@chromium.org Bug: 1048908, 1050377, b:148744040 Change-Id: If43571fdc386a7f92f36689a9c78cbcda5ba6829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082301Reviewed-by:
-
Glen Robertson authored
Just moved all the methods across for now to ensure tests were not affected by this cleanup change. Some duplication (now within TABM) could be cleaned up in future. In prep for making an ABM factory as suggested by bsep@ in crrev.com/c/2075001 Change-Id: Idcaad639bcc270a7ed3cc1f77f88b0fd5f2366a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082220 Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium ef326b6a. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: Id9bc3d6c6e4ac268251cfd651788b18a56596436 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083692Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746195}
-
Ana Salazar authored
There was a small jump observed when we scaled the icon on long press. We need to scale the padding of the icon as well as we are making the icon bigger. Bug: 1050730 Change-Id: I0aaa015a121963742e179319a8aa6ccc333251e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083605 Commit-Queue: Ana Salazar <anasalazar@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
-
Kyle Horimoto authored
These subpages have existed for a long time, but they did not have associated constants. Change-Id: Ib5612190dde72ee66ed53d6b76ee7f5d90e5f826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080891 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Hugo Benichi authored
To ensure that ARC would consistently get IP properties from the host for all networks, change-id I24d26d6492f133e0c38949c8c3b4403687bfac21 (https://chromium-review.googlesource.com/c/chromium/src/+/2028881) added a delayed property update request to shill when ArcNetHostImpl cannot retrieve IP properties for a Shill connected Service. However, one such request will trigger multiple property updates from Shill and will retrigger the same codepath in ArcNetHostImpl that asked for the property update request. This amplification can lead to an infinite loop between Chrome and Shill incurring high CPU usage on the system when ArcNetHostImpl will keep failing to find the IP properties from the ONC properties or from the Device cached state. This patch prevents this loop from happening at a high frequency by making sure that at most one delayed property update request is scheduled. A follow-up patch will add exponential backoff for the retry delays. It was reported in crbug/1054676 to happen consistently for the case of native VPNs backed by a WiFi connection (i.e it does not happen with VPNs backed by ethernet). The reason why ArcNetHostImpl fails to find IP properties in that specific scenario is still unknown and will be investigated separately. BUG=1054676 TEST=Compiled, connected L2TP VPNs, observed that logs patterns seen in crbug/1054676 do not happen and that cpu% of shill, chronos, and system_server stays at normal levels. Change-Id: I2a39ba9c8d14cf42b6b0dbdd10c885bf5be09cfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078372 Commit-Queue: Hugo Benichi <hugobenichi@google.com> Reviewed-by:
-
Lukasz Anforowicz authored
This CL recognizes that https://url.spec.whatwg.org/#scheme-start-state only allows "ASCII alpha" as the first letter of a URL scheme. Thanks to this change, "1:..." is not treated as an absolute URL. Fixed: 530123 Change-Id: I5ebadaebab18aebb5903968d14f39f092057f3cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080075Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#746191}
-
John Chen authored
Modify the log replay tool so it can pass arbitrary flags to ChromeDriver. This is needed for the investigation of an internal bug, to pass flags such as --disable-build-check. Bug: b/147732888 Change-Id: Ic38ce33da006965e4861467a37cb0209c9ca9b3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079609 Commit-Queue: John Chen <johnchen@chromium.org> Auto-Submit: John Chen <johnchen@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#746190}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: I7f2aa4433f7686c116285a03c919fc74e6364560 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083396Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#746189}
-
