- 05 Jun, 2019 40 commits
-
-
Dominik Röttsches authored
https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+log/97b926857759..659eeddb2df5 $ git log 97b926857..659eeddb2 --date=short --no-merges --format='%ad %ae %s' 2019-06-03 bruce.mitchener Use C++11 override keyword. 2019-06-01 corbett.dav [myanmar] Make medial_group match the OT spec 2019-05-29 qxliu [subset] Hmtx/vmtx tables to use subset2 and new iterator frameworks 2019-06-03 ariza added parentheses to FDSelect::sanitize as well 2019-06-03 ariza added test data 2019-06-03 ariza parenthesized cond-exp in CFF2FDSelect::sanitize 2019-06-03 ebrahim Reapply possible bsearch overflow fix 2019-06-03 bruce.mitchener test: Use nullptr in C++ code. (#1744) 2019-06-02 ebrahim [ci] revert to xenial 2019-06-02 ebrahim minor 2019-06-02 ebrahim Use a unified bsearch (#1741) Created with: roll-dep src/third_party/harfbuzz-ng/src R=bashi@chromium.org,behdad@chromium.org,bungeman@chromium.org,drott@chromium.org,eae@chromium.org,jshin@chromium.org Bug: 969261 Tbr: bungeman, eae Change-Id: Ib7c0a4cc9fec1d8f390a8d41dc5cb2ff2b0ffdd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645212Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#666235}
-
Jan Krcal authored
Bug: 836718 Change-Id: Ie8e1a039d8ef653b5377bb57638cd180dd87e1c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642551Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#666234}
-
Darren Shen authored
In a previous patch, we changed the MODECHANGE key behaviour so that pressing it once will only show the current input method. This was to follow the UX specs. However, upon consideration, we're going to change it back to the original behaviour of switching to next input method on first key press. The original code used a event rewriter to convert the MODECHANGE key into Ctrl-Shift-Space (which switches to the next key press). We then changed the code to be in ash accelerators because of the extra logic involved. Now that we don't need this extra logic, we could revert back to event rewriter, but we think it's better to keep it in accelerators because we still have some extra logic around histogram logging. TBR=holte@chromium.org Bug: 953901 Change-Id: I2cf4dc41300b62ee6f57085408e199a2a55062b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642487 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#666233}
-
Sergio Villar Senin authored
They belong to wtf/ and the WTF:: namespace. They're currently placed in the top-level platform/ directory under blink namespace. Bug: 968504 Change-Id: Iea6bb38e5b4406b18c4a264d7ded6d2065a73d58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635821 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#666232}
-
Friedrich Horschig authored
This CL collapses all code-paths for accessory sheets into one. All sheets now have common classes for coordinator, mediator and model. For the ViewBinders, this would make no sense (since they are static classes used to implement interfaces anyway) and Views are largely shared anyway. The wiring is only partly hidden in these super classes since it would be too difficult to find the connection between ViewBinder, Model and Coordinator if we would just require interfaces [1]. Minor, intentional clean-ups: - Credit Cards now have a UserInfo type representation. - The address sheet isn't any longer in V2 but instead guarded by the same flag as the credit card sheet. [1] I tried and reverted it. It pretty much takes 300 more lines away but then, the whole component becomes very in-transparent. Details to follow. Bug: 902425 Change-Id: Ia44694f72418b5f27a021569bfb3e70a19f24201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634736 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#666231}
-
Alex Chau authored
- Introduce encryption result enum and callback - Added encryption logic in GcmEncryptionProvider based on EncryptionRoundTrip unit test Bug: 966035 Change-Id: I390651722f89eaf380c8a2e8d43a76ad72d447c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635610Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Auto-Submit: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#666230}
-
Jan Wilken Dörrie authored
This change removes code duplication between base::BindOnce and base::BindRepeating by introducing a generic base::internal::BindImpl. Bug: 554299 Change-Id: Ia06233baf973d62b458ed5cb3fbded0da865f83b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617775Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#666229}
-
jdoerrie authored
This change introduces base::Contains(), generalizing the existing base::ContainsKey() and base::ContainsValue(). base::Contains() has multiple templated overloads, depending on what API the queried container provides. If possible, it invokes a contains() member function on the passed in container. If this does not work, it will choose a member find() function. If such a function is not present either, it will use std::find() as a fallback. Bug: 970209 Change-Id: I54fb619b6cf229308a40cc81658bd800c3671d40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631406Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d944a1a52fef..082a93c5faa3 git log d944a1a52fef..082a93c5faa3 --date=short --no-merges --format='%ad %ae %s' 2019-06-05 dberris@chromium.org SheriffRedux: Handle empty configs cases Created with: gclient setdep -r src/third_party/catapult@082a93c5faa3 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:953181,chromium:971170 TBR=skyostil@google.com Change-Id: I652bbd5f045fafe120d84f6f4d4a102fbc862d1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645121Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#666227}
-
Julie Jeongeun Kim authored
This class is not used: (1) app_shell is defunct as a product (2) no tests rely on the class Its presence is a hindrance to an upcoming effort to internalize OAuth2TokenService behind IdentityManager. This change was originally authored by Colin Blundell<blundell@chromium.org> Bug: 967598 Change-Id: I7e353d891518d1626eb2e4d83294c6ca223b0d0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635120 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#666226}
-
arthursonzogni authored
This is probably caused by a slow renderer process that is removed by the swapout / unload timeout before it has finished running its unload handler. BUG=969727 Change-Id: I83c9af526ce0550435f62758a057741c5155b7d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643533 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#666225}
-
Sami Kyostila authored
Add transparent forwarding wrappers in order to remove the "WithTraits" suffix from the various task posting APIs. These wrappers will be removed once all the call sites have been rewritten to also remove the suffix. This patch also renames methods on the TaskExecutor interface to remove the same suffix as well as some internal ThreadPool APIs; the full code base will be adjusted in later patches. TBR=kkhorimoto@chromium.org Bug: 968047 Change-Id: I429da2bdf0ad75240b3f4fc574e3b6932bf1be40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640650Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#666224}
-
Martin Robinson authored
Change to original: Modified implementation to use a WindowObserver in the View accessibility code to reduce the test surface of the original patch. This should eliminate issues with flaky tests. Now instead of firing a "window minimization state changed" event the code fires a "window visibility changed" event. Original change's description: > Add support for setting the AtkObject state and sending the > appropriate AtkWindow events when a toplevel window in Chrome > is minimized and restored. Bug: 866336 Change-Id: I18636759730879762fcbe8e423a4537590241757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619700Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#666223}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fbfc92ef1538..80255d87a852 Created with: gclient setdep -r src-internal@80255d87a852 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=xidachen@google.com,gayane@google.com,calamity@google.com,kinuko@google.com Change-Id: I9e52c6615df83e744a4eb1321a82437feb6f370e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645120Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#666222}
-
Richard Knoll authored
This allows us to see how this new feature is used and to spot any issues in the current UX. Bug: 969018 Change-Id: Ib6c2d01b18df6b137c0e5929316eada77f4aba2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638517Reviewed-by:
-
Tanmoy Mollik authored
Reland "Changing OAuth2TokenService::Observer and its subclasses to use CoreAccountId instead of std::string" This is a reland of 2669b5b5 The previous cl had a merge conflict with another cl that introduced a new file components/signin/core/browser/oauth2_token_service_delegate_android_unittest.cc This cl fixes the error. > Changing OAuth2TokenService::Observer and its subclasses to use CoreAccountId instead of std::string > > This cl is part of the effort to use CoreAccountId instead of std::string > to denote account_id. > > Bug: 959157 > Change-Id: I6b95b6adf7d73228c399162daf2867c532acd7cd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626599 > Reviewed-by: David Roger <droger@chromium.org> > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Commit-Queue: Tanmoy Mollik <triploblastic@google.com> > Cr-Commit-Position: refs/heads/master@{#663069} Bug: 959157 Change-Id: I064945cb25872e8c87e3f9012cd4cf44a9c98d7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628622Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@google.com> Cr-Commit-Position: refs/heads/master@{#666220}
-
Anatoliy Potapchuk authored
Bug: 959967 Change-Id: Ie103f78978f3daaaf31f280c8c51e6c96601242a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641262 Auto-Submit: Anatoliy Potapchuk <apotapchuk@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#666219}
-
Vasilii Sukhanov authored
Currently if the username has a conflict with current credentials, it's cleared before presaving. The CL moves this logic into PasswordGenerationState. Bug: 936011 Change-Id: Ib008187f301a44e2d9cf1ef3f9c5dbaef2255d77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643553 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#666218}
-
Siddhartha S authored
This reverts commit bfb7d0c3. Reason for revert: Roll after perfetto fix Roll src/third_party/perfetto/ fc15cad36..f80d2d4f0 (27 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/fc15cad36895..f80d2d4f0a64 $ git log fc15cad36..f80d2d4f0 --date=short --no-merges --format='%ad %ae %s' 2019-06-05 primiano@google.com Disable metatrace_unittest on windows builds 2019-06-05 primiano@google.com Speculative fix of windows build 2019-06-05 eseckler@google.com service: Fix tracing service unittest build for chromium. 2019-06-04 primiano@google.com Fix races in metatrace unittest and gcc build 2019-06-04 fmayer@google.com Make HeapprofdEndToEnd a parametrized test. 2019-06-04 hjd@google.com typo: the the -> the 2019-06-04 hjd@google.com Reland: perfetto_cmd: add ability to compress trace packets 2019-06-04 fmayer@google.com Fix typo. 2019-06-04 hjd@google.com Revert "perfetto_cmd: add ability to compress trace packets" 2019-06-04 eseckler@google.com tools/idle_alloc: Only build in standalone builds. 2019-06-04 hjd@google.com perfetto_cmd: add ability to compress trace packets 2019-06-04 fmayer@google.com Add missing setsid before fork to avoid leaking children. 2019-06-04 hjd@google.com Make tools/tmux work with fish 2019-06-04 primiano@google.com Move README.md from include/perfetto to include/ 2019-06-04 primiano@google.com Improve metatrace, allow to be used in production 2019-06-03 ssid@google.com Fix idle_alloc.cc build 2019-06-03 ssid@google.com Rename the thread names in ChromeThreadType to specify chrome 2019-05-31 kodiobika@google.com Added tests for raw syscall recording 2019-06-03 primiano@google.com Add API usage example for the Android tree 2019-06-03 fmayer@google.com Add docs for idle page tracking. 2019-06-03 eseckler@google.com processor: Parse TrackEvent arguments 2019-06-03 primiano@google.com Add consumer API and --query cmdline to list data sources 2019-06-03 fmayer@google.com Update trace_to_text for heap_profile. 2019-06-03 lalitm@google.com perfetto: add java proto targets and fix compile 2019-06-03 fmayer@google.com Allow to specify data_source_stop_timeout in TraceConfig. 2019-06-03 lalitm@google.com docs: add toc entry and fix some links 2019-05-31 fmayer@google.com Use IDLE bit instead of referenced bit. Original change's description: > Revert "tracing: Add thread names and types to perfetto traces and roll perfetto" > > This reverts commit 906024f5. > > Reason for revert: Perfetto roll seems to break compile: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8911612852241220240/+/steps/compile/0/stdout?format=raw > > Original change's description: > > tracing: Add thread names and types to perfetto traces and roll perfetto > > > > Roll src/third_party/perfetto/ fc15cad36..3cd1230c5 (6 commits) > > > > https://android.googlesource.com/platform/external/perfetto.git/+log/fc15cad36895..3cd1230c5eb3 > > > > $ git log fc15cad36..3cd1230c5 --date=short --no-merges --format='%ad %ae %s' > > 2019-06-03 ssid Fix idle_alloc.cc build > > 2019-06-03 ssid Rename the thread names in ChromeThreadType to specify chrome > > 2019-06-03 fmayer Update trace_to_text for heap_profile. > > 2019-06-03 lalitm perfetto: add java proto targets and fix compile > > 2019-06-03 lalitm docs: add toc entry and fix some links > > 2019-05-31 fmayer Use IDLE bit instead of referenced bit. > > > > Created with: > > roll-dep src/third_party/perfetto > > > > Depends on aosp/973864. > > > > Change-Id: Ib57d2b9005fea04673c133e8f5aed19fddcf4a29 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637680 > > Commit-Queue: ssid <ssid@chromium.org> > > Reviewed-by: Eric Seckler <eseckler@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#665798} > > TBR=ssid@chromium.org,eseckler@chromium.org > > Change-Id: I26be2dd8e6af0038f623d4b306124d2b54f758dd > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642748 > Reviewed-by: Darren Shen <shend@chromium.org> > Commit-Queue: Darren Shen <shend@chromium.org> > Cr-Commit-Position: refs/heads/master@{#665805} TBR=ssid@chromium.org,eseckler@chromium.org,shend@chromium.org Change-Id: I93290110464f8a2d9ea3c38eaecb33ae002e3ca6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643652 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#666217}
-
Rune Lillesveen authored
As discussed in github issue 3949[1], we should not set the canvas color to black if the view is forced transparent, like it wouldn't be white in the default scheme. [1] https://github.com/w3c/csswg-drafts/issues/3949 Change-Id: I33ff79c17c245a9cbae3a5602d2240361fca293d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643575Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#666216}
-
arthursonzogni authored
This checks subframes survives while being in the BackForwardCache. In particular, what happens when loading a new main document in the same process of the cached subframe? Does it survive? Currently: Yes. + Test: BackForwardCacheBrowserTest.SubframeSurviveCache1 + Test: BackForwardCacheBrowserTest.SubframeSurviveCache2 + Test: BackForwardCacheBrowserTest.SubframeSurviveCache3 + Test: BackForwardCacheBrowserTest.SubframeSurviveCache4 Four new test cases: 1) A1(B2) -> C3 -> A1(B2) 2) A1(B2) -> B3 -> A1(B2) 3) A1(B2) -> B3(A4) -> A1(B2) -> B3(A4) 4) A1(B2) -> B3 -> A4 -> B5 -> A1(B2) Bug: 511340 Change-Id: I25414030dc48d5bf7fcbe85b33dc00c9a2cd890d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627029 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
-
Alex Clarke authored
A followup to https://crrev.com/c/1637460 Bug: 906125 Change-Id: Ib9bb0ba030e001816c6b75d124060f8a04a8525d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638540 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#666214}
-
Etienne Pierre-doray authored
Add perftests to compute read + write throughput. This CL only implements benchmarks for ThreadLocalStorage. PlatformThreadLocalStorage will be added as a follow-up. Change-Id: I80de0bcb3a31e771646c942413aa156ecf960798 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643469 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
-
Mario Sanchez Prada authored
This CL implements a version of content::PushMessagingClient inside Blink that communicates directly via Mojo-based IPC with the implementation of blink::mojom::PushMessaging in //content/browser (i.e. PushMessagingManager), and update callers to use this new implementation instead of the old one, to be removed in a follow-up CL. Bug: 939943 Change-Id: I5c2d67d6983a47c09932ecdd3e925f8a7f168adf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631401 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
-
Yi Su authored
This CL removes CRWWebController._isHalted. Bug: 956511 Change-Id: I1db2c218f51b8ad47f9d169bbd1a9a81b9df2a86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640101 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#666211}
-
Manuel Rego Casasnovas authored
Elements with "contain: size" should be treated as having no contents, that's not happening for <select> elements. To fix this we add a check for size containment in LayoutMenuList::UpdateOptionsWidth(). BUG=966673 TEST=external/wpt/css/css-contain/contain-size-select-001.html Change-Id: Ie71a16e113d7bef4fd5c7b62e1838feba9b15cb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643872Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#666210}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ie7542b3984f0344583a6ecd1fec831d60b2dc779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645253Reviewed-by:
-
Yi Su authored
This CL removes CRWWebController.abortLoad since it has only 2 lines and is ambiguous to co-exist with CRWWebController.stopLoading, CRWWKNavigationHandler.stopLoading, WKWebView.stopLoading and CRWLegacyNativeContentController.stopLoading. Bug: 956511 Change-Id: Ib0d6b38b66f8f21be7f4234893b132641b0f81ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641244 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
This reverts commit 8b51a44e. Reason for revert: the original CL broke downstream, but the fix landed before this revert landed. Thus the revert is *causing* the build failure. Reverting it. Original change's description: > Revert "Delete GaiaCookieManagerServiceObserver in favor of callbacks." > > This reverts commit 58fe1e69. > > Reason for revert: This looks like it breaks an ios internal trybot https://ci.chromium.org/p/chrome/builders/luci.chrome.ci/ios-internal-chromium-tot > > Original change's description: > > Delete GaiaCookieManagerServiceObserver in favor of callbacks. > > > > This CL replaces GaiaCookieManagerServiceObserver with vanilla > > callbacks. Now that GCMS is owned by IdentityManager, and cannot have > > multiple observers, a callback interface seems more natural than an > > Observer class. > > > > This also has the nice side effect of removing transitive includes of > > gaia_cookie_manager_service.h via identity_manager.h. > > > > Change-Id: I9cdac56c8237c9a09eb2c2ce87f41f48872a9fb6 > > Bug: 939372 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630162 > > Reviewed-by: Mihai Sardarescu <msarda@chromium.org> > > Reviewed-by: Colin Blundell <blundell@chromium.org> > > Commit-Queue: Lowell Manners <lowell@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#665616} > > TBR=blundell@chromium.org,msarda@chromium.org,lowell@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 939372 > Change-Id: I777df13eb9bc5eddeea46640b973c287d6622061 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642232 > Reviewed-by: Lowell Manners <lowell@chromium.org> > Commit-Queue: Lowell Manners <lowell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#666007} TBR=blundell@chromium.org,msarda@chromium.org,lowell@chromium.org Change-Id: I02604da8703d681033ea7a0d53252eb8b264065d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 939372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645357Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/899f7e5389c4..d944a1a52fef git log 899f7e5389c4..d944a1a52fef --date=short --no-merges --format='%ad %ae %s' 2019-06-05 perezju@chromium.org [Telemetry] Fix reporting of tracing errors during DumpMemory Created with: gclient setdep -r src/third_party/catapult@d944a1a52fef The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:964960 TBR=skyostil@google.com Change-Id: Iccc56453013f2111608eebd2ffd558037ae9a923 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645058Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/23fce88da7cf..fbfc92ef1538 Created with: gclient setdep -r src-internal@fbfc92ef1538 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=xidachen@google.com,gayane@google.com,calamity@google.com,kinuko@google.com Change-Id: Ie66c23537bc7b12499000423a29a5e3136018b1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645254Reviewed-by:
-
Yi Su authored
CRWWKNavigationHandler. This CL moves CRWWebController._certVerificationErrors into CRWWKNavigationHandler since it's only used there. Bug: 956511 Change-Id: Iaa7225a2181b720b0184f80243ff1f945a72e032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639390 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
-
Etienne Pierre-doray authored
This CL replaces ScopedNestableTaskAllower with kNestableTasksAllowed passed as argument to the RunLoop involved if any. Only native nested loops should use ScopedNestableTaskAllower (soon to be deprecated). For more details, see: https://cs.chromium.org/chromium/src/base/message_loop/message_loop_current.h?sq=package:chromium&dr=CSs&g=0&l=159 A small step towards deleting MessageLoop. This CL was generated with git cl split. Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1635819 Please CQ if LGTY! This CL was uploaded by git cl split. R=tommi@chromium.org Bug: 766678 Change-Id: I5169a00876479db55907237bc3b7dc339f463bb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635825 Auto-Submit: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#666203}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/620197bd6535..4a00a80c4048 git log 620197bd6535..4a00a80c4048 --date=short --no-merges --format='%ad %ae %s' 2019-06-05 afdx@google.com Add fuzzer pass to add dead breaks. (#2654) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@4a00a80c4048 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel;luci.chromium.try:win_angle_deqp_rel_ng TBR=radial-bots+chrome-roll@google.com,geofflang@google.com Change-Id: I9de44bf6c2f734d31e1ca21874b04c2bc18d23e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645115Reviewed-by:
-
Mihai Sardarescu authored
This CL enables Unified Consent feature by default. It removes a few earl grey tests that were only used for pre-Unity flows. It also removes the unified consent test suite as it is no longer relevant and this significantly reduces the bots build time. Bug: 960260 Change-Id: Iff7972e3b6533dc8f547562e2aae854b6f6b1833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617444Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
-
Yi Su authored
This CL moves remaining navigation helper methods from CRWWebController into CRWWKNavigationHandler. Bug: 956511 Change-Id: I272a8e8247a104df1559b56c0bca06935f7a2e71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640550 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
-
Clemens Arbesser authored
This is the client change required to allow scripters to override the default state of the third party terms&conditions checkbox. Bug: b/131588758 Change-Id: I3e6a970b3e972405a76e0fc8bf505939bc2459ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605202 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#666199}
-
Anand K. Mistry authored
This change adds the restore path, but usernames are not currently saved. BUG=891462 Change-Id: I045fa9d1624a84dd95892e7b3c45d8b303992ef5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644321 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#666198}
-
Carlos Caballero authored
BEST_EFFORT tasks will not run until after startup and only if there is no critical work pending. This patch should not change the current behaviour. Please double check whether the task being posted via BrowserThread::PostAfterStartupTask really cares about being run after startup or just wants to run after any critical work was completed. If you are fine with it just running after critical work has completed LGTM and keep on with your life. If that is not the case let me know and please explain your reasoning in a comment. More details: https://docs.google.com/document/d/1P8PV1qX2cOR2WRFD6v9CjygJkE_mftCtJ7BoqQHCKZI This CL was uploaded by git cl split. R=raymes@chromium.org Bug: 887407 Change-Id: Ia9dc2635bcaf61cfec8134f381260e9d19d70752 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632240 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Auto-Submit: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#666197}
-
Victor Hugo Vianna Silva authored
Previously, FaviconSource used {kFavicon} as an IconTypeSet in its FaviconService queries. We propose to use every possible icon type for both mobile and desktop, so as to avoid platform specific code. Change-Id: I7a57f81300552b8f25007ac408616fb353572b55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642668 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#666196}
-
