GitLab

The experimental contextual suggestions service provides 0-suggest
autocomplete suggestions based on the URL that is visited in the active
tab, at the time the address bar is focused. This CL adds to the request
a timestamp corresponding to the time the user started navigating the
URL for which the suggestions are requested.

This change is a requirement for the process of enabling server-side
logging of the contextual suggestions that are sent to Chrome clients.
If logged, contextual suggestions are to be removed as soon as a
synced user removes from their history the page that was visited at the
time the suggestions were displayed. The timestamp is necessary for
matching suggestions with the corresponding navigation.

TBR=rohitrao
for mechanical changes to ios/c/b/a/*

Bug: 692471
Change-Id: I6939d108cfab91b69640acdbb3b8307687999320
Reviewed-on: https://chromium-review.googlesource.com/879167
Commit-Queue: Gheorghe Comanici <gcomanici@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531999}

This CL shows 'allow shared proxies' for device managed proxies
since these proxy settings may be subject to the
'use_shared_proxies' pref.

This also:
* Adds tests for the detail page, including a minor change to
  internet_detail_page.js to facilitate testing.
* Fixes a subtle bug in isNetworkPolicyControlled.

  CrSettingsInternetDetailPageTest.InternetDetailPage

Bug: 798553
Test: browser_tests --gtest_filter=\
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I918710e106606127ff1246dd4400125b4c291273
Reviewed-on: https://chromium-review.googlesource.com/881867
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531998}

The accessibility enums were used in over 300 files and many
of those uses depended on details of the bindings generated
from the IDL file. To keep this as much of a pure refactoring
as possible, this change does the following:

* Implements Parse and ToString functions in ax_enum_util
  that match the behavior of the IDL bindings.
* Explicitly adds a kNone and kLast item to every enum, to
  support code that iterates over enums.

Bug: 650275
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I6610169991ea1209629dab9a8c4c2c1f03c4116f
Reviewed-on: https://chromium-review.googlesource.com/877417Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531997}

TBR=danakj

Bug: 177475
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I4278dac80badb5768e725986f6a32b11ca244507
Reviewed-on: https://chromium-review.googlesource.com/886882
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531996}

We've moved from using Bind to BindOnce and BindRepeating. This
implements that change in chromeos/printing.

BUG=chromium:804035
TEST=passes unit tests

Change-Id: Icaf15b00252398c9685a0482e114e7fef7ddea74
Reviewed-on: https://chromium-review.googlesource.com/884825
Commit-Queue: Luum Habtemariam <luum@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531995}

Looks like all fallthroughs in net were intentional.
No intended behavior change.

Bug: 741046,177475
Change-Id: I004ce3a7b2eb487a34972ced44e1b564468c7d70
Reviewed-on: https://chromium-review.googlesource.com/887303
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531994}

Bug: 768691
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I46857805a46a44c9c3a2ce3280d7dbb3e32c0825
Reviewed-on: https://chromium-review.googlesource.com/882454Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531993}

This CL adds a new memlog stack mode: native-with-thread-names. When enabled,
the thread name will be inserted as the first frame of each stack.

Other minor changes:
  * Fixed minor bug in the parsing logic for ProfilingTestDriver.
  * Fixed a JSON exporter issue [node and string ids should begin at 1, not 0.
chrome://tracing UI ignores nodes with id 0.]
  * Add TLS destructor for allocator shim.
  * base::android::AttachCurrentThread() now preserves thread name.

Change-Id: I8c9d82084d6439e663f94e563068c987d1cf3b23
Bug: 758739
Reviewed-on: https://chromium-review.googlesource.com/877085Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Dmitry Skiba <dskiba@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531992}

[UIApplication sharedApplication].keyWindow.rootViewController was
used to present UI. Now, the appropriate view controller is
plumbed into autofill to present UI.

Bug: 791793, 692525
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: If82b5a5ee37d2ea9778d0332dd6686949d6bbfab
Reviewed-on: https://chromium-review.googlesource.com/882400Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531991}

NSNumber literals, expression literals, container literals: e.g. in
base/mac/foundation_util.mm (expression literal),
base/mac/foundation_util_unittests.mm (NSNumber literal, container literal).
This is a compiler feature and we have used it for years.
https://clang.llvm.org/docs/ObjectiveCLiterals.html

@implementation instance variables, in translate_bubble_controller.h
(note that ivars referred to in the _unittest.mm need to stay in the .h).
This requires the "modern runtime". We could use this once we we shipped
64-bit chrome (m39, late 2014).

NSDictionary and NSArray subscripting, e.g. in service_process_util_mac.mm.
Note that for scoped_nsobject<NSArray>, you need to do ptr.get()[index].
(We could probably return a proxy object from scoped_nsobject::operator[]
to make that unnecessary, but that feels like it might be too clever.)
Custom @interfaces can add their own support for subscripting.
This has worked since the 10.8 SDK.

Generics, e.g. in translate_bubble_controller.h: NSDictionary<NSNumber*, NSView*>
instead of just NSDictionary.  This works only since the 10.11 SDK, and the
bots had an older SDK until erikchen's 10.12 SDK work completed late last year.

https://developer.apple.com/videos/play/wwdc2012/405/, click "slides", auth
See also https://developer.apple.com/library/content/releasenotes/ObjectiveC/ObjCAvailabilityIndex/index.html

We don't use property auto-synthesis because it's very magical. We build
with -Wobjc-missing-property-synthesis to make sure the compiler informs
us if we forget to synthesize a property in some way.

We don't use arc.

Bug: 324079
Change-Id: I78659ed47829fe73c2b87cce43a83ec36deb87e8
Reviewed-on: https://chromium-review.googlesource.com/884011
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531990}

This CL got reverted because Linux debug builds crashed
when running browser tests. I reproduced the crashes locally
and fixed them with:

 -    "//content/public/gpu:gpu_sources",
 +    "//content/public/gpu",

> Background:
> Sometimes (depending on the execution order of browser's
> GPU vs IO thread), the IO thread is shutting down while
> the GPU thread starts up.
>
> Problem:
> BrowserIO can end up in an endless loop where it tries to
> create GPU channels => Linux OOM:
>
> SendOutstandingReplies()'s first while-loop never exits.
>
> ~GpuProcessHost
>  GpuProcessHost::SendOutstandingReplies
>   BrowserGpuChannelHostFactory::EstablishRequest::OnEstablishedOnIO
>    BrowserGpuChannelHostFactory::EstablishRequest::EstablishOnIO
>     GpuProcessHost::EstablishGpuChannel // Queues a channel_request.
>      => SendOutstandingReplies sees another request => endless loop.
>
> This happens because of OnEstablishedOnIO's retry-logic.
>
> Solution:
> (1) Run EstablishOnIO async. That gives
>     SendOutstandingReplies a chance to exit its loop.
> (2) Synchronously Stop() the GPU thread before we destruct
>     its dependencies (here: tell it to stop starting).
>
> Q: What happens if we don't stop the GPU thread
>    before we destruct BrowserChildProcessHostImpl?
> A: We get another race (and even a crash if we use
>    the bug description's timing):
>
> [15658:15698:FATAL:outgoing_broker_client_invitation.cc(52)]
> 0 0x7fe6a522e12d base::debug::StackTrace::StackTrace()
> 1 0x7fe6a522c02c base::debug::StackTrace::StackTrace()
> 2 0x7fe6a52c51ea logging::LogMessage::~LogMessage()
> 3 0x7fe69ef8262b mojo::edk::OutgoingBrokerClientInvitation
>                  ::ExtractInProcessMessagePipe()
> 4 0x7fe6a60592d8 content::ChildThreadImpl::Init()
> 5 0x7fe6a605c032 content::ChildThreadImpl::ChildThreadImpl()
> 6 0x7fe6a5eb94cf content::GpuChildThread::GpuChildThread()
> 7 0x7fe6a5eb9e47 content::GpuChildThread::GpuChildThread()
> 8 0x7fe6a5ee0b23 content::InProcessGpuThread::Init()
> 9 0x7fe6a54c5b47 base::Thread::ThreadMain()
> 10 0x7fe6a54a4161 base::(anonymous namespace)::ThreadFunc()
> 11 0x7fe6ac4d56ba start_thread
> 12 0x7fe691ab63dd clone
>
> Manual test: Follow the bug description's steps.
> Automated test: Run content_browsertests.

Bug: 799002
Change-Id: I1d61475b35abf11c98c6a6a21be6987f6eebdb0f
Reviewed-on: https://chromium-review.googlesource.com/886483Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Hugo Holgersson <hugoh@vewd.com>
Cr-Commit-Position: refs/heads/master@{#531989}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=govind@chromium.org

Change-Id: Ia221f9c5086b54b9829c03ccbfdab345e9bbdb70
Reviewed-on: https://chromium-review.googlesource.com/887906Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531988}

Bug: None
Change-Id: I5524c2aed18531713bfca5c047cef2f18c5c5203
Reviewed-on: https://chromium-review.googlesource.com/887752Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531987}

Recommends base/component_export.h and deprecates the old pattern.

Bug: None
Change-Id: I8bb5d5fbdbafbb9310638d7ce50c8acb5194dce7
Reviewed-on: https://chromium-review.googlesource.com/887624Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531986}

This reverts commit c7f6f0de.

Reason for revert: Reverting because it was not the root causing the issue. Test in Waterfall still fails.


Original change's description:
> [ChromeDriver] Disabling GPU for Mac platform
> 
> The waterfall tests on Mac appear to be flaky so disabling GPU for Mac platforms as well.
> 
> Bug: chromedriver:1695
> Change-Id: Id39fea14a40857bec33e78ffe2d3c65e51ada91c
> Reviewed-on: https://chromium-review.googlesource.com/884303
> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org>
> Reviewed-by: John Chen <johnchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#531669}

TBR=johnchen@chromium.org,khachatryan@chromium.org

Change-Id: Ie149de38211f1a424b5dd341f14081b30b51e61e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromedriver:1695
Reviewed-on: https://chromium-review.googlesource.com/887168Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Artur Khachatryan <khachatryan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531985}

This bubble is deprecated and we don't want to maintain the UI while
waiting for a possible replacement.

Bug: 699338
Change-Id: I8014ca39219aad0d358a1db4c4deb3b42032520a
Reviewed-on: https://chromium-review.googlesource.com/861325Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531984}

This change adds a thrown error message for browser environments
that do not implement Web Bluetooth Test API. The message also
points to the README file that has more information.

BUG=509038

Change-Id: Ic5906a32aca5a4169184e07f6ca804170eb863c9
Reviewed-on: https://chromium-review.googlesource.com/858484Reviewed-by: Conley Owens <cco3@chromium.org>
Reviewed-by: Vincent Scheib <scheib@chromium.org>
Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531983}

To accomplish this:
 - Create a new view and enable/disable it.
 - Make that view paint to it's own layer, which will ensure it paints
   over the icon.

Bug: 803629
Change-Id: I6de0f02024d6287c205187be1babfa2d0ab6f41f
Reviewed-on: https://chromium-review.googlesource.com/884388Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531982}

Merge MultiActivityTestCommon into MultiActivityTestRule since there is
no long need for sharing the implementation with other classes

Bug: 711517
Change-Id: I30612a8815763a56fc9764008913e6c36c846df7
Reviewed-on: https://chromium-review.googlesource.com/881833Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Yoland Yan <yolandyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531981}

Adds a test to ensure that pressing the Daydream controller's app button
while presenting from a deep linked intent is a noop.

Bug: 805712
Change-Id: I7c359d8cd8f574ef239486f96a150695e84f07ef
Reviewed-on: https://chromium-review.googlesource.com/887362Reviewed-by: Yash Malik <ymalik@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531980}

The goal of this CL is to provide a sample call site for
base::NoDestructor.

SslIndexSingleton does nothing in its destructor, so not registering
with AtExitManager doesn't affect behavior.

Change-Id: I19c334faa7148c8f0340c370c854272023fc3950
Reviewed-on: https://chromium-review.googlesource.com/879103Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Buck Krasic <ckrasic@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531979}

The SamplingNativeHeapProfiler::GetSamples used to return all the
memory allocation samples recorded since first call to Start.

Make it return samples recorded since arbitrary Start event.

BUG=803276

Change-Id: I66de31267c6e976a02988c0d85df3c46ae00cd9b
Reviewed-on: https://chromium-review.googlesource.com/879431
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531978}

The code in place handles cases where the container is a TableSection
with a transform. Extend this to also work when the container is a
TableRow with a transform. In general, this patch changes IsTableSection
to IsTablePart to handle any part of the table that can be a container.

This also changes the EnclosingIntRect to RoundedIntRect in a DCHECK,
since offsets under EnclosingIntRect are susceptible to int differences
when the source has small floating point changes. For example,
-1.0000028610 offset in one rect becomes -2, but
-1.0000000000 stays -1.

R=chrishtr@chromium.org

Bug: 804952
Change-Id: Ibc1e062953c1c6bc436101705d4842209e6af707
Reviewed-on: https://chromium-review.googlesource.com/884681Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531977}

Tbr: vasilii@chromium.org
Bug: 805794
Change-Id: I958d1d6a1bce99a7213ad603be75204d35d342c0
Reviewed-on: https://chromium-review.googlesource.com/887161Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531976}

Also fix a few missing breaks found by the warning in gpu/.

Bug: 177475,805881
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I8027c3f22c7972318bd996168ce6b6b18d3bfc78
Reviewed-on: https://chromium-review.googlesource.com/886963
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531975}

Display brokenness expiration times for broken alternative services in chrome://net-internals/#alt-svc

Bug: 792155
Change-Id: I64e9286e157d8d475a90222da910b5c1171bd56b
Reviewed-on: https://chromium-review.googlesource.com/882545
Commit-Queue: Yixin Wang <wangyix@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531974}

TBR=charliea@chromium.org
NOTRY=true

Bug: 806001
Change-Id: I41666e372a765d01f5fbb1dbf30c5928e79c34e4
Reviewed-on: https://chromium-review.googlesource.com/887369Reviewed-by: Emily Hanley <eyaich@chromium.org>
Commit-Queue: Emily Hanley <eyaich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531973}

This UMA currently records all resumption attempts.
This CL fixes that by updating the UMA only on the first
resumption attempt after a browser restart.

BUG=804522

Change-Id: I8a591b0b0fdaf411693df374c2ad81b5979f3456
Reviewed-on: https://chromium-review.googlesource.com/883405Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531972}

BUG=799189
R=ymalik

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I055bda2aef02a3278a090a6ebdd31a8769e8d4ce
Reviewed-on: https://chromium-review.googlesource.com/884372Reviewed-by: Yash Malik <ymalik@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531971}

ImageSanitizer now clears its callbacks when finished to prevent holding
on to other objects and causing memory leaks.

Bug: 800540
Change-Id: Ifcc4f403ee32df6819d906744c07a1f6bd0684ae
Reviewed-on: https://chromium-review.googlesource.com/887104
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531970}

https://pdfium.googlesource.com/pdfium.git/+log/5a21af6cf90c..b9ec0b31a932

$ git log 5a21af6cf..b9ec0b31a --date=short --no-merges --format='%ad %ae %s'
2018-01-25 dsinclair Remove draw from creatable widgets

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ie04c66731b953c9e8ca6a6a755106ce850cf9ddf
Reviewed-on: https://chromium-review.googlesource.com/886657
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531969}

This patch adds a slider to adjust the size or zoom of a display from
chrome display settings page. The slider is hidden behind a command line
switch which can be toggled from the chrome experiments page.

Adds a check on the API to ensure the values are not abused are always
within reasonable bounds. Added tests for the same.

This patch also updates the minimum allowed device scale factor for a
display from 1.0f to 0.5f.

Bug: 790723
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I8027d144859d06a8e5a1a5b3bc7988b217edd851
Component: Display settings webui, chromeos switches, about flags
Reviewed-on: https://chromium-review.googlesource.com/879111
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531968}

SnapLayerToPhysicalPixelBoundary calculates the sub pixel offset that is needed
for a layer to end up on a physical pixel boundary but it does not take into
account that a layer can have a scaling transform applied to it.

This showed up as a problem when https://chromium-review.googlesource.com/691338
landed since it made layers with scale transforms applied start triggering
DCHECKs in CheckSnapped. The reason there was no problem before that CL is that
ConvertPointToLayer used to return floored coordinates.

This patch attempts to fix this problem by applying the transform scale to the
offset vector, similar to how the device scale factor is applied.

Bug: 805425
Change-Id: I401de72a465b83b00762a92ad2634ac2fc40dff5
Reviewed-on: https://chromium-review.googlesource.com/883782
Commit-Queue: Antoine Labour <piman@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531967}

With display zoom a wide range of device scale factors can now be set as
for a given device. Sometimes a value can lead to a failure in the pixel
snapping check. This patch increases the threshold for these checks.

Bug: 790723
Change-Id: I21ae6711f608b9f6bc99efd47d0c8466f03722eb
Component: Dip Util, Pixel Snapping,
Reviewed-on: https://chromium-review.googlesource.com/884361
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531966}

Change-Id: I41ee353dddff2aa5a72701503956894668d82f1c
Reviewed-on: https://chromium-review.googlesource.com/873970
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531965}

Change-Id: I390b9983b624db7086cb5fb8adee43622434f3d4
Reviewed-on: https://chromium-review.googlesource.com/884483
Commit-Queue: Malcolm White <malcolmwhite@google.com>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531964}

Now webkit-patch rebaseline-server is removed in
https://crrev.com/c/847641.

layout-tests-server is likely also unused, and it would
be good to reduce the surface area and quantity of code
in webkitpy if possible.

Bug: 704384
Change-Id: I518153ae01c36d1e34433dc38c5ebea9b87cc869
Reviewed-on: https://chromium-review.googlesource.com/883613Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531963}

We mustn't open it as bookmark.

Bug: 791962
Change-Id: I65b51e8af76c4b31f83991a4f7d3f3f8c37f1a9f
Reviewed-on: https://chromium-review.googlesource.com/882902Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531962}

With this change we won't need to pass SyncItem over IPC later.

Bug: 733662
Change-Id: I4fa2e3743b8c8c36c98f74b9fb609750a2cfbe99
Reviewed-on: https://chromium-review.googlesource.com/885084Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jiaquan He <hejq@google.com>
Cr-Commit-Position: refs/heads/master@{#531961}

https://chromium.googlesource.com/angle/angle.git/+log/2d8e432a9e50..aba14ff52bea

$ git log 2d8e432a9..aba14ff52 --date=short --no-merges --format='%ad %ae %s'
2018-01-15 geofflang Add GLES1 conformance tests.

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Change-Id: I861260ae89d16768549666d4760f02151e31c39d
Reviewed-on: https://chromium-review.googlesource.com/887101Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531960}