- 20 Jul, 2017 40 commits
-
-
Takeshi Yoshino authored
Bug: Change-Id: I72bb8b8b547980e3097c23f1f64fc1da37929774 Reviewed-on: https://chromium-review.googlesource.com/578698 Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#488185}
-
Tetsui Ohkubo authored
For better MD style download notification representation, we're going to add new attributes to Notification class, and going to use these strings. TEST=manual BUG=740807 Change-Id: I05a5f1a2094814b579aee886297732b0df2c56b5 Reviewed-on: https://chromium-review.googlesource.com/578752Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#488184}
-
Vaclav Brozek authored
On iOS, unlike on Android or desktop platforms, toggling the "Save password" switch to off hides the stored passwords (including blacklisted entries). Those are still present in the profile, and are still filled in forms. The user needs to enable saving to be able to delete them from the passwords settings. The UI guidance (https://crbug.com/515462#c7) and product guidance (https://crbug.com/515462#c8) is that iOS should instead mirror the other platforms here and display the stored entries no matter whether saving is enabled or disabled. This CL implements that change. Bug: 515462 Change-Id: Iae1d35fc6b1eda273dc8efa068454462c1649110 Reviewed-on: https://chromium-review.googlesource.com/573381 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#488183}
-
Tetsui Ohkubo authored
Add "Chrome OS system" string that will be used for system notification when new-style notification is enabled. BUG=738779,726241,740807,740813 TEST=manual Change-Id: I2e4ce586385065752abcc4e38445b7e67c6bb2ef Reviewed-on: https://chromium-review.googlesource.com/578696Reviewed-by:
-
Gustavo Sacomoto authored
The mocks are here: https://docs.google.com/presentation/d/1GnKn5ca_KrM_BTQB-He9cCmzAQtwVF6JJJ6Lo6i4gqI/edit?ts=596e5846#slide=id.g4af27b4ff_35243 Bug: 746046 Change-Id: Ie2dff5c8913f71db4fd738a04c27fc082db1b803 Reviewed-on: https://chromium-review.googlesource.com/578030Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Gustavo Sacomoto <sacomoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#488181}
-
Austin James Ahlstrom authored
Bug: Change-Id: I026fc3a546afe4699452ced6810b187addeb576b Reviewed-on: https://chromium-review.googlesource.com/578537Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Commit-Queue: Austin James Ahlstrom <aahlstrom@google.com> Cr-Commit-Position: refs/heads/master@{#488180}
-
Daniel Bratell authored
Compiling browser code in blink/modules currently use about 80 CPU minutes. That is about 7% of the total compilation time. If you use jumbo compilation (merge many files into a single translation unit) that time drops to about a fifth of that. There are also unit_tests in modules that will be jumbofied in a different patch. Bug: 713137 Change-Id: I9155d2af0c9dce6b3178f77b9366062eb45d4560 Reviewed-on: https://chromium-review.googlesource.com/568302Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#488179}
-
Benoit Lize authored
This is a non-regression test for the linked bug. BUG=742294 Change-Id: I749e223b831f7558b53039a14704625e52192a15 Reviewed-on: https://chromium-review.googlesource.com/576173 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#488178}
-
Colin Blundell authored
As a precursor to changing the implementation of chrome.identity.getAccounts() to use the Identity Service, this CL moves that implementation away from using AccountTracker::GetAccounts() to using OAuth2TokenService::GetAccounts(). The latter is the function that we intend to back the upcoming Identity Service API. AccountTracker::GetAccounts() is fundamentally based on OAuth2TokenService::GetAccounts(): they both have the basic behavior of returning the informations of all accounts for which a refresh token is available. However, AccountTracker::GetAccounts() layers some extra information on top relating to the primary account (a concept of which the OAuth2TokenService is not aware). (AccountTracker itself gets this information via IdentityProvider; in the context of the chrome.identity.getAccounts() impl, this is ProfileIdentityProvider, which is backed by SigninManager). To avoid any behavioral changes, this CL ports the particular semantics of AccountTracker::GetAccounts() to live directly in the implementation of chrome.identity.getAccounts(): - Returns an empty list if there is no primary account or there is no refresh token available for the primary account - Otherwise, puts the primary account first in the returned list Bug: 729536 Change-Id: Ib4f6cff0afd2f751ec3a7409d24b797b1be0ec79 Reviewed-on: https://chromium-review.googlesource.com/574709Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
-
Vaclav Brozek authored
PasswordsSettingsTestCase exposes a number of instance methods to do instance-independent work. Those should either become class methods or functions in the anonymous namespace. Those methods are not related to the PasswordsSettingsTestCase class either, and there already are helper functions in the anonymous namespace in passwords_settings_egtest.mm. Therefore this CL moves the mentioned methods to become functions in the anonymous namespace. Bug: 744058 Change-Id: I1f8ede1d5bb4ef950f701cdefe407dc2d3bac0dd Reviewed-on: https://chromium-review.googlesource.com/573025 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0850262f..3ef78954 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Id347d315033198db7404210f5a4c4a368421b448 Reviewed-on: https://chromium-review.googlesource.com/578850Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#488175}
-
Hajime Hoshi authored
Now mojo is fixed to pass unique IDs across processes, Let's enable new ownership edges for base::SharedMemory and remove old ownership edges. Perf sheriffs: If you see sharp bumps in metrics like cc/gpu/discardable/ shared_memory this is very likely the culrprit, please revert it. Bug: 604726 Change-Id: Iad7bf261f3e2c884d60e935cb2635923de46b2e2 Reviewed-on: https://chromium-review.googlesource.com/557741 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Siddhartha S <ssid@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#488174}
-
Dominic Battre authored
Bug: 732846 Change-Id: I011b4805a15501df0fb32ac3fd6002e44a56d9c2 Reviewed-on: https://chromium-review.googlesource.com/575242 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#488173}
-
Clemens Hammacher authored
Since the DISALLOW_* macros now use the C++11 syntax "= delete", it does not matter whether they are used in the public or the private section of a class definition. In fact, the style guide recomments putting deleted constructors or assignment operators in the public section. Thus, remove the hint to put them in the private: declarations. Drive-by: Fix the syntax of the deleted copy assignment operator. R=thakis@chromium.org Change-Id: I10af0d71c18dc1f3b08e4601ae571ed53d8c71e3 Reviewed-on: https://chromium-review.googlesource.com/578027Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#488172}
-
Benoit Lize authored
BUG=742450 Change-Id: Ia767797d89022b862e38b7ae72949bed08d94c09 Reviewed-on: https://chromium-review.googlesource.com/578067Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#488171}
-
Yoshifumi Inoue authored
This patch renames |FrameSelection::VerticalDirection| to |SelectionModifyVerticalDirection| since it is used for a parameter of |SelectionModifier::ModifyWithPageGranularity()| for improving code health. Change-Id: Ic7c5c53a5b7d6cdb2f4c5350a4b7074d522ef5ef Reviewed-on: https://chromium-review.googlesource.com/578911 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#488170}
-
Koji Ishii authored
This patch implements break-after-space style line breaking. This style is needed for 'white-space:pre-wrap', and when in editing. The current layout engine handles this in BreakingContext. This patch implements the style in LazyTextBreakIterator so that ShapingLineBreaker can implement the behavior without additional code. The current layout engine supports 3 modes: 1. break-before-space (most cases) 2. break-after-space (white-space:pre-wrap) 3. break-after-space + hanging space (editing) This patch does not support 3rd mode yet, and that editing behavior is slightly different from the current layout engine, closer to Edge. The editing test failure is caused by this difference. I'll evaluate the impact and the needs of the 3rd mode later. There are more tests that actually pass, but they fail for other reasons, such as the lack of quirks mode support. BUG=636993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Iec1b684da4dcf45f10eaa408889ebf77d387e668 Reviewed-on: https://chromium-review.googlesource.com/574903 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#488169}
-
Vaclav Brozek authored
The button matchers in passwords_settings_egtest.mm have currently some redundant grey_layout()-based sub-matchers. The idea is that when matching for the buttons, the layout of the detail view page is also checked. However, these redundant matchers make the button matchers heavy and sometimes unusable (e.g., in the presence of different layouts for federated or blacklisted credentials). Therefore this CL removes the layout constraints from the matchers and instead creates specialised tests dedicated to just checking the layout. The past test "testBlacklisted" has been subsumed in the more detailed new "testLayoutBlacklisted", and hence the former was removed. Bug: 744058 Change-Id: I5428c9246e5de29f1124788e368550f7e6cfa72b Reviewed-on: https://chromium-review.googlesource.com/573024Reviewed-by:
-
Kent Tamura authored
The default value of |base| is 10, and only one instance with base=16 exists. This CL adds String::HexToUIntStrict(), and remove |base| arguments of the following integer parsing functions: - String::ToIntStrict() - String::ToUIntStrict() - String::ToInt64Strict() - String::ToUInt64Strict() - StringImpl::ToIntStrict() - StringImpl::ToUIntStrict() - StringImpl::ToInt64Strict() - StringImpl::ToUInt64Strict() - CharactersToIntStrict() - CharactersToUIntStrict() - CharactersToInt64Strict() - CharactersToUInt64Strict() Bug: 746157 Change-Id: If269771609e674d9f1baa279c0ed4954a14b7bc6 Reviewed-on: https://chromium-review.googlesource.com/578536 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#488167}
-
Tatsuhisa Yamaguchi authored
Bug: 740842 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia7513ab41b6e684fec446d4f6232b4e29f09b0f5 Reviewed-on: https://chromium-review.googlesource.com/577975 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#488166}
-
Aaron Leventhal authored
Bug: None Change-Id: I2539556dbeafe0545dfd618ac74f45975e4b8614 Reviewed-on: https://chromium-review.googlesource.com/562819Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#488165}
-
Sylvain Defresne authored
The NetworkChangeNotifier owns an object that checks it is destroyed on the correct thread (HistogramWatcher). This requires the object to be destroyed before the thread is stopped, so add helper function to control when the NetworkChangeNotifier is destroyed. For the same reason, do it also for MessageLoopForUI. Call the new function from WebMainLoop destructor. This fixes a new regression that was introduced during the refactoring of this code that moved the object destruction till after the "main" function returns (as they are owned by "static" globals). To ensure the destruction happens in the same order as before the refactoring in https://chromium-review.googlesource.com/558268, use base::ScopedClosureRunner to register in which order the helper functions are called. As CroNet code was leaking those objects, do not add a call to the destroy function there. Bug: 746478 Change-Id: If2e5d1dea15c73bccd973222f9811660a5687b77 Reviewed-on: https://chromium-review.googlesource.com/577851 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#488164}
-
Peter Kasting authored
The AutofillWebDataService APIs can be consumed on any thread, not just the DB thread, so it's not necessary to post to the DB thread to call them. The AwFormDatabaseService itself is only accessed on one thread, and blocks while it has an ongoing HasFormData() call, so there can't be multiple requests in-flight at once. This lets us remove the entire result map. Bug: None Change-Id: I7b6cd5272cb569d00fcd4cc6f89f22082100184c Reviewed-on: https://chromium-review.googlesource.com/578298 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Selim Gurun <sgurun@chromium.org> Cr-Commit-Position: refs/heads/master@{#488163}
-
Lutz Justen authored
Does not open a separate browser tab for SAML auth anymore, but moves the auth page into a webview in the support app. The old code (ab-)used the ToS negotiation code path to display the AD auth page. The new code uses the authentication code path already used by LSO auth. Apart from being clearer, this has the advantage that Chromad Tier 1.0, which doesn't require SAML auth, does not pop up any page. It also gets rid of an interstitial page. As soon as SAML SSO is supported, we should be able to hide the page completely. Reskins the AD auth screen to match the OOBE design. BUG=chromium:719874 TEST=out/Release/unit_tests --gtest_filter=Arc* Change-Id: I3d6b09c89ac41ef7e14c5e08adbaec146df98710 Reviewed-on: https://chromium-review.googlesource.com/569967Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#488162}
-
Tatsuhisa Yamaguchi authored
Bug: 740842 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8a0826a93cb36588bda03b5acfbf633c35d8d11e Reviewed-on: https://chromium-review.googlesource.com/577978Reviewed-by:
-
calamity authored
BUG=667892 Review-Url: https://codereview.chromium.org/2952133002 Cr-Commit-Position: refs/heads/master@{#488160}
-
Sam McNally authored
Remove the deprecated ChildProcessHost::CreateChannelMojo overload and migrate its final user (service utility process) to the other overload. This requires the service process to directly connect to the service_manager.mojom.Service interface to bind interfaces and claim to be the browser service when binding interfaces so ChildThreadImpl allows the IPC bootstrap request. Change replay process to support the non-deprecated approach of using the initial mojo handle as a service_manager::mojom::ServiceRequest. Change chrome/utility/importer/firefox_importer_unittest_utils_mac.cc to define its own constant for the channel token and remove the shared content::switches::kMojoChannelToken. Bug: 666605 Change-Id: Ib0721eecae5f53373262d320ebeb23745b62c7c1 Reviewed-on: https://chromium-review.googlesource.com/564914Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#488159}
-
Yoichi Osato authored
Since we can split marking SelectionState and invalidate painted LayoutObject. SelectionPaintRange has both info but we should split it. This patch introduces SelectionMarkingRange which is just copy from SelectionPaintRange class. I will drop unused functionality from each class in later patches. Bug: 739062 Change-Id: I6ffececbf96228f1b7593ac82e49632b1a348760 Reviewed-on: https://chromium-review.googlesource.com/578701Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#488158}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2e867917..0850262f Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I5f911c135d6900cd0be45a25aca76b93226b3e11 Reviewed-on: https://chromium-review.googlesource.com/578399Reviewed-by:
-
Brett Wilson authored
We previously removed the optimization that this option turned off but forgot to remove the option. It currently does nothing, so removing it is a no-op. Change-Id: Iefe122b9351dbe06f88fec098d4267b789b8e786 Reviewed-on: https://chromium-review.googlesource.com/578245 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#488156}
-
Yutaka Hirano authored
Bug: None Change-Id: I939a06f5d554101cea344f092f8de63bfb15e758 Reviewed-on: https://chromium-review.googlesource.com/575113 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
Kent Tamura authored
This reverts commit 0627c931. Reason for revert: Link failure on some Windows bots. e.g. https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.win%2FWin_Builder%2F42057%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout Original change's description: > Remove unnecessary #includes from Assertions.h > > Change-Id: I9d9a0ff0c56a10923e393d4eef7ccde7b33c4a2b > Reviewed-on: https://chromium-review.googlesource.com/578532 > Commit-Queue: Yuta Kitamura <yutak@chromium.org> > Reviewed-by: Yuta Kitamura <yutak@chromium.org> > Cr-Commit-Position: refs/heads/master@{#488149} TBR=yutak@chromium.org,tkent@chromium.org Change-Id: If9b9b1ada6a3b45bd3a670b9aaab908401530e9d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/578829Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#488154}
-
Andreas Haas authored
The issue which made this test flaky has been fixed in https://chromium-review.googlesource.com/c/559769/, so we can turn this test on again. R=bsep@chromium.org Bug: chromium:736676 Change-Id: I423782d2cd1f299f40a70a1f1595b573fa7646c2 Reviewed-on: https://chromium-review.googlesource.com/576033Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#488153}
-
Peter Kasting authored
Calling one of these APIs results in creating a WebDataRequest object to allow calling back with the result. This object assumed the caller had a ThreadTaskRunnerHandle, but there's no reason callers need to have such a handle. Instead, allow calling any task back, using the thread or sequenced task runner if available, or simply PostTask() if not. Bug: 689520 Change-Id: Icf901e6de5a5b629bcf9d17617baf46a45502844 Reviewed-on: https://chromium-review.googlesource.com/578572 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#488152}
-
ricea authored
Only WebSocket connections from the main page were tested. WebSocket connections from Workers should also lead to display of an interstitial. Modify malware_websocket.html to accept a "type" query parameter indicating which environment to create the WebSocket in. Make the MalwareWebSocketBlocked tests be parameterised on the environment type. Due to a recent change (https://codereview.chromium.org/2960703003), these changes need to be tested by passing --enable-features=NetworkService to browser_tests, as opposed to the --enable-network-service argument that was needed before. BUG=644744 Review-Url: https://codereview.chromium.org/2971333002 Cr-Commit-Position: refs/heads/master@{#488151}
-
apacible authored
This change adds a general window that overlays other windows, initially for the use case of picture in picture. This includes a partially stubbed views implementation. Cocoa work will be done in a separate CL. BUG=726621 Review-Url: https://codereview.chromium.org/2905833004 Cr-Commit-Position: refs/heads/master@{#488150}
-
Kent Tamura authored
Change-Id: I9d9a0ff0c56a10923e393d4eef7ccde7b33c4a2b Reviewed-on: https://chromium-review.googlesource.com/578532 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
-
Ramin Halavati authored
Network traffic annotation is added to network request of: content/browser/frame_host/render_frame_message_filter.cc BUG: 656607 Change-Id: Ie68e036d5e00aaf4cad0966e6a5e0ce2a1d624b0 Reviewed-on: https://chromium-review.googlesource.com/570029 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#488148}
-
John Abd-El-Malek authored
TBR=yzshen@chromium.org NOTRY=true Change-Id: I9d8fe29dc0a840e98d070164bb1171334cc32464 Reviewed-on: https://chromium-review.googlesource.com/578660 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#488147}
-
Koji Ishii authored
The word-break:keep-all code was forked in [1]. This patch merges it back to single template function, in preparation of supporting after-white-space in LayoutNG. Includes some cleanup to make IsBreakable() inline function smaller without increasing non-inline function calls. [1] https://codereview.chromium.org/1094863007 BUG=636993 Change-Id: I6471b83437e29f5ee2fcb30473c8eb8d526abf35 Reviewed-on: https://chromium-review.googlesource.com/575799 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
