GitLab

The RGB pixel components are flipped in the software decoder
implementation.

Also add latency calculation to example plugin.
Flip picture vertically (it was upside down).

BUG=281689

Review URL: https://codereview.chromium.org/346543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278237 0039d316-1c4b-4281-b951-d872f2087c98

This adds a function to PPB_View which allows plugins to know the scroll offset
of the page when they are in view. This is useful for OOP PDF which uses the
scroll offset of the window it is contained in to determine the document's
scroll location. A web page can send scroll location via postMessage but
this is slow. Sending the offset directly via view messages is much faster
and seems reasonable.

We don't send the scroll offset in the cases where the plugin is off screen
to avoid any more additional IPC traffic than what currently exists.

BUG=303491

Review URL: https://codereview.chromium.org/329033003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278236 0039d316-1c4b-4281-b951-d872f2087c98

This is a follow-up CL of r276344.

Currently, when audio and video decoders receive an EOS buffer, they do the following in order:
1, Flush the codec, return all internally buffered frames through the OutputCB.
2, Return a EOS frame through the OutputCB.
3, Return the DecodeCB.

Since the DecoderStream knows when an input buffer is an EOS, when the DecodeCB is returned, DecoderStream knows that decoding has finished. Therefore, step (2) is redundant.

This CL drops step (2) which simplifies a lot of code.

BUG=385872

Review URL: https://codereview.chromium.org/339653003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278232 0039d316-1c4b-4281-b951-d872f2087c98

Added option to bookmarkManagerPrivate.getMetaInfo() to get meta info from all bookmarks in a one function call.
Needed to improve stars extension performance.

BUG=383600

Review URL: https://codereview.chromium.org/330983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278231 0039d316-1c4b-4281-b951-d872f2087c98

 * If NSS version doesn't support AES-GCM
 * If NSS version doesn't support RSA-OAEP

BUG=384485

Review URL: https://codereview.chromium.org/343473004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278230 0039d316-1c4b-4281-b951-d872f2087c98

Since we don't keep track of the current entry when showing the dialog,
it should be dismissed on a navigation to avoid reading the wrong data.

BUG=384176

Review URL: https://codereview.chromium.org/335293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278229 0039d316-1c4b-4281-b951-d872f2087c98

Use the built-in bubble title and close button views.
Use the bubble's title insets for the other views.
Use BookmarkSyncPromoView colors for the UMA promo.
Use views layout constants for the spacing values.
Use default label/checkbox/bubble colors, not hard-coded.
(black/off-white + supports inversion for accessibility)
Fix the UMA promo separator line (wasn't fully extended).

Inline some BrowserRemovalObserver function implementations.
Other misc. code cleanup. See before/after pics on the bug.

BUG=384123
TEST=Session crashes bubble looks good, works well.
R=yiyaoliu@chromium.org,sky@chromium.org

Review URL: https://codereview.chromium.org/331353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278228 0039d316-1c4b-4281-b951-d872f2087c98

This CL was originally uploaded at
https://codereview.chromium.org/269513002 but was reverted due to a high
number of crash reports on Windows. The issue was that RTree::Insert()
would remove duplicate nodes before re-inserting them, but didn't handle
the corner case where the root node would end up as a non-leaf node with
only one child. RTree::Remove() did the right thing in this case, which
is to remove the root and replace it with its solitary child, but
RTree::Insert() did not. This lead to a situation with invalid trees
being created that would ultimately lead to a crash on a subsequent
call to RTree::Insert(). A short unit test that reproduced the crash
is included.

BUG=384736

Review URL: https://codereview.chromium.org/342723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278227 0039d316-1c4b-4281-b951-d872f2087c98

BUG=239879
TBR=noamsml

Review URL: https://codereview.chromium.org/345453005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278226 0039d316-1c4b-4281-b951-d872f2087c98

This change propagates GCM connection state from GCMInvalidationBridge
to SyncNetworkChannel where based on this notification overall
invalidations state is updated.

This change still has issue that when GCM connection is down but HTTP request
succeeds then status is updated to NOTIFICATIONS_ENABLED. Fixing this
requires minor refactoring which I would like to pull into separate change.

BUG=378536
R=rlarocque@chromium.org

Review URL: https://codereview.chromium.org/334253006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278225 0039d316-1c4b-4281-b951-d872f2087c98

The aync CommitLayers() call will never be completed, if no layers changed since the last call to CommitLayers(). So we have to force a commit for each CommitLayers() call.

BUG=374383
R=bbudge@chromium.org, piman@chromium.org

Review URL: https://codereview.chromium.org/345443005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278224 0039d316-1c4b-4281-b951-d872f2087c98

Improve the no-op reconcilor so that it doesn't "hang" after the first execution, but instead successfully completes the reconciliation.
Improve the UMAHistogramHelper so that it can nicely take snapshots between tests, allowing the test writer to easily test ONLY the changes logged in "this" test.
Write a new unit test that executes the reconcilor twice, and make all reconcilor unit tests execute with and without the flag.

BUG=357693
TBR=phajdan.jr@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277605

Review URL: https://codereview.chromium.org/309843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278223 0039d316-1c4b-4281-b951-d872f2087c98

Move SkFontMgr::Factory to skia/ext so that we can use the warmed-up
sandbox version when using DirectWrite that's created by content/. This
avoids the previous default behaviour of creating a GDI SkFontMgr which
is always wrong when DirectWrite is being used (and causes crashes
when --enable_win32k_renderer_lockdown is enabled).

R=jamesr@chromium.org,bungeman@google.com
BUG=385926,356950,385717
TEST=http://www.effectgames.com/demos/canvascycle/ http://www.w3schools.com/tags/tryit.asp?filename=tryhtml5_canvas_filltext and enabling FPS in about:flags with both --enable_win32k_renderer_lockdown and --disable-direct-write

Review URL: https://codereview.chromium.org/344653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278222 0039d316-1c4b-4281-b951-d872f2087c98

Also removes obsolete test cases which tested the behavior  before tooltips were toplevel windows on Linux

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/333333003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278221 0039d316-1c4b-4281-b951-d872f2087c98

BUG=326577

Review URL: https://codereview.chromium.org/340773004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278220 0039d316-1c4b-4281-b951-d872f2087c98

Also, when we cleanup tilings on the active twin, we use the pending
twin's ideal contents scale. But when the twin !CanHavTilings() there
is no need to use that ideal scale and save tilings.

R=enne@chromium.org, enne

Review URL: https://codereview.chromium.org/334953003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278219 0039d316-1c4b-4281-b951-d872f2087c98

webapp_build.py wasn't updated properly in r278198. As result main.html
wasn't properly package in the webapp.

TBR=wez@chromium.org
BUG=134215

Review URL: https://codereview.chromium.org/344753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278218 0039d316-1c4b-4281-b951-d872f2087c98

BUG=383907

Review URL: https://codereview.chromium.org/332943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278217 0039d316-1c4b-4281-b951-d872f2087c98

An oversight, the histograms should have the UMA_ prefix.

BUG=385159

Review URL: https://codereview.chromium.org/343643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278215 0039d316-1c4b-4281-b951-d872f2087c98

This patch adds implementation for GinJavaBoundObject class, which
is responsible for interacting with injected Java objects, and a helper
trivial class GinJavaBoundObjectDelegate which is used with GinJavaMethodInvocationHelper

Java interaction code is mostly taken from the existing implementation.
The main difference that the new implementation has, is that the relationship
between Java objects and JavaScript interface objects is now managed
by us, not by NPAPI.

This patch also contains the following fixes to the existing code
discovered after re-running tests:

 -- ART doesn't like when static Java methods are invoked using JNI calls
    for instance methods, so switched to use the right JNI calls;

 -- accessing 'window' object when adding JavaScript interface objects
    may cause DidClearWindowObject to be called, so guard against double
    entrance.

BUG=355644

Review URL: https://codereview.chromium.org/323403007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278214 0039d316-1c4b-4281-b951-d872f2087c98

This is simple cleanup in preparation for a Label rewrite.
These overrides were supplying an extra gfx::Canvas flag.
Instead, add an explicit label flag for NO_SUBPIXEL_RENDERING.
Update some callers and the unit test.

TODO(followup): Update more Label::SetBackgroundColor callers.

BUG=240037
TEST=No exit warning or sticky keys label rendering changes.
R=sky@chromium.org

Review URL: https://codereview.chromium.org/341713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278213 0039d316-1c4b-4281-b951-d872f2087c98

This is a re-land of https://codereview.chromium.org/340523006/

BUG=384514
R=maruel@chromium.org

Review URL: https://codereview.chromium.org/341623003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278212 0039d316-1c4b-4281-b951-d872f2087c98

On startup and on network changes, a request is made to the data reduction proxy to warm the connection. This reduces the page load time for first loads.

BUG=354438

Review URL: https://codereview.chromium.org/338723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278210 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/341603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278209 0039d316-1c4b-4281-b951-d872f2087c98

After the landing https://codereview.chromium.org/212303003,
update_screen.cc doesn't need the command line switch related
headers anymore. So we can remove these.

BUG=349033

Review URL: https://codereview.chromium.org/334403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278208 0039d316-1c4b-4281-b951-d872f2087c98

BUG=322395

Change-Id: Ie0376052892349f18db5d60737f6329b8c92eb1c

Review URL: https://codereview.chromium.org/333003003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278207 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278206 0039d316-1c4b-4281-b951-d872f2087c98

r278198 broke official build bots. This change should fix it.

BUG=134215
TBR=wez@chromium.org

Review URL: https://codereview.chromium.org/342873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278205 0039d316-1c4b-4281-b951-d872f2087c98

r278198 broke official build bots. This change should fix it.

TBR=wez@chromium.org
BUG=134215

Review URL: https://codereview.chromium.org/340303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278204 0039d316-1c4b-4281-b951-d872f2087c98

BUG=385222
TBR=glider@chromium.org

Review URL: https://codereview.chromium.org/342853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278201 0039d316-1c4b-4281-b951-d872f2087c98

We hook onMaximized so that if the user maximizes the window, it automatically full-screens. This allows us to get the same behaviour if the user double-clicks the title bar or uses some other OS shortcut to maximize the window as we get if they clicks the maximize button. However, it's not a particularly clean transition to full-screen mode, especially on Mac, and I suspect it's the root cause of the referenced bug (though I can't repro it). This CL simplifies the common case of maximizing via the window control, which gives a much smoother UX.

BUG=384678

Review URL: https://codereview.chromium.org/338373004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278199 0039d316-1c4b-4281-b951-d872f2087c98

BUG=134215
R=weitaosu@chromium.org, wez@chromium.org

Review URL: https://codereview.chromium.org/342583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278198 0039d316-1c4b-4281-b951-d872f2087c98

This patch introduces the abstract API definitions for BluetoothGattConnection
and BluetoothDevice::CreateGattConnection, which are used to manage the life
time of a GATT connection among multiple apps that request it.

BUG=384620

Review URL: https://codereview.chromium.org/336933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278197 0039d316-1c4b-4281-b951-d872f2087c98

Currently we do a walk over all tiles in the pending tree's pile, but
there can be 1 million x 1 million tiles on some pages, which makes this
method take multiple _seconds_ to complete.

These loops were added in r184525 which gave the tradeoffs that led to
them, which are that we want to only use a single pile for all the tiles
on this layer, but we don't want raster tiles on the active layer (when
this activates) that can't be rastered by the pile they are attached to.

Instead of walking every pile-tile, to find the tiles that are not
present in the current recording and invalidate them, we expand
invalidations outside the interest rect to cover the full recording tiles,
and we expand invalidation inside the interest rect to include any raster
tiles that don't have a recording (such as in the offscreen animating gif
case). We give this expanded invalidation to the pending layer, causing
it to drop rastered tiles from the active tree that intersect with an
unrecorded area.

R=enne
BUG=371839

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277964

Review URL: https://codereview.chromium.org/294163009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278196 0039d316-1c4b-4281-b951-d872f2087c98

BUG=373917
R=rsleevi@chromium.org
TBR=rsleevi@chromium.org

Review URL: https://codereview.chromium.org/340883004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278195 0039d316-1c4b-4281-b951-d872f2087c98

To support imageWriterPrivate on Mac for the Chromebook Recovery Tool we will have to write to USB drives on Mac.  OS X allows us to open a single FD with elevated privileges through running the authopen command.

Unmounting and claiming the disk are a bit more complicated as they require use of the Disk Arbitration framework.

Disk Arbitration is an asynchronous interface.  In order to simplify the code we use a mutex to block.

The core logic is derived from the previous recovery tool.  See googleclient/chrome/chromeos_recovery/mac/ChromeOSRecovery/AppController.mm in the internal Google repositories.

BUG=376398
BUG=318451

Review URL: https://codereview.chromium.org/294163008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278194 0039d316-1c4b-4281-b951-d872f2087c98

TBR=brettw@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/342773005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278193 0039d316-1c4b-4281-b951-d872f2087c98

The URLRequestJobManager will now crash if there is not one.
This is part of the work aimed at eliminating the JobManager.

BUG=142945

Review URL: https://codereview.chromium.org/332833003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278192 0039d316-1c4b-4281-b951-d872f2087c98

This test fails consistently on Linux Tests (dbg) (1)

[ RUN      ] PDFExtensionTest.BasicPlugin
...
[1023:1023:0618/142028:INFO:CONSOLE(0)] "[SUCCESS] testPageSize", source: chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/index.html?http://127.0.0.1:42118/pdf/test.pdf (0)
[17:17:0618/142028:WARNING:resource_message_handler.cc(49)] 'Post' message handler failed to complete successfully.
[17:17:0618/142028:ERROR:pepper_uma_host.cc(106)] Host or histogram name is not allowed to use the UMA API.
[17:17:0618/142028:WARNING:resource_message_handler.cc(49)] 'Post' message handler failed to complete successfully.
memory allocation bug: object at 0x7f5a852272c0 has never been allocated
BrowserTestBase signal handler received SIGTERM. Backtrace:
#0 0x7f9e4351c8b5 base::debug::StackTrace::StackTrace()
#1 0x00000462f8f2 content::(anonymous namespace)::DumpStackTraceSignalHandler()
#2 0x7f9e2fb2f4a0 \u003Cunknown>
#3 0x7f9e2fbe1a43 __poll
#4 0x7f9e30917ff6 \u003Cunknown>
#5 0x7f9e30918124 g_main_context_iteration
#6 0x7f9e434e49e5 base::MessagePumpGlib::Run()
<truncated, full output is in gzipped JSON output at end of step>
#31 0x7f9e34f05dc7 content::RunNamedProcessTypeMain()
#32 0x7f9e34f074df content::ContentMainRunnerImpl::Run()
#33 0x7f9e34f0528b content::ContentMain()
...

> Re-enable PDFExtensionTest.BasicPlugin
> 
> This test was disabled because it was failing. A few changes have been made:
> -The page zoom cannot be assumed to be 100% on load as it will depend on the screen size being tested on. So testPageSize now doesn't make that assumption.
> -testAccessibilityWithPage was flaking because accessibility information was not always returned for the two text boxes. I spent a bit of time investigating, but couldn't work it out so I've left it partially disabled for now and filed crbug.com/378091.
> -The files have all been moved to a more appropriate location (in particular the test was moved out of the data directory).
> 
> BUG=303491
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273819
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274186
> 
> Review URL: https://codereview.chromium.org/290803007

TBR=raymes@chromium.org

Review URL: https://codereview.chromium.org/346693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278191 0039d316-1c4b-4281-b951-d872f2087c98

I'm excluding this instead of suppressing it to keep it consistent with lsan, and  to avoid hiding real issue on other tests.

BUG=386080
TBR=perkj@chromium.org

Review URL: https://codereview.chromium.org/340213003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278187 0039d316-1c4b-4281-b951-d872f2087c98