GitLab

Root cause:
Our testharnessreport.js removes unnecessary text nodes in a callback registered
by add_completion_callback() [1]. The html5lib tests add other completion
callbacks to show failure reasons, and they run after the callback of
testharnessreport.js.  So, the failure reasons remain in *-expected.txt.

Resolution:
testharness.js doesn't provide a way to specify that "This callback must run at
the end of callbacks." So we delay the text nodes cleanup by setTimeout(done, 0).

[1] https://github.com/w3c/testharness.js/blob/master/docs/api.md#callback-api

BUG=527262

Review URL: https://codereview.chromium.org/1303313006

git-svn-id: svn://svn.chromium.org/blink/trunk@201628 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://html.spec.whatwg.org/multipage/scripting.html#script-processing-for
> 12. If the script element has an event attribute and a for attribute, then run
> these substeps:

Our implementation was "... has a non-empty event attribute and a non-empty for
attribute, ...".  This CL corrects isEmpty() checks to isNull().
The new behavior is compatible with IE and Firefox.

BUG=520844

Review URL: https://codereview.chromium.org/1305213005

git-svn-id: svn://svn.chromium.org/blink/trunk@201627 bbb929c8-8fbe-4397-9dbb-9b2b20218538

ResourceClientWalker uses a reference to m_clients (a member of the
RawResource instance). Therefore, when w.next() is invoked, the RawResource
instance must be alive.

RawResourceClient (e.g. DocumentThreadableLoader) may destroy the RawResource
in didSendData() and didDownloadData().

Like other methods (appendData(), willFollowRedirect(), ...) these methods
should also have a protect.

BUG=527046
R=japhet,hiroshige

Review URL: https://codereview.chromium.org/1307743009

git-svn-id: svn://svn.chromium.org/blink/trunk@201626 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch replaces static member function |VisibleSelection::selectionType()|
by |VisibleSelection::Strategy::selectionType()| in |PendingSelection| class
as preparation of moving |VisibleSelection::selctionType()| out from
|VisibleSelection| as local static function, since it is used only
|PendingSelection| and |VisibleSelection| classes for ease of templatizing
|VisibleSelection| to introduce composed tree version.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1323933003

git-svn-id: svn://svn.chromium.org/blink/trunk@201625 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=516604, 496496

Review URL: https://codereview.chromium.org/1320443005

git-svn-id: svn://svn.chromium.org/blink/trunk@201624 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=None

Review URL: https://codereview.chromium.org/1326773002

git-svn-id: svn://svn.chromium.org/blink/trunk@201623 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch moves |honorEditingBoundaryAtOr{Before,After}()| for
|VisiblePosition| to "VisibleUnits.cpp" form "VisiblePosition.cpp" to make
"VisiblePosition.cpp" to simpler for improving code health and ease of
templatizing |VisiblePosition| class to introduce composed tree version.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1303173010

git-svn-id: svn://svn.chromium.org/blink/trunk@201622 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=rev&rev=201530 fixed the assertion
failures.

BUG=519997
TBR=kouhei@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1321663004

git-svn-id: svn://svn.chromium.org/blink/trunk@201621 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Style attribute declarations were added in a separate scope after all
other author origins. Instead add style attribute declarations right after
collecting matching rules from the element's scope. This means that we can
override values set on the style attribute from outer scopes, like we can
with values from inner scope's stylesheet.

Without this fix, you would get green on orange below:

<style>html /deep/ span { color: green; background-color: lime }</style>
<host>
  <host:root>
    <style>span { color:red }</style>
    <span style="background:orange">Green on orange?</span>
  </host:root>
</host>

With this change, we will get green on lime.

The regression (issue 526634) was not relying on this, but it would be
more complex code to fix the regression without fixing the style attribute
cascading order.

R=kochi@chromium.org,hayato@chromium.org
BUG=526634

Review URL: https://codereview.chromium.org/1322753006

git-svn-id: svn://svn.chromium.org/blink/trunk@201620 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch replaces member variables |Position| and |TextAffinity| in
|VisiblePostion| class to |PositionWithAffinity| to simplify construction
of an object for preparation of templatizing |VisiblePostion| to introduce
composed tree version.

This patch also moves default constructor into .cpp file from header file to
reduce size of header file.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1311913006

git-svn-id: svn://svn.chromium.org/blink/trunk@201619 bbb929c8-8fbe-4397-9dbb-9b2b20218538

According to the standard and web-platform-tests, empty attribute value should
return the document URL.
https://html.spec.whatwg.org/multipage/forms.html#dom-fs-formaction

> The formAction IDL attribute must reflect the formaction content attribute,
> except that on getting, when the content attribute is missing or its value is
> the empty string, the document's address must be returned instead.

This CL removes empty formaction tests in submit-form-attributes.html.
html/semantics/forms/attributes-common-to-form-controls/formaction*.html cover
them.

BUG=520835

Review URL: https://codereview.chromium.org/1321033003

git-svn-id: svn://svn.chromium.org/blink/trunk@201617 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Removed m_isQuirkValue from CSSValue and updated callers to use
CSSPrimitiveValue::UnitType::QuirkyEms instead.

Review URL: https://codereview.chromium.org/1316153003

git-svn-id: svn://svn.chromium.org/blink/trunk@201616 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201598

BUG=521730
TBR=tkent@chromium.org

Review URL: https://codereview.chromium.org/1329663002 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201615 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/1314773006

git-svn-id: svn://svn.chromium.org/blink/trunk@201614 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=521730
NOTRY=true
TBR=pilgrim

Review URL: https://codereview.chromium.org/1326593003

git-svn-id: svn://svn.chromium.org/blink/trunk@201613 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch makes |VisiblePosition| constructor private by replacing it by
|createVisiblePosition()| as preparation of simplify implemenation of
|VisiblePosition| construction.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1317053004

git-svn-id: svn://svn.chromium.org/blink/trunk@201612 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Because the W3C's web-platform-tests are run using a
different origin (http://web-platform.test versus
http://127.0.0.1), we should use the existing host-
detection code in get-host-info.js.

BUG=462361

Review URL: https://codereview.chromium.org/1314123002

git-svn-id: svn://svn.chromium.org/blink/trunk@201611 bbb929c8-8fbe-4397-9dbb-9b2b20218538

 - WebPermissionStatus* (ownership transferred)
  => WebPermissionStatus
 - WebVector<WebVRDevice>* (ownership not transferred)
  => const WebVector<WebVRDevice>&

1/3: https://codereview.chromium.org/1317243002/
2/3: https://codereview.chromium.org/1309803006/
3/3: https://codereview.chromium.org/1321763002/

BUG=493531

Review URL: https://codereview.chromium.org/1321763002

git-svn-id: svn://svn.chromium.org/blink/trunk@201610 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201592

BUG=452914
TBR=kojii@chromium.org

Review URL: https://codereview.chromium.org/1317743004 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201609 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Improve usability of jsHeapSize readability by formatting as bytes.
Refactor counter checkboxes to reuse CheckboxFilterUI. Delete swatch component.
Change default height of memory counters from 200 to 112px.

BUG=523697

Review URL: https://codereview.chromium.org/1309723003

git-svn-id: svn://svn.chromium.org/blink/trunk@201608 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Remove old blink isolate files. (patchset #1 id:1 of https://codereview.chromium.org/1319753003/ )

Reason for revert:
broke android build

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/37274

Original issue's description:
> Remove old blink isolate files.
> 
> BUG=524758
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201602

TBR=dpranke@chromium.org,maruel@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=524758

Review URL: https://codereview.chromium.org/1309323005

git-svn-id: svn://svn.chromium.org/blink/trunk@201607 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch cleans up the method which was deprecated in part 1, and
whose implementations were removed in part 2.

This is part 4 of a four-part blink-chromium-blink dance.
Part 1: https://codereview.chromium.org/1309393003
Part 2: https://codereview.chromium.org/1324903002
Part 3: https://codereview.chromium.org/1316743002
Part 4: https://codereview.chromium.org/1314453003 (this patch)

BUG=518884

Review URL: https://codereview.chromium.org/1314453003

git-svn-id: svn://svn.chromium.org/blink/trunk@201606 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=501896

Review URL: https://codereview.chromium.org/1311783003

git-svn-id: svn://svn.chromium.org/blink/trunk@201605 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=522762

Review URL: https://codereview.chromium.org/1311013007

git-svn-id: svn://svn.chromium.org/blink/trunk@201603 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=524758

Review URL: https://codereview.chromium.org/1319753003

git-svn-id: svn://svn.chromium.org/blink/trunk@201602 bbb929c8-8fbe-4397-9dbb-9b2b20218538

For the main thread we seem to always run
v8::Isolate::RequestGarbageCollectionForTesting but it's
not the case on the worker thread, which seems to cause leaks
on the context object.

BUG=526424

Review URL: https://codereview.chromium.org/1316233004

git-svn-id: svn://svn.chromium.org/blink/trunk@201601 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Chromium's third_party/sqlite build config arranges for
third_party/sqlite to be part of the include path so that <sqlite3.h>
works in these files.  The system version of sqlite3.h can still be used
with the use_system_sqlite build override.

BUG=526828

Review URL: https://codereview.chromium.org/1317683008

git-svn-id: svn://svn.chromium.org/blink/trunk@201600 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=295792

Review URL: https://codereview.chromium.org/1300573002

git-svn-id: svn://svn.chromium.org/blink/trunk@201599 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We filed specific bugs.
Also, we confirmed form-validation-reportValidity.html just needs rebaseline.

BUG=526930,526898,526920,527262
TBR=kojii@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1305923006

git-svn-id: svn://svn.chromium.org/blink/trunk@201598 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://github.com/whatwg/xhr/issues/19

BUG=395931
R=dominicc@chromium.org

Review URL: https://codereview.chromium.org/1310543002

git-svn-id: svn://svn.chromium.org/blink/trunk@201597 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=527270,524804,527278,527281
NOTRY=true
TBR=pilgrim

Review URL: https://codereview.chromium.org/1302323007

git-svn-id: svn://svn.chromium.org/blink/trunk@201596 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch moves |{left,right}PositionOf()| for |VisiblePosition| to
"VisibleUnits.cpp" form "VisiblePosition.cpp" to make "VisiblePosition.cpp"
to simpler for improving code health and ease of templatizing |VisiblePosition|
class to introduce composed tree version.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1310953005

git-svn-id: svn://svn.chromium.org/blink/trunk@201595 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=521092
NOTRY=true

Review URL: https://codereview.chromium.org/1318043003

git-svn-id: svn://svn.chromium.org/blink/trunk@201594 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=
TBR=thakis@chromium.org

Review URL: https://codereview.chromium.org/1325033002 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201593 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch fixes HarfBuzzFace to round widths and bounds of glyphs
when SkPaint.isSubpixelText() is false.

SimpleFontData::platformWidthForGlyph() and platformBoundsForGlyph()
have this rounding. This difference in HarfBuzzFace caused poor text
positioning only in complex path.

Unlike SimpleFontData that uses round() for glyphBounds, this CL uses
roundOut() to avoid possible glyph rendering outside the visual
overflow rect. The same fix for SimpleFontData is in a separate CL[1].

[1] https://codereview.chromium.org/1326563003/

BUG=452914

Review URL: https://codereview.chromium.org/1316843005

git-svn-id: svn://svn.chromium.org/blink/trunk@201592 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Corresponding will* methods are declared on DOMDebugger agent already.

BUG=439376

Review URL: https://codereview.chromium.org/1327713002

git-svn-id: svn://svn.chromium.org/blink/trunk@201591 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When building the payload for POST data with files, Blink was
normalizing strings. Similar to crbug.com/427183, we're calling
normalizeAndEncode() when encode() is more appropriate, and matches
the behavior in other browsers.

BUG=341019
R=tkent@chromium.org

Review URL: https://codereview.chromium.org/1306073004

git-svn-id: svn://svn.chromium.org/blink/trunk@201590 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch implements paint offset cache as described in:
https://docs.google.com/document/d/1oY8P7a7G4W2LYOvT3VyqUNKOOek6S_e-jD2XjM_7g9U/view

This patch is large but only a few new concepts have been added:
1) A LayoutPoint for paint offset is now passed into all layout drawing
recorders.
2) The display item list temporarily stores the previous paint offsets.
These will be moved onto the LayoutObject themselves once
https://codereview.chromium.org/1315213002 lands.
3) If a new paint offset is detected during paint, the recorded offset is
updated and the layout object is marked as invalid in the display list.
4) Asserts have been added that paint offsets do not change between
phases. DisplayItemList::m_clientsWithPaintOffsetInvalidations checks
for emitting cached display items after the paint offset was invalidated.
DisplayItemList::invalidatePaintOffset checks for existing non-cached
display items added before the paint offset was invalidated.

BUG=508383

Review URL: https://codereview.chromium.org/1315993004

git-svn-id: svn://svn.chromium.org/blink/trunk@201589 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/1324943004

git-svn-id: svn://svn.chromium.org/blink/trunk@201588 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=509482

Review URL: https://codereview.chromium.org/1323913002

git-svn-id: svn://svn.chromium.org/blink/trunk@201587 bbb929c8-8fbe-4397-9dbb-9b2b20218538