- 23 Sep, 2019 40 commits
-
-
Samuel Huang authored
The Courgette Fuzzer found a bug where DisassemblerElf32ARM::ParseRelocationSection() overruns buffer because reloc units are not sorted. This CL fixes the bug by adding a check. The bug does not happen for X86 case, or for Zucchini. Bug: 961540 Change-Id: I5ff49c510e9fd8083f42a34e99140ff2c47201e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818875Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#698927}
-
Daniele Castagna authored
in crrev.com/c/1761708 we changed how we do partial damage on surfaceless output surfaces. Instead of copying undamaged contents from the previous buffer, we started expanding the damage rect and recompositing what changed onto the buffer since the last time we composited to it. This wrongly assumed that the damaged area could be arbitrarily expanded and all the quads for the frame would be there. On some platforms, this was not the case, since SurfaceAggregator would prune quad that didn't intersect with the damage region. This CL disables that optimization on platforms using surfaceless output surfaces so that the new logic can expand the damage rect and there will always be quads covering the expanded area. Bug: 1004621 Test: OOBE on cave stopped flickering Change-Id: Ifbafc294b96d183992483d833533668d9f2e0ea1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818819Reviewed-by:
Yi Xu <yiyix@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#698926}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8ab15bbab0fa..16f6f6e4dd63 git log 8ab15bbab0fa..16f6f6e4dd63 --date=short --no-merges --format='%ad %ae %s' 2019-09-23 seanabraham@chromium.org chromeos_config: disable lakitu builders Created with: gclient setdep -r src/third_party/chromite@16f6f6e4dd63 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I855d77e92613b72fe7c7eff6333b02f47dc93d8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818714Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698925}
-
Yulun Wu authored
Bug: 998055 Change-Id: Ic0421f238a581fd5c9e0c6944cd2fdf46261a641 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817209Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#698924}
-
Brandon Goddard authored
This reverts commit 12915a69. Reason for revert: Hiding the name column prevents the ability to open the sidepane for network requests (headers, timing, etc). This will be confusing to users, as none of the visible columns will provide the ability to see the view they are used to when selecting a network request. Original change's description: > [devtools] Add Url and Path Column to Network Log > > This patch adds url and path as available columns to > the network log view and allows the name to be removed > because it is not needed if the user decides to show > the path or the whole url. > > Bug: chromium:993366 > Change-Id: Ib4600d1631bd436cb3c8b8e79b3709dddc38b166 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809161 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Jan Scheffler <janscheffler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#698891} TBR=yangguo@chromium.org,sigurds@chromium.org,bmeurer@chromium.org,janscheffler@chromium.org Change-Id: I5363b928cd8f21b8b6677e8b2bc38e42e7918140 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:993366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819617Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Brandon Goddard <brgoddar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#698923}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ab52a7a53db6..e7bd1cb4f650 git log ab52a7a53db6..e7bd1cb4f650 --date=short --no-merges --format='%ad %ae %s' 2019-09-23 brianosman@google.com Roll third_party/externals/angle2 6c4ff5ddab07..8be7a4c7f738 (12 commits) Created with: gclient setdep -r src/third_party/skia@e7bd1cb4f650 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@google.com Bug: chromium:None Change-Id: I72ab3e885f13f404d6528da4043b354296249048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818715Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698922}
-
Mikel Astiz authored
The sync datatype doesn't provide any useful features to enterprise users using local sync (aka roaming profiles), so displaying the UI is unnecessary and causes confusion. We avoid such UI by forcefully disabling the sync datatype for local sync users, which is also sufficient to hide the UI. Bug: 1004400 Change-Id: I3c5d93a9b78de3172550d7e63915b878c2d75099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813346 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#698921}
-
Yue Ru Sun authored
Change-Id: Idce2a6b0281607882bfd3ab005accaf2a3d2bfe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813781Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Yue Ru Sun <yrsun@chromium.org> Cr-Commit-Position: refs/heads/master@{#698920}
-
Eric Stevenson authored
Downstream usages have been updated to use proxy native methods. Bug: 929661 Change-Id: I05cb9a3a520ae58006395f3826487f92f14e5e74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818871 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#698919}
-
Jacob DeWitt authored
This makes the values up to date with the webxr-input-profiles registry values as https://github.com/immersive-web/webxr-input-profiles/pull/91 has been completed. Bug: 992631 Change-Id: I98677777d47710a83fbd91ad56bda6017134af9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816731 Auto-Submit: Jacob DeWitt <jacde@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#698918}
-
Mandy Chen authored
This patch adds the functionality to autofix grdp/grd file paths that are out of date. * <part> file entries that reference non-existent grdp files in devtools_ui_strings.grd are removed. * Grdp files with the wrong names are renamed (format should be <folder_name>_strings.grdp) along with the corresponding part file entries in devtools_ui_strings.grd. * If more than one grdp files are under a directory, an error is issued to ask the user to consolidate these grdp files. This patch will eliminate the need to manually fix grdp/grd inconsistensies (e.g. https://crrev.com/c/1637591) after unexpected changes (e.g. audits2 renamed to audits: https://crrev.com/c/1614691). Bug: 941561 Change-Id: Ie413fe070a2f5b4319a12ce07653ec1a79912215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703044Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Mandy Chen <mandy.chen@microsoft.com> Cr-Commit-Position: refs/heads/master@{#698917}
-
Mohamed Amir Yosef authored
After migrating to the new parser, renderer_ids are always used. This CL is a cleanup CL for obsolete code paths and irrelevant tests. Change-Id: Ibb19d9213f1804c4843850b594fd8ef799729570 Bug: 949519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819497Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#698916}
-
Vadym Doroshenko authored
Bug:875768 Change-Id: I37be128e8371ccb9f08654c7c8d0d61b666e5253 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819308 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#698915}
-
Juan Antonio Navarro Perez authored
Helps avoid mixing recent data from results "without patch" (which are shifted to one year in the past), with old data that actually ran a year ago. Also helps making sure that the size of the csv file with the uploaded dataset does not grow without bounds. Bug: 1006723 Change-Id: I9e5f847563e5ab62c937ef7236fd10094fd003eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819501Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#698914}
-
Luke Sorenson authored
Bug: 1005827 Test: Not necessary. Change-Id: Iabd6f7e2d636a6e5be244cb3a1b41a89b2cd23af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814158Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Luke Sorenson <lasoren@chromium.org> Cr-Commit-Position: refs/heads/master@{#698913}
-
Ella Ge authored
Bug: 999552 Change-Id: I30baf1b87c3338583e3bf2c5a41aedfed7dcd549 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817678Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#698912}
-
Mohamed Amir Yosef authored
After recent modification to the FormSaver (namely the introduction of Unblacklist() API), no need to expose the whole list of blacklisted entries from the FormFetcher. PasswordFormManager needs only to know whether there are any blacklisted entries exist or not. Change-Id: I8659016a67ced2d1f9988dbfbfcea97f91d6ec28 Bug: 1004783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813298Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#698911}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b22117bdb5c3..b3c3754a9c0f Created with: gclient setdep -r src-internal@b3c3754a9c0f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I93cf9be897cbf325e59c9c3c89a5d5df079f41e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819348Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698910}
-
Raul Tambre authored
Conversion performed automatically using '2to3 -w -f has_key .'. This is backwards compatible with Python 2. Bug: 941669 Change-Id: I566bdb8b3bc522ffba87e9159f20062a192bf492 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817602 Auto-Submit: Raul Tambre <raul@tambre.ee> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#698909}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f278de18..246cf2b1 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6ecc17483aa390650e87df489791a2fa39f2aecb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819407Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698908}
-
Friedrich Horschig authored
Speculative fix because I couldn't reproduce it. Crashes occurring since M75 show seg faults in the method AutofillKeyboardAccessoryAdapter::AcceptSuggestion. It uses exactly one pointer (controller_) and this pointer is never set to null. If compared with the old AutofillPopupViewAndroid, it shows that the adapter for the accessory view doesn't reset the controller after |ViewDestroyed()|. This methods does this exactly like the AutofillPopupViewAndroid which is not perfect [1] but risk-free to merge to M77. [1] An ideal solution would use unique_ptr instead of raw pointer and have the controller delete the views instead of them self-destructing. Besides the merge, it makes more sense to clean this up when we remove the old popup code entirely. Bug: 1006311 Change-Id: I6766504c1ed7fffd0befb872d1e4a745dfdb45ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819441Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#698907}
-
Vladislav Kuzkokov authored
Bug: 964948 Change-Id: Ib47f8d7fcdd5700322bd227326b3df7740c75b5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816554 Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#698906}
-
Peter Kasting authored
Bug: 82078 Change-Id: I00bb47e46d3d78283a61da88fb34d549d0ff3873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818646Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#698905}
-
Andrei Chulkov authored
Because of the custom view used for the password manager modal dialogs (leak detection, onboarding) the ModalDialogProperties.TITLE property is null and TalkBack doesn't speak the title of the dialog automatically when it appears. This CL implements a one-line fix setting the CONTENT_DESCRIPTION property to be read out when the dialog appears. Bug: 1006773 Change-Id: I0308d716f631c1006b553d72289e380f9e0d653d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819312Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Andrei Chulkov <achulkov@google.com> Cr-Commit-Position: refs/heads/master@{#698904}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c48d43717c32..0df60d76f437 git log c48d43717c32..0df60d76f437 --date=short --no-merges --format='%ad %ae %s' 2019-09-23 khokhlov@google.com [Telemetry] Save shared diagnostics in intermediate results Created with: gclient setdep -r src/third_party/catapult@0df60d76f437 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:981349 Change-Id: I6bd82c5d5f5178864dfc6f19bafae9233352ec19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818723Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698903}
-
ckitagawa authored
Create new component for Paint Previews (Internal Link: go/fdt-design). The reasoning for creating this component is outlined in the README. Adds some basic file IO interfaces for working with Skia data streams. Design Doc [Internal]: go/fdt-design Part of landing: https://chromium-review.googlesource.com/c/chromium/src/+/1786583 Bug: 1005949 Change-Id: I6e09aaa840766806527e5baab2224d2ccfc5945a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814875Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#698902}
-
Mihai Sardarescu authored
This reverts commit cf88a217. Reason for revert: Logs confirm our current suspicion. There is no need to have these logs anymore. Original change's description: > [signin] Add logs to investigate why there is a mismatch in the list of accounts. > > This CL adds the logs necessary to debug on Canary why there is a mismatch > in the list of accounts that leads to the Signin modal dialog being presented > on every start-up. > > Bug: 1006717 > > Change-Id: Ic326d2166ef473a4f9922d8f1ee9221634fdbef2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817884 > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Commit-Queue: Mihai Sardarescu <msarda@chromium.org> > Cr-Commit-Position: refs/heads/master@{#698871} TBR=rohitrao@chromium.org,msarda@chromium.org,justincohen@chromium.org,jlebel@chromium.org Change-Id: Iae7c4e79798d4369f100a4fbd7913a65b7009b9b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1006717 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814824Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#698901}
-
Leonard Grey authored
This was marked as flaky on Linux only but is also flaking on Mac and Windows: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=RestoreOnStartupPolicyTestInstance%2FRestoreOnStartupPolicyTest.RunTest%2F2 TBR=thomasanderson@chromium.org Bug: 701023 Change-Id: I5018441e068aa3ea968290eace5537bf7361d6b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816654Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#698900}
-
Yi Gu authored
v2 ignored pointer-events: none for X-origin iframes which made oopif in a portal hit testable. crrev.com/c/1797092 has addressed this issue. Bug: 1002228 Change-Id: I6128530c9f0e78462f555b91f3785f1c56fec4f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818865 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#698899}
-
Leonard Grey authored
This reverts commit 885f3782. Reason for revert: Failed build with this revert in it: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/14503 Original change's description: > Revert "[Sheriff] Disable many PolicyDeviceDisplayResolution tests." > > This reverts commit 7f37ccd8. > > Reason for revert: I have menually tested the previously failing tests > on linux-chromeos-os builders. Tests no longer fail, enabling them back. > > Original change's description: > > [Sheriff] Disable many PolicyDeviceDisplayResolution tests. > > > > PolicyDeviceDisplayResolution/DeviceDisplayResolutionRecommendedTest.Internal/0 > > PolicyDeviceDisplayResolution/DeviceDisplayResolutionRecommendedTest.Internal/1 > > PolicyDeviceDisplayResolution/DeviceDisplayResolutionRecommendedTest.Internal/2 > > PolicyDeviceDisplayResolution/DeviceDisplayResolutionRecommendedTest.ResizeExternalDisplay/0 > > PolicyDeviceDisplayResolution/DeviceDisplayResolutionRecommendedTest.ResizeExternalDisplay/1 > > PolicyDeviceDisplayResolution/DeviceDisplayResolutionRecommendedTest.ResizeExternalDisplay/2 > > PolicyDeviceDisplayResolution/DeviceDisplayResolutionTest.ConnectExternalDisplay/0 > > PolicyDeviceDisplayResolution/DeviceDisplayResolutionTest.Internal/0 > > PolicyDeviceDisplayResolution/DeviceDisplayResolutionTest.Internal/2 > > PolicyDeviceDisplayResolution/DeviceDisplayResolutionTest.ResizeExternalDisplay/0 > > PolicyDeviceDisplayResolution/DeviceDisplayResolutionTest.ResizeExternalDisplay/1 > > PolicyDeviceDisplayResolution/DeviceDisplayResolutionTest.ResizeExternalDisplay/2 > > PolicyDeviceDisplayResolution/DeviceDisplayResolutionTest.SetAndUnsetPolicy/0 > > PolicyDeviceDisplayResolution/DisplayResolutionBootTest.Reboot/0 > > > > TBR=antrim@chromium.org > > > > Bug: 1000694 > > Change-Id: I58373a317fc917f79ff440ec14c62dc9d84cda6b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800409 > > Reviewed-by: vitaliii <vitaliii@chromium.org> > > Commit-Queue: vitaliii <vitaliii@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#696000} > > TBR=antrim@chromium.org,vitaliii@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1000694 > Change-Id: I179ddcf31fe0ac425ce6f5d8c99d2ed35420d962 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813345 > Reviewed-by: Denis Kuznetsov <antrim@chromium.org> > Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#698854} TBR=antrim@chromium.org,vitaliii@chromium.org,apotapchuk@chromium.org Change-Id: Ifd5b92256da79436abc93e73df02a849919de4f6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1000694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816128Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#698898}
-
Vladislav Kuzkokov authored
Bug: 964948 Change-Id: I5a6f751ebdde9a33fe2a5d61881626da9c9256a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790112Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#698897}
-
Andrew Grieve authored
Change-Id: Ifac41db781e6e0e9d8e131044fe1ec307ed3f3d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801987 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#698896}
-
Xiaocheng Hu authored
This is a second attempt of crrev.com/c/1777025, as the previous attempt led to a performance regression. As CSSLengthArray cannot represent all lengths, and in particular, cannot represent lengths where min/max() are present, this patch augments InterpolableLength with a CSSMathExpressionNode representation, so that all lengths can be interpolated and animated. Bug: 991672, 1002177 Change-Id: Ic8af313872b900eac2587531c56a8eca65d55a5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805718Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#698895}
-
Henrique Ferreiro authored
Convert the implementation and all users of the content::mojom::PowerMonitorTest interface. Bug: 955171 Change-Id: If6fd5af9f155de275ba3ed1a136f4605605faf63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800753 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#698894}
-
Raul Tambre authored
Conversion performed automatically using '2to3 -w -f has_key .'. This is backwards compatible with Python 2. Bug: 941669 Change-Id: I0fa85094d653173d14d8b7a63e3d5120397fd5f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814927 Auto-Submit: Raul Tambre <raul@tambre.ee> Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#698893}
-
https://chromium.googlesource.com/Andrew Grieve authored
Change-Id: Idecb1fe3d962557ee30fac7bec103ca57a45edc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814880 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#698892}
-
Jan Scheffler authored
This patch adds url and path as available columns to the network log view and allows the name to be removed because it is not needed if the user decides to show the path or the whole url. Bug: chromium:993366 Change-Id: Ib4600d1631bd436cb3c8b8e79b3709dddc38b166 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809161Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Jan Scheffler <janscheffler@chromium.org> Cr-Commit-Position: refs/heads/master@{#698891}
-
Tomasz Moniuszko authored
Bug: 1006787 Change-Id: I1882b04323570828ac9dcea7a72dcc2c9843b5fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819256Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Tomasz Moniuszko <tmoniuszko@opera.com> Cr-Commit-Position: refs/heads/master@{#698890}
-
Sigurd Schneider authored
Apparently, we can get raw locations with a `null` content provider. This CL filters them until we can prevent their generation altogether. Bug: chromium:1005789 Change-Id: I02ababe8c3f3e355e9bc48622f15aa7c0d5f18b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819300Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#698889}
-
Andrew Grieve authored
Bug: 1005979 Change-Id: I72bf91be86d4c800050dd5e4ec4b21ef1f0cc241 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815655 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#698888}
-