- 26 Jun, 2019 40 commits
-
-
Lucas Furukawa Gadani authored
Change-Id: I841ad1a15facad1b9a59b9ef75d803b3d132b233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679221Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#672667}
-
Tatiana Buldina authored
Return heap snapshot as a string instead of JSON object. This resolves two issues: * The snapshot sometimes uses characters not allowed by our JSON parser. * Chrome's snapshot reader is sensitive to the ordering of properties in the snapshot. Converting the snapshot into JSON object and then re-serialize into string often results in a file not loadable by the snapshot reader. Bug: chromedriver:2964, chromedriver:1616 Change-Id: Ia721c28ed78a085d567111459c9e50d8bc26f81d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679224Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#672666}
-
Alex Cooper authored
This is the first step to convert the types in the vr_service.mojom to common gfx.mojom geometry types. By adding typemaps from the gfx.mojom geometry types on the blink side, we can have cleaner and consistent code across both sides of the mojom pipe. Bug: 977008 Change-Id: I1eafdc938be9d5dc7e67ecd5c964d07a90bc6d29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1668569Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#672665}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/7bf0ecb40e23..2b2367291125 git log 7bf0ecb40e23..2b2367291125 --date=short --no-merges --format='%ad %ae %s' 2019-06-26 saklein@chromium.org Build API: Add validation decorators. Created with: gclient setdep -r src/third_party/chromite@2b2367291125 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: Ia9196f22f2a8d88cc8d9b23091fec85eb2e13dcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678265Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672664}
-
Xiaocheng Hu authored
Intent to implement and ship: http://bit.ly/2J75JAQ Bug: 825895 Change-Id: I404323bc50dc6ad0362de6c7385edae9a85caefa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679132 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#672663}
-
Yue Li authored
Since we recently turn the flag back to default off and plan to rollout the feature after M77 stable, update the expiry milestone to M78. Bug: None Test: Local Build Change-Id: Ib51fb7b148dfab90a3d1d52000eaf050b8e3b7bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677546Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#672662}
-
Edward Wang authored
Https is quite heavy for periodic connectivity check. Change to http version to reduce the server load after initial https check passsed. Bug: b/135769650 Test: Verified the check change to http one after last check succeed. Change-Id: I73d0c9ffaa6a22d0319d6782ed17ee1152045894 Signed-off-by:
Edward Wang <wangedward@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677263Reviewed-by:
Sergey Volk <servolk@chromium.org> Cr-Commit-Position: refs/heads/master@{#672661}
-
Kurt Horimoto authored
This CL creates a separate file for OverlayPresenter::UIDelegate (renamed to OverlayPresentationContext). This was done because the presentation context will need to support observation so that the presenter can be aware of when it has a coordinator in which to present overlay UI. The class was renamed because it seems like an anti-pattern for a delegate to support observation. This CL also moves OverlayPresenter::Observer to a separate file for consistency. Bug: 941745 Change-Id: I92208a28a84a450d3a00aa08c7dfbf546bb7ff98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671028Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#672660}
-
Johannes Henkel authored
Change-Id: Ic99de0b23ec2b1c4d1c4f6477eb727f2b87c23c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677240 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#672659}
-
Nicolas Norvez authored
"Contributing" doc has moved from dev.chromium.org to Markdown file, update the link. Bug: None Change-Id: I8574dec9fb980b347a024f067c0aa59637e6eaca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678286Reviewed-by:
Xiaochu Liu <xiaochu@chromium.org> Commit-Queue: Xiaochu Liu <xiaochu@chromium.org> Cr-Commit-Position: refs/heads/master@{#672658}
-
Yuke Liao authored
The clang_coverage recipe module was renamed to code_coverage in https://chromium-review.googlesource.com/c/chromium/tools/build/+/1670914. This CL updates the references at chromium/src side accordingly. Bug: 977032 Change-Id: I2059b978cbc75d3f8621e7c14880ee6d40a92f85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669984 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#672657}
-
Dana Fried authored
Followup to: https://chromium-review.googlesource.com/c/chromium/src/+/1674290 UX decided that moving the hit test area was better than moving the hover card. Bug: 972582 Change-Id: Icbe87ad28d1c5c040bd2b3a5ea5635cc12f2b2d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679129Reviewed-by:
Caroline Rising <corising@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#672656}
-
Fabrice de Gans-Riberi authored
* Modify WebComponent and WebContentRunner to take optional extra headers to pass to LoadUrl(). Bug: 977753 Change-Id: I7d23b57629831b775e23ca19a0d0d96886155e6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672528 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#672655}
-
Xiaochu Liu authored
ComponentUpdater.ChromeOS.MountTime is measuring perf of a system service (imageloader) which is used by component updater and DLC project which many other features in Chrome (on Chrome OS) depend on. Set expiration date for 2 years from now. BUG=chromium:975957 TEST=None Change-Id: I970d4bca9e4df9153f49ad465886d625de9bdd87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679219Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Xiaochu Liu <xiaochu@chromium.org> Cr-Commit-Position: refs/heads/master@{#672654}
-
Mostyn Bramley-Moore authored
This sysroot setup makes it easier to make hermetic 32bit linux Clang builds, in a way that also works with Goma. BUG=978360 Change-Id: I6fe5622fcade9c66726ac34f3832c2e670ce4795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675349Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Cr-Commit-Position: refs/heads/master@{#672653}
-
Krishna Govind authored
TBR=meacer@chromium.org Change-Id: I319a54d51a6e9167501a4335f81c6c2548779277 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679131 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#672652}
-
Morten Stenshorne authored
Change-Id: Iae482240741fd096e42df9b842dbfbca146e0070 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677055 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#672651}
-
Julian Kung authored
The function SendCommand was never used in run_py_tests.py and would error whenever called due to passing bad params. Since the function is not used, rather than fixing the function this changelist deletes it R=johnchen@chromium.org Change-Id: I161c965f21f5150976305ca78be7c734178b6fc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678884Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Julian Kung <juliankung@google.com> Cr-Commit-Position: refs/heads/master@{#672650}
-
Avi Drissman authored
On the Mac, translate the z-order enum to the native window level values. On other platforms, treat everything other than "normal" as an undifferentiated "always on top" leaving open the possibility of implementing full window level support on ChromeOS later. There are six basic window levels. The "security sensitive" one is unused in this CL but will be used in a follow-up CL to fix a bug. BUG=865287, 869486 Change-Id: Icf3c39b79490a6490b7ad107a94cf5903d569777 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636606 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#672649}
-
Tina Wang authored
Put send tab to self icon to the left of other page action icons. Bug: 978520 Change-Id: I155ea9213ebe3405fa88f95e3c0b788cccd4c421 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676614 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Cr-Commit-Position: refs/heads/master@{#672648}
-
Matt Wolenetz authored
Adds runtime experimental exposure of JS MediaSource constructor on workers context. This change does not include the actual constructor's implementation (later changes will add functionality behind this new feature flag). To differentiate from pre-existing JS MediaSource construction on the Window (blink main) thread, this change also adds a MediaSourceStable feature for use in the IDL for the constructor. This change also includes recording UMA for each execution context's thread type (window, dedicated worker, shared worker) that constructs a MediaSource instance. Anticipating the eventual need for recording a UseCounter in later changes to differentiate MSE objectUrl construction on main thread versus worker contexts, this change also includes the definition of that UseCounter. See the prototype combined full change (https://chromium-review.googlesource.com/c/chromium/src/+/1405697/) for expected usage of this new UseCounter from url_media_source.cc. Intent-to-implement: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/CNRywDqgKjY/F0nnA4tTAwAJ BUG=878133 Change-Id: I793a9d4f3a609352df773a96e3befd4d1bd66f5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674413 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Auto-Submit: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#672647}
-
Jazz Xu authored
Error handling for touchless controls. Bug: 976287 Change-Id: Ib28cbea20ec046745bdfe8caf240ceffea53c5cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663905Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#672646}
-
Alex Newcomer authored
Make sure the SBV corners are correct. Add a function to reset the state of the view before it is reshown. Bug: 976988 Change-Id: Ia726cc1244ba7a2cd47481a5dd67ed95734737ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677558 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#672645}
-
John Chen authored
This reverts commit af29dafa. Reason for revert: Perf test failures (https://crbug.com/978932) Original change's description: > heap: Enable unified GC scheduling > > This flips the default to enable unified GC scheduling where Oilpan's > numbers are reported to V8 and contribute to scheduling unified heap > GCs. No more Oilpan follow up or stand-alone GCs are scheduled unless > absolutely needed (e.g. worker teardown). > > This change may move around GCs. In the general case, there should be > less overall (Oilpan + V8) GC traffic at the expense of giving more > memory in scenarios where performance is needed. Scenarios that exhibit > memory pressure or can use idleness should preserve their memory > characteristics. > > Bug: 948807 > Change-Id: Iba0ffcf13830c4cfe3f8d5657098ea12bfd1ab04 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675425 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#672409} TBR=haraken@chromium.org,hpayer@chromium.org,mlippautz@chromium.org Change-Id: I6f4d473c05211bbfc6389fa83d78c38f0666f15f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 978932, 948807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679244Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#672644}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/material-motion/motion-transitioning-objc/+log/8f360fc6f016..5bb0d577dd78 git log 8f360fc6f016..5bb0d577dd78 --date=short --no-merges --format='%ad %ae %s' 2019-06-26 featherless@google.com Merge branch 'release-candidate' into stable Created with: gclient setdep -r src/ios/third_party/motion_transitioning_objc/src@5bb0d577dd78 The AutoRoll server is located here: https://autoroll.skia.org/r/motion-transitioning-objc-chromium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:ios-internal-mdc TBR=bling-p10-rolls@google.com Change-Id: I5e6fd938f4e50565c0c5a5c6c7b2d5927425a611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678781Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672643}
-
Kristyn Hamasaki authored
Bug: 972256 Change-Id: Ib4aed2917ab444ca05451bf20647dab9196c1c11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678174Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Kristyn Hamasaki <khamasaki@google.com> Cr-Commit-Position: refs/heads/master@{#672642}
-
Sebastien Marchand authored
This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1665913 A whitelist has been added to allow "bthprops.cpl" to fail to be delay loaded as the failure will be intercepted by bluetooth_init_win.cc -------- Original CL description ------------- This allows getting a crash report when failing to delay load a DLL. Example of the stack trace that this will provide: chrome_child!base::debug::BreakDebugger+0xc [C:\src\chrome\src\base\debug\debugger_win.cc @ 28] chrome_child!logging::LogMessage::~LogMessage+0x3f5 [C:\src\chrome\src\base\logging.cc @ 939] chrome_child!DllLoadHook+0x75 [C:\src\chrome\src\chrome\child\delay_load_failure_hook.cc @ 24] chrome_child!__delayLoadHelper2+0x13f [d:\agent\_work\3\s\src\vctools\delayimp\delayhlp.cpp @ 305] chrome_child!RtlUnwind+0x470 chrome_child!SkFontMgr::legacyMakeTypeface+0x13 [C:\src\chrome\src\third_party\skia\src\core\SkFontMgr.cpp @ 164] chrome_child!blink::DWriteVersionSupportsVariations+0x7f chrome_child!blink::WebFontTypefaceFactory::FontManagerForVariations+0xc Bug: 970893, 976241 Change-Id: I5a4981d81bcec92c4916481b5238a161bdb290f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676996Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#672641}
-
Henrique Grandinetti authored
Bug: 974002 Change-Id: I8658537c9557d686ab46bc2d57129cb74e23806b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679136Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Henrique Grandinetti <hgrandinetti@chromium.org> Cr-Commit-Position: refs/heads/master@{#672640}
-
Peter Kasting authored
To avoid decreasing the supported platforms from today, this expands enable_hidpi from Linux (incl. CrOS)/Mac/Win to also include iOS. Bug: 564112 Change-Id: I246ea0dd25d93a174195489c2e388e3c7a890e8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670357 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#672639}
-
Natalie Chouinard authored
When this rule was previously added, it was narrowed to Preference Fragments, but there are other fragments in preferences (also instantiated via reflection), which extend the support library Fragment class directly. Tracking this change's binary size impact as part of the original regression tracker for this -keep flag. Bug: 978754, 972581 Change-Id: I9c5fe9c9bf621bad8755ecd8f677c840ed5ed32b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678941Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#672638}
-
Tim Song authored
BUG=977535 Change-Id: Ic63e17a9ee2ddca1893b9e9f001870790c02068b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679128Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#672637}
-
John Budorick authored
Tbr: bpastene@chromium.org Bug: 978773 Change-Id: Ida9e14a36eb16ced91a38e48771b4087d0d23556 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678943Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#672636}
-
Martin Kreichgauer authored
Currently, the cr-dialog key press handler only triggers an action button click when an enter keypress event has an 'CR-INPUT' target. This means that if a cr-input is embedded in another custom element inside the cr-dialog, enter key presses to that cr-input will be ignored because the corresponding event gets retargeted to the custom element. Instead, make the keypress handler check that the first element in the composedPath() is an 'INPUT'. Bug: 955859 Change-Id: I486158fadbc32b95c3c3284240bfe4ae690d78d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677597 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#672635}
-
Andrew Grieve authored
Moves initialization into ChromeApplication so that it will always happen in time. This was a regression introduced by a4c20235. TBR=agrieve # trivial refactor to a couple tests Bug: 978328 Change-Id: Iaf7c99b4d0c3e11f0419e076a5430f9a3cd48cda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677729Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#672634}
-
John Chen authored
Change-Id: I04675449d025bd2ad142c6ab1ef1e4d8cb36dc39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679050 Auto-Submit: John Chen <johnchen@chromium.org> Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#672633}
-
Eric Orth authored
Used to trigger config update in SystemDnsConfigChangeNotifier on Android and ChromeOS where the update is triggered external to the network stack. Primarily needed for SystemDnsConfigChangeNotifier, but updated the current soon-to-be-modified code in NetworkChangeNotifierPosix to use the new unified method on DnsConfigService and removed its special DnsConfigService overrides in order to simplify and prepare for the transition to SystemDnsConfigChangeNotifier. Bug: 971411 Change-Id: I944073d4ff86e43aae40d0e1404a2cfbb1bb902a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1668147Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#672632}
-
Yue Zhang authored
Change the structure of tab_grid_card_item so that the close button zooms in with the card in drop-to-merge animations. Bug: 978642 Change-Id: Iba5b0e5c1269420615f20851934ca1f2710ef064 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677259Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@google.com> Cr-Commit-Position: refs/heads/master@{#672631}
-
Stephen McGruer authored
This is a code health CL which makes a number of changes: * Renames AnimationEffect::RepeatedDuration to ActiveDuration to align with the spec. * Adds a few links/descriptions to the AnimationEffect header. * Moves two functions in timing_calculations.h to the end, to properly group all spec-related functions and differentiate them from non-spec related. * Documents said moved functions. No behavior changes should be seen from this CL, its purely renames + comments. Bug: 630915 Change-Id: I8c9618212722d650ea009f54af0fa910214d3452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678719Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#672630}
-
Michael Lippautz authored
Disconnect ResizeObserver from media controls when the controls are hidden. Otherwise, the obervsers are have pending activities (are observed) which makes them roots for the object graph, ultimately keeping elements (including e.g. HTMLVideoElement) and nodes alive. Bug: 969049 Change-Id: I07a4470170f187631db307188f6cbe0052aa7d8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677053 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#672629}
-
Sungguk Lim authored
Use the new JSONReader::Read API that use the new API of base::Value (move semantic) and convert the surrounding code to the new API at the same time. Bug: 646113, 925165 Change-Id: I6d0a9e4d1f2131b756eb55fceb192153541695f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677846Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Sungguk Lim <limasdf@gmail.com> Cr-Commit-Position: refs/heads/master@{#672628}
-