- 22 Sep, 2020 40 commits
-
-
Tommy Li authored
Previous CL added GOC Variations for on-focus: https://chromium-review.googlesource.com/c/chromium/src/+/2422473 This CL adds the exact same variations for on-clobber. It also makes the on-clobber Desktop only, as we never implemented the UI hook for Mobile (either Android or iOS). Bug: 1106096 Change-Id: If5cc05667e86892b8d491777e950e37ef81a3f8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424545 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Auto-Submit: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#809485}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1600775907-52df3750a6dec0d6a74672a50b3faa88175a1e9e.profdata to chrome-linux-master-1600797595-fd8ddba8caaa456739bdf5b1d17d7be117d929dc.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: Ic0799fe621347b2cc8f49f03e6cc407984d71b47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424966Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809484}
-
Jazz Xu authored
Change-Id: I191a218b74d95b898959ba5050557840dbf9aa33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421639Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#809483}
-
Joshua Peraza authored
3e065b11d0ca linux, mac: disable cfi-icall for cross-dso calls 76c6de22e1c2 [fuchsia] Enable ConvertInvalidUTF8ToUTF16 90344b24ed1c fuchsia: suppress -Wconversion warnings a98ee20e578f [crashpad] Prepare crashpad for base::string16 switch 1c77abe90956 fuchsia: Centralize disabling of Wconversion 36d4bb83b3d7 Remove base dependency from no_cfi_icall This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/2422809 with changes to google_chrome_behaviors.cc to fix the compile failure in crbug/1130851. Bug: 1130851 Change-Id: I1f6029b97c4ac643b218db4dd33d3f54ee778370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423048Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Auto-Submit: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#809482}
-
Carlos IL authored
This extends interstitial.decision.repeat_visit and interstitial.ssl. did_user_revoke_decisions2 to match other interstitial histograms. Also extends mixed content autoupgrade histograms since the launch is still ongoing. Change-Id: I5b5ff0c088ab7ebf2636b8b0f6d59f2556e8da90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422477 Commit-Queue: Carlos IL <carlosil@chromium.org> Auto-Submit: Carlos IL <carlosil@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#809481}
-
Wenbin Zhang authored
This reverts commit 0b0e0753. Reason for revert: Android builders failing after this is checked in. Error message is related: error: incompatible types: String cannot be converted to GURL Original change's description: > Migrate NavigationHandle from String URLs to GURL > > Migrates NavigationHandle to use GURL internally and adds getUrlString > for callsites that still need URLs to be a string (to be fixed in > followups). > > Some unit tests needed to be moved to Instrumentation tests, one > requiring a change to CriteriaHelper to allow checking for a condition > after every task. > > QualityEnforcerUnitTest was too difficult to migrate to Instrumentation > tests, so it now uses JUnitTestGURLs to use GURL in junit tests. > > Bug: 783819 > Change-Id: I1283d5d7d1946e666e964f8d24aeaf0352eb8805 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419140 > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809396} TBR=yfriedman@chromium.org,mthiesse@chromium.org Change-Id: Idb17bbf3cba4034c8ce47afc331b77117608ab9b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 783819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425006Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#809480}
-
chrome://newtabEsmael El-Moslimany authored
When the default search engine is changed, chrome://newtab is loaded on the tabs with a NTP loaded. chrome://newtab will redirect to the NTP associated with the new default search engine. Bug: 1129499 Change-Id: I03360bb781c7bf94e2db65f282ee163386dd26cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423169Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#809479}
-
Bence Béky authored
Bug: 1113661 Change-Id: I88015ab4eb033eafb9b2801ad025c7bfc1d70c3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423166 Commit-Queue: Nick Harper <nharper@chromium.org> Auto-Submit: Bence Béky <bnc@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#809478}
-
Philip Rogers authored
This patch adds three UseCounters for measuring dark mode usage: 1. kForcedDarkMode which is set for pages loaded with forced dark mode. 2. kPreferredColorSchemeDark which is set when prefers-color-scheme media queries will match dark. 3. kPreferredColorSchemeDarkSetting which is set when the preferred color scheme dark setting is set (i.e., the system is in dark mode). This can differ from #2 in cases where the system is in dark mode and forced dark mode is enabled, resulting in prefers-color-scheme being "light" in some cases. Bug: 1131028 Change-Id: I85bc9db6ef30ce0dfc4f78c0c51d039bb04a100d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423168Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#809477}
-
Mitsuru Oshima authored
Bug: None Change-Id: I710de4d31154bf05d3574cc527e055006ba08b3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410728 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#809476}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/44623aeccd06..9ff58ddd0adf 2020-09-22 lehoangq@gmail.com Metal: Support array of matrices varying. 2020-09-22 geofflang@google.com Vulkan: Add features to modify sampling parameters 2020-09-22 timvp@google.com Vulkan: Allocate descriptor pools with layouts 2020-09-22 jmadill@chromium.org Use c++ thread_local for current thread. 2020-09-22 geofflang@google.com Initialize InternalFormat::blendSupport. 2020-09-22 jmadill@chromium.org Pass #pragma optimize setting down to compilation. 2020-09-22 jmadill@chromium.org Give restricted gold tests executable bit. 2020-09-22 jmadill@chromium.org Test Runner: Improve sharding validation. 2020-09-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from fe878dedd5ad to 6aadd31a5f98 (1 revision) 2020-09-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from a148cdd49041 to 8fdc21e4078d (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Test: Test: CQTest: Test: DrawCallPerfBenchmark.Run/vulkan_nullTest: Test: EGLContextASANTest.DestroyContextInUse/ES3_Vulkan Change-Id: Ie96095d144fdf6a8c0ae33c5ad7adfadd385ecdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424571Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a9be76de8b43..187b04b35777 2020-09-22 robertphillips@google.com Increase testing of GrThreadSafeUniquelyKeyedProxyViewCache wrt GrResourceCache purging 2020-09-22 michaelludwig@google.com GrClipStack::contains, add fast path for axis-aligned paths If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1108408 Tbr: csmartdalton@google.com Change-Id: Ic5e5b7e2fc8d3d724090936345c99eeb615e3118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424575Reviewed-by:
-
Donn Denman authored
Adds a default-disabled Feature to override the policy that Contextual Search applies to plain HTTP pages. This allows disabling the recent change that treats HTTP just like HTTPS landed in https://crrev.com/c/2393526. Enabling the Feature will allow us to go back to the legacy policy, and allow us to measure the impact of the policy change accurately. BUG=1124397,1129969 Change-Id: If9ceab183053a573b45a3db6051b55c625c21755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422264 Commit-Queue: Donn Denman <donnd@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#809473}
-
Isuru Pathirana authored
This CL updates the VideoCaptureDeviceFactoryWin/VideoCaptureDeviceMFWin implementations to use D3D11 with the MF device source and capture engine. The VideoCaptureDeviceFactoryWin creates and manages an IMFDXGIDeviceManager and associated D3D11 device instance. It provides the IMFDXGIDeviceManager to the MF device source and also plumbs it to the VideoCaptureDeviceMFWin implementation. The VideoCaptureDeviceMFWin implementation subsequently provides the IMFDXGIDeviceManager to the MF capture engine on initialization. Providing a MF DXGI device manager to the MF device source and capture engine is required for zero-copy capture (it allows the Windows frame server service and MF capture engine to keep captured video frames in GPU memory and expose MF samples backed by D3D11 textures). Bug: 1120900 Change-Id: Ic5367d03f337daab2220f8d87d1bfe51f6ca8b72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370092Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Markus Handell <handellm@google.com> Reviewed-by:
Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by:
Ilya Nikolaevskiy <ilnik@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Isuru Pathirana <Isuru.Pathirana@microsoft.com> Cr-Commit-Position: refs/heads/master@{#809472}
-
Piotr Bialecki authored
CL followup - make XRDepthData into an union so that it is possible to express that the data sent over mojom boundary is either still valid, or that new data has arrived. For discussion, see: https://crrev.com/c/2391619/comment/177fee99_a1338219/ Change-Id: I240357a32dc7fadcae379c3b5f1ca29bdeffcb6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417570Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#809471}
-
Mason Freed authored
This seems like a leftover - likely there used to be more after the if(). Change-Id: I4671f52e73de2e5e573e267de6d5444a03caf2f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424523 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Yu Han <yuzhehan@chromium.org> Reviewed-by:
Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#809470}
-
Alexandre Courbot authored
Quick and easy fixes reported by clang-tidy. BUG=None TEST=video.DecodeAccel.h264 passes on Kukui. Change-Id: I8345f2eb44fc3c2b4a29772d9e2fcdf1a2a0c032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421996 Commit-Queue: Fritz Koenig <frkoenig@chromium.org> Reviewed-by:
Fritz Koenig <frkoenig@chromium.org> Cr-Commit-Position: refs/heads/master@{#809469}
-
Olivier Yiptong authored
This change consolidates all QueueShareMemoryRegionWhenReady() overrides in the base class implementation, because, it turns out, it's the same code on all platforms. Bug: 1043306 Change-Id: If26b5e9b5e2361e4e66b21bcfdd2e93484c1a15b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421637 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Auto-Submit: Olivier Yiptong <oyiptong@chromium.org> Cr-Commit-Position: refs/heads/master@{#809468}
-
Gang Wu authored
This reverts commit cb2f5900. Reason for revert: https://ci.chromium.org/p/chromium/builders/ci/Lollipop%20Phone%20Tester/27059 Original change's description: > [Instant Start] Avoid pre-native GURL usage > > Remove native dependency of > ReturnToChromeExperimentsUtil.shouldShowStartSurfaceAsTheHomePage() > and PseudoTab.readAllPseudoTabsFromStateFile() so that they can be > called without leading to native initialization. > > Benchmarking results using http://crrev.com/c/2373287: > > 100 samples on Nexus 5X > Median Diff with control p-value > FirstDrawCompletedTime 414.0ms -29.0ms (-7.00%) 0.000000 > SingleTabTitleAvailableTime 287.0ms -31.5ms (-10.98%) 0.000000 > FeedStreamCreatedTime 836.5ms -39.5ms (-4.72%) 0.000030 > FeedContentFirstLoadedTime 1898.5ms -0.5ms (-0.03%) 0.534189 > FeedsLoadingPlaceholderShown 234.0ms -2.0ms (-0.85%) 0.629761 > > 100 samples on Pixel 2 XL > Median Diff with control p-value > FirstDrawCompletedTime 176.0ms -18.0ms (-10.23%) 0.000000 > SingleTabTitleAvailableTime 131.0ms -14.0ms (-10.69%) 0.000000 > FeedStreamCreatedTime 424.0ms -31.0ms (-7.31%) 0.000180 > FeedContentFirstLoadedTime 1137.0ms -18.5ms (-1.63%) 0.075061 > FeedsLoadingPlaceholderShown 107.0ms -1.0ms (-0.93%) 0.718766 > > 100 samples on Pixel 3 XL > Median Diff with control p-value > FirstDrawCompletedTime 155.0ms -13.5ms (-8.71%) 0.000000 > SingleTabTitleAvailableTime 117.0ms -13.0ms (-11.11%) 0.000000 > FeedStreamCreatedTime 356.0ms -35.5ms (-9.97%) 0.000001 > FeedsLoadingPlaceholderShown 94.5ms -2.0ms (-2.12%) 0.007312 > FeedContentFirstLoadedTime 924.0ms -6.5ms (-0.70%) 0.034100 > > Bug: 1041865 > Change-Id: I640aaeb6f2dae64b9152fd94d0cd354a487f5bf5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372900 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Reviewed-by: Xi Han <hanxi@chromium.org> > Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809226} TBR=mthiesse@chromium.org,hanxi@chromium.org,agrieve@chromium.org,wychen@chromium.org Change-Id: I7d864239a477c7875bc79f1e39be54d18a72c9ff No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1041865,1131139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424983Reviewed-by:
Gang Wu <gangwu@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#809467}
-
Sorin Jianu authored
This is a Windows follow up for the change: Updater: Do not updatecheck in ControlService wake during --install https://chromium-review.googlesource.com/c/chromium/src/+/2414559 There is some amount of code duplication between implementation of various RPC functions. This issue must be addressed at some point, if more RPC functions are added. Bug: 1128397 Change-Id: I23e0875bf76e5b878423105fff805eb91061cb64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424648 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#809466}
-
Nate Fischer authored
No change to logic. This disables flaky tests in StartSurfaceLayoutTest. Bug: 1130830 Test: out/Default/bin/run_chrome_public_test_apk -f StartSurfaceLayoutTest.* Change-Id: Iaa2a802b0cc1cbe29c316f6f2a3d2409c7d72756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422688 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#809465}
-
Stephen McGruer authored
Passing an async function to async_test will soon be disallowed in WPT, as any asserts thrown will be turned into unhandled promise rejections and the test will timeout. If a test needs async functions it should use promise_test instead. (The naming conflict is a sad historical legacy; WPT had async_test long before EcmaScript spec'd promises!) Bug: https://github.com/web-platform-tests/wpt/issues/21435 Change-Id: I0a31872525844a1540aea548e329929e8097663e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414923Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#809464}
-
Yue Zhang authored
Bug: 1130814 Change-Id: If8d93fb7c134637f399735637ff031abbe31ebc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411671Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
-
Azeem Arshad authored
This CL adds //third_party/barhopper to .gitignore. This repo is imported from src-internal and is used for implementing Chrome's shape-detection API's in ChromeOS. DEPS entry previously added at https://crrev.com/c/2416746. Bug: 1093185 Change-Id: I714456bfa8b484be58381c4cb34fe6c1a5e6d943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422821Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#809462}
-
Taylor Bergquist authored
Two closely related bugs fixed here: - When the tabstrip is not stretched to fill all available space (see https://crrev.com/c/2300993) and the window is dragged wider, the tabstrip stays small as if the window had not been widened. This was happening because the tabstrip was ignoring all Layout() calls unless its width changed. Now, it also needs to relayout if the available width has changed. The fix was to track the available width at the last layout time in parallel with the tabstrip's own width, and ignore the layout only if both are unchanged. - When the tabstrip is being resized wider, the trailingmost tab may become invisible until the next call to Layout(). This was happening because the tabstrip was being sized based on stale layout information, but the tabs themselves were being laid out based on current layout information, so the total width of the tabs didn't line up with the width of the tabstrip. The tab that didn't fit in the tabstrip was then hidden. The tabstrip calculated its preferred size based on the current location of the tabs in order to correctly handle the case where the tabstrip was being animated wider, e.g. when opening a new tab. The fix was to calculate the tabstrip's preferred size in a more conventional way, based on the unconstrained widths of the tabs, except when animation was ongoing. Bug: 1116741 Change-Id: I2006aef4a57389b2c75d21db777d6675b6479048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419633 Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#809461}
-
Alison Maher authored
When we were adding new proxy fragments directly after a spanner, we were computing the wrong offset for these new fragmentainers. This change fixes this by looking at the offset of the spanner when determining the offset of proxy fragments in this case. Bug: 1079031 Change-Id: I34a6358f9bc1b1d630d72bb268f3ae79edcdff00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422424 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#809460}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/aeda49ba5046..6db3a24c19e7 2020-09-22 bryan.bernhart@intel.com Revert "Disable debug layer logger" 2020-09-22 cwallez@chromium.org Simplify the BindGroupLayout validation code. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1130483 Tbr: cwallez@google.com Change-Id: I160391ec7da675af7e2a265f15c8caaacb9b9325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424565Reviewed-by:
-
Jihwan Marc Kim authored
Currently the BluetoothChooser has C++ enums for event type. And the BluetoothChooserDialog java code has event type too. It would be better to define these enums in one place in C++ And the Java code can share it without defining them again. Bug: 994392 Change-Id: I12c8ba92219b4aa3290da6a746467d40e39de1f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387901 Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#809458}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I4d7ee548c4ed9f8203509d15fd10e07d4aac72df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424644Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#809457}
-
Alexandre Courbot authored
Quick and easy fixes reported by clang-tidy. BUG=None TEST=video.DecodeAccel.h264 passes on Kukui. Change-Id: Id4f54a7c29cbf17ae10e2f4e289e95edf81d5a4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421995 Commit-Queue: Fritz Koenig <frkoenig@chromium.org> Reviewed-by:
-
Boris Sazonov authored
If MobileIdentityConsistency flag is enabled - replaces "Sync and Google services" link in Privacy settings with: * One "Google services" link if sync is off; * Two separate "Sync" and "Google services" links otherwise. Bug: 1130623 Change-Id: I0bd8db188350a5ca3ac8c8c0276eba0a3f9bc8f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421461 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#809455}
-
Mohamed Amir Yosef authored
This reverts commit 670197a4. Reason for revert: https://ci.chromium.org/p/chrome/builders/ci/linux-autofill-captured-sites-rel/2954 Original change's description: > [Autofill] Parse the new proto in FormStructure > > Before this patch: > The new protos were converted to the old protos before being > parse by the FormStructure. > > After this patch: > The new protos are parsed directly. > > Bug: 1114655 > Change-Id: Ieb7d71c573e3010067aba250ab161be7946d203e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404584 > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > Reviewed-by: Dominic Battré <battre@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809279} TBR=battre@chromium.org,mamir@chromium.org Change-Id: Iadc92bd3b29f9e2ddca7051e65cb8548c1e0fd80 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1114655 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424272Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#809454}
-
Xiaodan Zhu authored
This CL Adds two unit tests of ReverseGestureHandlerTest: - OverviewReverseGestures to test the overview reverse gestures. - SwitchDesksReverseGestures to test the desk switching reverse gestures. Bug: 1107183 Change-Id: I2ea9304d637217330ecd0c16ab79a296eb8fedaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419930 Commit-Queue: Xiaodan Zhu <zxdan@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#809453}
-
Livvie Lin authored
Change-Id: I4c7baafca5fd55365f456e3357421dbdd9f040ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422728 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Ali Juma authored
This histogram is still being used to ensure that new features (e.g., Safe Browsing) do not regress page load time. Bug: 1052999 Change-Id: Ib7951a308443a56f0d7e383d7ba3d512ff9e96cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423906Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#809451}
-
Markus Handell authored
When forwarding a frame to Video Encode Accelerator, RTCVideoEncoder would almost always create a frame copy unless the incoming media::VideoFrame was backed by STORAGE_SHMEM. The copy would be backed by STORAGE_SHMEM, which results in the video decode accelerator wrapping the VideoFrame's memory in a CVPixelBufferRef. Changes: 1) Break out code in media::VideoFrame::WrapIOSurface() that creates an IOSurface from a GMB handle. 2) Code is added to WrapVideoFrameInCVPixelBuffer to create a CVPixelBufferRef via GpuMemoryBuffer::CloneHandle(). 3) RTCVideoEncoder is changed to pass on GMB-backed video frames. Bug: 1127791, 1125879 Change-Id: I59dd1eae59ae4dffb591830152f44e470fb3cce5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410244Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Markus Handell <handellm@google.com> Cr-Commit-Position: refs/heads/master@{#809450}
-
Hui Yingst authored
OpenPDFParamsParser currently maintains an array of requests and assumes they will get replied in the same order. By changing the return type of getNamedDestinationCallback() to a promise, this CL enables getViewportFromUrlParams() to handle the data returned by the plugin directly, without storing all the requests inside OpenPDFParamsParser. This CL also removes the usage of onNamedDestinationReceived() from browser tests. Bug: 55776,535978,748852 Change-Id: If6e8285a363d2efee169457856ca465cb498805a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391102 Commit-Queue: Hui Yingst <nigi@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#809449}
-
Nelson Billing authored
- .dwp files produced by clank build will now be output to lib.unstripped folder instead of the root out folder. This is to ensure they are in the expected place for Breakpad symbol generation and symbol archiving. Bug: 1112935 Change-Id: Id5cfb8a0188e3a6fa30fb56ed98bdb4e7da2af03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406595 Commit-Queue: Nelson Billing <nbilling@google.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#809448}
-
Jose Dapena Paz authored
Fixes this compilation error: ../../components/autofill/core/browser/data_model/autofill_offer_data.cc:56:8: error: ‘sort’ is not a member of ‘std’; did you mean ‘sqrt’? Bug: 957519 Change-Id: Iaef429cfca5e55af8b819457f9b9729ab4f669f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423586 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#809447}
-
Stephen McGruer authored
Bug: None Change-Id: I9a0817a90270266a538062aaf4e322a86fa3ed6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422146Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#809446}
-
