GitLab

When opting in via GYP_MSVS_USE_SYSTEM_TOOLCHAIN=0, set
environment variables that tell gyp how to find the automatic
toolchain in third_party/win_toolchain.

R=maruel@chromium.org
BUG=323300

Review URL: https://codereview.chromium.org/100613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238426 0039d316-1c4b-4281-b951-d872f2087c98

This sets up (most of) the infrastructure that'll be needed to set up a
PlatformChannel between parent and child processes.

R=darin@chromium.org, darin

Review URL: https://codereview.chromium.org/99473007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238425 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert: Bug 323749 still unresolved

TBR=
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/101543004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238424 0039d316-1c4b-4281-b951-d872f2087c98

The file was moved in r191811.

BUG=none
TEST=none
R=isherman@chromium.org
TBR=achuith@chromium.org, joi@chromium.org

Review URL: https://codereview.chromium.org/100453005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238423 0039d316-1c4b-4281-b951-d872f2087c98

Stores xsrf token in AutocompleteMatch search_terms_args for later use
in case the user triggers deletion of a suggestion.

BUG=312477

Review URL: https://codereview.chromium.org/54203008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238422 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238421 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=163008:163087&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/101963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238420 0039d316-1c4b-4281-b951-d872f2087c98

The tests uses media served by cns.chrome:9000/ server under cable and wifi network conditions. 

BUG=311713
TEST=run_benchmark media.media_cns_cases
NOTRY=true

Review URL: https://codereview.chromium.org/91623004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238419 0039d316-1c4b-4281-b951-d872f2087c98

It's deprecated in r233176 and the option is the current default.

BUG=231166

Review URL: https://codereview.chromium.org/101353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238417 0039d316-1c4b-4281-b951-d872f2087c98

BUG=315108
TEST=manual tests on lumpy and pixel

Review URL: https://codereview.chromium.org/98583004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238416 0039d316-1c4b-4281-b951-d872f2087c98

WebNotification::isHTML() has been returning false since late July when
we removed the Web Exposed entry point, so all of this is dead code. The
removal shipped in Chrome 30, so it's unlikely to return.

BUG=

Review URL: https://codereview.chromium.org/95223003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238415 0039d316-1c4b-4281-b951-d872f2087c98

BUG=n/a
TEST=should pass all existing tests

Review URL: https://codereview.chromium.org/80973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238414 0039d316-1c4b-4281-b951-d872f2087c98

TBR=senorblanco@chromium.org
BUG=110783
TEST=waterfall

Review URL: https://codereview.chromium.org/102263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238413 0039d316-1c4b-4281-b951-d872f2087c98

store, nacl, multidevice, devtools

patch from issue 100723002

Eli, I've added you as a reviewer. This includes very simple starter file for native client so that we can push content migration. I need a native client owner to approve this change.

TBR=eliben@chromium.org

Review URL: https://codereview.chromium.org/100783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238411 0039d316-1c4b-4281-b951-d872f2087c98

This CL whitelists two more apps for use in public sessions, Google Keep
demo and Google+ Photos demo. Both will be used in retail mode.

The CL also updates the descriptions of existing whitelisted apps to
clarify which ones are demo versions of actual apps.

BUG=317909
TEST=None

Review URL: https://codereview.chromium.org/88293003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238410 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/57913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238409 0039d316-1c4b-4281-b951-d872f2087c98

This has the minimal support working. You can create layerless
windows add/remove them from a hierarchy, add children with layers and
everything is kept in sync (including bounds).

Painting has not been wired up yet.

The interesting bit of this change is that Layer and Window bounds are
no longer in sync. This is necessitated by Layer's having to be
parented to Layers. To avoid changing bounds() to dynamically figure
out the real bounds I made Window cache the bounds.

BUG=none
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/82283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238408 0039d316-1c4b-4281-b951-d872f2087c98

This will make sheriffing easier and print the link to the bug
in case there are no online devices.

BUG=324744
TBR=navabi@chromium.org

Review URL: https://codereview.chromium.org/98693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238407 0039d316-1c4b-4281-b951-d872f2087c98

This is a re-land of https://codereview.chromium.org/92153002/.

BUG=271392

Review URL: https://codereview.chromium.org/101163003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238406 0039d316-1c4b-4281-b951-d872f2087c98

The code in this directory was moved from chrome/renderer/pepper so
the OWNERS over there are the appropriate folks to review the changes
in the new nacl/renderer directory.

This is part of an effort to componentize NaCl code.

BUG=244791

Review URL: https://codereview.chromium.org/99673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238404 0039d316-1c4b-4281-b951-d872f2087c98

There is no functional change in this patch. This change only does
renaming.

Extensions API namespaces:
webrtc.castSendTransport -> cast.streaming.rtpStream
webrtc.castUdpTransport -> cast.streaming.udpTransport

Class renaming:
WebRtcNativeHandler -> CastStreamingNativeHandler
CastSendTransport -> CastRtpStream

Tests and related files are also renamed to get rid of the webrtc
label.

BUG=301920

Review URL: https://codereview.chromium.org/90083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238403 0039d316-1c4b-4281-b951-d872f2087c98

Crashes on android

BUG=325216

> Infobar system refactor.
> 
> This changes the ownership model of infobars so that InfoBars are long-lived and
> own their InfoBarDelegates directly.  The InfoBarService pseudo-owns the
> InfoBars (instead of deleting them directly, it tells them when they're unowned
> and expects them to delete themselves).
> 
> This fixes leaks when infobars are closed while not visible (e.g. in a
> background tab) and in general makes the system clearer and easier to reason
> about.
> 
> BUG=62154
> TEST=none
> R=erg@chromium.org, sail@chromium.org, sky@chromium.org
> 
> Review URL: https://codereview.chromium.org/22694006

TBR=pkasting@chromium.org

Review URL: https://codereview.chromium.org/102163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238402 0039d316-1c4b-4281-b951-d872f2087c98

BUG=324260

Review URL: https://codereview.chromium.org/98913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238401 0039d316-1c4b-4281-b951-d872f2087c98

This CL refactors the Manage Passwords Bubble Code which previously depended on TabSpecificContentSettings to directly interact with ManagePasswordsController.

BUG=261628

Review URL: https://codereview.chromium.org/87853004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238400 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://codereview.chromium.org/98833003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238399 0039d316-1c4b-4281-b951-d872f2087c98

This patch reworks the SSL session caching scheme for OpenSSL
client sockets, as an attempt to get rid of the mysterious crashes
described at http://crbug.com/298606

- Move the internal SSLSessionCache class to its own source file,
  while renaming it as SSLSessionCacheOpenSSL.

- Change the session caching logic to:

  - Completely disable OpenSSL's builtin cache.
  - Implement Session ID generation (and uniqueness check).
  - Implement eviction and expiration detection.

- Add a unit test for SSLSessionCacheOpenSSL.

- Modify SSLClientSocketOpenSSL implementation to use the new cache.

BUG=298606
R=rsleevi@chromium.org,agl@chromium.org,wtc@chromium.org

Review URL: https://codereview.chromium.org/89623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238398 0039d316-1c4b-4281-b951-d872f2087c98

TBR=tonyg@chromium.org, piman@chromium.org
NOTRY=true
BUG=323813

Review URL: https://codereview.chromium.org/101963003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238397 0039d316-1c4b-4281-b951-d872f2087c98

Failed to comile on Linux ChromiumOS: http://goo.gl/vNSg7r

> Add some DVLOG's in MetadataDatabase::Update* methods
> 
> BUG=none
> TEST=manual
> 
> Review URL: https://codereview.chromium.org/101743002

TBR=kinuko@chromium.org

Review URL: https://codereview.chromium.org/102063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238396 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=manual

Review URL: https://codereview.chromium.org/101743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238395 0039d316-1c4b-4281-b951-d872f2087c98

BUG=313751
R=glider@chromium.org
TBR=cpu@chromium.org

Review URL: https://codereview.chromium.org/96083003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238394 0039d316-1c4b-4281-b951-d872f2087c98

DriveService seems to return HTTP_CONFLICT when precondition error
is returned from Drive. (At least for Upload)

BUG=none
TEST=manual

Review URL: https://codereview.chromium.org/101223003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238393 0039d316-1c4b-4281-b951-d872f2087c98

This should move the implementation of StdStringCanonOutput from the
header to the source file, that should please the chromium-style clang
plugin.

BUG=287029
TEST=url_unittests
R=thakis@chromium.org,abarth@chromium.org
TBR=abarth

Review URL: https://codereview.chromium.org/84673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238392 0039d316-1c4b-4281-b951-d872f2087c98

Clean up the huge switch of accelerators as well:
* Move a bunch of code into Handle helpers.
* Alphabetize the anon namespace helpers.
* Clean up the OS_CHROMEOS groupings a bit.

BUG=321695
R=jamescook@chromium.org

Review URL: https://codereview.chromium.org/78763003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238391 0039d316-1c4b-4281-b951-d872f2087c98

It is incorrect to wrap close in HANDLE_EINTR on Linux. Correctness is
generally undefined on Mac, but as of r223369, it is incorrect in Chrome on
Mac.

To avoid new offenders, a PRESUBMIT check ensures that HANDLE_EINTR is not
used with close, and that IGNORE_EINTR is only used with close. Unnecessary
#includes of eintr_wrapper.h are also removed.

base/posix/einter_wrapper.h, PRESUBMIT.py, and ppapi/tests/test_broker.cc
contain non-mechanical changes. Variable naming within the latter is updated
per r178174. Missing #includes for <errno.h> in
content/zygote/zygote_main_linux.cc and tools/android/common/daemon.cc were
manually added. Mechanical changes were generated by running:

sed -E -i '' \
    -e 's/((=|if|return|CHECK|EXPECT|ASSERT).*)HANDLE(_EINTR\(.*close)/\1IGNORE\3/' \
    -e 's/(ignore_result|void ?)\(HANDLE_EINTR\((.*close\(.*)\)\)/\2/' \
    -e 's/(\(void\) ?)?HANDLE_EINTR\((.*close\(.*)\)/\2/' \
    $(git grep -El 'HANDLE_EINTR.*close')

sed -E -i '' -e '/#include.*eintr_wrapper\.h"/d' \
    $(grep -EL '(HANDLE|IGNORE)_EINTR' \
        $(git grep -El '#include.*eintr_wrapper\.h"'))

BUG=269623
R=agl@chromium.org, jln@chromium.org
TBR=OWNERS

Review URL: https://codereview.chromium.org/100253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238390 0039d316-1c4b-4281-b951-d872f2087c98

Core code in the Autofill component now gets the AutofillWebDataService from
the embedder. This CL eliminates the declaration of the static
AutofillWebDataService::FromBrowserContext() from the Autofill component's core
code, instead having the concept of getting an AutofillWebDataService from a
BrowserContext/Profile be entirely an embedder-level concept.

BUG=303048

Review URL: https://codereview.chromium.org/72613006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238389 0039d316-1c4b-4281-b951-d872f2087c98

UpdateResource can do the same thing.

BUG=None
TEST=build

Review URL: https://codereview.chromium.org/100903005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238387 0039d316-1c4b-4281-b951-d872f2087c98

BUG=316397

Review URL: https://codereview.chromium.org/99393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238386 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238385 0039d316-1c4b-4281-b951-d872f2087c98

R=rmistry@google.com

Review URL: https://codereview.chromium.org/100473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238384 0039d316-1c4b-4281-b951-d872f2087c98

BUG=298036

Review URL: https://codereview.chromium.org/99853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238383 0039d316-1c4b-4281-b951-d872f2087c98