GitLab

R=darin@chromium.org

Review URL: https://codereview.chromium.org/218883003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260492 0039d316-1c4b-4281-b951-d872f2087c98

In this CL, I move the status variables of SharedWorker from SharedWorkerInstance to SharedWorkerHost.

The main purpose of this change is to make it possible to pass SharedWorkerInstance to SharedWorkerDevToolsManager and store it in WorkerInfo in http://crrev.com/196503005.

BUG=327256

Review URL: https://codereview.chromium.org/214343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260489 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260488 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=170424:170424&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/218823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260487 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260485 0039d316-1c4b-4281-b951-d872f2087c98

(This will make it much easier to improve the handle table, e.g., by caching
handle look-ups.)

R=darin@chromium.org

Review URL: https://codereview.chromium.org/216893005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260482 0039d316-1c4b-4281-b951-d872f2087c98

Use EXPECT_GT instead of EXPECT_TRUE. Made URLs clickable.

Review URL: https://codereview.chromium.org/216573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260481 0039d316-1c4b-4281-b951-d872f2087c98

This breaks a dependency from //apps onto //chrome, getting us closer to
an app_shell build that does not include chrome.

* Introduce apps/browser/api and apps/common/api to mirror extensions.
* Introduce an apps_api build target.
* Hook up schema and function registration in chrome and app_shell.

* Move app_runtime_api.h/cc into //apps and switch to apps namespace.
* Eliminate AppEventRouter dependencies on Chrome:
** Use ExtensionsBrowserClient to determine if we're in kiosk mode.
** Introduce apps::file_handler_util for GrantedFileEntry (anticipating
   more code from app_file_handler_util to move there in the future).

BUG=357818
TEST=browser_tests *PlatformApp*

Review URL: https://codereview.chromium.org/217533006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260480 0039d316-1c4b-4281-b951-d872f2087c98

BUG=347709

Review URL: https://codereview.chromium.org/211333005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260479 0039d316-1c4b-4281-b951-d872f2087c98

* Introduce a ProcessManagerObserver
* Make the Chrome extension RuntimeAPI implementation use it to send onStartup
  events.

BUG=354552
TEST=browser_tests *Extension*

Review URL: https://codereview.chromium.org/212603020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260478 0039d316-1c4b-4281-b951-d872f2087c98

Refactor only, no behavioral change.

This lands server change 63167890 by hkhalil.
https://codereview.chromium.org/202383002/


Syntactic-only changes to use protocol_version() over spdy_version_ in SpdyFramer.

Also use the lowest possible enumeration value when doing comparisons,
which makes deprecating older versions easier.

This lands server change 63165647 by hkhalil.
https://codereview.chromium.org/202113002/


Add some break statements in spdy_protocol for clarity.

This lands server change 63158241 by hkhalil.
https://codereview.chromium.org/198213007/


Minor logging change for catching development errors during testing.

This lands server change 63102059 by hkhalil.
https://codereview.chromium.org/201943003/


Introduce new SpdyConstants class

Used for translating between code constants and on-the-wire
representations (which differ from version to version). Currently
only handles SpdyFrameType constants.

This lands server change 62928184 by hkhalil.
https://codereview.chromium.org/202073003/


Fix SpdyFramerTest.ProcessDataFrameWithPadding so it no longer tells SpdyFramer to read past the end of a buffer.

This lands server change 62728542 by elving.
https://codereview.chromium.org/197863004/


Added OverwriteFlags method to SpdyFrameBuilder.

If we find the after-compression payload of a HEADERS or PUSH_PROMISE is too
long, we can go back and turn off the END_HEADERS or END_PUSH_PROMISE flag.

Will be used in a follow-up CL to automatically serialize header blocks across
CONTINUATION frames as needed.

This lands server change 62682641 by mlavan.
https://codereview.chromium.org/202063002/


Update SPDY4 length field to exclude frame prefix length.

Does not enforce the new 16KB max frame size.

This lands server change 62559133 by mlavan.
https://codereview.chromium.org/202033002/


Implement padding for SPDY4/HTTP2 DATA frames.

Padding is correctly interpreted, but not emitted.

This lands server change 62555297 by raullenchai.
https://codereview.chromium.org/199843005/

Review URL: https://codereview.chromium.org/202403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260477 0039d316-1c4b-4281-b951-d872f2087c98

BUG=339270
TBR=brettw@chromium.org,shess@chromium.org

Review URL: https://codereview.chromium.org/213433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260476 0039d316-1c4b-4281-b951-d872f2087c98

When a test or measurement was not supported on a platform, we used to print
a warning and call sys.exit(0). This caused problems with unittests, because
it was considered a failure (for page measurements it was not a failure).

This patch introduces the page_test.TestNotSupportedOnPlatformFailure
exception. Tests and measurements throw this exception if they can't run on
a platform. PageTestRunner and unit tests catch these exceptions and
print a warning, but they don't consider it an error.

R=tonyg@chromium.org, dtu@chromium.org, vmpstr@chromium.org
BUG=

Review URL: https://codereview.chromium.org/100443007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260475 0039d316-1c4b-4281-b951-d872f2087c98

elements when autofilled.

This more closely matches the spec behavior[1]:

"""
When the user agent is to change an input element's value on behalf of the user
(e.g. as part of a form prefilling feature), the user agent must queue a task to
first update the value accordingly, then fire a simple event that bubbles named
input at the input element, then fire a simple event that bubbles named change
at the input element.
"""

BUG=353691,354257
R=isherman@chromium.org

[1] http://www.whatwg.org/specs/web-apps/current-work/multipage/common-input-element-attributes.html#event-input-input

Review URL: https://codereview.chromium.org/214823011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260474 0039d316-1c4b-4281-b951-d872f2087c98

https://chromeperf.appspot.com/report?masters=Chromium&bots=chromium-rel-linux-64&tests=sizes%2Fchrome-bss&checked=all&start_rev=255766&end_rev=260470

The addition of a library has caused the sizes bot to fail. This CL updates
the sizes expectations.

NOTREECHECKS=true
NOTRY=true
BUG=358051
TBR=waffles@chromium.org

Review URL: https://codereview.chromium.org/218803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260473 0039d316-1c4b-4281-b951-d872f2087c98

BUG=357714

Review URL: https://codereview.chromium.org/216183005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260470 0039d316-1c4b-4281-b951-d872f2087c98

It's failing like so:

[ RUN      ] ChromeNotifierServiceTest.SetAddedAppIdsTest
../../chrome/browser/notifications/sync_notifier/chrome_notifier_service_unittest.cc:712: Failure
Value of: notification_manager()->added_notifications()
  Actual: 1
Expected: static_cast<size_t>(2)
Which is: 2
[  FAILED  ] ChromeNotifierServiceTest.SetAddedAppIdsTest (37 ms)

TBR=petewil@chromium.org
BUG=358031

Review URL: https://codereview.chromium.org/218723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260469 0039d316-1c4b-4281-b951-d872f2087c98

This is part of the effort to eliminate Signin-related notifications.

BUG=345617

Review URL: https://codereview.chromium.org/187693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260468 0039d316-1c4b-4281-b951-d872f2087c98

This function could set an outgoing pointer to an already-released COM object, and then (correctly) return an error.
At the call sites though, the return value was not being checked, but instead the pointer was checked.
The worst part (and this is really the bug) about this was that if the pointer was valid on return, we would always call Release() on it, and that caused us to attempt to release an already-released object.

BUG=354027
TBR=mcasas

Review URL: https://codereview.chromium.org/218673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260467 0039d316-1c4b-4281-b951-d872f2087c98

And move it into content/child/sync_load_response.*.

As requested by John in -
https://codereview.chromium.org/186193005/diff/1/content/public/child/resource_loader_bridge.h#newcode111

BUG=265753, 338338, 237249
TEST=content_unittests
R=jam@chromium.org
TBR=darin

Review URL: https://codereview.chromium.org/216913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260466 0039d316-1c4b-4281-b951-d872f2087c98

BUG=357648,162530
TBR=rpaquay@chromium.org for sockets API

Review URL: https://codereview.chromium.org/217263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260465 0039d316-1c4b-4281-b951-d872f2087c98

Currently there is no method to receive the changes of recently closed pages
in chrome.sessions APIs. This callback can give extensions a chance to know
there is a change and update by calling GetRecentlyClosed again.

R=kalman@chromium.org
BUG=353007

Review URL: https://codereview.chromium.org/201393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260464 0039d316-1c4b-4281-b951-d872f2087c98

BUG=357782
TEST=no change

Review URL: https://codereview.chromium.org/216793014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260463 0039d316-1c4b-4281-b951-d872f2087c98

BUG=357715
TEST=none

Review URL: https://codereview.chromium.org/217133007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260462 0039d316-1c4b-4281-b951-d872f2087c98

This change allows CHROME_USER_DATA_DIR to override the default profile location
is Chrome is launched via a start-up script. The behaviour is unchanged if that
environment variable is not set.

BUG=351002

Review URL: https://codereview.chromium.org/190473005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260461 0039d316-1c4b-4281-b951-d872f2087c98

These tests and the feature that they test rely on iOS 7 APIs.
This change skips those tests if the platform is not recent enough.

BUG=348820

Review URL: https://codereview.chromium.org/213703005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260460 0039d316-1c4b-4281-b951-d872f2087c98

(C++ files still to do.)

Also, as a drive-by, update the generated copyright notice in
build_gles2_cmd_buffer.py to the correct, current one (no "(c)").

R=darin@chromium.org
TBR=piman@chromium.org

Review URL: https://codereview.chromium.org/218193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260459 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit 42e7514f.

It is breaking the bots like this:
https://chromegw.corp.google.com/i/clank/builders/clang-builder/builds/3819
Traceback (most recent call last):
...
Exception: The BUILDTYPE environment variable has not been set

The reason is that the downstream clang-builder uses recipes, and recipes don't
set environment variables between steps. The recipe being used is
android_builder which can be checkout as part of the buildbot code in dir:
build/scripts/slave/recipes/android/.

TBR=andrewhayden@google.com
BUG=357190

Review URL: https://codereview.chromium.org/217893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260458 0039d316-1c4b-4281-b951-d872f2087c98

NOTREECHECKS=true
NOTRY=true
NOPRESUBMIT=true
BUG=357915
R=cpu@chromium.org, waffles@chromium.org
TBR=cpu@chromium.org, waffles@chromium.org

Review URL: https://codereview.chromium.org/218693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260457 0039d316-1c4b-4281-b951-d872f2087c98

This CL eliminates almost all usage of Profile in SigninManager:
- It now gets the PrefService from the SigninClient.
- It now gets the URLRequestContext from the SigninClient.
- It has the ProfileOAuth2TokenService passed in explicitly.
- The static method DisableOneClickSignIn() now takes in a PrefService instead
  of a Profile.

The only remaining usage is sending the Profile as a notification source, which
will go away shortly when those notifications are removed.

BUG=334209
TBR=thakis

Review URL: https://codereview.chromium.org/216493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260456 0039d316-1c4b-4281-b951-d872f2087c98

On some Chrome OS devices there are drives that appear removable to the user but are listed in the system as fixed.  This is the case with SD cards on parrot, where they are exposed as a fixed mmcblk device.

This CL creates a new Chrome OS implementation for listing removable drives that uses the chromeos::disks::DiskMountManager, similar to how the Chrome OS ImageBurner is set up.

BUG=352430

Review URL: https://codereview.chromium.org/207383004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260455 0039d316-1c4b-4281-b951-d872f2087c98

BUG=348271

1st commit: https://src.chromium.org/viewvc/chrome?view=rev&revision=259808

NOTRY=True

Review URL: https://codereview.chromium.org/208643007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260454 0039d316-1c4b-4281-b951-d872f2087c98

R=wtc@chromium.org
BUG=

Review URL: https://codereview.chromium.org/216573004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260453 0039d316-1c4b-4281-b951-d872f2087c98

Prior to this change, Mac handles pinch gestures directly in the UI layer (BrowserWindowController).  Here we instead have the RenderWidgetHost send GesturePinchUpdate events, and when those events go unhandled WebContentsImpl implements the browser zoom behavior (similar to how it does already for ctrl+mousewheel events on other platforms).

This lays the groundwork in the short term for giving the web page a chance to override the pinch behavior.  Longer term this will enable us to hook into the pinch-zoom codepath used for touchscreen so that we can get a similar effect (instead of just browser-zoom - which probably isn't really what the user wants when pinching).

The only observable behavior change in this CL is that pinching outside the content area (eg. in the tabstrip) no longer does anything.  It's not clear what the pinch origin should be in such a case, and it probably doesn't really make sense to try to handle it (pinching is supposed to zoom whatever is under the cursor).

This adds some basic unit test coverage for the pre-existing (but untested) logic for mapping pinch scales to zoom in/out actions.

Depends on blink CL: https://src.chromium.org/viewvc/blink?view=rev&revision=168482

BUG=289887

Review URL: https://codereview.chromium.org/181723006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260452 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260451 0039d316-1c4b-4281-b951-d872f2087c98

Trace-viewer ended up needing charts too so we moved the charts upstream.
This does a deps roll to that fresh version and removes the local copies.

TBR=dsinclair
NOTRY=True

Review URL: https://codereview.chromium.org/218503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260450 0039d316-1c4b-4281-b951-d872f2087c98

This CL moves the OptionsUI browsertest from listening for Signin notifications
to observing the SigninManager as part of eliminating Signin notifications.

BUG=333997

Review URL: https://codereview.chromium.org/217043003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260449 0039d316-1c4b-4281-b951-d872f2087c98

There are a few crash reports coming in where the destructor
~ScopedCGLSetCurrentContext is being implicated inside
CompositorSwapBuffers. Reduce the scope of the 
ScopedCGLSetCurrentContext in CompositorSwapBuffers.

At a minimum, this will make the crash reports reveal which
place is causing problems. At a maximum, this may fix the
issue (in particular, LayoutLayers may call displayIfNeeded,
which may mess with the current context, potentially causing
crashes, as ScopedCGLSetCurrentContext does not expect
this).

BUG=245900
NOTRY=true

Review URL: https://codereview.chromium.org/216733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260448 0039d316-1c4b-4281-b951-d872f2087c98

BUG=335933

Review URL: https://codereview.chromium.org/214873003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260447 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260446 0039d316-1c4b-4281-b951-d872f2087c98