GitLab

This will be manually testable by checking for NotifyClientDimensions messages logged by hosts, once the host end logging is enabled.

DO NOT COMMIT THIS UNTIL CL 10262035 HAS LANDED.

BUG=110212

Review URL: http://codereview.chromium.org/10265033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134846 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125219
TEST=


Review URL: http://codereview.chromium.org/10283008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134845 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:30075
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134774

Review URL: https://chromiumcodereview.appspot.com/10214013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134844 0039d316-1c4b-4281-b951-d872f2087c98

BUG=98716
R=jam@chromium.org
TBR=willchan@chromium.org,sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10261003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134843 0039d316-1c4b-4281-b951-d872f2087c98

A separate cl will modify the do_signing.sh script to use this
script instead of calling hdiutil directly.

This cl is a follow-up to 10197005 to address comments.

Review URL: http://codereview.chromium.org/10261033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134842 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=tested on device


Review URL: http://codereview.chromium.org/10283006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134841 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134840 0039d316-1c4b-4281-b951-d872f2087c98

Remove the code for the aggressive HistoryURL provider field trial and make the HistoryURL provider aggressive for everyone.  Also remove the single about flag that allowed users to force a particular behavior.  (Pretty much no one did.)

BUG=
TEST=


Review URL: http://codereview.chromium.org/10260020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134839 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=tree
Review URL: https://chromiumcodereview.appspot.com/10293004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134838 0039d316-1c4b-4281-b951-d872f2087c98

Apply path tweaking logic for remote resources in FileBrowserEventRouter::RemoveFileWatch to match
that in AddFileWatch, otherwise we would fail to locate the watch_path in the map "file_watchers_"
and to remove the file watcher.

BUG=chromium-os:29720
TEST=Tested locally with debug chrome build on Linux


Review URL: http://codereview.chromium.org/10293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134837 0039d316-1c4b-4281-b951-d872f2087c98

information about the current tab with the metro driver.

BUG=125673
R=cpu
Review URL: https://chromiumcodereview.appspot.com/10290004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134836 0039d316-1c4b-4281-b951-d872f2087c98

R=darin@chromium.org
BUG=123085
TEST=None


Review URL: http://codereview.chromium.org/10268014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134835 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134834 0039d316-1c4b-4281-b951-d872f2087c98

TBR=binji@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10282007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134833 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125864
Review URL: https://chromiumcodereview.appspot.com/10286005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134832 0039d316-1c4b-4281-b951-d872f2087c98

Revert 134830 - Added support in Metro mode for retrieving the information about the currently
displayed tab url and title. This is retrieved via a registered window message sent
by the metro driver. The information is used by the share charm in metro.

BUG=125673
R=cpu,sky
Review URL: https://chromiumcodereview.appspot.com/10291007

TBR=ananta@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10286004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134831 0039d316-1c4b-4281-b951-d872f2087c98

displayed tab url and title. This is retrieved via a registered window message sent
by the metro driver. The information is used by the share charm in metro.

BUG=125673
R=cpu,sky
Review URL: https://chromiumcodereview.appspot.com/10291007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134830 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:18898
TEST=Should find a flag in about:flags to enable 3-finger click.

Review URL: http://codereview.chromium.org/10264019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134829 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=No uses yet, check compiles.


Review URL: http://codereview.chromium.org/10273024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134828 0039d316-1c4b-4281-b951-d872f2087c98

This change includes a process id in the synthesized temp dir
names, so that created directories will be more unique across
the system when you're running a bunch of base-using processes at
once (e.g., in the layout tests).

BUG=125678
R=brettw@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10264026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134827 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:30273
TEST=verified devices show up when discovering

Change-Id: I46284ee28675e726d8479bf3e0cbb812bd764b49


Review URL: http://codereview.chromium.org/10279003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134826 0039d316-1c4b-4281-b951-d872f2087c98

For UMA opted-in users, this adds a new field to the omnibox event record that's uploaded when the user uses the omnibox.  In particular, it records a simple enum of what type of page the user was looking at, such as a generic web page or the new tab page.

This change only adds the field to the protocol buffer upload format, not the XML format.  If I decide later I want to add it to the XML format, I'll do it in another changelist.

BUG=
TEST=using VLOG(1) of what would be uploaded


Review URL: http://codereview.chromium.org/10273019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134824 0039d316-1c4b-4281-b951-d872f2087c98

Turning on by default before M20 branch, but leaving flag code for now so that
it's just a one-liner to disable if necessary post-branch.

BUG=118552,112879

Review URL: http://codereview.chromium.org/10281003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134823 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134822 0039d316-1c4b-4281-b951-d872f2087c98

BUG=115967
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134740

Review URL: https://chromiumcodereview.appspot.com/10273023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134821 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=tree
Review URL: https://chromiumcodereview.appspot.com/10285004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134820 0039d316-1c4b-4281-b951-d872f2087c98

Clean up LoginUIService::ShowLoginUI() API to not take a force_login flag.
Moved force_login code into the only place that needs it - AppNotifyChannelUI.

Fixed AppNotifyChannelUI code to gracefully handle having sync UI visible when the
user tries to re-auth.

BUG=118795
TEST=bring up sync UI via various methods (promo, app notifications infobar, wrench menu, error link in settings page, etc)


Review URL: http://codereview.chromium.org/10192005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134819 0039d316-1c4b-4281-b951-d872f2087c98

view model with a -1.

BUG=125127
TEST=covered by unit test
R=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10291002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134818 0039d316-1c4b-4281-b951-d872f2087c98

To be re-enabled tomorrow.

R=dennisjeffrey@chromium.org
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10265019

TBR=nirnimesh@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10283009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134817 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=functional/apptest.py

Review URL: https://chromiumcodereview.appspot.com/10282006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134816 0039d316-1c4b-4281-b951-d872f2087c98

BUG=no
TEST=no

Review URL: https://chromiumcodereview.appspot.com/10280005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134815 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125795,110212


Review URL: http://codereview.chromium.org/10262035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134814 0039d316-1c4b-4281-b951-d872f2087c98

This function is no longer used as it was replaced by
GetEntryInfoByPathAsync(), GetFileInfoByPathAsync(), and
ReadDirectoryByPathAsync().

BUG=chromium-os:30251,chromium-os:30204
TEST=compiles

Review URL: https://chromiumcodereview.appspot.com/10280004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134813 0039d316-1c4b-4281-b951-d872f2087c98

BUG=122641
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10291004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134812 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134810 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=tree
Review URL: https://chromiumcodereview.appspot.com/10287003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134809 0039d316-1c4b-4281-b951-d872f2087c98

GetDownloadDataCallback parameter in GDataFileSystem::GetFileByPath()
was optional hence a null callback was passed in many places, and
the null callback was posted to a message loop without checking if
it's null or not.

BUG=chromium-os:30198
TEST=double clicking on an image file on gdata; copy-pasting from gdata to Downloads; both don't crash

Review URL: https://chromiumcodereview.appspot.com/10288006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134808 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123657
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10278006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134807 0039d316-1c4b-4281-b951-d872f2087c98

Also, build more stuff on win_aura.

BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10260033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134806 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134805 0039d316-1c4b-4281-b951-d872f2087c98