- 01 Dec, 2020 40 commits
-
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=pbommana@chromium.org Change-Id: I2602e3b6e48939be6dac0001eedbaad02b8b432a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566719Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#832200}
-
Eugene But authored
CreateSyntheticCrashReportForUte can be legitimately called with empty breadcrumbs vector, in which case the app should not crash. This CL uses "No Breadcrumbs" signature instead of trying to access the element in an empty vector. Bug: 1154039 Change-Id: I45537944122700c9085c4e824ae9edeafe1c7395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566361 Commit-Queue: Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#832199}
-
David Munro authored
We were checking for the wrong signal name. In practise we get both or neither signal but still good to clean up. Bug: None Test: CQ Change-Id: Ibe93fe677c9359454e1cd6a88a5c8d3ade9dd199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567053 Auto-Submit: David Munro <davidmunro@google.com> Reviewed-by:
Fergus Dall <sidereal@google.com> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#832198}
-
Sammie Quon authored
On clicking, capture mode session will end and we try to snap a deleted window. This CL ignores the capture label window so that the window finder algorithm can find the next top window. That next top window will be the snapped window instead and will persist when capture session gets destroyed. This can happen to any capture session widget/window, but only the capture label is visible or created during window mode. Fixed: 1152938 Test: ash_unittests CaptureModeTest.TabletTouchCaptureLabelWidgetWindowMode Change-Id: I6fe8c2fea34c4738ef41dbafca2609b0b6913589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566450 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#832197}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f37338cdaa21..42433abb9596 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I6e1329ccbcc381ca8c5901caffda8b30b4b91ba9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566357Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#832196}
-
Tom Anderson authored
This is needed for [1] which adds the assumption that Chrome makes all requests on the main Xcb connection. This CL simply moves the requests to occur on a separate connection to satisfy this assumption. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2565440 R=penghuang Bug: None Change-Id: Ia85799c460d0fef372121dae3244874130158fa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566342 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#832195}
-
Koji Ishii authored
This patch reverts removed `<Item>`s in r816912 <crrev.com/c/2467503> back, because Visual Studio started to fail to parse `natvis` when it has `<Item>`s for anonymous unions. It looks like the issue was fixed in Visual Studio 16.7.7, released on Oct 27th. Developers who have not upgraded will not be able to use DebugVisualizer for |NGFragmentItem|, but can still view the raw view, and will benefit from the DebugVisualizer once they upgraded. Also adds a unit test as suggested by brucedawson@ in <crrev.com/c/2467503>. Change-Id: I4d35ee40a8bbdf2c455f7c4ecf8f8f3b80d1248a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558136 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#832194}
-
David Grogan authored
When using the aspect ratio, we were doing size = large1 * large2 / large3. large1 * large2 was overflowing LayoutUnit. Now we do those calculations with the operands as doubles. We still multiply first because *most* of the time these values will all be integers, and all the integers up to LayoutUnit::Max()*LayoutUnit::Max() can be exactly represented with double precision. Change-Id: Id714f38493554c5f1b7e4dfe56bdaa6742f3d8a5 Fixed: 1151608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564199 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#832193}
-
Nancy Wang authored
This CL implements the restore notification on startup after crash, based on the ui review deck go/cros-full-restore page 9. There will be some follow up CLs to add the reading restore settings, and other full restore notifications implementation. BUG=1146900 Change-Id: I194b1e794e08c4afca556fe2307b804e1184b135 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554717 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#832192}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f37338cdaa21..42433abb9596 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If6692b2103f62e67270834b7852c8bd76c43fdb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566298Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4c6f57a23e63..416fe32ce119 2020-12-01 bungeman@google.com Ensure variable font from data created at default. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: westont@google.com Change-Id: Id5926fbf29aca89e1979b80ccabc048231181e1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566972Reviewed-by:
-
Andrew Xu authored
Bug: 1152815 Change-Id: Ic21c07a055043a2fd6fbd908ad8e27f99b78b041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561026Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#832189}
-
Daniel Cheng authored
https://crrev.com/c/2518105 was a previous attempt to fix this, but incorrectly assumed that LocalFrame->LocalDOMWindow would be cleared on frame detach. In fact, this is not the case. In the interest of a simple, mergeable patch, simply add the appropriate null check directly inside ScreenOrientationController. This + the incorrect checks in the caller will be cleaned up in a followup. Bug: 1143380 Change-Id: I27a64d62762bd4f9559b690aaf06a0fb89fae02b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566713Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#832188}
-
Aaron Leventhal authored
- Makes the parent-child relationships symmetrical, such that the parents of any <ruby> children is the <ruby> element, not a child of it. Currently, this symmetry is broken because AddChildren() uses LayoutObject's, whereas ComputeParent() uses DOM traversal. This broken symmetry also causes the linked clusterfuzz crash. The test for asymmetry is in WIP CL:2528573, which adds a DCHECK() for incorrect parent computation results. - Removes another special case for building children, getting closer to a unified model for AddChildren(). - Generally, speaking ruby text is redundant with the base text. This CL avoids double speech while allowing the ruby text to be announced separately, by exposing ruby text only as an annotation to the <ruby> element, similar to <span aria-description="foo">bar</span>. By exposing as a description, users will be able to leverage screen reader options already available for presentation of annotations. Most screen readers provide an option to turn on/off annotations, and more feature work is underway because of ARIA annotations. - Do not expose contents of the <rp> element, which contains parens. The screen reader will already delineate descriptions from main text. Bug: 427756,1152973 Change-Id: I5ad410e73b873f632fb68466cc5da3c4b2ac4539 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563861 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#832187}
-
Livvie Lin authored
This experiment has launched and code should execute by default. Bug: 1015626 Change-Id: I4b307447248331eca1be0bd5c46c30c84ba9d28e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552768Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Chris Thompson <cthomp@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#832186}
-
Liquan (Max) Gu authored
Motivation: This CL lays the preparatory work to create onShowCalledAndAppQueried() which will encapsulate the following methods: - disconnectIfNoPaymentMethodsSupported - showAppSelector - triggerPaymentAppUiSkipIfApplicable Behavioural changes: Note that disconnectIfNoPaymentMethodsSupported() depends on mHasEnrolledInstrument, so this moving will add prefsCanMakePayment to the disconnection conditions. The new behaviour should be a correct one because mHasEnrolledInstrument is finalized only after prefsCanMakePayment. Before the CL, disconnectIfNoPaymentMethodsSupported tests different mHasEnrolledInstrument when it's invoked in different places. Bug: 1153353 Change-Id: I6752d33d5c4d2bbbb6ce237248dc4692584ef1e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562836 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#832185}
-
WangHui authored
Fix typo in Comments. Bug:None Signed-off-by:
WangHui <wanghui210@huawei.com> Change-Id: I9a423ea4f360eb3434955c51c75b5b995a809d30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564930Reviewed-by:
Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#832184}
-
Leo Lai authored
BUG=b:172775884 TEST=build. Change-Id: I0a8d0b55c85473c524eb0470b989bf56b3c1da5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563008Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Leo Lai <cylai@google.com> Cr-Commit-Position: refs/heads/master@{#832183}
-
Tom Anderson authored
R=penghuang Bug: 1153156 Change-Id: I21a024b4ce2918ca8d407ce3df4b0c7928942b2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565194 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
Leo Lai authored
We are deprecating CanAttemptOwnership by cryptohome. BUG=b:172775884 TEST=build ok. Change-Id: I4d08df9fc318dc1e21e8783f332eb73b549f19aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563339Reviewed-by:
-
Hassan Talat authored
This CL adds windowControlsOverlay object to the window.navigator API. The changes are behind the flag: "WebAppWindowControlsOverlay" Explainer: https://github.com/WICG/window-controls-overlay/blob/master/explainer.md Design Doc: https://docs.google.com/document/d/1k0YL_-VMLIfjYCgJ2v6cMvuUv2qMKg4BgLI2tJ4qtyo/edit?usp=sharing I2P: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/cper6nNLFRQ/hU91kfCWBQAJ Bug: 937121 Change-Id: Iabe3ff49ab4948e3aa225fb2764f6975c890bddf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549120Reviewed-by:
Chase Phillips <cmp@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hassan Talat <hatalat@microsoft.com> Cr-Commit-Position: refs/heads/master@{#832180}
-
Erik Chen authored
The metric is deprecated. Bug: 1033151 Change-Id: Ia4f59367ce357916e791e2f59b28e7f58a8aac6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963132Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#832179}
-
Lukasz Anforowicz authored
Bug: 1152550 Change-Id: Icd7141a79a8590bd05dd865c70f1148b7d157c74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559212 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#832178}
-
Sammie Quon authored
Left/right shelf -> bar bottom is 16px from the display bottom. Extended hotseat -> bar bottom is 16px from the top of the hotseat. Regular shelf -> bar bottom is 16px from the shelf. Fixed: 1153986 Test: manual Change-Id: I4a3e5a9d3e751601ae9b31bf392f33edacbef98c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566358Reviewed-by:
-
Clark DuVall authored
This was because it had an interface with a single implementer in the DFM, similar to image_editor. Bug: 1154061 Change-Id: Ie4f1ff1eaa912ffa2f54b08d64c5537d2049f1f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566340 Commit-Queue: Clark DuVall <cduvall@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#832176}
-
Julie Jeongeun Kim authored
If mojom::PrintManagerHost is disconnected in the browser after calling UpdatePrintSettings() in the renderer, |settings| could be null. This CL sets the error if |settings| could be null after UpdatePrintSettings(). Bug: 1151870 Change-Id: I7145212f495d2d9304dd588998cd54bc96ecce2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560016Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#832175}
-
Bao-Duy Tran authored
These are always called together consecutively at callsites. Merging them to simplify and avoid the requirement that Initialize() must be called before any other methods. This refactoring should also facilitate dependency injection to fix test failures due to mixed usage of prod config data and hermetic test data. Bug: 970790, 1134465 Change-Id: Ic891bd62e68786b4afa545c6118d729139535a75 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome;luci.chromium.try:linux-chromeos-rel,linux-chromeos-dbg Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552329 Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
-
Alan Cutter authored
TBR=clemensb@chromium.org Bug: 1153626 No-Try: True Change-Id: Iff754524538537346a7a9c61e5629d4e629a3faf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567231 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#832173}
-
Shik Chen authored
Bug: b/172879638, b/174497133 Test: Manually Change-Id: I5b4d22063dd6741a530f84192c5475b08706c055 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567230 Auto-Submit: Shik Chen <shik@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#832172}
-
Bartek Nowierski authored
While at it, add a couple tests for Android and Windows. Bug: 1121427 Ignore-Goma-Freeze: small increased goma usage (4 CI builders x 80 jobs). Change-Id: Ia14a52ebe2051b023a6e291f4d2982a952fb3507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560355 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#832171}
-
Yoshifumi Inoue authored
This patch gets rid of |LayoutObject::Caret{Min,Max}Offset()| because |LayoutObject::CaretMinOfset()| always return zero for other than |LayoutText| and usage of |CaretMaxOffset()| is being deprecated because returning one for <hr> is questionable, for improving code health. Change-Id: Ie02fd5fbdbadb0a3e1e0799c595d3187cd9b8c9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563392 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#832170}
-
Adam Rice authored
Add ports 69, 137, 161, 554, 1719, 1720, 1723, 6566 to the restricted ports list to match Firefox. See https://hg.mozilla.org/mozilla-central/file/tip/netwerk/base/nsIOService.cpp. Leave out port 10080 for now as it seems likely to cause compatibility problems. BUG=1148309 Change-Id: I16f9a61068dbe35334fd5ca2bf55b3ab0287df74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562905Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#832169}
-
Clark DuVall authored
This increases the package ID of WebLayer in standalone WebView, since it seems some devices are already using the 0x0c package ID. Bug: 1128591 Change-Id: Ib5aa17f9d997e3cf9e6611f651610238b796a07e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566294Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1606759191-e36e6bb9e34aaec2b6f2fa507df72b0ae1dbb4d4.profdata to chrome-mac-master-1606780634-1ea1516e4fb1522afac8d06bcea54ae6d1ecbcd2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I65eba0d63b1c42c8bf0cf349d4f8e3ac7946e044 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566462Reviewed-by:
-
Fergal Daly authored
This is a prefactor for https://crrev.com/c/2536214. This just wraps FrameTreeVisualizer().DepictFrameTree(...). This makes a few tests a simpler but also insulates them from changes to the implementation. Change-Id: I8509ea44577aa41280c18225f4e091f90f422bef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560700 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Auto-Submit: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#832166}
-
Chan Li authored
To stop using result_adapter for tests on those builders, since android test runner should be able to report the results directly. Bug: 1136998 Change-Id: I30dbe53cacf2f33d01d565a982de6d7ebbb23cf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561446 Commit-Queue: Chan Li <chanli@chromium.org> Reviewed-by:
benjamin joyce <bjoyce@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1606759191-6cd311392c4a2d76b8ec4391ac1874206c9889b0.profdata to chrome-linux-master-1606780634-867f063cb43c5794bf65123662fce4e91b9de4cb.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I2eba53edd93a1e00f7804af988fccc315d0a4173 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566503Reviewed-by:
-
Mike Dougherty authored
ContextMenu historgrams extended to date ~6 months away which is already used by other ContextMenu histograms. Bug: 1140065, 1144815 Change-Id: I3f6aaa03a45e3354634ed263d50ec12024b33c8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566170 Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#832163}
-
Bartek Nowierski authored
This reverts commit cdf4fd98. Reason for revert: Multiple perf regressions https://chromeperf.appspot.com/group_report?rev=831852 Original change's description: > [PA] Eagerly decommit single-slot slot spans > > Empty slot spans are typically registered for lazy decommitting, to > avoid perf regression when going back and forth between > decommitted<->active states. However, we haven't observed a perf > difference for single-slot slot spans, in which case better to decommit > them as soon as they become free. > > Change-Id: I09e09055dd2b54b17a54ed35f518d72e9a16e310 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549024 > Auto-Submit: Bartek Nowierski <bartekn@chromium.org> > Reviewed-by: Benoit L <lizeb@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Bartek Nowierski <bartekn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#831852} TBR=haraken@chromium.org,lizeb@chromium.org,bartekn@chromium.org Bug: 1153975, 1153970e, 1153974, 1153977, 1154029, 1153972, 1153983 Change-Id: I4ba792e2bd06194cb3b0ae7aa231d70592c188f3 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566391Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
-
Muhammad Hasan Khan authored
Sign-in and check-in are both from GMS so fixing the naming. BUG=b:166322619 TEST=CQ Change-Id: I4c3173448d06488b0c4a98fb5825207e7724d1eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558762 Commit-Queue: Muhammad Hasan Khan <mhasank@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#832161}
-
