GitLab

This also update test_runner.pydeps to include changes to references to
catapult_base directory.

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/578e20909005..fa2c4f21907f

$ git log 578e20909..fa2c4f219 --date=short --no-merges --format='%ad %ae %s'
2016-08-30 benjhayden Rename Histogram.add() to addSample().
2016-08-30 benjhayden Replace ScalarNumerics with Histograms in value_set_test and value_set_table_test.
2016-08-30 ksakamoto Update FirstMeaningfulPaint to use Blink's implementation
2016-08-30 aiolos Revert of [polymer] - Sort series data before adding to legend. (patchset #1 id:1 of https://codereview.chromium.org/2233763003/ )
2016-08-30 benjhayden Refactor NumericBuilder to HistogramBinBoundaries.
2016-08-30 fmeawad v8CallStats: Add a map between URL and known domain names
2016-08-30 eakuefner [Catapult] Update .gitignore to point to new locations in common/
2016-08-30 washingtonp Pass in custom options to Systrace agents
2016-08-30 nednguyen [telemetry] Only disable trace profiler for TBM
2016-08-30 jbudorick [devil] Re-add the reset_usb import to unblock the catapult roll.
2016-08-30 fmeawad v8CallStats: Update the arg name
2016-08-30 benjhayden Migrate memoryMetric from ScalarNumerics to Histograms.
2016-08-30 nednguyen Remove catapult_base/ and move its files to common/py_utils/

BUG=638124, 642716

TBR=catapult-sheriff@chromium.org

patch from issue 2298183003 at patchset 1 (http://crrev.com/2298183003#ps1)

Review-Url: https://codereview.chromium.org/2300623002
Cr-Commit-Position: refs/heads/master@{#415625}

Using gcc_compile_wrapper.py unconditionally is inefficient and makes
debugging more difficult. This is problematic since resource
whitelisting occurs relatively infrequently.

BUG=642498

Review-Url: https://codereview.chromium.org/2296033002
Cr-Commit-Position: refs/heads/master@{#415624}

COMMAND_PREFIX and COMMAND_SUFFIX should be used simultaneously

BUG=

Review-Url: https://codereview.chromium.org/2295103002
Cr-Commit-Position: refs/heads/master@{#415623}

PasswordFormManager::ProcessMatches currently happily accepts credentials from
PasswordStore with a different PasswordForm::Scheme than the observed form has.
However, it still has a DCHECK against it later (in the Autofill* methods), so
it is clearly not expecting these, rather than mixing the schemes being by
design.

And it should not be by design. Especially, if the saved credential is a
non-HTML one, and should be filled in a HTML form. Mixing them makes the
non-HTML credential vulnerable against (injected attacker's) JavaScript
accessing them.

This CL filters out credentials with non-matching scheme from the batch coming
from the PasswordStore. Given the absence of DCHECKs in release builds, this
actually changes the behaviour for Chrome users, but the change is a desired
one.

BUG=640897

Review-Url: https://codereview.chromium.org/2298733002
Cr-Commit-Position: refs/heads/master@{#415622}

https://chromium.googlesource.com/skia.git/+log/3ee255f25954..272b311298d7

$ git log 3ee255f25..272b31129 --date=short --no-merges --format='%ad %ae %s'
2016-08-31 mtklein GN: forgot Clang+ccache fix on Android.  And sort.
2016-08-31 mtklein GN: add sources_when_disabled to optional

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=bsalomon@google.com

Review-Url: https://codereview.chromium.org/2300603002
Cr-Commit-Position: refs/heads/master@{#415621}

BUG=642482
TBR=stanisc@chromium.org,nick@chromium.org

Review-Url: https://codereview.chromium.org/2294113003
Cr-Commit-Position: refs/heads/master@{#415620}

This CL fixes a regression by crrev.com/414002.  It accidentally changed
select() behavior because focus() scrolls element's containers so that the
selection is visible.  Focus by select() should not scroll.

BUG=642320

Review-Url: https://codereview.chromium.org/2295083002
Cr-Commit-Position: refs/heads/master@{#415619}

morrita@ has been inactive for 1+ year. To make reviewer selection work
smoothly, remove morrita@ for now.

R=mkwst
BUG=none

Review-Url: https://codereview.chromium.org/2274043002
Cr-Commit-Position: refs/heads/master@{#415618}

Accessing |max_render_time_| under |lock_| in Stop(). It's already accessed under the lock in the other place.

BUG=641339

Review-Url: https://codereview.chromium.org/2292053002
Cr-Commit-Position: refs/heads/master@{#415617}

This CL adds a clang tool to rewrite unneeded scoped_refptr<>::get, and
applies it to //base.

To build and apply this tool, run below:
$ ./tools/clang/scripts/update.py --force-local-build --without-android --tools base_bind_rewriter
$ ./tools/clang/scripts/run_tool.py --regenerate-compdb base_bind_rewriters out/Release base

Review-Url: https://codereview.chromium.org/2283003002
Cr-Commit-Position: refs/heads/master@{#415616}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/b1336315..299d5acf

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2297733003
Cr-Commit-Position: refs/heads/master@{#415615}

The current implementation allows filtering for one origin.

The GURL->bool filter that is nowadays used by BrowsingDataRemover
allows specifying whitelists or blacklists of multiple URLs
(typically entire origins).

TBR=droger@chromium.org
BUG=589586

Review-Url: https://codereview.chromium.org/2289853002
Cr-Commit-Position: refs/heads/master@{#415614}

When an IgnoreResult is passed as a rvalue-reference, Bind impl has passed
the target functor as a lvalue-reference. That causes a compile failure
when the target functor can be run via rvalue-reference only.
This CL changes IgnoreResult handling in base::Bind impl, so that it
uses rvalue-reference functor when IgnoreResult itself is passed as
a rvalue-reference.

BUG=554299

Review-Url: https://codereview.chromium.org/2298133003
Cr-Commit-Position: refs/heads/master@{#415613}

Revert of All DCP manager tests that enroll/register are tested with all auths. (patchset #7 id:120001 of https://codereview.chromium.org/2287343004/ )

Reason for revert:
Reverting due to use after free. See http://crbug.com/624187#c28

Original issue's description:
> All DCP manager tests that enroll/register are tested with all auths.
>
> Use a FakeSigningService in the DeviceCloudPolicyInitializer in order
> to be able to unit test re-enrollment for locked devices when
> registering with a certificate.
>
> BUG=624187,641447
> TEST=unit_tests
>
> Committed: https://crrev.com/f71058accb8d57221145dfb2c34769244d6cc54d
> Cr-Commit-Position: refs/heads/master@{#415574}

TBR=pastarmovj@chromium.org,drcrash@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=624187,641447

Review-Url: https://codereview.chromium.org/2302443002
Cr-Commit-Position: refs/heads/master@{#415612}

Some arguments to the PerformanceResourceTiming::create() methods have m_
prefixes, which makes them look like class members. Remove the m_ prefixes to
reduce confusion.

R=ksakamoto@chromium.org
BUG=
TEST=compiled

Review-Url: https://codereview.chromium.org/2284323002
Cr-Commit-Position: refs/heads/master@{#415611}

Review-Url: https://codereview.chromium.org/2297903004
Cr-Commit-Position: refs/heads/master@{#415610}

This CL adds ClearHistory() to ContentSuggestionsService and its
providers, which is called when the history is removed using Clear
Browsing Data dialog, so that the providers can remove their history.

BUG=641321

Review-Url: https://codereview.chromium.org/2284393002
Cr-Commit-Position: refs/heads/master@{#415609}

BUG=642361

Review-Url: https://codereview.chromium.org/2291163002
Cr-Commit-Position: refs/heads/master@{#415608}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/8b4eaefc8859cf67683a5fa2e558b27e7c48dbfd Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/3a98a0a38287c090976ffd2f0cd47d12ba21b2d3 Add dart/packages recipe, and builders using it. (whesse@google.com)
depot_tools:
  https://crrev.com/6d3c290164360907fe08784093e36314069e689f It's time to bring subprocess42 to depot_tools. (tandrii@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=635641

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2294243002
Cr-Commit-Position: refs/heads/master@{#415607}

Move the implementation of GURL::DomainIs into a shared function in url_util/,
to be used both by GURL and url::Origin.

The reason for this refactoring is to reap significant performance gains in
scenarios where previously url::Origins had to be converted to GURLs for
DomainIs checks. This involved string copying, allocations, and parsing the
entire URL once again.

BUG=517560

Review-Url: https://codereview.chromium.org/2287483002
Cr-Commit-Position: refs/heads/master@{#415606}

BUG=603176

Review-Url: https://codereview.chromium.org/2292233002
Cr-Commit-Position: refs/heads/master@{#415605}

- Use symbols consistent with operator<< for PositionAnchorType.
- Add offset only if OffsetInAnchor
  The output of PositionTemplate::showTreeForThis() is changed:

  BODY
  *       #text ...
  offset, offset:9

  to

  BODY
  *       #text ...
  offsetInAnchor[9]

- printPosition() uses toAnchorTypeAndOffsetString().
  The output of printPosition for OffsetInAnchor is changed:

  #text "..."@9

  to

  #text "..."@offsetInAnchor[9]

This CL doesn't affect production.

Review-Url: https://codereview.chromium.org/2296863003
Cr-Commit-Position: refs/heads/master@{#415604}

BUG=527059
TBR=mef, droger

Review-Url: https://codereview.chromium.org/2291033003
Cr-Commit-Position: refs/heads/master@{#415603}

They are unused after https://codereview.chromium.org/2253853002/ and thus this
CL removes them from MemoryCache::TypeStatistic and WebCache::ResourceTypeStat.

This CL also fixes compile errors when MEMORY_CACHE_STATS is enabled.

BUG=603791

Review-Url: https://codereview.chromium.org/2254593003
Cr-Commit-Position: refs/heads/master@{#415602}

https://chromium.googlesource.com/chromium/src/+/0f93d7965

BUG=637811
TBR=robhogan@gmail.com

Review URL: https://codereview.chromium.org/2298713002 .

Cr-Commit-Position: refs/heads/master@{#415601}

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2251263003
Cr-Commit-Position: refs/heads/master@{#415600}

BUG=640319
TBR=fgorski@chromium.org

Review-Url: https://codereview.chromium.org/2300563002
Cr-Commit-Position: refs/heads/master@{#415599}

Neither the corpus nor the dictionary are helpful for the fuzzer at the
moment.

R=mmoroz@chromium.org

Review-Url: https://codereview.chromium.org/2298153002
Cr-Commit-Position: refs/heads/master@{#415598}

When a suggestion is dismissed from the NewTabPage using the 'Remove'
context menu item, the content that it refers to cannot be looked up
from the corresponding ViewHolder, as onBindViewHolder may be called
while the context menu is still open (which would result in the wrong
suggestion being dismissed).
Instead, store the referenced suggestion in the listener for the
context menu items. This requires some additional refactorings.

When the 'Remove' item is clicked for a suggestion that has been
removed for other reasons (section became unavailable, suggestion was
invalidated) in the meantime, ignore the call. When it is clicked for
a suggestion that as moved out of the visible view, skip the
animation and just dismiss it from the underlying data model directly.

BUG=641313

Review-Url: https://codereview.chromium.org/2285833002
Cr-Commit-Position: refs/heads/master@{#415597}

TBR=dpapad@chromium.org
BUG=642574,625332

Review-Url: https://codereview.chromium.org/2298113002
Cr-Commit-Position: refs/heads/master@{#415596}

BUG=642482
TBR=stanisc@chromium.org,nick@chromium.org:

Review-Url: https://codereview.chromium.org/2301493002
Cr-Commit-Position: refs/heads/master@{#415595}

BUG=570121

Review-Url: https://codereview.chromium.org/2285663002
Cr-Commit-Position: refs/heads/master@{#415594}

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2257793002
Cr-Commit-Position: refs/heads/master@{#415593}

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2253053003
Cr-Commit-Position: refs/heads/master@{#415592}

ErrorResponse can be null when an error happens locally.
Also, this logging is unnecessary as ObjectProxy::CallMethod is already
doing that.

BUG=642241

Review-Url: https://codereview.chromium.org/2291453006
Cr-Commit-Position: refs/heads/master@{#415591}

Disabling the Microsoft software synthesizer due to security reasons.
See http://crbug.com/499279 for details.

R=toyoshim@chromium.org

Review-Url: https://codereview.chromium.org/2298103002
Cr-Commit-Position: refs/heads/master@{#415590}

BUG=642050

Review-Url: https://codereview.chromium.org/2289193003
Cr-Commit-Position: refs/heads/master@{#415589}

Revert this CL and its successors. A new approach will be progressed under 637811.

BUG=637811,627305,623026,465096,468699

Review-Url: https://codereview.chromium.org/2296883002
Cr-Commit-Position: refs/heads/master@{#415588}

https://pdfium.googlesource.com/pdfium.git/+log/2fdacfb09551..7e7ef3dd60a8

$ git log 2fdacfb09..7e7ef3dd6 --date=short --no-merges --format='%ad %ae %s'
2016-08-30 thestig Update .gitignore to properly ignore base/

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2290243003
Cr-Commit-Position: refs/heads/master@{#415587}

This patch converts "editing/execCommand/find-after-replace.html" to use w3c
test harness to simplify test script for improving readability.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2300553002
Cr-Commit-Position: refs/heads/master@{#415586}