GitLab

TBR=msramek@chromium.org
NOTRY=true

Bug: 736333
Change-Id: Ibc07aa373a6dd7c779705d10dec8efc26ebd8a15
Reviewed-on: https://chromium-review.googlesource.com/545995Reviewed-by: Xida Chen <xidachen@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481894}

It seems all tests are being flaky for some reason :-(

BUG=736257
TBR=dpranke@chromium.org,mcgreevy@chromium.org,qyearsley@chromium.org,jeffcarp@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2952423002
Cr-Commit-Position: refs/heads/master@{#481893}

Revert of ChromeWebView integration test for Incognito. (patchset #3 id:40001 of https://codereview.chromium.org/2945563002/ )

Reason for revert:
Failing on downstream bots

Original issue's description:
> ChromeWebView integration tests for Incognito.
>
> These tests verify that browsing data (cookie, localStorage) does not
> leak between incognito and non-incognito web views.
>
> BUG=None
>
> Review-Url: https://codereview.chromium.org/2945563002
> Cr-Commit-Position: refs/heads/master@{#481755}
> Committed: https://chromium.googlesource.com/chromium/src/+/aa87813942a324671466d574bc8567c0f74a7749

TBR=ichikawa@chromium.org,michaeldo@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None

Review-Url: https://codereview.chromium.org/2952403003
Cr-Commit-Position: refs/heads/master@{#481892}

Only content of claim-fetch.https.html needs to be revised.

BUG=678905
TEST=blink_tests
external/wpt/service-workers/service-worker/claim-fetch.https.html

Change-Id: I0efb5298847bb69c0f29bc2dffb1fc51c5a02960
Reviewed-on: https://chromium-review.googlesource.com/544677
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481891}

Bug: 695808
Change-Id: Iab3b5da25eb6c920e3ab998fe7a6cbc69d7222af
Reviewed-on: https://chromium-review.googlesource.com/542995
Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481890}

BUG=689520,667892

Change-Id: I1143fbc8c5f7c12dfdd8e5764d58c9b372d3cb16
Reviewed-on: https://chromium-review.googlesource.com/544782
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481889}

TBR=msramek@chromium.org
NOTRY=true

Bug: 736370
Change-Id: Ifb265e3ed6120b21b3e10ca17188122eed4b0a84
Reviewed-on: https://chromium-review.googlesource.com/545616Reviewed-by: Xida Chen <xidachen@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481888}

Upcoming work that will embed Service Manager in //ios/web will add
usage of //ios/web/resources; I will test this embedding via an EG
test that exercises web_shell and thus will need web_shell to bundle
these resources.

Bug: 731588
Change-Id: I1767d02ab13f6960811d80f516cc807f6ad486a1
Reviewed-on: https://chromium-review.googlesource.com/544310Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481887}

rendezvousing with promised streams. This fixes a bug where
a session could be closed, and the push handle deleted
before the QuicHttpStream was notified resulting in
a use-after-free of the push handle.

BUG=719461

Review-Url: https://codereview.chromium.org/2948143002
Cr-Commit-Position: refs/heads/master@{#481886}

XCallbackParameters does not carry anything information that is used
and is just passed around the app startup parameters due to legacy
reasons.

Note that googlechrome-x-callback and chromium-x-callback custom URL
schemes are *still supported*. They are parsed and the URL part is
extracted for opening in a tab.

Review-Url: https://codereview.chromium.org/2923013005
Cr-Commit-Position: refs/heads/master@{#481885}

DebugDaemon has a function, GetLog(), that returns the output of one
log command. This patch adds a new log source class to fetch the output
of GetLog().

BUG=733846

Review-Url: https://codereview.chromium.org/2955463002
Cr-Commit-Position: refs/heads/master@{#481884}

QuickLaunch will attempt to bring up its own Aura. However it is possible for
QuickLaunch::OnStart to occur after the peer has closed. AuraInit requires a
Directory api to load resources. Currently failing with a CHECK when it is not
available.

This updates AuraInit to report success/failure at initializing. QuickLaunch
uses this to cleanly close the ServiceContext on its side.

This will clean up a series of random crashes occuring in mash_browser_tests

TEST=mash_browser_tests
BUG=678687

Review-Url: https://codereview.chromium.org/2949103002
Cr-Commit-Position: refs/heads/master@{#481883}

This CL adds support for handling multiple concurrent Dice responses.

BUG=730589

Review-Url: https://codereview.chromium.org/2950073002
Cr-Commit-Position: refs/heads/master@{#481882}

This reverts commit 83daa38b.

Reason for revert: The patch potentially caused crbug.com/736248, need further investigation.

Original change's description:
> cc: Enable mask tiling
> 
> Set the cc flag enable_mask_tiling to true. Masks without filters are
> now tiled.
> 
> Bug: 567293, 567296
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: Iaeb8477b1aba550f0eec1afd9ef0cbb27381ccc1
> Reviewed-on: https://chromium-review.googlesource.com/543517
> Commit-Queue: Xianda Sun <sunxd@chromium.org>
> Reviewed-by: Chris harrelson <chrishtr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#481563}

TBR=trchen@chromium.org,chrishtr@chromium.org,enne@chromium.org,sunxd@chromium.org,schenney@chromium.org

Change-Id: I0f83150b90caca0ef2e65e6c886509c06863df47
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 567293, 567296
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/545775Reviewed-by: Xianda Sun <sunxd@chromium.org>
Commit-Queue: Xianda Sun <sunxd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481881}

When a service worker is involved, it's possible to get an opaque
filtered response for a mode: "cors" request. We peviously
checked it in ResourceFetcher but it's insufficient when the resource is
shared before the response arrives.

This CL instead make a CORS error when we see such response in
DocumentThreadableLoader.

Bug: 731669, 625575
Change-Id: I65334dbe21c0e2e8aaedd6d5dd5fae762c7cb72c
Reviewed-on: https://chromium-review.googlesource.com/527768
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481880}

TBR=msramek@chromium.org
NOTRY=true

Bug: 736354
Change-Id: I4d6ddca7c5cb167d6f39da22a63fba7eac54e00e
Reviewed-on: https://chromium-review.googlesource.com/545735Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481879}

This removes a //chrome dependency in base (process_version_rc_template),
allowing //base to be used by targets that do not have access to //chrome.

BUG=642115
TEST=eventlog_provider.dll is installed and SYSLOG works.

Review-Url: https://codereview.chromium.org/2946983002
Cr-Commit-Position: refs/heads/master@{#481878}

This reverts commit 2878e36f.

Reason for revert: This is checking for a feature before FeatureList::InitializeInstance is called, causing a crash at startup; see https://crbug.com/736251.

Original change's description:
> Disable the buggy RSA parser by default.
> 
> In doing so, fix the error mapping in openssl_ssl_util.cc. An SSL
> connection may fail due to errors in other modules as well (notably the
> RSA parser lives in libcrypto). Map any unknown error to
> ERR_SSL_PROTOCOL_ERROR, rather than ERR_FAILED and continue to
> report the error info.
> 
> Bug: 735616
> Change-Id: Icb587e66987ddd9d5445d30d456de1c029cda21a
> Reviewed-on: https://chromium-review.googlesource.com/540536
> Commit-Queue: Steven Valdez <svaldez@chromium.org>
> Reviewed-by: Steven Valdez <svaldez@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#481640}

TBR=davidben@chromium.org,svaldez@chromium.org

Change-Id: If7f24fa8a99bfd7a8daa2efad926b06350d5d9a6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 735616
Reviewed-on: https://chromium-review.googlesource.com/545715Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481877}

Following bot results are included.
510 511 520 523 525 531 543 544

Skipped some results due to instabilities of the bot.

1341 lines removed by 12 consecutive passes since 495 (Jun 20.)

BUG=591099
TBR=eae@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2951063002
Cr-Commit-Position: refs/heads/master@{#481876}

This removes the plumbing in LogoBridge for using components/doodle.
The actual components/doodle code will be deleted separately later.

TBRing deletion of the c/b/doodle folder (which I in fact own, but the
commit queue doesn't seem to care :)
TBR=jochen

Bug: 690467
Change-Id: Ie9b52bb3ab79f14795cbdd70d3fba4b9ada5032f
Reviewed-on: https://chromium-review.googlesource.com/544311
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481875}

https://skia.googlesource.com/skia.git/+log/eb64b9b201d0..f3b9d4b033a6

$ git log eb64b9b20..f3b9d4b03 --date=short --no-merges --format='%ad %ae %s'
2017-06-22 halcanary SkPDF: add some TRACE_EVENTs
2017-06-22 mtklein fix repeat/mirror sampling bleed
2017-06-22 jvanverth Remove static initializer restriction for Vulkan tests
2017-06-22 jvanverth Blacklist TransferPixelsTest on NVIDIA Shield
2017-06-22 ethannicholas Revert "Revert "clean up sksl dead variable handling""

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=halcanary@chromium.org

Change-Id: I7659925327b24524ad321b46f4669de9266f994d
Reviewed-on: https://chromium-review.googlesource.com/545456Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481874}

This was a subclass purely because WindowTargeter implements
EventTargeter functions in a protected block. Given it is expected
that WindowTargeter is an EventTargeter and EventTargeter is not an
implementation detail it seems the overrides should be in the public
section.

BUG=none
TEST=none

Change-Id: Ib93232ad50a072a63a4beb982e9f265a606b6cbe
Reviewed-on: https://chromium-review.googlesource.com/544680Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481873}

Mention that env var overrides don't work in Google Chrome builds.

BUG=710575

Review-Url: https://codereview.chromium.org/2958463002
Cr-Commit-Position: refs/heads/master@{#481872}

This CL:
- incorporates the feedback (see linked bug) that
  memory_benchmarks.md doesn't mention where to find the trace files on
  perf dashboard.
- adds
  "memory:chrome:all_processes:reported_by_chrome:net:effective_size_avg"
  string in a comment in url_request_context.h, so it's greppable in
  code and makes it easier to find where the metric comes from.

BUG=734619

Review-Url: https://codereview.chromium.org/2952203002
Cr-Commit-Position: refs/heads/master@{#481871}

TBR=msramek@chromium.org
NOTRY=true

Bug: 736345
Change-Id: I74ec229f350a540aa6641d8e0b53c36b4af4498e
Reviewed-on: https://chromium-review.googlesource.com/545615Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481870}

This cl adds a is_video_suggestions field to the ContentSuggestions class and the Java equivalent SnippetArticle.
The field is set based on the content_type of a RemoteSnippet. RemoteSnippet is now supporting the content_type field of suggestions sent by the server.

Bug: 735072
Change-Id: I02401c2856bb2ff3c7bb95cc4cb91e67dc464e0d
Reviewed-on: https://chromium-review.googlesource.com/543142
Commit-Queue: Markus Heintz <markusheintz@chromium.org>
Reviewed-by: vitaliii <vitaliii@chromium.org>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481869}

Smart Go/Next brings better user experience to the user during form submitting applications.
For navigating between form elements, user can use NEXT/PREVIOUS button from IME
without touching on individual fields. This will avoid unnecessary form submissions before
filling or visiting all fields in the form.

Additionally it will save user time and avoid redundant network requests before actually
filling/attending entire fields in the form

Design Document: https://docs.google.com/document/d/1h0diigZ8LUi7A3UKJ_zwNUbvNQoe-Nwr55_p6ivSPNg/edit?usp=sharing

Initial patch is reviewed @ https://codereview.chromium.org/2839993002/

BUG=410785,648986, 733222

Review-Url: https://codereview.chromium.org/2948593002
Cr-Commit-Position: refs/heads/master@{#481868}

There's no need to go through an intermediate SharedBuffer, because we
start with a flat Vector<char> in FontPlatformData::OpenTypeTable().

Refactor the validation code to use Vector<char> instead of
SharedBuffer.

BUG=728627

Change-Id: I81892c0c5c42b4f2e2abdeeabaca20979cd60eeb
Reviewed-on: https://chromium-review.googlesource.com/544317Reviewed-by: Ben Wagner <bungeman@google.com>
Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481867}

Before, we'd clear the cached data when the refresh request failed due
to e.g. missing network connectivity. Now, we keep the cache in that
case. We still clear the cache if the server responds with an HTTP
error, or when it returns invalid/unexpected data.

Bug: 583292
Change-Id: I974ec774591d77bb11417a7cafdb511934250fcb
Reviewed-on: https://chromium-review.googlesource.com/541357
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481866}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a7e622ba..753d46ee

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2949103007
Cr-Commit-Position: refs/heads/master@{#481865}

BUG=730589

Review-Url: https://codereview.chromium.org/2947853002
Cr-Commit-Position: refs/heads/master@{#481864}

Before this CL the base lexer treated comments as tokens and the base
parser had some custom rules to handle special comments like
copyrights. Blink's lexer/parser needed to extend the base lexer/parser
to remove comments as otherwise comments must be explicitly included
in the grammar. Since the base parser is only used by Blink and Blink
doesn't need comments (at least now), it makes sense to ignore comments
in the base lexer/parser. This enables us to remove all custom rules
from BlinkIDLParser.

BUG=617899

Change-Id: I6ead510680457dfb13ed9797ac056c34c185e292
Reviewed-on: https://chromium-review.googlesource.com/544424
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481863}

TBR=foolip@chromium.org
NOTRY=true

Bug: 736255
Change-Id: I5c44e037aa86f8de3060f97cc9326544a79f12c0
Reviewed-on: https://chromium-review.googlesource.com/545278Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481862}

This is very similar to the ExpeditedDispatcher except you can pause
and resume requests.

Bug: 
Change-Id: Ia53d4187d97e2c263fb46a14e970083f4da10ada
Reviewed-on: https://chromium-review.googlesource.com/545001Reviewed-by: Eric Seckler <eseckler@chromium.org>
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481861}

Happened to notice that this code is no longer used anywhere. It was
added in https://chromiumcodereview.appspot.com/12380006, where it was
used by PushMessagingAPI. However, the push messaging implementation no
longer uses this class.

TBR=thakis

Change-Id: I41c427f1a539ac7ed5e0f8b7e6c2cd49b19564b9
Reviewed-on: https://chromium-review.googlesource.com/539455Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Peter Williamson <petewil@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481860}

In usual cases, ResourceFetcher::StopFetching and ClearContext are
called by DocumentLoader or FrameLoader in the disposal sequence.

But, when we use WorkerFetchContext by enabling off-main-thread-fetch,
ResourceFetcher is owned by WorkerFetchContext instead of Loaders.
Thus, ResourceFetcher isn't finalized correctly.

This patch runs ResourceFetcher finalization steps in
WorkerOrWorkletGlobalScope instead of Loaders so that
WorkerOrWorkletGlobalScope can be disposed safely even in the case
of having active loading tasks on GC collecting it.

This problem can be observed in the layout test,
http/tests/serviceworker/chromium/stop-worker-during-respond-with.html,
when off-main-thread-fetch feature is enabled. But test itself can pass
on the head.

BUG=735410

Change-Id: Ib5526b0e35c0ebe9a55589f0ff44e0180db19f91
Reviewed-on: https://chromium-review.googlesource.com/544637
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481859}

This CL improves some fetcher-related tests located in remote
suggestions provider unittests. The ones, which duplicate
RemoteSuggestionsFetcherTest, were removed. The ones missing there were
moved there. Some were adapted to test provider bit only.

This is preparation for using only MockFetcher in provider tests.

Bug: 733129
Change-Id: If344dd064dce40e1a7231edf3c443693466784a4
Reviewed-on: https://chromium-review.googlesource.com/544989Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481858}

These are no longer being used.

BUG=721921

Review-Url: https://codereview.chromium.org/2897213002
Cr-Commit-Position: refs/heads/master@{#481857}

This will be needed to implement fetch API preloading support.

Bug: 652228
Change-Id: Icc7719a137731552cce5613fe006097d657af7ef
Reviewed-on: https://chromium-review.googlesource.com/544377Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481856}

Now that Google App Launcher has been deprecated, there's nothing left
to be cleared.

Bug: 721921,227636
Change-Id: I32cf9f3ea7b458f80ef91e24984db379d9abe4cb
Reviewed-on: https://chromium-review.googlesource.com/544848
Commit-Queue: Peter Lee <pkl@chromium.org>
Commit-Queue: Louis Romero <lpromero@chromium.org>
Reviewed-by: Louis Romero <lpromero@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481855}