- 19 Jun, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/200c69540dc7..fd4e0560a28b Created with: gclient setdep -r src-internal@fd4e0560a28b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:849505,chromium:790246 TBR=huangdarwin@google.com,sdy@google.com,alancutter@google.com,tschumann@google.com Change-Id: Ib80946cb7f6bf9f0a9942279f1493a1ea50111ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666555Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#670354}
-
rbpotter authored
If the user's preferred language for the selected Google Cloud Print (GCP) account does not match the language for the Chrome UI, the names and descriptions of cloud printers will appear in the account's preferred language, mismatching the langauge of the rest of the UI. This also means these printer names/descriptions are not searchable in the Chrome UI language, which is confusing. Send the locale as a query parameter in cloud print requests so that the GCP server sends printer names and descriptions in the appropriate language. Note: the Accepts-Language header is ignored by the GCP server. Bug: 974869 Change-Id: Ia63432d2ef83206a7985f38bf83f88ae6a24b63b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663400 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#670353}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/32d718f3e81e..9a4bd48d5f0c git log 32d718f3e81e..9a4bd48d5f0c --date=short --no-merges --format='%ad %ae %s' 2019-06-19 jiawei.shao@intel.com Allow overwriting angle_root in non-Chromium GN configurations 2019-06-18 jmadill@chromium.org Revert "Vulkan: Add missing command pool reset." 2019-06-18 ynovikov@chromium.org Switch ANGLE Win and Linux CI bots to builderless. 2019-06-18 geofflang@chromium.org GL: Add extensions to enable hardware video decode on Android. Created with: gclient setdep -r src/third_party/angle@9a4bd48d5f0c The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:973992,chromium:967410 TBR=jonahr@google.com Change-Id: I0b5158eee0a856d7535f3c43c06f4831ee068157 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666558Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#670352}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/342f98b11765..b7a3e3f5c42a git log 342f98b11765..b7a3e3f5c42a --date=short --no-merges --format='%ad %ae %s' 2019-06-18 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 8639acbe..619b0737 (670130:670258) 2019-06-18 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision bf62d746..8639acbe (669828:670130) 2019-06-18 sprang@webrtc.org Allow RtpPacketHistory encapsulator function to abort retransmit 2019-06-18 oprypin@webrtc.org Roll chromium_revision 6ae0f0cd..bf62d746 (669703:669828) + fix AndroidManifest 2019-06-18 perkj@webrtc.org Fix potential signed overflow in IntervalBudget::set_target_rate_kbps Created with: gclient setdep -r src/third_party/webrtc@b7a3e3f5c42a The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:None,chromium:891996,chromium:none TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Icb31e172bfaf0aa5d79cbb0750c93ec10578be47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666557Reviewed-by:
-
Chirantan Ekbote authored
Bug: None Change-Id: I777c8962ae3e4fe3db8531e461f83b179363ee0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646798 Auto-Submit: Chirantan Ekbote <chirantan@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Chirantan Ekbote <chirantan@chromium.org> Cr-Commit-Position: refs/heads/master@{#670350}
-
Tim Song authored
The redesigned Clear All button is now shown at the top in the notification stacking bar, so remove the bottom button. BUG=952557 Change-Id: I4f471141094a01dc9cbc5b69f49cf87d69780097 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659535Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#670349}
-
Peter Kasting authored
This also moves ShowSystemMenuAtPoint() from gfx (why was it there?) to views. BUG=none TEST=Hit alt-space; system menu should appear below the tabstrip. Change-Id: Iba2ca9fc54746f253ef7d61ed5b190d61de47f5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1049063Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#670348}
-
Ahmed Fakhry authored
This effectively disables the feature in tablet mode if entered before creating more than one desk. BUG=976442 TEST=Manual, added a new test. Change-Id: I38966dd59cf0eb76873958ca0fb4472c9bf5a53f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666548 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#670347}
-
Tom Anderson authored
Implements (most of) menus for use in DBus status icons. Still left is adding a default "click-action" item to the menu and showing a native menu when the server does not support menus. BUG=419673 R=thestig Change-Id: Idc340581b9960ed9769b98857820eb8ab4a1c87f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654489 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
Darwin Huang authored
This test was failing on https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/13544 TBR=akihiroota@chromium.org,aboxhall@chromium.org Bug: 976105 Change-Id: I52a6f9a792d7e47acc5caff9143529333221e33c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666440 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#670345}
-
Robert Ogden authored
- PLM observer - Histograms - Context Menu - DRP Server LoFi Triggering - ServerLoFi Blink code Bug: 944286 Change-Id: I05de571209c85d6fb24dd47074b26b5ed171e190 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652012 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#670344}
-
dpapad authored
This is addressing a TODO in the code that is no longer blocked. Bug: None Change-Id: Ifb42f374c4461dc490194651eae88101dd15b818 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654192Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#670343}
-
Brian Sheedy authored
Suppresses several failures that started popping up in the Skia Gold pixel tests on Windows after several blank images where marked as negative. TBR=kbr@chromium.org Bug: 974380, 835867 Change-Id: I4f0fec24dce1d18154be0ec4ef44f64c3732cdae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666531Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#670342}
-
Maggie Chen authored
Bug: 949839 Change-Id: I418e39d621ab7ab294fd00ee2618234341dbf287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661216Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#670341}
-
Will Cassella authored
Each check for hardware availability was very similar, this CL introduces helper methods which reduce code duplication as much as possible, making it easier to add new device types in the future. This CL also attempts to consolidate conditional compilation where possible. Bug: 968295 Change-Id: I9ed3c02251ed886156d46f3bbd70af7866a53cf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642392Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Will Cassella <cassew@google.com> Cr-Commit-Position: refs/heads/master@{#670340}
-
dpapad authored
Also replace a few usages of bind(this) with arrow functions. Bug: 747596 Change-Id: I498eda4d6b4667900eab27f3c69287b9deb02508 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663185Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#670339}
-
Zhenyao Mo authored
BUG=974713 TEST=compile R=sunnyps@chromium.org Change-Id: Icb9bbb7896fbd2994c0e1936b798e48eb7ab4f13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666612 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Auto-Submit: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#670338}
-
Takumi Fujimoto authored
Update expiration dates, or add one if the histogram doesn't already have one. For histograms that we still need, set the expiry to M85, which is around a year from now. Bug: 976053 Change-Id: Icb71ebf6137b40644cb63976682cdf3437ec2948 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663074Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#670337}
-
Tom Anderson authored
Wanted for this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1654489/ BUG=419673 R=thestig Change-Id: I7a2ecd8e443929ff38b08c16558eb210ca2308d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666528 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
Alexey Baskakov authored
It disables BookmarkAppInstallManager code path (with BookmarkAppHelper inside). It enables unified WebAppInstallManager and InstallFinalizer infrastructure. Bug: 915043 Change-Id: Id77289a7b6b51681b8833d9c83d7a9657c1af624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627847 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#670335}
-
Ben Pastene authored
Forgot this bit in https://chromium-review.googlesource.com/c/chromium/src/+/1663023 R=dpranke, jbudorick Bug: 932269 Change-Id: I8f5df4581265fa55e57a3cbcfc2293518c4c3f31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666330 Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#670334}
-
Livvie Lin authored
References to this unused field were deleted in https://chromium.googlesource.com/chromium/src.git/+/84c5e49b65ef24c2c0acbc8b631138c2e7d41cb1. Bug: 960113 Change-Id: Ic72e8ad8da55bc98e6070002973a57400dae323c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665897Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#670333}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b00478d5. With Chromium commits locally applied on WPT: 9e3affdd "Ship `referer` header length limitation." 3d4f72a8 "Worker: Add service worker interception tests for shared workers" 043af69d "WebSocket: stop removing an iframe in onerror from crashing" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I816cfb41c30a266e20368e2f5f8e943b18e005d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666368Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#670332}
-
Tim Song authored
When ChromeVox is enabled, Search+Space simulates a mouse press, which was not being forwarded properly to the child contents in NotifierSettingsView. TEST=manually verified BUG=897974 Change-Id: I13a738034891ac7d073c30d86daa3a3e98e321ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666309Reviewed-by:
-
Lukasz Anforowicz authored
This CL replaces strict-equality comparisons like if (url == GURL(content::kAboutSrcDocURL)) ... with if (url.IsAboutSrcdoc()) ... Unlike the old code, the new code correctly handles about:srcdoc#ref and other corner-cases (see gurl_unittest.cc for more examples). Note that in the long-term URLs like about:srcdoc#ref should not be encountered in practice (see https://crbug.com/974300), but for now such navigations are still possible (e.g. frames can directly navigate to about:srcdoc#ref by setting window.location). Using IsAboutSrcdoc instead of strict-equality should correctly account for the current implementation state (and should remain correct in the long-term). To prevent reoccurence of strict-equality comparisons, the CL also removes the content::kAboutSrcDocURL constant. Bug: 973922 Change-Id: I2bd80c82c395a4659ccb50f4caf236baa5ad3c8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659195 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#670330}
-
Dana Fried authored
Most of our Views class properties are of type ClassProperty<T*> where T is a value type, but we're forced to use pointers because T can be of any type and must therefore be allocated on the heap. This leads to a lot of code like: my_view->SetProperty(kMarginsKey, new Insets(kMyViewDefaultInsets)); ... *my_view->GetProperty(kMarginsKey) = new_insets; (The latter pattern is to prevent a second heap allocation - but only works if the initial allocation happens; otherwise it crashes.) This CL shortcuts this behavior so that it behaves in the way we actually want to use the system 90% of the time: // Allocates a copy of kMyViewDefaultInsets for the property. my_view->SetProperty(kMarginsKey, kMyViewDefaultInsets); // Updates the value of the existing property. my_view->SetProperty(kMarginsKey, new_insets); // De-allocates the existing property value. my_view->ClearProperty(kMarginsKey); In order to use this new functionality: - The property must be an owned property of pointer type. - The property type behind the pointer must be copy- or move-assignable. Change-Id: Idec1d5b9c104814f234270214b615774fa5a7084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657288Reviewed-by:
-
Piotr Bialecki authored
XRPlaneSet is a readonly setlike<XRPlane>. Change-Id: Ifefac1ff5f04a5d52dfb80828b2a2c769c62ebf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663456 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#670328}
-
John Budorick authored
Bug: 790202 Change-Id: Ibeec43f1c538754af0538dbf73173f0c52eb7e55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666228Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#670327}
-
Sébastien Séguin-Gagnon authored
Those are fundamental histograms that will be used for the foreseeable future. Bug: 975368 Change-Id: Iad08b86e0d3b4738ff5562b3217808f7e0974dc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662994Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Commit-Queue: Tanya Gupta <tgupta@chromium.org> Cr-Commit-Position: refs/heads/master@{#670326}
-
Peng Huang authored
Bug: 973413 Change-Id: I9edcc776485bbb21af5631b6db3c02bbb7723b4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664204 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
-
Kunihiko Sakamoto authored
These are still useful to have around. Bug: 975822,975867,975217,975462,975703 Change-Id: Ie355963173d7561e6b82fd0d26e7c6ed85b9b60d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663481Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#670324}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/49131ca238de..764ec87e51cd git log 49131ca238de..764ec87e51cd --date=short --no-merges --format='%ad %ae %s' 2019-06-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (nontrivial). Created with: gclient setdep -r src/third_party/depot_tools@764ec87e51cd The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I079f173d5881c22cebeee1c21136c07ebbf22921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665295Reviewed-by:
-
Kunihiko Sakamoto authored
Bug: 975025 Change-Id: I8436aff3e4a9d4fd96ce42513a746cc1fbc71e74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663880Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#670322}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/40ee745abc3b..4e5c106f96c4 git log 40ee745abc3b..4e5c106f96c4 --date=short --no-merges --format='%ad %ae %s' 2019-06-18 jclinton@chromium.org Update reasons that moblab-generic-vm is experimental Created with: gclient setdep -r src/third_party/chromite@4e5c106f96c4 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I2998b7bc14e8272f1fe8db33553274ff660ba3f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666170Reviewed-by:
-
Tarun Bansal authored
flaky test Change-Id: Ie570dcde651f4f85530fa5c8cdd2b0cdf5b7ee75 Bug: 974895 TBR: rajendrant@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666550Reviewed-by:
-
Tom McKee authored
The Element Timing specification originally included a provision for reporting timings of elements that were automatically detected as 'important'. This would allow useful information from the Element Timing API to be reported through the Performance Timeline even if site authors neglected to mark their important elements with the 'elementtiming' attribute. The automatic detection of 'important' elements is, necessarily, a heuristic and, until consensus for the correct heuristic had been reached, we were treating any image that occupied greater than %15 of the viewport as 'automatically important'. As the Element Timing specification is still being refined, the exact threshold and heuristic is still being investigated. Until agreement on an appropriate heuristic is reached, implicit registration will be disabled. This CL removes our %15 threshold and disables implicit registration. There was also WPT coverage to test that all browsers would respect the %15 threshold so that test is being removed too. Change-Id: I14847533402f5a68bb3de63a8f9acbd004c5a8e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643379Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Tom McKee <tommckee@chromium.org> Cr-Commit-Position: refs/heads/master@{#670319}
-
Robert Ogden authored
* Tab visibility * ECT * Bloom filter blacklisting Still remaining: * Preconnect to origin * Browser tests Bug: 971918 Change-Id: I00d265ae1e4f4a1aeca017edad9d6cacd9c0e018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665852Reviewed-by:
-
Kristi Park authored
Delete the CerseiFakeboxOnNtp fieldtrial and move the most likely to launch variant to OmniboxBundledExperimentV1. Bug: 958655 Change-Id: If9eec80b57454424344bea8930b132e6255bca91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664971 Auto-Submit: Kristi Park <kristipark@chromium.org> Commit-Queue: Nik Bhagat <nikunjb@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/88825299a7d4..200c69540dc7 Created with: gclient setdep -r src-internal@200c69540dc7 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:849505,chromium:790246 TBR=huangdarwin@google.com,sdy@google.com,alancutter@google.com,tschumann@google.com Change-Id: I1e516469551f6e709816eb1769e5570bf780ae1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666169Reviewed-by:
-
Steve Anton authored
These histograms are useful to identify and monitor any critical SRTP-related regressions across the ecosystem. Bug: 975885 Change-Id: I9d2b37a9e5efd05c06daf50668a7d6cfd1c8dc7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665652 Auto-Submit: Steve Anton <steveanton@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Steve Anton <steveanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#670315}
-
