- 08 Aug, 2011 5 commits
-
-
dmazzoni@chromium.org authored
scale of these parameters in the TTS API, the conversion to Chrome OS values was done incorrectly and this fixes it. BUG=91883 TEST=manual testing Review URL: http://codereview.chromium.org/7550049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95781 0039d316-1c4b-4281-b951-d872f2087c98
-
hashimoto@chromium.org authored
BUG=None TEST=None Review URL: http://codereview.chromium.org/7563004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95780 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome://settings/cookiestzik@chromium.org authored
BUG=88644 TEST='BrowsingDataQuotaHelperTest.*' Review URL: http://codereview.chromium.org/7387007 TBR=tzik@chromium.org Review URL: http://codereview.chromium.org/7491085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95779 0039d316-1c4b-4281-b951-d872f2087c98
-
yusukes@google.com authored
BUG=None TEST=None Review URL: http://codereview.chromium.org/7583030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95777 0039d316-1c4b-4281-b951-d872f2087c98
-
zork@chromium.org authored
BUG=None TEST=None Review URL: http://codereview.chromium.org/7572015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95774 0039d316-1c4b-4281-b951-d872f2087c98
-
- 07 Aug, 2011 9 commits
-
-
thakis@chromium.org authored
The previous increase made almost all interactive_ui_tests pass in Debug, but DevToolsSanityTest.TestShowScriptsTab DevToolsSanityTest.TestScriptsTabIsPopulatedOnInspectedPageRefresh are still failing. They used to take 23.3s and 24s with gcc, and the DevToolsSanityTests got about 5s slower in Debug on 10.5 (less on 10.6). BUG=91371 TEST=none TBR=phajdan.jr Review URL: http://codereview.chromium.org/7583029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95771 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
This is to test if the browser_test and interactive_ui_test failures on the mac dbg builds after the switch to clang are due to tests narrowly missing their timeout -- that's what it looks like locally. BUG=91371 TEST=none TBR=phajdan.jr Review URL: http://codereview.chromium.org/7569033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95770 0039d316-1c4b-4281-b951-d872f2087c98
-
davemoore@chromium.org authored
BUG=None TEST=None TBR=achuith@chromium.org Review URL: http://codereview.chromium.org/7541067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95768 0039d316-1c4b-4281-b951-d872f2087c98
-
dhollowa@chromium.org authored
Cycle bots BUG=none TEST=none Review URL: http://codereview.chromium.org/7569032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95766 0039d316-1c4b-4281-b951-d872f2087c98
-
jar@chromium.org authored
Clean up macros which do one-time initialization of static pointer to histograms to use subtle atomic operators. r=willchan, dvyukov BUG=7535006 Review URL: http://codereview.chromium.org/7535006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95762 0039d316-1c4b-4281-b951-d872f2087c98
-
dhollowa@chromium.org authored
Suppresses leaks introduced with r95607 related to BrowsingDataQuotaHelper. Generalizing suppressions. BUG=91836 TEST=Valgrind and HeapCheck bots turn green. TBR=tzik@chromium.org Review URL: http://codereview.chromium.org/7584025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95761 0039d316-1c4b-4281-b951-d872f2087c98
-
dhollowa@chromium.org authored
Suppresses leaks introduced with r95572 related to BrowserAccessibilityManager. Another suppression. BUG=91845 TEST=Valgrind and HeapCheck bots turn green. TBR=dtseng@chromium.org Review URL: http://codereview.chromium.org/7541066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95760 0039d316-1c4b-4281-b951-d872f2087c98
-
dhollowa@chromium.org authored
Suppresses leaks in WebIntentsRegistry introduced in r95710. BUG=91950 TEST=Tests go green on Valgrind and HeapCheck bots. TBR=groby@chromium.org Review URL: http://codereview.chromium.org/7491082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95756 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
BUG=none TEST=none TBR=rsleevi Review URL: http://codereview.chromium.org/7491081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95755 0039d316-1c4b-4281-b951-d872f2087c98
-
- 06 Aug, 2011 26 commits
-
-
thakis@chromium.org authored
displayName is set to initialName in -[BookmarkEditorBaseController awakeFromNib], and initialName is [@"" retain]. This seems to return a new object with clang but the same object with gcc. Not relying on internalized strings seems cleaner in general. BUG=none TEST=tree goes green TBR=mrossetti Review URL: http://codereview.chromium.org/7569030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95753 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95752 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
BUG=7229 TEST=1- Launch Chrome Task Manager and select any process/puglin in the window. 2- Hit Alt E(/e) to kill that process. R=evan@chromium.org Review URL: http://codereview.chromium.org/7582025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95751 0039d316-1c4b-4281-b951-d872f2087c98
-
nkostylev@chromium.org authored
Based on a patch by altimofeev http://codereview.chromium.org/7461117/ BUG=chromium-os:17892 TEST=manual Review URL: http://codereview.chromium.org/7520037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95750 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
BUG=none TEST=none TBR=rsleevi Review URL: http://codereview.chromium.org/7491080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95747 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
BUG=none TEST=none TBR=rsleevi Review URL: http://codereview.chromium.org/7583027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95746 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/7584023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95744 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95739 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
To get my trivial fixes of base/md5.h BUG=None TEST=None R=thestig@chromium.org Review URL: http://codereview.chromium.org/7584022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95738 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-release@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95734 0039d316-1c4b-4281-b951-d872f2087c98
-
isherman@chromium.org authored
BUG=none TEST=browser_tests --gtest_filter=FormManagerTest.MultipleLabelsPerElement Review URL: http://codereview.chromium.org/7541059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95732 0039d316-1c4b-4281-b951-d872f2087c98
-
cevans@chromium.org authored
BUG=72492 Review URL: http://codereview.chromium.org/7572046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95731 0039d316-1c4b-4281-b951-d872f2087c98
-
darin@chromium.org authored
R=rvargas@chromium.org Review URL: http://codereview.chromium.org/7569005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95730 0039d316-1c4b-4281-b951-d872f2087c98
-
darin@chromium.org authored
TBR=vrk@chromium.org Review URL: http://codereview.chromium.org/7541061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95729 0039d316-1c4b-4281-b951-d872f2087c98
-
mseaborn@chromium.org authored
This is needed for testing Native Client's support for Breakpad on x86-64. However, ultimately crash_service is only used for testing (Google Update's crash reporter is what is used in an installation of the official Chrome build). Initially, crash_service.exe will only work on x86-32 processes, and crash_service64.exe will only work on x86-64 processes. Eventually we will want to make crash_service64.exe work for both 32-bit and 64-bit processes. It might not be possible to make crash_service.exe work on 64-bit processes because Windows' ReadMemory() function only works on 64-bit target processes if the caller is a 64-bit process. BUG=89730 TEST=NaCl's run_inbrowser_trusted_crash_in_startup_test Review URL: http://codereview.chromium.org/7541057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95728 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95727 0039d316-1c4b-4281-b951-d872f2087c98
-
mseaborn@chromium.org authored
This pulls in the following Native Client changes: r6323: (mseaborn) sel_universal: Clean up usage of threads a little r6324: (jvoung) Fix pnacl_coordinator's usage of undefined var_arg behavior (broke on Windows) r6325: (krasin) service_runtime: remove nacl_bottom_half because it's a dead code. r6326: (robertm) This will allow us to do proper book-keeping of PPB_Core_AddRefResource and r6327: (robertm) Make the pepper event loop more versatile, i.e. allow for polling and time limits. r6328: (krasin) Revert r6325 due to build break (service_runtime: remove nacl_bottom_half because it's a dead code) r6329: (robertm) Revert 6326 which fails memcheck r6330: (mseaborn) Cleanup: Remove unused function NaClThreadKill() r6331: (mseaborn) Cleanup: Remove help string for sel_ldr's '-I' option (which was removed in r6280) r6332: (thakis) Fix a compiler warning. r6333: (robertm) Add a few more tests to url_loader and some cleanup r6334: (robertm) Resubmit of rev6326 after fixing memcheck issue r6335: (mcgrathr) Parameterize in-tree test links' use of libraries r6336: (krasin) service_runtime: remove nacl_bottom_half because it's a dead code. r6337: (jvoung) Update compiletime perf expectations for benchmarks that compile faster r6338: (mseaborn) Cleanup: Rename ARM's NaClGetSp() to NaClGetStackPtr() for consistency r6339: (ncbray) Refactored ppapi_bad test to dynamically create the embed tags it uses as it runs. BUG=none TEST=trybots Review URL: http://codereview.chromium.org/7583017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95726 0039d316-1c4b-4281-b951-d872f2087c98
-
achuith@chromium.org authored
Put common code in hr.shadow class. BUG=chromium-os:18807 TEST=Top and bottom lines should not be present in gaia signin screen. Review URL: http://codereview.chromium.org/7569021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95725 0039d316-1c4b-4281-b951-d872f2087c98
-
vrk@chromium.org authored
This CL implements the proxy necessary for out-of-process video decoding and introduces a shared base class between the PPB_VideoDecoder_Impl and the proxy. BUG=NONE TEST=gles2 plugin runs with or without --ppapi-out-of-process flag, no crashes Review URL: http://codereview.chromium.org/7545014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95724 0039d316-1c4b-4281-b951-d872f2087c98
-
sreeram@chromium.org authored
When suggest has been disabled, omnibox text is not sent to the default search engine. Instant's field trial should also be disabled in such a case, to avoid sending the omnibox text due to Instant. Note that if the Instant experiment has already been enabled, and *then* the user disables suggest, this won't disable the experiment immediately (since we don't listen for changes to prefs::kSuggestEnabled). Instead, it will be disabled at the next opportunity (some Instant pref changing, browser restart, etc). I think this is acceptable since, if the user is fiddling with preferences after Instant has been enabled, they can already click the Instant checkbox to turn it off. BUG=91730 TEST=Disable suggest. Verify that the Instant field trial doesn't get enabled. Review URL: http://codereview.chromium.org/7578014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95723 0039d316-1c4b-4281-b951-d872f2087c98
-
vandebo@chromium.org authored
BUG=91862 TEST=NONE Review URL: http://codereview.chromium.org/7585012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95722 0039d316-1c4b-4281-b951-d872f2087c98
-
mmenke@chromium.org authored
PrerenderManager::GetAsValue(). NetInternalsTest.NetInternalsPrerenderView expects to always see the prerender as active or in the history, once started. BUG=91799 TEST=NetInternalsTest.NetInternalsPrerenderView (Currently flaky) Review URL: http://codereview.chromium.org/7550031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95721 0039d316-1c4b-4281-b951-d872f2087c98
-
pucchakayala@chromium.org authored
passwords.PasswordTest.testInfoBarDisappearByNavigatingPage BUG=91887 Test=Run above Review URL: http://codereview.chromium.org/7583020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95720 0039d316-1c4b-4281-b951-d872f2087c98
-
piman@chromium.org authored
The API is very simple at this point but works end-to-end. BUG=None TEST=VideoCapture sample (in a later CL) Review URL: http://codereview.chromium.org/7553003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95719 0039d316-1c4b-4281-b951-d872f2087c98
-
aocampo@chromium.org authored
- Modified enterprise_helper_linux script to handle changing file permissions for multiple json files. BUG=NONE Review URL: http://codereview.chromium.org/7453062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95718 0039d316-1c4b-4281-b951-d872f2087c98
-
mseaborn@chromium.org authored
Change crash_service.exe so that the named pipe it listens on (normally global) and the directory it writes to (normally per-user) can both be overridden via command line options. Similarly, add an environment variable to Chromium for connecting to crash_service.exe via a non-default named pipe. This will allow automated tests of Chromium's Breakpad crash reporting to be more robust. A test runner can use a temp dir for crashes and a temporary named pipe, so that it does not have to worry about pre-existing instances of crash_service.exe or pre-existing dump files. BUG=http://code.google.com/p/nativeclient/issues/detail?id=2006 TEST=inbrowser_crash_test in the NaCl tree, with the change http://codereview.chromium.org/7569002 Review URL: http://codereview.chromium.org/7538036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95714 0039d316-1c4b-4281-b951-d872f2087c98
-