- 18 Jun, 2020 40 commits
-
-
Victor Hugo Vianna Silva authored
crrev.com/c/2246157 is suspect of causing failures in CrSettingsPasswordsSectionV3Test. This could be caused by click events in the new tests not being flushed, so this CL adds missing flush() calls. Bug: None Change-Id: I3abff7ddb894aa4a3cb3f7cf0dd2a06c7f05ec73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252138 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#779837}
-
Daniele Castagna authored
SurfaceAggregator has an option to output only quads that intersect the damage rect computed by SA itself. crrev.com/c/2205886 re-enabled a SurfaceAggregator optimization for GLRenderer but left it disabled for SkiaRenderer/ This patch enables the optimization for SkiaRenderer. Bug: 925181 Change-Id: I1ad90ab2ec0d3a5b5444350ffadb7c3a5f2469ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250780Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#779836}
-
Sebastien Lalancette authored
The fix is to get the root VC to dismiss our hierarchy. If we simply use the current VC then, when the pop-over is presented, only that pop-over will be dismissed (as per the UIKit documentation and as per this bug). Bug: 1093908 Change-Id: Ia576910873acec1163f54abf8012210d13e016fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241995Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Auto-Submit: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#779835}
-
OlivierLi authored
Bug: 1075553 Change-Id: Ie863e35e110966efa62c4a3eaf8ac4dd4b0fa46e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248072Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#779834}
-
Ali Juma authored
The WKNavigation for a committed interstitial is used in the callback passed to ChromeWebClient::PrepareErrorPage, in order to commit the associated navigation item. For SSL interstitials, this callback is called later, asynchronously. This means that deleting the navigation in didFailProvisionalNavigation later leads to a crash when attempting to access the navigation's item, in the case where the error page load is triggered in didFailProvisionalNavigation. This happens in ErrorRetryStateMachine::DidFailProvisionalNavigation when the current webview URL is a restore_session.html URL. This CL fixes this crash by not deleting the navigation in didFailProvisionalNavigation when it is for a committed SSL interstital. There is already similar logic for deciding whether to delete a navigation in didFinishNavigation. Change-Id: Ib8aabeeeca33f63b313daa0772990b8b841d462a Bug: 1050808 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248137 Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
Livvie Lin <livvielin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#779833}
-
Lucas Furukawa Gadani authored
Bug: 967204 Change-Id: I276e6f8d8bdc3d317f5ce58f138d77601ee3c878 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248059Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#779832}
-
Christian Dullweber authored
The opt-in for account storage of passwords needs to be reset after password deletion is finished and committed to the sync server. Add integration test for password deletion for account storage. Bug: 1052005 Change-Id: I342f60b076a2ee0a7a8dfae0de4341b7ab684cb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250186 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
-
Xiyuan Xia authored
Replace AnimationMetricsReporter with AnimationThroughputReporter to use new code path for smoothness metrics. Bug: 1021774 Change-Id: I1d15a836b43bacb80cc244a840cbe01de6f34ec6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250502Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#779830}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592470587-41d382284b84615cf61150faa274f216b9eaf19d.profdata to chrome-win32-master-1592481559-cd0ac58705eebf31c71fdcab35041388ee8d8f2d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I88e2910db16e04936c763fe84c8b8a01d58a8829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251737Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779829}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/88024df12147e56b6abd66b743ff441a0aaa09a8..c17985424391fcbaaa57f733b7197c5dd3e510aa The following commits have Chromium bugs associated: 251b5169f Assert md_size > 0. The following commits have update notes: cd8f3d36f Enforce the keyUsage extension in TLS 1.2 client certs. Bug: 1092697 Change-Id: I1fe40b43b42a93a1ace5a1cf9f1671aef6665e81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250885 Auto-Submit: David Benjamin <davidben@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#779828}
-
sandromaggi authored
This adds a new method to the |TriggerContext| enabling us to check if a certain experiment is present. Bug: b/158750294 Change-Id: Ibff03efef920c2e9afad6eb0b11a071ff2fa3864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250069 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#779827}
-
Side Yilmaz authored
This CL replaces deprecated functions of IdentityServicesProvider with the newer service getters with profile parameter. Since first run flow only run in regular mode, it is safe to pass always regular profile to IdentityServicesProvider functions. Note: This CL does not make any behaviour change. Bug: 1041781, 1075562 Change-Id: Ibee67f4d13e364613ebd267c77ec2d5981b9458e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241545Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#779826}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2878b9ea5ed3..d70c25298bc8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kolos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: kolos@google.com Change-Id: Iec854c25ab111a72a1ade0f3ebf67e2387a58dfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251735Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779825}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/57f137d71cdf..5ad9ad04a741 2020-06-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from a7112d544b2e to 99651228b238 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: Ice1c0d877358e0e8af94bae97b5163deb0e365e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251736Reviewed-by:
-
Tibor Goldschwendt authored
Previously, we nested the doodle iframe inside a chrome-untrusted iframe because web iframes in WebUIs were not supported. This is possible now. + Remove chrome-untrusted://new-tab-page/iframe as this is no longer needed. Bug: 688960 Change-Id: Ibf3b78097193c51ed05f65a89c9f14d1fbe89ba4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250826 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#779823}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3ef226c9565d..5b621a997903 2020-06-18 lalitm@google.com Merge "tp: remove over-cautious detection of use-after-free in iterators" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Icd792d51bf690504f8008e59ff559a94e19f8714 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251731Reviewed-by:
-
Mustaq Ahmed authored
Bug: 1049456,1080997,1081277 Change-Id: Ia0958f533ade479f523f61f4225b02a883d26122 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250219Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#779821}
-
Mahmoud Gawad authored
Add HTTP PATCH Mojo API support in wilco_dtc_supportd.mojom. Add the HTTP PATCH method to the list of supported HTTP methods in wilco_dtc_supportd mojo client. This enables the requester (wilco_dtc_supportd daemon) to make HTTP PATCH requests instead of receiving errors. BUG=b:159097923 TEST=Added unit test for Patch method (PASS) Change-Id: I1000067f5c3658f80c6046e4ffea9871d49d557d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247030Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Commit-Queue: Mahmoud Gawad <mgawad@google.com> Cr-Commit-Position: refs/heads/master@{#779820}
-
Colin Blundell authored
For the translate infobar WebLayer needs a couple Material Design resources. Allow these as an exception to the exclusion of material design resources in system_webview_apk_tmpl.gni, as without this allowance TriChrome (and presumably standalone WebView)-powered WebLayer crash when showing the translate infobar. I didn't detect this when landing the initial CL enabling translate in WebLayer because the default weblayer_shell build doesn't do this exclusion. Needed resources are the ones referenced here: third_party/android_deps/libs/com_android_support_design/com_android_support_design.info: "res/layout/design_layout_tab_icon.xml", third_party/android_deps/libs/com_android_support_design/com_android_support_design.info: "res/layout/design_layout_tab_text.xml", Bug: 1025620 Change-Id: I63543aaa17b45829897cee999d372aecc156d750 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250109Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#779819}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8514078e455e..55ac3e87d96a 2020-06-18 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I17c42dc78ce2f586c44f7fd5ee2ba4c96a4b7280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252019Reviewed-by:
-
Side Yilmaz authored
This CL changes ImageFetcherBridge behaviour for different profiles. Today, ImageFectherBridge is singleton, so there is only one instance created for one regular and multiple incognito profiles on Android. To avoid data leak between profiles, we need to create different instances for each profile. By this CL; - Each call to |ImageFectherBridge#getForProfile| function creates an instance of ImageFectherBridge that stores profile as member variable. - Each call to any other function of ImageFectherBridge will directly hit the native services through native bridge. - Native image_fetcher_bridge is a wrapper to reach the service that belongs to the given profile. There is no member functions anymore, but all are static. Bug: 1075562, 1041781, 1083923 Change-Id: Ic96d1c8fa1a7bd093abcf8939375f8934fd3cd92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231124 Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
-
Raymond Toy authored
This is the Arm/Neon equivalent of the x86/simd version of the main k-rate processing loop. The Web Audio Bench (100 runs of 10 sec) shows that we have about a 33% improvement in speed (on a Pixel 2). The difference is statistically significant. Without CL: TEST μs MIN Q1 MEDIAN Q3 MAX MEAN STDDEV Baseline 1778 1778 1888 2013 2498 3363 2225.6 437.41 Oscillator 1388 1388 1597 2104 2427 5244 2079.37 581.86 With CL: TEST μs MIN Q1 MEDIAN Q3 MAX MEAN STDDEV Baseline 1757 1757 1863 1955 2378 3280 2164.5 424.23 Oscillator 897 897 1001 1224 1764 4068 1399.1 515.9 Manually ran the tests in webaudio/Oscillator and all tests pass. Bug: 1013118 Change-Id: I738dfc9e9f108ac6a421099c69f11aab7750605f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233003 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#779816}
-
Paul Wankadia authored
https://chromium.googlesource.com/external/github.com/google/re2.git/+log/e9d517989f66..e6613e91b26e $ git log e9d517989..e6613e91b --date=short --no-merges --format='%ad %ae %s' 2020-06-16 junyer Distinguish between missing ')' and unexpected ')'. 2020-06-16 junyer Make RE2::Set and FilteredRE2 movable. 2020-06-15 junyer Herp derp. It's actually constant-time append. Created with: roll-dep src/third_party/re2/src R=thakis@chromium.org CC=mmoroz@chromium.org Change-Id: Idda604a248dd85373905c069aa0db96b9a6c396b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250476 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#779815}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/a84ab4815027..581c407cd20b 2020-06-18 cwallez@chromium.org Fix TypedInteger hash compilation failure with stdlibc++ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I34be8a79c857ec2b08a1b54b373c624e27870132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252018Reviewed-by:
-
Maria Kazinova authored
FormJsTests. This is a small fix to stop tests from hanging forever in case something goes wrong. Change-Id: I334d85e97b0f290ecf011a0b8ef40e1300275aff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238156Reviewed-by:
-
Mikel Astiz authored
No behavioral changes. This patch removes some dead code and in particular the notion of sync IDs from APIs used by models (specific features integrating with sync via SyncableService), as well as obsolete concepts and APIs in SyncChangeProcessor. Change-Id: I2a4654cb295ae070ea3e91cd3bde345cb75ba497 Bug: 923287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249931 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
Alex Ilin authored
Some new strings are not referenced in code yet, but we'd like to upload the final strings ASAP. Bug: 1045515 Change-Id: I6f7a831f4066d27170c80bd600d86392b20f74c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241526 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
-
Harald Alvestrand authored
This CL should make the test run consistently and always finish; we break out early from the test that was failing rather than waiting forever. Bug: chromium:869126 Change-Id: Ic52fbf0dea69a03645165a073354f61a3d28ad81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250065 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#779810}
-
Takashi Sakamoto authored
Bug: 1086388 Change-Id: If3ebac4df104b607d3fd68588263f4ea19a63edc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237501 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#779809}
-
Alice Wang authored
This CL removes the redundant teardown in ShareButtonControllerTest, as the ChromeTabbedActivity is ensured to be destroyed in ChromeTabbedActivityTestRule. Bug: 1083138 Change-Id: Ic33e5b1d08804525d737bab44fe5fdbd4573a470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245625Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#779808}
-
Vikas Soni authored
1. Refactor SharedImageBackingFactoryAHB to pull out GenGLTexture() method into ahardwarebuffer_utils* so that it can be re-used by multiple classes. This will eliminate code duplications in future. 2. Make few private members of gles2::Texture as public since those members were used by too many friend classes. Bug: 1091945 Change-Id: I0e82cd93d431d900fce2787478a97bef19b11eaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249582 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#779807}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/53f973c22a26..81454dfaa92a 2020-06-18 bsalomon@google.com Use hardware wrap mode in perlin noise effects. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: djsollen@google.com Change-Id: I5b8fa92fd1a162b6815daa94db6ccfd26b4b31d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251733Reviewed-by:
-
Marc Treib authored
If EnablePasswordsAccountStorage is enabled, then SaveUpdateBubbleController is not used at all - SaveUpdateWithAccountStoreBubbleController is used instead. This CL adds DCHECKs in both classes about the feature state, and explicitly enables/disables the feature in their unit tests. Bug: 1093310 Change-Id: I7d0d960725053e3371d3a0c81d4f1ce8aa9d22b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249933 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#779805}
-
Colin Blundell authored
I brought in these resources in the initial fork of infobars (https://chromium-review.googlesource.com/c/chromium/src/+/2224869), before I realized that Android resources effectively reside in a global namespace and thus any resources with the same IDs between //weblayer and //chrome will collide in Monochrome. Hence, the //weblayer resources either need to be renamed or shared. As we now already have infobar resources in //components and these resources are unlikely to be changed by WebLayer, it is cleaner to just componentize and share them than rename them. Bug: 1093846 Change-Id: I1f90394109be509488f036ac9ac4a966b2ccccae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250198Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#779804}
-
Robert Sesek authored
It was previously disabled and is now unused. Bug: 925998 Change-Id: I504065c37a4436369021f8f20928f3f071b0f143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250579Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#779803}
-
Hans Wennborg authored
Add direct includes for things provided transitively by logging.h (or by other headers including logging.h). This is in preparation for cleaning up unnecessary includes of logging.h in header files (so if something depends on logging.h, it needs include it explicitly), and for when logging.h no longer includes check.h, check_op.h, and notreached.h. Bug: 1031540 Change-Id: Ib5be18e72766eac66f627569186a2803f5db4cfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249840 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#779802}
-
Maxim Kolosovskiy authored
This reverts commit c3de1340. Reason for revert: IconLoaderBrowserTest.LoadGroup failures. Builder: https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests First failed build: https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/24355?blamelist=1#blamelist-tab Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/1987273 TBR=avi@chromium.org,robliao@chromium.org,wfh@chromium.org Change-Id: I90479f28ef4849c382b28cfdbd40db4b84ad3a69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250202Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I18629d5a41bfdb7e691592c73e9ddb6cc57b88fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251740Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779800}
-
sauski authored
CL changes incorrect usage of IsUserControlled to IsUserModifiable for checking whether a preference could be changed by the user. Also updates test cases that set the user preference to establish a known test state, to instead set default preferences. Bug: 1096471 Change-Id: I5d7fb02e438331e92d91d9d50b36b69250468667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250185Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#779799}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1592459911-64171aa0ec184a29370607ccffd98ff29f1f78e8.profdata to chrome-mac-master-1592481559-9b531f50abff54ae1c92c78422a2cf2d21554f30.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I775e55aaa8a2abf22bb9ea4247359c6594768a3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251734Reviewed-by:
-
