GitLab

R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org
BUG=340522

Review URL: https://codereview.chromium.org/319453002

git-svn-id: svn://svn.chromium.org/blink/trunk@175497 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The "root" translation layer was previously below the overlap controls
host layer. This meant it was actually below the pinch viewport's scale
layer. We really want the root translation layer to be at the root so that
DevTools' screen emulation feature can scale and offset the entire tree.

BUG=370035

Review URL: https://codereview.chromium.org/308183002

git-svn-id: svn://svn.chromium.org/blink/trunk@175496 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=dglazkov@chromium.org
BUG=378610

Review URL: https://codereview.chromium.org/313903002

git-svn-id: svn://svn.chromium.org/blink/trunk@175494 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The test crashes because the createFlingAnimationCurve call hits the int version in Platform.h which is no longer matching the signature in content/test/test_webkit_platform_support.h (and content/child/blink_platform_impl.h). Instead it hits the default one in Platform.h which just returns 0.
Subsequently the WebActiveGestureAnimation calls through the null pointer in WebActiveGestureAnimation::animate.

TBR=rjkroege@chromium.org, jam@chromium.org, ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org
BUG=

Review URL: https://codereview.chromium.org/310413002

git-svn-id: svn://svn.chromium.org/blink/trunk@175493 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL refactors the FrameView methods to be paintInvalidation instead
of repaint.

I have left the repaint rect output to be 'repaint' for now as that
seems like a large and scary rebaseline when it lands.

I also did not change the slowRepaints methods as they were previously
mentioned as not having to do with paint invalidation.

BUG=338691

Review URL: https://codereview.chromium.org/306413002

git-svn-id: svn://svn.chromium.org/blink/trunk@175492 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It helps to troubleshoot messages traffic between DevTools and the inspected page.

BUG=

Review URL: https://codereview.chromium.org/316813003

git-svn-id: svn://svn.chromium.org/blink/trunk@175491 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=vollick@chromium.org

Review URL: https://codereview.chromium.org/313023002

git-svn-id: svn://svn.chromium.org/blink/trunk@175490 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When we run sanitizers like ASAN and LSAN, we typically don't care about whether the tests run exactly like they do normally; we are just looking for errors that the sanitizers have detected.

This flag changes run-webkit-tests to ignore text and image failures and just look for crashes and timeouts (most crashes will be sanitizer-triggered).

In theory most of the time the tests *should* run the same way, but in practice we see a lot of noise that no one has the time to deal with, so this change should reduce a lot of the redness we see on the bots.

BUG=336971, 374043

Review URL: https://codereview.chromium.org/294973008

git-svn-id: svn://svn.chromium.org/blink/trunk@175488 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This reverts commit r174963.
Reason for revert: the patch regressed ::content selectors for distributed
nodes in shadow DOM.

BUG=380414,356999
TBR=vsevik
NOTRY=true

Review URL: https://codereview.chromium.org/311123002

git-svn-id: svn://svn.chromium.org/blink/trunk@175487 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The specification for ready is here:
https://github.com/slightlyoff/ServiceWorker/issues/223

ready is a convenience that lets the page talk to an installed
ServiceWorker, without having to track the details of whether that
Service Worker is controlling the page, or merely installed but
waiting for the page to reload.

This implements the trivial ready case, where the page is
controlled by a Service Worker and ready can produce that one
immediately.

BUG=363967

Review URL: https://codereview.chromium.org/309233002

git-svn-id: svn://svn.chromium.org/blink/trunk@175486 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove the specialized code for tracking wheel events in favor of the
generic EventHandlerRegistry. Covered by existing tests.

See https://codereview.chromium.org/206603002/ for full review history.

BUG=359566,332793
TEST=fast/events/wheelevent-handler-count.html

Review URL: https://codereview.chromium.org/225823007

git-svn-id: svn://svn.chromium.org/blink/trunk@175485 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=none

Review URL: https://codereview.chromium.org/318653003

git-svn-id: svn://svn.chromium.org/blink/trunk@175484 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The test is still very flaky on Windows, and somewhat flaky on other
platforms.

TBR=jchaffraix@chromium.org, yoav@yoav.ws
BUG=380664

Review URL: https://codereview.chromium.org/311133002

git-svn-id: svn://svn.chromium.org/blink/trunk@175483 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=361045
R=caseq@chromium.org

Review URL: https://codereview.chromium.org/311113002

git-svn-id: svn://svn.chromium.org/blink/trunk@175482 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We used to rely on timeline record to timeline category mapping, which is not
entirely correct, since the set of trace events is slightly different. Let's fork
the style map for the time being.

BUG=361045

Review URL: https://codereview.chromium.org/316553005

git-svn-id: svn://svn.chromium.org/blink/trunk@175481 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Allow sub-css-pixel font-sizes and thus smooth font scaling which in
turn allows for stable layout when zooming and drastically improves
readability and font rendering quality on high dpi devices.

This change enabled the experimental subpixel font scaling flag by
default across all supported platforms.

Entry in Chromium Dashboard
  http://www.chromestatus.com/features/6259163214643200

OWP launch tracking bug
  https://code.google.com/p/chromium/issues/detail?id=164167

Intent to ship
  https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/4-f2i7OEWeg

Originally landed as r175192 but reverted as r175308 due to chromeos
test failures.

R=eseidel@chromium.org, dglazkov@chromium.org
BUG=164167

Review URL: https://codereview.chromium.org/315623002

git-svn-id: svn://svn.chromium.org/blink/trunk@175480 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a follow-up fix after r175430.
We don't need to use a PersistentHeapVector on a stack.

BUG=340522

Review URL: https://codereview.chromium.org/316823003

git-svn-id: svn://svn.chromium.org/blink/trunk@175479 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The possible reason of crash seems to be renderer value being null.

R=tkent@chromium.org
BUG=356128

Review URL: https://codereview.chromium.org/318633002

git-svn-id: svn://svn.chromium.org/blink/trunk@175478 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Avoid calling is8Bit() for every character in SelectorChecker's
containsHTMLSpace() by doing the check once at the beginning and then call a
templated containsHTMLSpaceTemplate() for the corresponding character type that
will iterate over the raw string array.

String::operator[] is not ideal here because:
- It checks if the String's StringImpl is non-null
- It does array bound checking
- It calls is8Bit() to access the right raw string array

The new implementation avoids doing these checks for every character in the
string being checked.

I see a 2.5% progression on cssquery-jquery's div[class~=dialog] subtest
(7152.80 -> 7331.60 +/- 0.5%):
http://dromaeo.com/?id=222400,222406

R=esprehn@chromium.org, eseidel@chromium.org

Review URL: https://codereview.chromium.org/307333004

git-svn-id: svn://svn.chromium.org/blink/trunk@175477 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Stop having HTMLNameCollection override HTMLCollection::virtualItemAfter(). It
is not really needed as the same DOM tree traversal code. Instead, we simply
create 2 subclasses called DocumentNameCollection and WindowNameCollection that
define an elementMatches() method that is called from HTMLCollection, similarly
to other HTMLCollection subclasses.

This avoids having a virtual function call, brings support for efficient
backward traversal of these collections and leverages optimizations in
HTMLCollection.

This CL is inspired from WebKit r149652 from rniwa@webkit.org:
http://trac.webkit.org/changeset/149652

R=esprehn@chromium.org, adamk@chromium.org

Review URL: https://codereview.chromium.org/315473002

git-svn-id: svn://svn.chromium.org/blink/trunk@175476 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The MIME type of the JavaScript file in this test has changed. It's the
only failing test on this, so I'm disabling it until Eric can take a look.

TBR=jchaffraix@chromium.org, eseidel@chromium.org
BUG=380649

Review URL: https://codereview.chromium.org/316903002

git-svn-id: svn://svn.chromium.org/blink/trunk@175475 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=357163

Review URL: https://codereview.chromium.org/313023004

git-svn-id: svn://svn.chromium.org/blink/trunk@175474 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch makes it possible to shift-drag resize widgets on responsive
design page to slow down their movement.

BUG=380190

Review URL: https://codereview.chromium.org/312813002

git-svn-id: svn://svn.chromium.org/blink/trunk@175473 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Using BlinkPlatform hides the WebView that requested the lock, making it
very hard to have a clever handling of screen lock on the browser side
given that it's unknown whom and when requested the lock.

It will also allow locking the appropriate screen in a multi-screen
scenario.

BUG=162827

Review URL: https://codereview.chromium.org/315693002

git-svn-id: svn://svn.chromium.org/blink/trunk@175472 bbb929c8-8fbe-4397-9dbb-9b2b20218538

If we skip framework with StepInto after a stepping button was hit in front-end,
we should eventually stop somewhere in the user code. On the other hand, in case of
an Event breakpoint we should not stop at all, if the callback is handled inside the framework.

BUG=267592
R=yurys, pfeldman@chromium.org

Review URL: https://codereview.chromium.org/309013005

git-svn-id: svn://svn.chromium.org/blink/trunk@175471 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Made hoverNode()/setHoveNode() private accessors while converting over
remaining PassRefPtr<Node>/RefPtr<Node> uses to transition types.

R=tkent@chromium.org
BUG=357163

Review URL: https://codereview.chromium.org/311053003

git-svn-id: svn://svn.chromium.org/blink/trunk@175470 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Adds idl files and tests.

Initial patch (1) by tommyw@ from https://codereview.chromium.org/145583015/

BUG=338511

Review URL: https://codereview.chromium.org/286673003

git-svn-id: svn://svn.chromium.org/blink/trunk@175469 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=361045

Review URL: https://codereview.chromium.org/307353004

git-svn-id: svn://svn.chromium.org/blink/trunk@175468 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL also declares VTTTreeBuilder as STACK_ALLOCATED and makes m_currentNode
and m_document traceable.

BUG=357163

Review URL: https://codereview.chromium.org/315843004

git-svn-id: svn://svn.chromium.org/blink/trunk@175467 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=380541

Review URL: https://codereview.chromium.org/311073002

git-svn-id: svn://svn.chromium.org/blink/trunk@175466 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The document() accessor on all Nodes end up touching the document. The
reason is that the document accessor gets the document from the
TreeScope which is often the document itself. Therefore, we cannot
use the document() accessor in Node destructors. Fortunately, there
is a more direct way of checking if the Document has been destructed.
HTMLMediaElement is an ActiveDOMObject which is a
ContextLifecycleObserver. Therefore, ActiveDOMObject::executionContext
will tell us if the Document is still alive so that we can access it.

R=haraken@chromium.org, oilpan-reviews@chromium.org, sigbjornf@chromium.org, zerny@chromium.org

Review URL: https://codereview.chromium.org/310333003

git-svn-id: svn://svn.chromium.org/blink/trunk@175465 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=357163

Review URL: https://codereview.chromium.org/316443004

git-svn-id: svn://svn.chromium.org/blink/trunk@175464 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Since NonThrowableExceptionState, TrackExceptionState, NoExceptionStateAssertionChecker and IgnorableExceptionState create no wrapper, we don't need to fix those exception state with empty context.

We need to fix ExceptionState. To ensure that all ExceptionStates are fixed, added ASSERT to ExceptionState::throwSecurityError and ExceptionState::throwDOMException.

BUG=369451

Review URL: https://codereview.chromium.org/311733003

git-svn-id: svn://svn.chromium.org/blink/trunk@175463 bbb929c8-8fbe-4397-9dbb-9b2b20218538

No substantive changes to generated bindings:
just reorders the constructors on global objects b/c split
between core and modules.

This almost completes splitting the build!
(Only remaining step is to split global objects, at which
point I can eliminate the bindings/generated.gyp)

Global constructors from modules are in bindings_core b/c
they affect core bindings (due to partial interfaces), with
FIXMEs to move them to bindings_modules.

R=haraken
BUG=358074

Review URL: https://codereview.chromium.org/310563004

git-svn-id: svn://svn.chromium.org/blink/trunk@175462 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL makes DocumentWriter GarbageCollectedFinalized.

BUG=357163

Review URL: https://codereview.chromium.org/314953002

git-svn-id: svn://svn.chromium.org/blink/trunk@175461 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=376753

Review URL: https://codereview.chromium.org/299393007

git-svn-id: svn://svn.chromium.org/blink/trunk@175460 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=175443

BUG=378489
TBR=tkent@chromium.org

Review URL: https://codereview.chromium.org/312103002

git-svn-id: svn://svn.chromium.org/blink/trunk@175459 bbb929c8-8fbe-4397-9dbb-9b2b20218538

ActiveParserSession, NestingLevelIncrementer, and PumpSession are allocatable
only on stack. We can make m_document Member<> without trace().

BUG=357163

Review URL: https://codereview.chromium.org/313033003

git-svn-id: svn://svn.chromium.org/blink/trunk@175458 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=357163

Review URL: https://codereview.chromium.org/318583002

git-svn-id: svn://svn.chromium.org/blink/trunk@175457 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Oilpan: Replace RefPtrs to Document in core/{accessibility,animation,fetch} with Oilpan transition types.

BUG=357163

Review URL: https://codereview.chromium.org/313023003

git-svn-id: svn://svn.chromium.org/blink/trunk@175456 bbb929c8-8fbe-4397-9dbb-9b2b20218538