- 09 Dec, 2020 40 commits
-
-
Peng Huang authored
Bug: 1157074 Change-Id: I6fad512dcb8a262d67fc5160c2af89b0a8dfeefe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581938 Commit-Queue: Peng Huang <penghuang@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#835279}
-
Wei Li authored
Use a variable instead of a static function to represent the default focus behavior in platform style files. Bug: 1001103 Change-Id: Icf92ea6b83037ba3b285ba0c5eccb7bc16f1f460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579653Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#835278}
-
Xiaocheng Hu authored
Bug: 1155018 Change-Id: Ia2c76552745a9b1499f7339f00aacb6c34203e2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578376Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#835277}
-
Jesse McKenna authored
This change makes the following cleanup changes: * replace NULL with nullptr * remove namespace specifier for web_app::internals when inside that namespace * replace for loops with range-based for loops * add braces around a multi-line conditional statement Change-Id: I93876e058cf95882b0faa1e4dc8dece891975a5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576501Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#835276}
-
Sigurdur Asgeirsson authored
It seems there's a possibility for a single frame client to be an un-committed controlee of two service worker version_ids at the same time. Presumably this happens rarely during e.g. version updates or some such. Bug: 1143281 Change-Id: I9250b24945e7eed0251a7dee2eef3f473c74c917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581939Reviewed-by:
Patrick Monette <pmonette@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#835275}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0e323e7bff96..8732c0efd3ab 2020-12-09 cwallez@chromium.org roll_dep.py: Fix outstanding references to subprocess If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1156908 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I4f9d5c4a1f060b3aa1e00154c7a9d05e655b5109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582182Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835274}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b5c844554e30..83448c4da727 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie862f61fd8379a0f54ce18ecfc6f2c5ad41d47e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582259Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4c1463884785..f87c8f0d0c37 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC anthonyvd@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1107904,chromium:1157050 Tbr: anthonyvd@google.com Change-Id: If47fb880ff4be02935f668e860a5c186bb546e3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582138Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835272}
-
vidorteg authored
Localization V2 migration on mobile_throttling had some changes on the legacy functions it exposes, changing the webtests to match the API Also, disabling the test so I can check in the front_end changes and then I'll follow up with a reenable. Associated frontend changes: 2572862: [Loc] Migrate mobile throttling setting panel to Localization V2 https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2572862 Bug: 1136655 Change-Id: I62165c3ae95075c68bd835b1a7e41b9f7f224781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580134 Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com> Reviewed-by:
Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#835271}
-
Mitsuru Oshima authored
BUG=chromium:1088371 Change-Id: Id22b8b928fe21b72b61ee4ad1b6d44d6bde72f49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578480 Auto-Submit: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#835270}
-
Mason Freed authored
This removes several V0-only tests, and modifies others to use V1 Shadow DOM. Bug: 966758,937746 Change-Id: I0ab0c1a14b18ef40de2320f576247a49b7b309f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580999 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#835269}
-
Mitsuru Oshima authored
Bug: None Change-Id: I30d46974760f98489d3a0fb88c4f2972f9731020 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581359 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Auto-Submit: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#835268}
-
David Black authored
When scheduling repaint of holding space item focus/selection rings, the wrong bounds were being used. As a result, there were paint artifacts being left behind. Bug: 1154998 Change-Id: I33f8fb681527a94f16341198cc588cef2b4c479c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581037Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#835267}
-
Clemens Arbesser authored
This adds the fieldtrial testing config for the scheduled launch of trigger scripts in M-88. Launch bug here: crbug.com/1126386. Bug: b/173104767 Change-Id: Ib596e55635d04c24db953bcbd9d9ca82716473c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567216 Commit-Queue: Clemens Arbesser <arbesser@google.com> Auto-Submit: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#835266}
-
Yaron Friedman authored
Continue propagation of https://chromium-review.googlesource.com/c/chromium/src/+/2572244 and switching WebContentsObserver to use GURL. BUG=783819 Change-Id: Iaee059196c35dbeb9c955e387553826e7957d867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577830 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#835265}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ia4cb93800db01c2f22b11414cdd667571b107c0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582140Reviewed-by:
-
Dave Tapuska authored
This callback can be removed in favor of a state variable on the WebFrameWidget that tracks whether drag and drop is disabled or not. BUG=1097816 Change-Id: I791cd4cf99604c6901b8bd75706c171448addac5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577005 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#835263}
-
Gavin Mak authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under //chrome/browser. Bug: 1113033 Change-Id: Id810f3d68fdf7bc52eab805b02c2099e7c42ff14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577012 Commit-Queue: Gavin Mak <gavinmak@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#835262}
-
Dave Tapuska authored
The callback is unnecessary because the WebViewPlugin can use the SetCursor callback on the simulated mojo interface it has. BUG=1097816 Change-Id: I60854e362a1ada7a4060c6226d2e56e448ca1f0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577003 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Felipe Andrade authored
Add Kerberos search tags to the new Kerberos section on OS settings. This tags will only be created if kerberos is enabled and the KerberosSettingsSection flag is enabled. Bug: 983041 Change-Id: I7ec90dcf4cf259ce36b50d2baf9958342cab5d60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565617 Commit-Queue: Felipe Andrade <fsandrade@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#835260}
-
Sophie Chang authored
This ensures we don't send hosts and field trials for non-MSBB users Bug: 1146151 Change-Id: I146977f62943aaa77a0b85cd7196a13ad5ca660a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579838Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#835259}
-
Danil Chapovalov authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/592924480a..fbdff6f3ae Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/592924480a..fbdff6f3ae Bug: None Change-Id: Ice6915c8eeeb95fd17d36a2dd20964d3ed7904b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580063Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Danil Chapovalov <danilchap@chromium.org> Cr-Commit-Position: refs/heads/master@{#835258}
-
Reilly Grant authored
This change upstreams most of the wpt_internal tests for the Web Serial API to the Web Platform Tests repository. The remaining tests validate Chromium-specific concerns. To isolate Chromium-specific implementation details from the tests fake-serial.js is moved to resources/chromium and exports a generic API for controlling fake ports which could be provided by any implementation. automation.js will fail tests early on platforms which do not provide this service. Bug: 884928 Change-Id: I86d3ff864bc4d38a923dbd96da464e74533dfba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577488 Commit-Queue: Michael Moss <mmoss@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#835257}
-
Collin Baker authored
Adds bubble CreateParams separate from FeaturePromoBubbleParams. This makes it possible to remove internal fields from FeaturePromoBubbleParams. Bug: 1156839 Change-Id: I0285fa64d9c49811c88b392cc3b2bdd907ae5763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580843Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#835256}
-
Dave Tapuska authored
Override WebFrameWidgetImpl so we don't have to have custom WebWidgetClient callbacks for tests. This will allow us to remove WebWidgetClient in the future. Move the WidgetHost implementation to a separate class. BUG=1097816 Change-Id: I41c0f279bdd56eb6052c63966822d441c0d1405b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574834 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Erik Chen authored
This CL is a refactor with no intended behavior changes. The new ScreenManager interface was landed in M88. Ash beta is now M88, and Lacros is not available on Ash stable M87, so Lacros can always assume that the new ScreenManager interfaces exist. Removing this dead code is a prerequisite to refactoring the test code, which itself is a prerequisite for other lacros_chrome_browsertests. Change-Id: Ia5311010c8003f763409b2dc556a7dd6a99fc80d Bug: 1155662, 1156872, 1094460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580107Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#835254}
-
Shu-yu Guo authored
I2S with 3 LGTMs: https://groups.google.com/a/chromium.org/g/blink-dev/c/nAkEvjsqQbE/m/ilxfKaQ2CAAJ Bug: 1022182 Bug: 994315 Bug: v8:9344 Change-Id: I86a997cc8be009f415361cd394b63e21bf61fa24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568557 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#835253}
-
Ben Pastene authored
crrev.com/i/3457056 allocates the machines for this. Bug: 1140727 Change-Id: I46540e4feee5aa68bcc976f11ff6ff84223fb905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582159Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#835252}
-
Brian Sheedy authored
Adds the textpb file for generating an x86 O AVD and adds it to the list of AVDs to generate on the builder. Bug: 1145728 Change-Id: I3c5b69a5c2ac125b6961e1c36a2980253d671344 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580738Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#835251}
-
Boris Sazonov authored
If MobileIdentityConsistency, isSyncingUrlsWithKeystorePassphrase should also check that sync is enabled. Bug: 1157046 Change-Id: Ia396b22a08d77f336ac8874f9940cf840ce60301 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579785 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#835250}
-
Natalie Chouinard authored
The exclusions that these exceptions apply to were already removed in: https://crrev.com/c/2551492 so cleaning up the no-op exceptions. Bug: 1151370 Change-Id: Ia9b1e4d230a904f2743125fc61a4384828352f25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579713Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#835249}
-
Andre Vincent authored
toggle selected: screenshot/7ZNeh5HNji2mnvk toggle not selected: screenshot/9WzpztqnYxkQL56 Fixed: 1154473 Change-Id: Id99211c5881b952cedf7d1b39b5df7a46fbe3b51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577654Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Andre Vincent <andrevincent@google.com> Cr-Commit-Position: refs/heads/master@{#835248}
-
Yann Dago authored
Bug: 1155194 Change-Id: I79b8e0fc2689853f4ac4de657b0e8f4498830a77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571856 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#835247}
-
Joe Downing authored
Change-Id: I7523f17be2b5e8c3c0bd533b0cec223af49fd555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575976 Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Auto-Submit: Joe Downing <joedow@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#835246}
-
Liquan (Max) Gu authored
This CL combines two invocation of createShippingSectionForPaymentRequestUI() into one and simplify the invocation conditions. Before the CL, the method was called in the following control routes: 1. PRService#updateWith() -> CPRService#continueShow() -> if isPaymentRequestUiAlive() -> invoke 2. PRService#onShowCalledAndAppsQueried() -> CPRService#showOrSkipAppSelector() -> PaymentUiService#buildPaymentRequestUI -> if !isShowWaitingForUpdatedDetails -> invoke Observing the invocation conditions of the two routes, we know that they are invoked under the same conditions because: 1. isShowWaitingForUpdatedDetails == false: satisfied by updateWith() show() called and apps queried: satisfied by isPaymentRequestUiAlive(). 2. isShowWaitingForUpdatedDetails == false: satisfied by the if. show() called and apps queried: satisfied by showOrSkipAppSelector(). Based on the conditions, these invocations is equivalent to one in CPRService#onShowCalledAndAppsQueriedAndDetailsFinalized(). Bug: 1155582 Change-Id: Id2978142bd62f4396bdae3937973631bc9408d73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575203 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#835245}
-
Rahul Arakeri authored
To repro this corner case, scroll using the scroll wheel and click immediately (i.e before the GSE for the wheel is fired) on the thumb and try to drag it. The user would be unable to drag the thumb. This happens because state on the cc::ScrollbarController would have been destroyed (by calling InputHandlerScrollEnd). The state gets cleared because the mousedown on the scrollbar arrives at the InputHandlerProxy before a GSE for the kWheel gesture device was processed. The fix is to first perform a hit test and process the mousedown only if the pointer is on the scrollbar. Bug: 1151956 Change-Id: If08373ea8bfe0b3d8f150e09303dcc39119e3c2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562600Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Cr-Commit-Position: refs/heads/master@{#835244}
-
Tommy Steimel authored
This is a reland of 2cf475dd. This adds the module_header.js file to the modules_resources.grdp file, which fixes the issues when optimize_webui = false. Original change's description: > NTP: Allow modules to instantiate the header > > This CL removes the module header from the wrapper and instead allows > the modules to instantiate it instead. This makes the title and actions > properties of the ModuleDescriptor obsolete, so this CL also removes > those. > > Bug: 1152205, 1152216 > Change-Id: Ib524a59c8c8a7cc69e130b31a8557b903233ab95 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570390 > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Commit-Queue: Tommy Steimel <steimel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#834424} Bug: 1152205 Bug: 1152216 Change-Id: Ibded5b577d31961786b90dc15c664a11702a5b96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581004Reviewed-by:
-
Scott Violet authored
The name hasn't been needed for a while. This drops it from the API (but not the aidl). This is an incompatible change to the client library, but is backward compatible as the name hasn't been needed since 84 ( https://chromium-review.googlesource.com/c/chromium/src/+/2324172 ) BUG=1154283 TEST=covered by tests Change-Id: Iabbbd524ecb105b079805fb73e65ec23feda9aac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580679Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#835242}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/84b9bb6621c7..eb597ff5b7f6 2020-12-09 sugoi@google.com Make Constants a singleton instead of a global If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I77e9c195aeca7dacbf67a7b84433962b39b90b07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581335Reviewed-by:
-
Felipe Andrade authored
Sync settings.KerberosErrorType enum with the ErrorType enum in third_party/cros_system_api/dbus/kerberos/kerberos_service.proto. This missing type will be mapped to a general kerberos error message in kerberos_add_account_dialog.js. Bug: 983041 Change-Id: I9231f3b1bc5b77fd2da8e02f8ee7e25db1e4703b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575032Reviewed-by:
-
