- 21 Aug, 2019 40 commits
-
-
Marina Ciocea authored
This test is flaky on MSan. TBR=mrobinson@igalia.com Bug: 981913 Change-Id: I8ece439d23b7302575166c90a3b681145e503e58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761168Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#688955}
-
Maksim Moskvitin authored
In order to support USS migrator with USS implementation of Nigori we will need to expose bridge owned Cryptographer to Directory. We don't expect Directory to modify this Cryptographer, so we pass it as const ptr to ensure our expectations not wrong. Bug: 922900 Change-Id: I3fc558d8f97fd11c9dfb9544ac765f27a28d7bfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760910 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#688954}
-
Lin Sun authored
Besides codename, now it supports specifying Intel GPU by generation. Also added Whisky Lake, Comet Lake, Cannon Lake and Ice Lake as Intel's new GPU types. BUG=991895 TEST=gpu_unittests Change-Id: Ia7d6e355bb04cbb82c59d9cf5f6436353ac626bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705972 Commit-Queue: Lin Sun <lin.sun@intel.com> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#688953}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/cbcc21fb49bc..3b27516ba774 git log cbcc21fb49bc..3b27516ba774 --date=short --no-merges --format='%ad %ae %s' 2019-08-21 primiano@google.com Merge "CI: fix job failures due to autoscaler and artifact uploader" Created with: gclient setdep -r src/third_party/perfetto@3b27516ba774 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: I27b6e92f2a7d4b31e88d9c99c95a4c0bba9f5732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762884Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688952}
-
Stepan Khapugin authored
No logical change, just renamed the variables and reordered methods and added #pragma marks. Bug: None Change-Id: I51ca439e1c245e7d47d094e7c0025a29a2513811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763669 Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#688951}
-
Tanisha Mandre authored
- Implement the Credit Card scanner camera controller. - Implement the Credit Card scanner camera controller delegate. Bug: 989432 Change-Id: I7ca5710d4e32e44317c31dce29fc444a1800c2f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760210 Commit-Queue: Tanisha Mandre <tanishamandre@google.com> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#688950}
-
Gyuyoung Kim authored
As a step to deprecate Platform::GetDataResource(name), this CL makes AudioBus::GetDateResource use Platform::GetDataResource(int, ui::ScaleFactor) instead of Platform::GetDataResource(name). Bug: 983396 Change-Id: Iaf1e4b85822185e78c72370e1e92cc2f560e39df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763347 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#688949}
-
Anton Bikineev authored
The data race was caused by non-atomic setting of InConstruction bit in the AllocateBackingStore functions, which was racing with the concurrent sweeper that assumes that this bit is set atomically. The main bottleneck in MakeGarbageCollected was already correct. Bug: 995646 Change-Id: Id72cdef47877ffae813d4d2e9a34b31a75f4a836 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762245 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#688948}
-
Alice Boxhall authored
Bug: 995603 Change-Id: I7e402104a729aa0fdaf525530be98f00b239f123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763547 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#688947}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 15ab9d0e. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Ia6c05b1f96a6eb00eaa8b0357e2f60bb0d18fb0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760425Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688946}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9f22c42088e3..18868b8f3d5f Created with: gclient setdep -r src-internal@18868b8f3d5f The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ieab361dff8ca086f043333aba3f0f8a0b9534a0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762883Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688945}
-
Sergey Ulanov authored
Previously the limit was set to min(512MB, total_ram/4), which is too high for some devices. This is temporary workaround until we have MemoryPressureMonitor implemented. Bug: 996028, 996030 Change-Id: I14a0e050adefd8af0691ea767520ffda7b5cdce5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762910Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#688944}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/941e663b..73ab90bd Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I84ad6ec4d5d4b1672fce28d86d717211508c5fff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763587Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688943}
-
Himanshu Jaju authored
Adds metrics for click to call to check for performance regression due to regex parsing for phone number in highlighted text. Bug: 992404 Change-Id: I3909bb6909e783c9311181600f8b5462824bd652 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754003 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#688942}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/364b2673c037..e8ef87bdadcf git log 364b2673c037..e8ef87bdadcf --date=short --no-merges --format='%ad %ae %s' 2019-08-21 bryanf@microsoft.com Include menus & dialogs in frames captured by WindowCapturerWin Created with: gclient setdep -r src/third_party/webrtc@e8ef87bdadcf The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:980864 Change-Id: Idbc1e058a642b0edf99e8c68478aee1b54e80c22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763193Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688941}
-
Himanshu Jaju authored
Bug: 993809 Change-Id: Ib80bad79ef801c4e45162149c50f9943a4266600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754165 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#688940}
-
Takuto Ikuta authored
This is to prevent occasional link failure in deterministic builder. Bug: 996081 Change-Id: Iebdf7c06aa841a856681be1ee04a5800bbe0c344 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761964 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#688939}
-
Marina Ciocea authored
TBR=fdoray@chromium.org Bug: 995682 Change-Id: I41264c56ac9a9313fcf7a48f855edb3e0aac328c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757926Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#688938}
-
Matt Falkenhagen authored
Some tests were still failing on the check in the destructor that resource_context_ is nullptr. This clearly avoids using resource_context_ at all. Bug: 824858 Change-Id: I03346c6400fbdb5067c19a0ba6b7480d5183881f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763348Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#688937}
-
Alexander Hendrich authored
This CL adss a CHECK to verify that the calling extension is running in the sign-in profile, has the "loginScreenUi" permission and the device is managed by policy. This should already be enforced by the feature definition for the "loginScreenUi" permission. However, since showing login screen UI has further security implications, we want to be extra secure and prevent any side-channels from calling this API. Bug: 957573 Change-Id: Ia8fcdf083b1e77aa5458c66da12b5616938c04f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762217 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Zakhar Voit <voit@google.com> Cr-Commit-Position: refs/heads/master@{#688936}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/378a17b20f14..0dd1307fc04f git log 378a17b20f14..0dd1307fc04f --date=short --no-merges --format='%ad %ae %s' 2019-08-21 perezju@chromium.org [Telemetry] Add Finalize method to results object Created with: gclient setdep -r src/third_party/catapult@0dd1307fc04f The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=crouleau@google.com Bug: chromium:973837 Change-Id: I54ff1fac74b9ad92691633d5b1ede806fb06f58c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762746Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688935}
-
Hiroki Nakagawa authored
For shared workers, this CL makes ApplicationCacheHost use BrowserInterfaceBrokerProxy bound with SharedWorkerGlobalScope (SharedWorkerHost) instead of legacy InterfaceProvider bound with blink::Platform::Current(). Along with that, this CL moves ApplicationCacheHostForWorker instance from WebSharedWorkerImpl on the main thread to SharedWorkerGlobalScope on the worker thread. This change removes thread-hops after shared worker script fetch (see SharedWorkerReportingProxy::DidFetchScript()). Note: This is a preparation for AppCache support with PlzDedicatedWorker. Each (nested) DedicatedWorkerGlobalScope on the worker thread will have its own ApplicationCacheHost like shared workers. Note: Currently, frames and shared workers have different code paths to create AppCache host/backend (see TODO comment in ApplicationCacheHost::BindBackend()). These will be integrated by a follow-up CL: https://chromium-review.googlesource.com/c/chromium/src/+/1758038 Change-Id: I331d13bc64051ffe883fe51e2dfa5b4597a3c947 Bug: 718652, 945673 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746128 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#688934}
-
Jan Wilken Dörrie authored
This change adds time metrics for the leak detection feature. Bug: 986298 Change-Id: Ida4bdd50adfa5d9b3fda910f70a26375b5031525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760921 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#688933}
-
Ioana Stefan authored
The refactoring of TaskInfo has been realized in a previous commit. This change had the following bug: the setting of task extras was moved to multiple places through the code and one setting was mistakenly forgotten, namely the setting of the task extras for periodic tasks with GcmNetworkManager. This CL relands the first changes and fixes the problem. A test is added to check this problem. Bug: 995264 Reland "[BackgroundTaskScheduler] TaskInfo refactoring" This is a reland of 8fb37f86 Original change's description: > [BackgroundTaskScheduler] TaskInfo refactoring > > The BackgroundTaskScheduler does not offer at the moment the possibility of scheduling a task at an exact moment. In preparation for this feature, the existing code is going to be updated first. > > This CL refactors the way in which specific task information is kept. A more object-oriented approach is implemented, based on the discussion in this Design doc: https://docs.google.com/document/d/1o9BS5qwv10QVN3Df6W2m4QKjSo1DXdGIgLf8p2l0PYc/edit?usp=sharing. Changes have been made only in the way timing info for a task is kept and not in the way pre-requisites information is kept. Updates have also been added to the test files. > > This change does not affect the interface exposed by the TaskInfo class. > > TBR=rouslan@chromium.org > > Bug: 970160 > Change-Id: I2985ca68da4e6db18f47e0fd1769db3138850cb0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707365 > Commit-Queue: Richard Knoll <knollr@chromium.org> > Reviewed-by: Tommy Nyquist <nyquist@chromium.org> > Reviewed-by: Mugdha Lakhani <nator@chromium.org> > Reviewed-by: Richard Knoll <knollr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#687603} Bug: 970160 Change-Id: I5a2cd49dabc5d399600b7f7ba855ddb19f5118e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760744 Commit-Queue: Ioana Stefan <ioanastefan@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#688932}
-
Thomas Tangl authored
Bug: 966388 Change-Id: I193f190a9f4d6f17afa172f29a079a2d893d4015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762507Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#688931}
-
Omer Katz authored
- Switch Member<> internals to using std::atomic<T*> instead of T* for writing (via mutator) and reading (via marking visitors). Reading via mutator remain non-atomic. - This is required for supporting concurrent marking while mutator is running. - All accesses are relaxed and do not introduce fences. For correctness see https://bit.ly/oilpan-concurrent-marking - Drive-by: Use WeakMember<T>* instead of T** for weakness processing to enforce atomic access. Bug: 986235 Change-Id: I456df63dffca6a2645c11b5827bb34a5022004a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749088 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#688930}
-
Yoshisato Yanagisawa authored
Compilers used for Simple Chrome is different from Chromium, we should enable ATS. Bug: 981433 Change-Id: I81aca2b28cf41c91888488eae8fee9284826f254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763508 Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#688929}
-
Yoshisato Yanagisawa authored
In commit 0e67738e, I made wrong builders to be triggered. Let me fix to trigger RBE one. Bug: 981433 Change-Id: I2f7ed9109a943c7caf9b9244934930ff8d2d4e12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763509 Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#688928}
-
Henrik Boström authored
This was reported as flaky. I am unable to reproduce, which could mean that the issue is fixed, or it could mean that it only flakes on certain setups (OS, builds, hardware, etc). To aid investigation I am speculatively re-enabling it; worst case it gets disabled again. Bug: 993020 Change-Id: I375aeefeffaa9498d962539063a7f9a003a4dad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761285Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#688927}
-
Hans Wennborg authored
It warns about implicit fallthroughs in switch cases. Before Clang r369414 the warning only applied to C++ code, but now it also fires in C code. Chromium has a few instances where it warns, so disable the warning until those have been cleaned up. TBR=thakis Bug: 995993 Change-Id: I436a4650088744322e6451cdf661a264efb7b283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757928Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#688926}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/bc62722b80a6..0cbdc7a2c35b git log bc62722b80a6..0cbdc7a2c35b --date=short --no-merges --format='%ad %ae %s' 2019-08-20 dneto@google.com Remove unimplemented method declaration (#2804) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@0cbdc7a2c35b The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,jonahr@chromium.org,jonahr@google.com Bug: None Change-Id: I753aee46d9805c42af159b500b3b2eca64478d29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763190Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688925}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6d653c02dd24..ed4906f89d3d git log 6d653c02dd24..ed4906f89d3d --date=short --no-merges --format='%ad %ae %s' 2019-08-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src 95609e6d923a..34cccdc65d79 (2 commits) 2019-08-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src bc62722b80a6..0cbdc7a2c35b (1 commits) Created with: gclient setdep -r src/third_party/angle@ed4906f89d3d The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@chromium.org,jonahr@google.com Bug: chromium:None,chromium:None Change-Id: If12fd6a166911bdd824c7bcf28549f76822e8945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763191Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688924}
-
Christopher Lam authored
Bug: 976578 Change-Id: Iad31642a92fd872bfc7681761270dfdd901d67c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763349 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#688923}
-
Matt Falkenhagen authored
The thread ServiceWorkerContextCore lives on (the "core thread") will move from the IO thread to the UI thread. This CL enables the following to pass when ServiceWorkerOnUI is enabled: - SameSiteDataRemoverBrowserTest.TestClearDataWithStorageRemoval - SameSiteDataRemoverBrowserTest.TestClearDataWithoutStorageRemoval Bug: 824858 Change-Id: Iaace639ff7425d4c933d18c5662cd67024790fe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763351Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#688922}
-
Yoshisato Yanagisawa authored
In the recipe, we configured to make the builders use chromium.fyi master instead of chromium.goma master. That caused build failures on builders. Bug: 981433 Change-Id: I5cdedb13191104d151e9e83dc1b2839a91d00837 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763278 Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#688921}
-
Anastasiia Nikolaienko authored
In WebDialogView override ShouldShowCloseButton to return delegate-> ShouldShowCloseButton (which, as before, returns true by default). This allows to hide close button in dialogs which override WebDialogDelegate. Bug: 991022 Change-Id: I0aa8ec7104a9e29eb96625f4ec15228b6df9338f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749009Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#688920}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dbd569afc423..9f22c42088e3 Created with: gclient setdep -r src-internal@9f22c42088e3 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: Ied6bb65e58c8d1b7940f808be16095bd23df9c16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763371Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688919}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5817e13649be..378a17b20f14 git log 5817e13649be..378a17b20f14 --date=short --no-merges --format='%ad %ae %s' 2019-08-21 dberris@chromium.org PinpointScheduler: Handle errors in task_updates Created with: gclient setdep -r src/third_party/catapult@378a17b20f14 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=crouleau@google.com Bug: chromium:988912 Change-Id: Id72519457aa96153a055231bbcf151c2bdb3ae3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763370Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688918}
-
Hans Wennborg authored
Starting with a one-liner for finding what files differ between two dirs. Bug: none Change-Id: Ibb85f066ab1da79b70795691b6213f3d91fd9a58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761604 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#688917}
-
Canon Mukai authored
Change error message "Illegal constructor" to "Cannot create writer when a WritableStream is locked" in getWriter(). Bug: 803008 Change-Id: Ie5393abf280075f3df9ad6a6dfd7135c0024fa7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762258Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Canon Mukai <canonmukai@google.com> Cr-Commit-Position: refs/heads/master@{#688916}
-