- 20 Oct, 2020 40 commits
-
-
Hidehiko Abe authored
According to the spec, it is expected that preedit_string is sent only when the preedit is updated. Bug: 1139731 Test: Test manually with SHIFT+LEFT + JP IME. Ran exo_unittests. Change-Id: I650ac18b585c00901671633e0f50221fd84ac66f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485666Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#818962}
-
Dave Tapuska authored
A lot of the core functionality has moved into blink. Yet a number of using and include definitions were left behind. BUG=1097816 Change-Id: I03092d6f2944d1aab549c89673f7bc7e6cfbef81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487221Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#818961}
-
Victor-Gabriel Savu authored
Allow fake login to continue without an OAuth cookie to fix the fake enterprise enrollment. Bug: chromium:1140422 Test: tast run <ip> policy.SystemTimezone Change-Id: I75985607421c370c610336b1afbcf5b7c708da89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487268 Commit-Queue: Victor-Gabriel Savu <vsavu@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#818960}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cd74dfa47721..13fa34606b78 2020-10-20 kjlubick@google.com [infra] Sync to latest infra repo. 2020-10-20 bsalomon@google.com Remove legacy SkImageGenerator YUV planes interface 2020-10-20 johnstiles@google.com Improve gencode for inlined blend and composition functions. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: egdaniel@google.com Change-Id: I442fb2041043b59099020da2ad04969b4470ecf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487209Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818959}
-
Tommy Li authored
This CL is a followup to: https://chromium-review.googlesource.com/c/chromium/src/+/2485561 It ports one more browser test to a unit test. Bug: 751031 Change-Id: I56928ef473e3a14982c2fec0d900176c3175de9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485562 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#818958}
-
Antonio Gomes authored
... and rename it to ImmersiveModeControllerChromeos. CL also adapts chrome::CreateImmersiveModeController(), the helper that create instances of ImmersiveModeController (see immersive_mode_controller_factory_views.cc). This is phase 3, on the design document [1]. [1] https://docs.google.com/document/d/1xHwcHrAiEaWuA4usGEqKZ9zm1H8SGk3WkS-Jf2Q_los/ BUG=1113900 R=jamescook@chromium.org, sky@chromium.org Change-Id: I9d13060bae1098ff7026b65e21545373503cc4b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486114 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#818957}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202010200700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/U-5IIfB8vy39NvpI83unV6yKRSTL446Zw5cBERt3kGgC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/168563701,b/169509246,b/170161460 Tbr: media-app@grotations.appspotmail.com Change-Id: I0aac44facb2dfa655945cdf570c413268961b6b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487164Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818956}
-
James Cook authored
Lacros gets its initial metrics consent state from ash. Older versions of ash didn't send this data, so we would open a first-run dialog to ask again if the user wanted to send metrics. Ash now always sends the data, so clean up the code that opens the dialog. Bug: 1131164 Test: manual, lacros inherits metrics consent from ash Change-Id: I75384f03b3cec28293c8ee019e0c57e817a8dc8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481960Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Greg Thompson <grt@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#818955}
-
Viktor Semeniuk authored
Bug: 1140400 Change-Id: I88e442649ce0fb0844f1a2633a81a27df6b58018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487128 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#818954}
-
Prakhar authored
Bug: 1139007 Change-Id: I4307e52114f1cc7a9d18c760014e06e23651708e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477613 Commit-Queue: Prakhar Asthana <pasthana@google.com> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Prakhar Asthana <pasthana@google.com> Cr-Commit-Position: refs/heads/master@{#818953}
-
Anders Hartvoll Ruud authored
Wrap CSSValue and the corresponding TreeScope from MatchResult in a ScopedCSSValue passing it to StyleBuilder. Currently use a nullptr TreeScope in the cases where we don't have one to look up tree-scoped references. We do not support such names/ references in UA stylesheets. We currently support @keyframes in user stylesheets, but collect them from the StyleEngine regardless of which scope the animation-name came from. It would be possible to have a TreeScope for user sheets (and even UA sheets) and use ScopedStyleResolvers instead of extra structures in StyleEngine. For now pass null TreeScopes for UA and user style values. Bug: 336876 Change-Id: I033c503aa92178a0c32efdac861ddf606ceb2cd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484656Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#818952}
-
Peter Kotwicz authored
This CL: - Makes fetch_all_androidx.py generate //third_party/androidx/cipd.yaml with all of the files that the bot should upload. This includes: - for each library: aar, LICENSE, README.chromium - //third_party/androidx/BUILD.gn - //third_party/androidx/additional_readme_paths.json - Makes fetch_all_androidx.py work if //third_party/androidx/BUILD.gn does not exist. - Makes fetch_all_androidx.py fail if fetch_all.py subcommand fails. BUG=1064277 Change-Id: I423763f9a1a4cf8328ca6133f0ead52dcad9b0f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462674 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#818951}
-
Chris Lu authored
This change fixes most of the multiwindow resizing bugs for the Smooth Scrolling viewport feature. See video for one remaining issue. Video: https://drive.google.com/file/d/1a_1-NTtp1NUIKhf2bnxzuhSKkUcQsynR/view?usp=sharing Bug: 1121527 Change-Id: I911ab6f8efd103650a35617eebc1a85c189908a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477597 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
David Jean <djean@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#818950}
-
Michael Moss authored
Some tools need to be used both when creating diffs and when installing diffs, so need to support the archs of both the target system and the system generating the diffs. These are generally the same thing, but when cross-compiling for arm64 on x86, it requires universal binaries. BUG=1119472 Cq-Include-Trybots: luci.chromium.try:mac-rel,mac-arm64-rel Change-Id: Ic329561b8f034477d491121e507ba34821419516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462242 Commit-Queue: Michael Moss <mmoss@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Auto-Submit: Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#818949}
-
Boris Sazonov authored
Extends "Profile.AndroidAccountManagementMenu" histogram by 6 months. Bug: 1127958 Change-Id: Id3aad1a26848a3ea0267aa3dafc8cd3f07e031f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479171 Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#818948}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I26c5d5fed4b6a4e85373efafde52549a329de200 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487170Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/c4593127cbdd..e557087870b0 2020-10-20 cwallez@chromium.org CMakeLists: make DAWN_THIRD_PARTY_DIR an option. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: If43a048eb320501bff73d60bde087f09bdb3bf0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487165Reviewed-by:
-
Aaron Tagliaboschi authored
Implement the Critical-CH response header as a URL Loader throttle. This restarts/internally redirects the request when it sees a Critical-CH header is can honor, as defined in the Client Hint Reliability explainer. https://github.com/WICG/client-hints-infrastructure/blob/master/reliability.md#critical-ch Bug: 1127313 Change-Id: I3987d8d385f078ecb781a5895ab637522c8c8261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405697 Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#818945}
-
rbpotter authored
Bug: 1132403 Change-Id: I7c86e8e57dd780e04fb2fb8d67dd33940cbe9ca8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486681Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#818944}
-
Josh Nohle authored
Always include the logged-in account in the list of contacts uploaded to the Nearby Share server. Also, mark this contact as "selected". This automatically enables sharing with other devices logged in with the same account. This self-sharing works in all- or selected-contacts visibility modes. Previously, to enable self-sharing, a user would need to manually add their own account to their list of contacts at contacts.google.com, for instance. Verified fix with manual testing. Fixed: 1138679 Change-Id: Ib3a2137257e4d4c56a43011d747811f522d9ad40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487244 Auto-Submit: Josh Nohle <nohle@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#818943}
-
Sorin Jianu authored
This function returns the version of the active updater. Bug: 1140270 Change-Id: I1e6fea77cb33be879cf5d8a0e148f0bdea1ca56f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485554Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#818942}
-
Yifan Luo authored
Bug: 1116418 Change-Id: Idfc4a634a12b354c0aa96c0cf5f2516138b38235 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475814 Commit-Queue: Yifan Luo <lyf@chromium.org> Reviewed-by:
Yifan Luo <lyf@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#818941}
-
Fergal Daly authored
http://cl/338053345 is updating the experiment to include disabling SkipEarlyCommitPendingForCrashedFrame and this change is needed alongside it. Bug: 1072817,1139104 Change-Id: Ie2c54557d85ba0fbbe1a494626602f6f8daaf583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486009 Commit-Queue: Fergal Daly <fergal@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Auto-Submit: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#818940}
-
Rune Lillesveen authored
This implements the style support for the pseudo element. The paint code needs to query the pseudo style during painting and paint invalidation needs to be added. Bug: 1136817 Change-Id: I933c4de5f473c25000f9a34efa00a5af2cc52232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463563Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#818939}
-
Sebastien Lalancette authored
On iPad, the Activity View popover needs to point to the start of the selected text for Shared Highlight (like what the default "Share..." action does). To do so, we needed to retrieve the client rect from JavaScript, convert it to the browser UI's coordinates, and then set the values on the UIActivityViewController's popover controller. Bug: 1136043 Change-Id: I95a1ced0a019524b76c3ad4995068f58755acb0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463324 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#818938}
-
Leonard Grey authored
Bug: 1014639 Change-Id: Idb0efe25b4a02432bbc4f07f29ac1fba963e600f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486092 Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Leonard Grey <lgrey@chromium.org> Reviewed-by:
-
Colin Blundell authored
This CL adds the subresource_filter namespace to classes that were recently moved from //chrome to //components/subresource_filter. Bug: 1116095 Change-Id: I91a27afcc8a70e101d53042d69dd5dbbd517be74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484426Reviewed-by:
Eric Robinson <ericrobinson@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#818936}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0c84d564df9f..b1ac88b6534f 2020-10-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 7e1825a59619 to 6fac705e7616 (6 revisions) 2020-10-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from f4f1d8a352ca to 3ead01191215 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: I089eb77b719f500e9af4b812f3a5a06664ac9b7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487144Reviewed-by:
-
Sebastien Lalancette authored
Two cases: - A simple page with two fragments in the URL. - A very long page, to force a scroll to occur. Bug: 1116463 Change-Id: I64c30542971e82f7b941b6d40d6b266f4435a0cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485573Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/19640aa61b04..1d0e7b6bbe17 2020-10-20 glahiru@webrtc.org Remove usage of "use_ios_simulator". If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I2b148e0c6da999720c8be31bc5ea61ce1132fc44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487147Reviewed-by:
-
Nazerke authored
This CL adds a TabStrip Cell. Bug: 1128249, 1134075 Change-Id: I3a8d35c9467672edfdfa7693b4c13147e284bd40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440556Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#818932}
-
Boris Sazonov authored
Enables FirstRunTest that was fixed in https://crrev.com/c/2450291. Enabling is done in a separate CL to simplify the revert in case these tests are still flaky. Bug: 616456 Change-Id: I289ccf035a22835b38917680fd74fb8ce9b3e761 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487104 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#818931}
-
Christian Biesinger authored
Intent to ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/TF41VMfLhMI R=ikilpatrick@chromium.org, mstensho@chromium.org Bug: 1045668 Change-Id: I3d310b9e3739694af769619ca14f8563fcaea312 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485582 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#818930}
-
Koji Ishii authored
This patch enables |HyphenationTest| for all platforms. It turns out that try-bots do not copy all test data files and that tests fail on most bots. This patch adds |data_deps| rules to |BUILD.gn| to copy dictionaries used in testing as part of |blink_platform_unittests_data|. The same issue occurs on |web_tests| too, I will investigate it in following patches. Bug: 1139950 Change-Id: I654332076a5ae194db905c72c525a16c3f90de4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483725Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#818929}
-
Andrew Xu authored
When fetching history record, the group stored in history updates. As a result, the focus node stored in history may not be a child of the group anymore. However, that obsolete node is still used as the preferred focus node. This CL fixes it. See comments under the issue for detailed analysis. Bug: 831407 Change-Id: I1e1553c4322408fb431b212d9e0397b95e7f50ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482184Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#818928}
-
Victor Hsieh authored
We still need this data to keep track of feature use. Extend for 1 year. BUG=1138237 TEST=None Change-Id: I27d5af9a309a8be6a44e1baeaf24dbe83b648d14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485612Reviewed-by:
-
Erik Språng authored
It now sets this flag to max_probe_delay:10ms,abort_delayed_probes:true by default. Bug: webrtc:11780, b/157420109 Change-Id: I5b5343bf8541c9363d054c2bd456edc0429cb549 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485067 Commit-Queue: Erik Språng <sprang@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Auto-Submit: Erik Språng <sprang@chromium.org> Reviewed-by:
-
Martynas Sinkievic authored
This change adds initialisation steps for the |PatternProvider| in all tests which require it. Change-Id: Ie5489ebab786aff5664a691b832a4dc132b47292 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435095Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
Christoph Schwering <schwering@google.com> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#818925}
-
Sebastien Lalancette authored
- I've contributed non-trivial changes to the classes in these directories: - crrev.com/c/2456288 - crrev.com/c/2463324 Change-Id: I9c0af9a2874e747f2f1ddb083022d62d03e00bec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471882 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
-
Ioana Pandele authored
Bug: 1044930 Change-Id: I987d4dc25677162e20a7091c543add190a5cedeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485098Reviewed-by:
-
