- 07 Oct, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e90aefd498fb..f3f59fd5e5fa 2020-10-07 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I35845b757db86f7425401d74f7a361c4a9b591bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455292Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814579}
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 87-4265.0-1601890590-benchmark-87.0.4280.9-r1 to 87-4265.0-1601890590-benchmark-87.0.4280.10-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: If62970f76bec8a97693014ce43cddcc8dab1331f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455296Reviewed-by:
-
Eric Willigers authored
When an app is newly uninstalled, we might attempt to read icons that are no longer present. This CL should avoid some flakes in browser tests, i.e. [app_icon_factory.cc(956)] Check failed: it != icon_bitmaps.end(). https://bugs.chromium.org/p/chromium/issues/detail?id=1119807#c14 Bug: 1119807 Change-Id: I05d0c0c63f26f1106b9f4674f9be350eb5c3a530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454920Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#814577}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b81fdbee92ce..439af79f26e2 2020-10-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from afe6ca45b6da to 635de036d766 (3 revisions) 2020-10-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 77e3d0ae97b6 to 3df629c55d89 (20 revisions) 2020-10-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 4259b6b6 to 3c775217 (463 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jvanverth@google.com Test: Test: Test: *debug_negative_coverage* Change-Id: Ia1ced376b353b1fdbb10b3afdbdc6d766ca915f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455286Reviewed-by:
-
Jose Dapena Paz authored
Fix build issue: /usr/include/c++/9/bits/unordered_map.h:105:18: required from ‘class std::unordered_map<std::__cxx11::basic_string<char>, update_client::CrxUpdateItem>’ ../../chrome/browser/ui/webui/settings/accessibility_main_handler.h:72:7: required from here /usr/include/c++/9/bits/stl_pair.h:215:11: error: ‘std::pair<_T1, _T2>::second’ has incomplete type Bug: 957519 Change-Id: I0c1f47c6cdd6f91828d3589bef4355d4602c2e1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453451Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#814575}
-
Aya ElAttar authored
Avoided the recreating of EnterpriseClipboardDlpController every time on policy update by creating a new instance only if there's not any instance running. Bug: 1135480 Change-Id: I65b17ab262ceb1572b104dbc2a4456c1c4b55663 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450280Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/master@{#814574}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3df629c55d89..8af9ef3b260f 2020-10-07 syoussefi@chromium.org Add emulated format clear perf test If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: Ifdbcd1883da1c094195827ea5fb048d73380d3a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455186Reviewed-by:
-
Eric Willigers authored
WebAppControllerBrowserTestBase is no longer parameterized on ProviderType. HostedAppEngagementBrowserTest is retired, tests are moved across to WebAppEngagementBrowserTest. Bug: 1012171,1065748 Change-Id: I1b65973fe1e300c99570d0e9b67102b2e9a79bf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454774 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#814572}
-
Eric Willigers authored
The browser test helper methods in web_app_browsertest_util.cc that install PWAs (InstallWebApp, InstallWebAppFromManifest, PendingAppManagerInstall) now wait for on_registry_ready(). This reverts commit 27680d16. and relands commit 4f68ef3f Bug: 1119807, 1135469 Change-Id: I3a76164f998377aa98167bab004510ae8bee1ba2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454811Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
-
Mike Jackson authored
Removes the parameterization for all tests in the web_app_provider_unittest.cc file, now that kDesktopPWAsWithoutExtensions flag is always true. Bug: 1065748 Change-Id: I1bebc1de80fc8cdb3f93d49f07acd938f5acfb09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453352 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
-
Joel Hockey authored
The current logic use background color for tab color in a tabbed PWA. So the current logic ignores any dynamic changes to bg for non-tabbed apps. But bg color also sets other things such as download shelf color, so we should still update themes for non-tabbed apps when bg color changes. Moved color change detection logic for theme_color / background_color, and UserChangedTheme notifications into UpdateThemePack to simplify its callsites. Bug: 1134112 Change-Id: Ibe68911b733b0eb7760cd2d2f4be96e3eb2c7a3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451989Reviewed-by:
-
Lei Zhang authored
In chrome_pdf::draw_utils::GetMostVisiblePage(), switch to using gfx::SizeF() so area calculations do not suffer from integer overflow. Bug: 1124816 Change-Id: I578ed4274b7ea2eb04ea02d216a4b355948d11cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444807Reviewed-by:
K. Moon <kmoon@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#814568}
-
Daniel Ng authored
Tests: built and ran browsertests Change-Id: I264e6c4b792e80775cb8ad81407374acd92127e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454966 Commit-Queue: Daniel Ng <danielng@google.com> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Daniel Ng <danielng@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#814567}
-
Jason Lin authored
The implementation is based on UX design [1]. [1] https://docs.google.com/presentation/d/1MWWejK-y2vnBN3Wg__Kd_LIiAcIF3VctzMowMI3wM4w/edit#slide=id.g91c6bdd2e4_0_12 Bug: b/167491603 Change-Id: Id107ea7b4b90aad0714a617147acc877adb9fc1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397979 Commit-Queue: Jason Lin <lxj@google.com> Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Noel Gordon authored
Chrome and Mozilla support color space information in a BMP image [1], when the BMP has (at least) a 108-byte BITMAPV4HEADER header [2]. Change piex-wasm BMP generation code to use a BITMAPV4HEADER. When the preview image is sRGB, write that to the BITMAPV4HEADER. Otherwise the image is 'adobeRgb' color space: write the RGB CIEXYZ tristimulus (the gamut) and gamma of the AdobeRGB1988 color space, in the encoded forms required by the BITMAPV4HEADER definition. With this change, all images returned by peix-wasm have embedded color space information so rendering these images in a color managed browser like Chrome produces color-correct rendering. [1] https://mzl.la/36S5Fm3 [2] https://bit.ly/30Iag6l Bug: 1132695 Change-Id: Ic53d53f0a68274bb3b4f13fd31c14991d276786b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454891Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#814565}
-
Ramin Halavati authored
Guest NTP is now shown for ephemeral Guest profiles. This change is behind disabled EnableEphemeralGuestProfilesOnDesktop flag. Please see go/guest-on-disk for more context. Bug: 1125474 Change-Id: I1b2e8f727f92c10d561e630ac7bce61b5d4eef94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452731 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#814564}
-
Noel Gordon authored
After CL:2454591 the image request task's colorSpace_ member serves no purpose: remove it. Bug: 1132695 Change-Id: Ib8e5ff2b8ea4bab388cebd7c3b1cc6f31caa558c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454552 Auto-Submit: Noel Gordon <noel@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f36b3a38..8f6d8b45 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idb2f1de7ff9fa3df2edc6221e51ef30f6330dde8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454096Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814562}
-
Risan authored
ChromeOS apparently might send 2 mount events for the same path without unmount event in between. Apparently this cause trouble in the map assignment: map[x] = CreateWatcher(x) Because there, the operation order is: 1. A new watcher is created 2. The old watcher is removed And the old watcher is associated with the same underlying filesystem inotify object with the newly created watcher, causing problem. Therefore, the assignment to the map entry should only happen when there were no old entry. This should solve the crash that happen only when 2 mount events for the same path happens without unmount event in between. When there is no such repeated mount events, this CL is not needed, which explain the random occurrence of the crash that is fixed by this CL. BUG=b:169910596 TEST=Login multiple times and observe no crash. Change-Id: Ibfc2ae15a367aa3ef4b2544fcd4ad570d0ee977f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451930 Commit-Queue: Risan <risan@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#814561}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/90ee6c436017..488d7a9346ff 2020-10-06 dsinclair@chromium.org [spirv-writer] Fix emission of OpExecutionMode 2020-10-06 dsinclair@chromium.org [msl-writer] Emit function constant information If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: kainino@google.com Change-Id: I594a907921e3bd37e9709ed45a041c9d99df1b2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454534Reviewed-by:
-
Mike Jackson authored
Removes the parameterization for all tests in the install_finalizer_unittest.cc file, now that kDesktopPWAsWithoutExtensions flag is always true. Bug: 1065748 Change-Id: Id992575f3b8a3e21960d5be923af38c8af87be1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455206Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/56a6120b0faf..b81fdbee92ce 2020-10-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 326e14f34bb5 to 7e22b1c44fb0 (6 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jvanverth@google.com Change-Id: I8811bcdaa619f5ffa83d3542c53b9485b7115737 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454808Reviewed-by:
-
Wei Lee authored
We have the following requirements: 1. We prefer loading CCA UI in the app window rather than browser tab => Therefore we added "capture_navigation=true" for CCA 2. We don't want to load resource URLs or invalid URL in the app window => Short term: Landing this CL to filter out unwanted URLs We decide not to support URL filtering feature for capture navigation since only camera app has such requirement at this moment. (crbug.com/1132151) Bug: 980846 Test: Type CCA url other than chrome://camera-app/views/main.html and the page is loaded in browser tab Change-Id: I467aa1498aa9fe975d34bdf82adee7f6dff6a14c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440076 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Jiewei Qian <qjw@chromium.org> Auto-Submit: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#814557}
-
Timothy Loh authored
Changes to components/exo appear to be generally less relevant to Guest OS than those matching cicerone|concierge|crostini|guest_os|plugin_vm. This CL updates the WATCHLISTS so they will go to crostini-ui+exo, allowing subscribers to filter these out. Change-Id: Ib9bd2b3843589d03f3c127c89ebc52cd70cae03d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454910 Auto-Submit: Timothy Loh <timloh@chromium.org> Reviewed-by:
Nic Hollingum <hollingum@google.com> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#814556}
-
Ben Reich authored
Add the flag --devtools-code-coverage to FileManagerBrowserTestBase and extend the class to attach a DevToolsListener instance to the foreground Files app page. The Files background_page is ignored due to crbug.com/v8/10820 which causes any renderers sharing the same v8 isolate to report coverage data on an isolate level not on the renderer level. The remainder of renderers (Audio Player, Video Player, etc) are also ignored for coverage to get a minimal set of coverage working end-to- end first: additional renderer support will be added later. Test: browser_tests --gtest_filter="*FilesApp*" Test: browser_tests --gtest-filter="*FilesApp*" --devtools-code-coverage Bug: 1113941 Change-Id: I75455c71bfb2d057f282e29194d5065261552fea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345831 Commit-Queue: Ben Reich <benreich@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#814555}
-
Kent Tamura authored
... to textarea-wrap-submission-value.html. This CL has no behavior changes. Change-Id: I1db197377a0494ff276582d45a7cbbb4deceb7ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454352 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#814554}
-
Ian Kilpatrick authored
There should be no behaviour change. Change-Id: Id7fddb20a0322b013d5467b4cf56e1863f98bc21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454847 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
-
Noel Gordon authored
Add createImageDataArray_ helper and use it to convert the view to the final data: a new Uint8Array(view) as before, but if the image is JPEG and it has 'adobeRgb' color space, embed an adobe color profile in the returned JPEG image data. Remove a TODO: the using code in image_request_task.js no longer needs to manually color correct the image from adobe to sRGB when drawing to the <canvas>. The chrome <canvas> is color managed, and uses the color profile embedded in the image to perform color correction to sRGB. Bug: 1132695 Change-Id: Iec21fb4021d8ab94a377f9fc682873854041bb87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454591Reviewed-by:
-
Mike Jackson authored
Removes the parameterization for all tests in the manifest_update_manager_browsertest.cc file, now that kDesktopPWAsWithoutExtensions flag is always true. Bug: 1065748 Change-Id: Iff13ff4b394a184fbd5b89b76b15475e017591e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453378Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/15f1e5d585c5..e90aefd498fb 2020-10-07 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7a9dea1f87df983280c73daa48897b39f95595ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454805Reviewed-by:
-
Shrek Shao authored
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/91b544d..1a111c2 TBR=kbr@chromium.org Bug: 1135785, angleproject:5038 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64 Change-Id: I618c5db369e68f8088a215f0a9b74f1e82b09636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455029Reviewed-by:
Shrek Shao <shrekshao@google.com> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#814549}
-
Joel Hockey authored
Some test logs show an error clicking on 'photos' folder after going back to the root of MyFiles, so adding a waitForFiles call immediately after clikcing MyFiles to wait for all files (including photos) to be visible. https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8867151645799555504/+/steps/browser_tests__with_patch_/0/logs/Flaky_failure:_FileManagerUITest.CrostiniShare__status_SUCCESS_TIMEOUT_/0 And while I'm here, fix the comment in filemanager_uitest.cc. The --disable-web-security flag allows files to be loaded, but has no affect on chrome:// urls - I don't why I ever wrote that (⌒_⌒;) Bug: 1135410 Change-Id: I9f5a97bb0a209a9590a2a55721cc420cec19ceb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454551 Commit-Queue: Fergus Dall <sidereal@google.com> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#814548}
-
Xianzhu Wang authored
Make PaintArtifactCompositor (PAC) almost ready for unified PaintController for pre-CAP and CAP. Now PaintArtifactCompositor takes a vector of PreCompositedLayerInfo as input. In pre-CAP the vector contains information from GraphicsLayers. In CAP the vector contains one entry as if we created a layer containing everything that needs full layerization. It's flexible to combine the two situations. Actually CompsoiteSVG is already using the combination. In next steps, we'll paint all GraphicsLayers into one LocalFrameView::paint_controller_ instead of multiple ones, and pass PaintChunkSubset of each GraphicsLayer to PAC::Update(). We can also let PAC manage all cc::Layers, after we let PAC generate all properties of cc::Layers. Bug: 1132717 Change-Id: I103ceaf7eefdafb7ada70ddad6f4ee7c346e380b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434768 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#814547}
-
Sunggook Chue authored
When user uninstall a PWA from Windows Settings or Control, it also uninstall PWA from browser registrar. The detailed design spec: https://docs.google.com/document/d/1XjFYnHXCJt08UsbWrQKw5vLW3_vQumOPrB7A9bpHq_s/edit?usp=sharing Bug: 957043 Change-Id: I927213c847033ddf5767679f3d7081d2c6760343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316848 Commit-Queue: Sunggook Chue <sunggch@microsoft.com> Reviewed-by:
Phillis Tang <phillis@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#814546}
-
Edward Lesmes authored
Add Generate DIR_METADATA files and remove metatada from OWNERS files for //dbus. R=hashimoto@chromium.org Bug: 1113033 Change-Id: I5bf308445d3e27bb51792bd7c8c70e8d052b0049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454690 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
-
Jason Lin authored
The implementation is based on UX design [1]. The notifications use some specific notifier Ids to avoid being counted by the systray notification counter when they are displayed. [1] https://docs.google.com/presentation/d/1MWWejK-y2vnBN3Wg__Kd_LIiAcIF3VctzMowMI3wM4w/edit#slide=id.g91c6bdd2e4_0_12 Bug: b/167491603 Change-Id: Ie8a996604d815b387dccba57648d48b8e3ef3881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400794 Commit-Queue: Jason Lin <lxj@google.com> Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3f8200abfd9a..8e79d255b3b9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yosin@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1133955 Tbr: yosin@google.com Change-Id: Iba9210665f2fc680dc9bd92d85f1c43ca1ae9e5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454799Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814543}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Ibaa2e58f06c667eedac98bf320cef0411fdc114b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454696Reviewed-by:
-
Chan Li authored
Bug: 1108016 Change-Id: I8988641e2db1cadd3c35898a504c804d4dc4cf5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453372Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#814541}
-
David Munro authored
Add a flag to signal Tremplin to reset the LXD database when starting LXD. Bug: chromium:1057869 Test: Deploy, set flag, check DB is reset Change-Id: If1e25d59f932271db170ce0430ac8b3a634d6edc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426666 Commit-Queue: David Munro <davidmunro@google.com> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#814540}
-
