GitLab

There were two problems here:
1. When FeatureListCreator created WebLayerVariationsServiceClient it
   was triggering creation of the network service (by calling
   SystemNetworkContextManager::GetSharedURLLoaderFactory). The network
   service has code paths that may check the state of features, so that
   by triggering creation of the network service before features were
   initialized the network service could potentially see features in
   the wrong state.
2. FeatureListCreator was calling PerformPreMainMessageLoopStartup
   followed by SetupFieldTrials(). This is not the expected order (in
   fact PerformPreMainMessageLoopStartup may also trigger creation of
   the network service). This makes the order match that of chrome.

BUG=1049426
TEST=test only change

Change-Id: I21508eada373d368c4f4d4b5d5719b636700dd44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125435
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754528}

Found while working on AshTestHelper.

Bug: none
Change-Id: Ib5baffa110d86fbd83e646268644330e169b0e98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125394
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754527}

This CL moves the //chrome/browser/settings module to browser_ui as
part of an effort to componentize the Site Settings UI so it can be
shared with WebLayer.

See go/weblayer-site-settings for more information.

Bug: 1058597
Change-Id: Iadf179fb02f129113af938e1efc3b15b5e4ec706
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111552Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754526}

This patch introduces the flag which may be used to disable the logic in
Nigori which removes metadata on cache guid mismatch.

When the flag is disabled, the cache guid from model_type_state will
never be changed.

Bug: 1063021
Change-Id: If46232655e1903a3458a7880cb2d713be7395d14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127206Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Rushan Suleymanov <rushans@google.com>
Cr-Commit-Position: refs/heads/master@{#754525}

After https://crrev.com/c/2122718 has landed
which switches to using inner text instead of the kValue
attribute for retrieving the contents of text fields
in AXPosition, there is no longer a need to have a workaround for
computing the parent position of a text position that is
located inside an autofill popup that is a child
of a text field, since the text of the
popup, i.e. the autofill suggestion, would be part of inner text/.
Previously, the kValue attribute didn't reflect the value of any autofill suggestion.

RelNotes: Users of VoiceOver, NVDA and Jaws screen readers are able to use the
"Read Current Line" and "Read Current Word" commands to read the placeholder text in a text field.
<label>Name: <input type="text" placeholder="John Doe"></label>

R=dmazzoni@chromium.org, aleventhal@chromium.org

Change-Id: If57e012e8d16fa2b99e091aa5f86a0f145e266d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125450Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Auto-Submit: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754524}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/f4f16eaf072e..9a8735962f3e

git log f4f16eaf072e..9a8735962f3e --date=short --first-parent --format='%ad %ae %s'
2020-03-30 chrome-bot@chromium.org Update config settings by config-updater.
2020-03-30 gbiv@google.com simplechrome: remove redundant gn arg
2020-03-29 vapier@chromium.org cbuildbot: fix infra_virtualenv checkout during bootstrap
2020-03-29 vapier@chromium.org cbuildbot: include infra_virtualenv in bootstrap
2020-03-28 manojgupta@google.com cbuildbot: Disable reverse dependency logic on toolchain builders
2020-03-27 andrewlassalle@chromium.org build_dlc: Move dlc image creation to build_image phase
2020-03-27 vapier@chromium.org cbuildbot: delete another unused CQ helper func
2020-03-27 shawnku@google.com chromeos_config: disable HW tests for asurada
2020-03-27 riverade@google.com lakitu: Turn off GCETest stage

Created with:
  gclient setdep -r src/third_party/chromite@9a8735962f3e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel
Bug: None
Tbr: chrome-os-gardeners@google.com
Change-Id: I3b663b17e62d1c43175f7f6f029ab5c38b17c153
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127134Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#754523}

This allows setting command-line flags before AshTestHelper is
constructed.

Bug: none
Change-Id: Iab006b3b144948f7a982a6b591dc5e4527b2feb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125179Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754522}

Autofill currently uses a Mojo interface to facilitate WebAuthn (and
because it has different security privileges, it requires a slightly
modified implementation.) However, since both Autofill and WebAuthn
exist in the browser process, it is not necessary to have a Mojo pipe.

This CL replaces the Mojo interface with a simple C++ interface, along
with a method "SetEffectiveOrigin".

There is only a Desktop implementation of this interface -- a follow up
CL will create an implementation for Android.


Bug: 949269
Change-Id: I3c209be3132e7ff8482c6783fc4784a38a438a9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117469Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Nina Satragno <nsatragno@chromium.org>
Commit-Queue: Manas Verma <manasverma@google.com>
Cr-Commit-Position: refs/heads/master@{#754521}

This reverts commit 04e528b0.

Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1066120

Original change's description:
> cros oobe: s/LoginManagerTest/OobeBaseTest
> 
> Moved DemoSetup* and EnableDebugging* tests to OobeBaseTest
> 
> Bug: 987587
> Change-Id: I1b0860861720d1cbd77be9e2c007c74a7e2f8801
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124608
> Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#754456}

TBR=antrim@chromium.org,rsorokin@chromium.org

Change-Id: I9d6fb2c76f75c31be96d4b8bea375d5c83be8e81
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 987587
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127786Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754520}

1. The url bar text and security status icon are now center-vertical
   aligned.
2. The size of the security status icon is fixed to 18dp.
3. 8dp of padding has been added to the end of the url text.
4. Default text size of the url bar text is now to 14 dp.
5. WebLayerShellActivity layout is also modified to better align the
   find-in-page button with the URL bar.

Some screenshots:
https://drive.google.com/drive/folders/1QhvEamyxJrcIpWlTQJUzJWQeNHgtWVa0?usp=sharing

Bug: 1025607
Change-Id: Id4dcd79d1f7d13e3b095199cc89b5a468ab3c51d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106155
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Auto-Submit: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754519}

eglGetMscRateCHROMIUM is not universally supported, so we will
switch to using the ANGLE version of the extension instead.

Bug: chromium:1064078
Change-Id: Ic57e2e55230df1d1c2c584e1cbf54331330a0b87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120453Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Cr-Commit-Position: refs/heads/master@{#754518}

Updates to existing OWNERS file for c/arc/session, and adds a new
OWNERS file for c/b/c/a/session.

BUG=None
TEST=n/a

Change-Id: Id81e8a537afc86d8a1aeeaaec7cba3c82a8e1f9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124537Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: Josh Horwich <jhorwich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754517}

Re-enable TabStripTest#testNewTabButtonWithManyTabs. Tested this
locally on an emulator repeating 20 times without issue.

I'll monitor the flake dashboard to see if this starts flaking and will
investigate further if any appear.

Bug: 592961
Change-Id: Ic25a995859bbba390e7fb73a62931af7ab850c0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124981
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754516}

This adds a util to parse a hex string to uint64. This is necessary for
the ConversionMeasurement API, as the impression data attribute is a
64-bit identifier provided as a hex string.

Link to explainer:
https://github.com/WICG/conversion-measurement-api#impression-declaration

Usage of this is included on https://crrev.com/c/2012883 in
html_anchor_element.cc

Change-Id: I18aeef488477a83dbcb31351fd9179f4957f5f5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123811Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: John Delaney <johnidel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754515}

The reporting API queue reports and send in a batch after a few seconds.
This might be after the WPT test timeout (10s).

This patch switch the timeout to be 'long' for those tests.
TBR=ahemery@chromium.org

Bug: None.
Change-Id: I1cb4ec0f62d43178204e2d1218887ec68000915e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124835Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754514}

Not restoring the capture was causing an issue where
1. The user has abrowser window with a single tab and they begin a drag.
   (The issue doesn't reproduce when detaching a tab during a drag)
2. The cursor moves quickly outside the window and chrome stops
   receiving motion events, so the tab drag stops.

The solution is to restore the capture state after remapping.

R=sky
BUG=416119

Change-Id: Ib85eae48116107afc0fac9708b117fd16b7efd7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125391
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754513}

The ActivityType |incognitoActivity2| was mapped incorrectly from the
String |incognitoActivityType1| instead of |incognitoActivityType2|
String.

This CL fixes the mapping.

Bug: 1035770
Change-Id: If010af9aedbf43b415c1d1220777cc4e3021a4a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126992
Commit-Queue: Rohit Agarwal <roagarwal@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754512}

This pref is going to be checked in multiple places; extensions
management, settings button, web apps, so I found it better to change
it to a list of enums instead of a list of strings.

Bug: 1061859
Change-Id: Ib0bde940c0248f2508271ac0cbfc915ee5e3ca49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124752
Commit-Queue: Aya Elsayed <ayaelattar@google.com>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754511}

This reverts commit 15af2fe9.

Reason for revert: Tests should no longer be flaky after https://chromium.googlesource.com/chromium/src.git/+/9cc2312030ea55160dd559fff630689b7165a472

Original change's description:
> Disable some flaky thread pool/group tests on Windows.
> 
> 
> BUG:1064953
> TBR=etiennep@chromium.org
> 
> Change-Id: Ibcb1f4c184045cc429d733e78f05ff892ca1a018
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121380
> Reviewed-by: Tim Schumann <tschumann@chromium.org>
> Commit-Queue: Tim Schumann <tschumann@chromium.org>
> Auto-Submit: Tim Schumann <tschumann@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#753630}

TBR=tschumann@chromium.org,etiennep@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I6b6a2aa37eb373bf5a981b9b5ba3fab362a09637
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127490Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754510}

Bug: 1057232
Change-Id: I56ec2f8d353bc93ccbebed6801d3b826b3c6c8ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121268Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754509}

The lucicfg vars defined under versioneds/vars were used as the
mechanism to abstract the channel branch details away from the milestone
configuration. Since the channel details have been removed, the
milestone configuration can now be expressed more simply as simple
constants in a milestone specific vars file.

Bug: 1062828
Change-Id: I9ccf3b08d5253f85cdd70b6bbb38f5e0ba137013
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122240
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Auto-Submit: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754508}

Using md5check speeds up the build by not re-compiling resources if its
dependencies have not changed.

Shaves 5 seconds off for Chrome Java Signature Change (77s -> 72s).
Shaves 12 seconds off for Base Java Signature Change (174s -> 162s).

Bug: 906803
Change-Id: Idccbc080dfdfb75b1ce801f3fcd934b93c2c3bb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120047
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754507}

* Use View::Views type alias
* Use make_unique over raw pointers
* EXPECT -> ASSERT where failing will crash
* "5u" in ASSERTs (matches prevailing test pattern)

Bug: none
Change-Id: Idb74ea2b1816ef74efc4b2177b6fce0508cb071e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126287
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754506}

Bug: 1058102
Change-Id: Idb9a212853c9826b654f76ae6aa14e7d776710df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119639Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Yann Dago <ydago@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754505}

Using wpt-import in Chromium 04e528b0.
With Chromium commits locally applied on WPT:
d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers"
6719ca2d "[AspectRatio] Add parsing support for aspect-ratio: X / Y"
9e853511 "Remove broken icon rendering for loading="lazy" images while loading"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
meade@chromium.org:
  external/wpt/web-animations

NOAUTOREVERT=true
TBR=lpz

No-Export: true
Change-Id: I0d2a86a6421082454de17ab6ffbf8ba66b89c4bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127348Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#754504}

This CL is a follow-up of https://crrev.com/c/2123500. It renames
flex-minimum-size-002.html to flex-minimum-size-001.html.

From the previous CL[1], min-size-auto.html was renamed to
flex-minimum-size-002.html and landed given that minimum-size-image.html
was supposed to be renamed to flex-minimum-size-001.html on the CL[2].
But, minimum-size-image.html was eventually renamed to
flex-aspect-ratio-img-column-011.html and there is no longer
flex-minimum-size-001.html.

So, rename flex-minimum-size-002.html to flex-minimum-size-001.html.

[1]https://crrev.com/c/2123500
[2]https://crrev.com/c/2123499

Bug: 1063749
Change-Id: Ic04772fdd0eb2b8cde09d43a735e6f34e017bf83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123956Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754503}

Found while working on AshTestHelper.

Bug: none
Change-Id: Ief613d20336460807cd53f1a36df21a6d4800d91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125299
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754502}

No behavior changed, this is a preparation to introduce B4P's conflict
resolution logic for password generation. We modify the API to take
matches instead of the form fetcher so that the multi-store save manager
can later pass only local matches to it in an overriden method.

Change-Id: Ib0eecb11b63fa23908e74a52116335433270468f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124455Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Victor Vianna <victorvianna@google.com>
Cr-Commit-Position: refs/heads/master@{#754501}

TBR=dtseng@chromium.org

Bug: 1065877
Change-Id: I7e225dc134f8b5cb55214dacca63dbdd65be57a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126990Reviewed-by: Michael Ershov <miersh@google.com>
Commit-Queue: Michael Ershov <miersh@google.com>
Cr-Commit-Position: refs/heads/master@{#754500}

Atomic32 |arm_disarm_counter_| can be accessed from multiple threads.
The watchdog calls NoBarrier_AtomicIncrement() to increase this counter.
Now add volatile qualifier to this class member according to the
function declaration,
Atomic32 NoBarrier_AtomicIncrement(volatile Atomic32* ptr, Atomic32 increment)

Bug:885066,885066

Change-Id: Id842b6de190bbcfb4ecc15293d790b62216700cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126571Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Maggie Chen <magchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754499}

https://skia.googlesource.com/skia.git/+log/e9bc857b39c2..46de36f99362

git log e9bc857b39c2..46de36f99362 --date=short --first-parent --format='%ad %ae %s'
2020-03-30 mtklein@google.com simpler immediates

Created with:
  gclient setdep -r src/third_party/skia@46de36f99362

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC michaelludwig@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: michaelludwig@google.com
Change-Id: I86f97fbff5c4cb971dffd3280be6189ee145c472
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127129Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#754498}

Adds equality to ArchivableCredential based on recordIdentifier.

Bug: 1045456
Change-Id: Ibe38c04745d1cefda3526267005ad24007e92215
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124499
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: David Jean <djean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754497}

Change-Id: Id32ab0a774dc45ca4459e2b709ff82d54389b3c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124949
Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754496}

Bug: 1065009
Change-Id: Icc01e48b583d9e41e1a9523315ed1f66629092c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122477
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Thiemo Nagel <tnagel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754495}

This CL replaces hard-coded English strings with translated IDs.

IDS_PASSWORD_MANAGER_OPT_INTO_ACCOUNT_STORE.png:
https://storage.cloud.google.com/chromium-translation-screenshots/8f84fa679e3583eb4bc1cadd68e4fd91b4952016

IDS_PASSWORD_MANAGER_OPT_INTO_ACCOUNT_STORED_GENERATION.png:
https://storage.cloud.google.com/chromium-translation-screenshots/bc24abb9b5fceb28199f375ee3643b1b8d02f6e9


Bug: 1062344
Change-Id: I9b8485e760f5f41f9638f01ec3ef999c95b8d3db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126987Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754494}

chrome/browser/ui/views/accessibility.

Move caption_bubble.h and .cc from chrome/browser/accessibility to
chrome/browser/ui/views/accessibility. The CaptionBubble is a View so
it should be in the ui/views directory. The CaptionBubble has as its
anchor view the contents_web_view from BrowserView. BrowserView is in
ui/views, so CaptionBubble too should be limited to only OS's that
include ui/views.

Bug: 1055150
Change-Id: If2c291ce25c5020fa8bd1e222fccb345626b4078
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119758Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Abigail Klein <abigailbklein@google.com>
Cr-Commit-Position: refs/heads/master@{#754493}

This is an optimization to avoid unnecessarily creating a worker if it's
going to be immediately destroyed.

In addition, the PerformanceManager can not handle a dedicated worker
whose render process is dead because that means the frame that created
the worker is also already gone.

Bug: 993029, 1064772
Change-Id: Id4ffbcfd34f2c23ad7e3381b92358cf543bae6c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124536
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754492}

This patch is step 3 in [1] and we adds a new RequestDestination field
in the structs / params where only RequestContextType is used.
If we are finish current step then RequestContextType field will be deprecated.

[1] https://docs.google.com/document/d/1kXXnH_27aJYGqjwbXLW6Bs9fW2xFhvZs8gJcXb4xnhQ/edit

Bug: 889751
Signed-off-by: DongJun Kim <djmix.kim@samsung.com>
Change-Id: Iedf80fc00e20e73d6780e0e6deb5ced83d04d13d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106708Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754491}

Bug: 1025603
Change-Id: I3c76b0bc60dba08dd87a9fe3ab25c0cf37f679f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126567
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Auto-Submit: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754490}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0ccd8de267fe..3fffd0d4592e

git log 0ccd8de267fe..3fffd0d4592e --date=short --first-parent --format='%ad %ae %s'
2020-03-30 tvanderlippe@chromium.org Remove unused global references from ui-legacy.js
2020-03-30 tvanderlippe@chromium.org Use built-in Map instead of object map

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@3fffd0d4592e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I16dd1528b4e69badc502935c5bad95a8a5c0ccf0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127127Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#754489}