GitLab

Bug: None
Test: None
Change-Id: Ib19c2d505e63522ac1c2c1798c2de37a5afa53d1
Reviewed-on: https://chromium-review.googlesource.com/c/1303035Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Matt Swartwout <mwswartwout@google.com>
Cr-Commit-Position: refs/heads/master@{#603197}

Bug: 899280
Change-Id: Ie3ac551233bfee2b4fc59fd87884eead21a1debf
Reviewed-on: https://chromium-review.googlesource.com/c/1302102Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603196}

- Add "vp09" parsing in widevine_cdm_component_installer.cc
- Add |supports_vp9_profile2| in media::CdmCapability and
  media::mojom::KeySystemCapability.
- In chrome_key_system.cc, read |supports_vp9_profile2| and decide whether
  EME_CODEC_VP9_PROFILE2 is supported.

CDM supports VP9 profile 2.

Bug: 707127
Test: No functionality change for now. Will update test when Widevine
Change-Id: I2441e65dbf29bdc0d30cdb3f5d26e38afd0e90df
Reviewed-on: https://chromium-review.googlesource.com/c/1297462Reviewed-by: John Rummell <jrummell@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603195}

This reverts commit aa60c219.

Reason for revert: it breaks  network_service_webview_instrumentation_test_apk on Mojo Android Build:
https://bugs.chromium.org/p/chromium/issues/detail?id=899376

Bug:899376

Original change's description:
> Start ServiceManger before creating BrowserMainLoop.
> 
> This CL instantiates the ServiceManagerContext before creating
> the BrowserMainRunner. It splits the startup path into two,
> with/without starting the full browser. The changes are implemented
> behind a flag "allow-start-service-manager-only".
> 
> Bug: 846846,729596
> Change-Id: I3584db0d89a10e59d6041e0f4412aaffdc840568
> Reviewed-on: https://chromium-review.googlesource.com/c/1113802
> Commit-Queue: Xi Han <hanxi@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#603092}

TBR=gab@chromium.org,jam@chromium.org,hanxi@chromium.org

Change-Id: I866cc2148d529d0d7a02d0ac75b2817d1695a8c9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 846846, 729596
Reviewed-on: https://chromium-review.googlesource.com/c/1303042Reviewed-by: Xi Han <hanxi@chromium.org>
Commit-Queue: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603194}

This CL adds a check in MediaViewerUtils to prevent creating a pending
view intent if the intent will throw a FileUriExposedException. This
will prevent the "Open with" option from showing up.

Bug: 893544
Change-Id: Id32d202a0bd9975bca7a93d2be7dc291cf8aab45
Reviewed-on: https://chromium-review.googlesource.com/c/1302104Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603193}

Bits of code have snuck into the local branch without making it
upstream. Add all of those bits here.

Bug: None
Test: Cast CQ
Change-Id: I6e042ae5dd83653e3f3656fcc9559e7b71a77c9c
Reviewed-on: https://chromium-review.googlesource.com/c/1300613Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Simeon Anfinrud <sanfin@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Reviewed-by: Sergey Volk <servolk@chromium.org>
Commit-Queue: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603192}

These names are already in the “cbor” namespace, thus we end up using a
cbor::CBORReader to get a cbor::CBORWriter and it's stuttery.

I defer entirely to the owner's personal preferences here because the
above is obviously just my personal preference. But, thanks to
clang-format, this only took five minutes to do.

(TBR for web_package due to non-semantic change of underlying API.)

TBR=kinuko@chromium.org

Change-Id: I8b34506ebe2aad2779548da0fb451ced61381ccf
Reviewed-on: https://chromium-review.googlesource.com/c/1289509
Commit-Queue: Adam Langley <agl@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603191}

Bug: 832879

Change-Id: Ib39e8caade4114b396337fa2efc04f4a54f69ed3
Reviewed-on: https://chromium-review.googlesource.com/c/1301843Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603190}

Bug: 862043
Change-Id: I78c19396fbacfdf0bc1ee2bffa07b61e75f0ee4b
Reviewed-on: https://chromium-review.googlesource.com/c/1300793Reviewed-by: Doug Turner <dougt@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603189}

BUG=899253

Change-Id: I23075d551c70b72babdb1eb180fe920d748523e2
Reviewed-on: https://chromium-review.googlesource.com/c/1302655Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603188}

Also use CertVerifyProcChromeOS.

Bug: 862043, 887007
Change-Id: I42bc36d58065db35cc70a1a2c587affec25a955a
Reviewed-on: https://chromium-review.googlesource.com/c/1292830Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603187}

BUG=765327
TBR=dtrainor@chromium.org

Change-Id: Iff5b69d1afc4e8ef21e3a9802824fd15ad55862c
Reviewed-on: https://chromium-review.googlesource.com/c/1302853Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603186}

Bug: 884817
Change-Id: Ie2535ee36d806801ecc98891c6ec37c53a339365
Reviewed-on: https://chromium-review.googlesource.com/c/1302329Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#603185}

Will promote back to non-experimental once pool:Chrome-quarantine has
been folded back into pool:Chrome.

Bug: 828031
Change-Id: Icb4f7da5b0aab18ec951bb612acf8d3e7e155a27
Reviewed-on: https://chromium-review.googlesource.com/c/1302657Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603184}

Only 2 values of this enum were used and those values can now be
represented as a BOOL. Also that BOOL will be passed as a method
argument instead of attaching to NSError.

Bug: None
Change-Id: Ifd9985e74997e12cb87fa4d73cae0466b3a3c218
Reviewed-on: https://chromium-review.googlesource.com/c/1300755
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603183}

Bug: None
Change-Id: Id21ef278d400f11f12cdf5e62cdc40810d2d737b
Reviewed-on: https://chromium-review.googlesource.com/c/1301954Reviewed-by: Michael Moss <mmoss@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603182}

https://webrtc.googlesource.com/src.git/+log/fdee701fa8e4..99b71dfd4a7c


git log fdee701fa8e4..99b71dfd4a7c --date=short --no-merges --format='%ad %ae %s'
2018-10-26 danilchap@webrtc.org Use function_video_(en|de)coder_factory from api
2018-10-26 ilnik@webrtc.org Use monotonic clock to derive NTP timestamps in RTCP module


Created with:
  gclient setdep -r src/third_party/webrtc@99b71dfd4a7c

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I76977c16a6bacd60ddff010f90147d1b57e2567c
Reviewed-on: https://chromium-review.googlesource.com/c/1302376Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#603181}

In addition to SO_REUSEADDR, that we were setting before, via
AllowAddressReuse(), for sockets for use with multicast, now also set
SO_REUSEPORT whenever that option is defined. On some non-Windows
platforms, this is needed for multicast messages to be received by all
sockets listening for them. This option is only set in a new
AllowAddressSharingForMulticast() method as the SO_REUSEADDR and
AllowAddressReuse() have other non-multicast uses where SO_REUSEPORT
would not be appropriate.

Also, for non-Windows platforms, bind the multicast sockets to the
multicast group address rather than to a wildcard. This will make us
more likely to only get messages from the relevant multicast group as
some platforms will otherwise give the socket any multicast messages
from groups joined by any sockets in the system. No change on Windows
where binding to a multicast group is not allowed.

TBR=thestig@chromium.org

Change-Id: I24d9d4a0d85134074b2deb14914a41109d7f724a
Bug: 899310
Reviewed-on: https://chromium-review.googlesource.com/c/1298298
Commit-Queue: Eric Orth <ericorth@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603180}

This CL corrects the following outstanding UX polish concerns:
* Tap effects are needed on footer rows
* Footer icon should be 14dp (vs. 16dp elsewhere), and icons should
  have explicit sizes
* Multiline items (e.g., http insecure warning) should wrap, not elide,
  and expand the popup height.

BUG: 898927

Change-Id: Ibe50c6ddea98dcdf91bc1d82e548b651ba486b37
Reviewed-on: https://chromium-review.googlesource.com/c/1297400Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603179}

In Polymer 2, the contents of an element are not stamped until after the
ready callback, unlike Polymer 1 (because of differences within Shadow DOM
v0 and v1).

Bug: 897594
Change-Id: I51509d5823bbffe4fba3bbf3cf7db9aec6c81e8c
Reviewed-on: https://chromium-review.googlesource.com/c/1297630Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603178}

This CL also deletes unused javatest_manifest_config.json

BUG=899274

Change-Id: Icdf3992983af4a0a9b4a942b544570bebd64448a
Reviewed-on: https://chromium-review.googlesource.com/c/1302094
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603177}

Add a placeholder page to show an activity log for an extension, hidden behind the
"enable-extension-activity-logging" command line flag, and accessible via
chrome://extensions/?id=<extension_id>. If the flag is disabled and a user
navigates to the page, redirect to the extensions details page.

Bug: 898309
Change-Id: Ib0f50487c323e8c07d6fddcd57df3b8e5477cfc6
Reviewed-on: https://chromium-review.googlesource.com/c/1295296Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603176}

This reverts commit 0e8f7da5.

Reason for revert: still failing on bots, for example:

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29/75295

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/35731


Original change's description:
> Enable http/tests/webaudio/autoplay-crossorigin.html
> 
> This test can be enabled again.
> 
> BUG=841933
> 
> Change-Id: I8729daf0584da308f089502f0730ae398befb022
> Reviewed-on: https://chromium-review.googlesource.com/c/1299550
> Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
> Commit-Queue: Becca Hughes <beccahughes@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#603107}

TBR=lukasza@chromium.org,beccahughes@chromium.org

Change-Id: Icb53758085810a468770f4492ac43ed1639b140f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 841933
Reviewed-on: https://chromium-review.googlesource.com/c/1302678Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603175}

This test was reenabled in crrev.com/c/1299550, and is breaking
the Mojo Windows and Mojo Linux fyi try bots.

Bug: 841933
Change-Id: I1bfb367a3145e55ed06d966d821f9e596069d7a3
Reviewed-on: https://chromium-review.googlesource.com/c/1302325
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603174}

Bug: 670615
Change-Id: Ifd560c15fe8440d6501935753afb5f6eff6cd176
Reviewed-on: https://chromium-review.googlesource.com/c/1299735
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603173}

BUG=882580

Change-Id: I1a065f608bdd709e74b4bbe83eb744bea5fcc9d2
Reviewed-on: https://chromium-review.googlesource.com/c/1302095Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603172}

mini_installer.exe embeds chrome.7z, and chrome.7z contains timestamps
of all files in the archive. To make chrome.7z more deterministic, give
all files in it deterministic timestamps.

Bug: 330260
Change-Id: Ia251dd38177acbebdde288b86826986f441b2d4d
Reviewed-on: https://chromium-review.googlesource.com/c/1302393Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603171}

Bug: 899239
Change-Id: I17dea00048fb3224dcfb17381ba6a1d5db689793
Reviewed-on: https://chromium-review.googlesource.com/c/1301839
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603170}

Don't create VisiblePosition and VisibleSelection in FrameSelection::SelectFrameElementInParentIfFullySelected()

This patch refactors the function's selection setting and validation
part, so that:

- It stops the problematic pattern of creating VisibleSelection before
  focusing parent frame, which may invalidate the VS

- It no longer creates VisiblePosition and VisibleSelection for creating
  the selection. This is because for a frame owner element, the range
  [before_node, after_node] is already a canonicalized range, on which
  creating VP or VS is unnecessary.

Bug: 657237, 897983
Change-Id: I5b046047071a4af7454cc1bfef52a457fe49d9c2
Reviewed-on: https://chromium-review.googlesource.com/c/1298179Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603169}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/07d9342e84c2..1ef5883ceab7


Created with:
  gclient setdep -r src-internal@1ef5883ceab7

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ia52f63ade549cf9dfe8b5267bda6487ce0ff4d9b
Reviewed-on: https://chromium-review.googlesource.com/c/1302213Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#603168}

https://google.github.io/styleguide/cppguide.html#Namespace_Names
> Namespace names are all lower-case.

This CL has no behavior changes.

Bug: 889726
Change-Id: I6e561ba5f0e92758fb2922bd8e41c4feb70f2203
Reviewed-on: https://chromium-review.googlesource.com/c/1301696Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Cr-Commit-Position: refs/heads/master@{#603167}

TBR=katie@chromium.org
NOTRY=true

Bug: 862710
Change-Id: I6d49841747cdd900570f97e128b647dc15060d04
Reviewed-on: https://chromium-review.googlesource.com/c/1302674Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603166}

The transfer buffer allocation on the client and GURL allocation on the
service was showing up in profiles. Avoid that by caching the last
active URL on the client and only send an update if it changes. Also
hook this up for GPU raster.

R=vmiura@chromium.org

Bug: 894200
Change-Id: If9519f3203a9f53ac16ccbeba685b239339aa5cc
Reviewed-on: https://chromium-review.googlesource.com/c/1298642Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Victor Miura <vmiura@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603165}

This also suppresses issues brought up by the checks that aren't easily
fixable.
Timing without change on chrome_java:
real	0m3.142s
user	0m7.278s
sys	0m0.563s

Timing with change on chrome_java:
real	0m3.429s
user	0m8.035s
sys	0m0.687s


TBR=trivial third_party changes

Bug: 898251, 874854
Change-Id: Ifcb10f260e80a542ab26a470bb53426e1404e9f0
Reviewed-on: https://chromium-review.googlesource.com/c/1297233
Commit-Queue: Sam Maier <smaier@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603164}

This category was not useful. It's adding a trace event for each
top-level post-task, which is about doubling the size of a trace.

Let remove it.

R=oysteine@chromium.org

Change-Id: I271f5314179e7ae6299835c36a0f92a6506eae08
Reviewed-on: https://chromium-review.googlesource.com/c/1301838Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603163}

Currently there is no way to know if a CanvasImageSource comes from
an HTML Image Element, so this CL adds another function to the base
class to differentiate SVGs from Image Elements.

Change-Id: I3978171ba199f372ec685d446215bdfdc83eaa9f
Reviewed-on: https://chromium-review.googlesource.com/c/1301967Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: David Quiroz Marin <davidqu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603162}

There are only ever a couple observers so base::flat_set should
have less overhead that std::unordered_set, especially given how
frequently it's copied.

Change-Id: Ib800e3461dbbb902041584ce8c4325eec4a91694
Reviewed-on: https://chromium-review.googlesource.com/c/1301965
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603161}

Bug: chromium:875740
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Iec6efad4b3d92877288fd29450f11ac008b26d27
Reviewed-on: https://chromium-review.googlesource.com/c/1280551Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Zach Stein <zstein@google.com>
Cr-Commit-Position: refs/heads/master@{#603160}

This reverts commit f144f4a9.

Breaks compile on "Linux Chromium OS ASan LSan":

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Builder/41713

../../ui/views/accessibility/ax_virtual_view.cc:2396: error: undefined reference to 'ui::AXPlatformNodeBase::GetData() const'
obj/ui/views/libviews.a(obj/ui/views/views/ax_virtual_view.o):ax_virtual_view.cc:vtable for views::AXVirtualView: error: undefined reference to 'ui::AXPlatformNodeDelegateBase::GetTreeData() const'
obj/ui/views/libviews.a(obj/ui/views/views/ax_virtual_view.o):ax_virtual_view.cc:vtable for views::AXVirtualView: error: undefined reference to 'ui::AXPlatformNodeDelegateBase::GetIndexInParent() const'
obj/ui/views/libviews.a(obj/ui/views/views/ax_virtual_view.o):ax_virtual_view.cc:vtable for views::AXVirtualView: error: undefined reference to 'ui::AXPlatformNodeDelegateBase::GetReverseRelations(ax::mojom::IntAttribute, int)'
obj/ui/views/libviews.a(obj/ui/views/views/ax_virtual_view.o):ax_virtual_view.cc:vtable for views::AXVirtualView: error: undefined reference to 'ui::AXPlatformNodeDelegateBase::GetReverseRelations(ax::mojom::IntListAttribute, int)'
obj/ui/views/libviews.a(obj/ui/views/views/ax_virtual_view.o):ax_virtual_view.cc:vtable for views::AXVirtualView: error: undefined reference to 'ui::AXPlatformNodeDelegateBase::GetTableRowCount() const'
obj/ui/views/libviews.a(obj/ui/views/views/ax_virtual_view.o):ax_virtual_view.cc:vtable for views::AXVirtualView: error: undefined reference to 'ui::AXPlatformNodeDelegateBase::GetTableColCount() const'
obj/ui/views/libviews.a(obj/ui/views/views/ax_virtual_view.o):ax_virtual_view.cc:vtable for views::AXVirtualView: error: undefined reference to 'ui::AXPlatformNodeDelegateBase::GetColHeaderNodeIds() const'
obj/ui/views/libviews.a(obj/ui/views/views/ax_virtual_view.o):ax_virtual_view.cc:vtable for views::AXVirtualView: error: undefined reference to 'ui::AXPlatformNodeDelegateBase::GetColHeaderNodeIds(int) const'
obj/ui/views/libviews.a(obj/ui/views/views/ax_virtual_view.o):ax_virtual_view.cc:vtable for views::AXVirtualView: error: undefined reference to 'ui::AXPlatformNodeDelegateBase::GetRowHeaderNodeIds() const'
obj/ui/views/libviews.a(obj/ui/views/views/ax_virtual_view.o):ax_virtual_view.cc:vtable for views::AXVirtualView: error: undefined reference to 'ui::AXPlatformNodeDelegateBase::GetRowHeaderNodeIds(int) const'
obj/ui/views/libviews.a(obj/ui/views/views/ax_virtual_view.o):ax_virtual_view.cc:vtable for views::AXVirtualView: error: undefined reference to 'ui::AXPlatformNodeDelegateBase::GetCellId(int, int) const'
obj/ui/views/libviews.a(obj/ui/views/views/ax_virtual_view.o):ax_virtual_view.cc:vtable for views::AXVirtualView: error: undefined reference to 'ui::AXPlatformNodeDelegateBase::GetTableCellIndex() const'
obj/ui/views/libviews.a(obj/ui/views/views/ax_virtual_view.o):ax_virtual_view.cc:vtable for views::AXVirtualView: error: undefined reference to 'ui::AXPlatformNodeDelegateBase::CellIndexToId(int) const'
obj/ui/views/libviews.a(obj/ui/views/views/ax_virtual_view.o):ax_virtual_view.cc:vtable for views::AXVirtualView: error: undefined reference to 'ui::AXPlatformNodeDelegateBase::GetTargetForNativeAccessibilityEvent()'
clang: error: linker command failed with exit code 1 (use -v to see invocation)
[15380/16841] LINK ./app_list_unittests






Original change's description:
> Reland "Adds code in ViewAccessibility to manage the focus of AXVirtualView descendants"
> 
> This is a reland of cb9c3091
> 
> TBR=afakhry@chromium.org,dmazzoni@chromium.org,sky@chromium.org
> 
> Original change's description:
> > Adds code in ViewAccessibility to manage the focus of AXVirtualView descendants
> >
> > Also renamed some methods to make interface more consistent.
> > In preparation for more changes in AXVirtualView.
> > R=dmazzoni@chromium.org, aleventhal@chromium.org
> >
> > Change-Id: Ib417493794cc16536e20c3ce72dc8b00ba8568a9
> > Reviewed-on: https://chromium-review.googlesource.com/c/1296621
> > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> > Reviewed-by: Scott Violet <sky@chromium.org>
> > Commit-Queue: Nektarios Paisios <nektar@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#602876}
> 
> Change-Id: I08aa777df2ce4a7fc93e30e00ef4aced623fdd6e
> Reviewed-on: https://chromium-review.googlesource.com/c/1301796
> Commit-Queue: Nektarios Paisios <nektar@chromium.org>
> Reviewed-by: Nektarios Paisios <nektar@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#603148}

TBR=ellyjones@chromium.org,dmazzoni@chromium.org,sky@chromium.org,afakhry@chromium.org,nektar@chromium.org,aleventhal@chromium.org

Change-Id: Ie75dec553acb4ea618665de25f5729f1feb51e12
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/1302499Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603159}

This reverts commit 4fcaee53.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 603116 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNGZjYWVlNTMxMzliMGFmYjAwM2ZmMWJhMTNiOTAyYTZhM2YyYTMxNQw

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/WebKit%20Mac10.13%20%28retina%29/6030

Sample Failed Step: webkit_layout_tests on ATI GPU on Mac Retina on Mac-10.13.6

Sample Flaky Test: media/controls/overflow-menu-toggle-class-for-animation.html

Original change's description:
> [Media Controls] Added animation to overflow menu
> 
> Toggle "closed" class when open/close menu to achieve transition animation.
> This CL only has opening animation.
> 
> TODO: Add close animation; Add wave like animation to label when opening menu.
> 
> Bug: 814507
> 
> Change-Id: I2a036297741f34905fe868c7ea0a99e9ea91cea3
> Reviewed-on: https://chromium-review.googlesource.com/c/1286949
> Commit-Queue: Jazz Xu <jazzhsu@google.com>
> Reviewed-by: Tommy Steimel <steimel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#603116}

Change-Id: Ia9b6c5e419ec201f6ac328a1de049c65528f6dc0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 814507, 899335
Reviewed-on: https://chromium-review.googlesource.com/c/1302577
Cr-Commit-Position: refs/heads/master@{#603158}