- 01 Dec, 2020 40 commits
-
-
edchin authored
Bug: 1099646 Change-Id: Ie8fb8ef1a281b9b170f9ea49ad2e799f14bd7375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567477Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#832425}
-
Josh Nohle authored
Records whether an HTTP call to send/receive messages from the Instant Messaging API succeeds or fails. On network failures, we log the network error code, and on HTTP response errors, we log the response code. Manually tested send/receive successes and network failures. I was not able to trigger an HTTP response code failure, however. Note: There are a few net::ERR_TIMED_OUT errors even during successful flows. These might be due to the nature of the Instant Messaging API. We will keep logging these error until they become cumbersome. Bug: 1123172, 1105579 Change-Id: I4852435228aff067e248a01692c3c73896d433a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556381 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#832424}
-
Gavin Williams authored
Add a new state CANCELING for showing a continuous progress bar when waiting for a cancel request to complete. http://screen/BJsFQbdZFDZscdV Bug: 1059779 Change-Id: I98ee9863367b602b3a29f8cd3583db36112cc081 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561505 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#832423}
-
Tarun Bansal authored
These histograms are still needed as the experiment analysis is still ongoing. Bug: 1151983 Change-Id: Ib0a5884c8b8ec0adbc1623454da2fb60af518571 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564444 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#832422}
-
manukh authored
Change-Id: I508b6f9cf93b577e984a86754e7353bb6b7ea86d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566370Reviewed-by:
-
Ahmed Fakhry authored
It was added by mistake by me. It is possible to get audio frames after we delete the capturer, since they're sent asynchronously from a different thread. BUG=1154087 TEST=None Change-Id: I297cbb7a2373e716dd5a46e7eb9f406914e059ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566717 Auto-Submit: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#832420}
-
https://crbug.com/1149654Dmitry Gozman authored
Bug: 1149654 Change-Id: Ib5e819b181d4f7ff36bbf7bb60e100334e854692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543545 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#832419}
-
Stephen Roe authored
Bug: 1126177 Change-Id: Iaa9faee2d54a07818397576c948d2b080bc2cc9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566830Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Stephen Roe <steveroe@google.com> Cr-Commit-Position: refs/heads/master@{#832418}
-
Ali Juma authored
A SafeBrowsingQueryManager can get destroyed in |UrlCheckFinished| when it calls |SafeBrowsingQueryFinished| on its observers. This happens when a prerendered WebState tries to load an unsafe URL: upon receiving the unsafe result, SafeBrowsingTabHelper cancels the prerender, which causes the prerendered WebState to be destroyed, and this destroys the SafeBrowsingQueryManager. Continuing to use the SafeBrowsingQueryManager's instance variables after this point causes a crash in |UrlCheckFinished|. This CL guards against this crash by using a weak pointer to detect that the SafeBrowsingQueryManager has been destroyed. Bug: 1153887 Change-Id: I7913f1bbb26253c0fbdfa5d46ca0b2312ba5558e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566092Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#832417}
-
Dominic Farolino authored
This reverts commit 422bc672. Reason for revert: We've collected enough info Original change's description: > Reland "[Prefetch]: DCHECK if recursive prefetch token is set incorrectly" > > This reverts commit 2638a6e6. > > Reason for revert: We thought we had collected enough crash data, however crbug.com/1122182 was not actually fixed yet, so the minidumps did not actually contain the information we needed. agrieve@ has informed me that the issue should be fixed now, and we'll confirm whether or not that is the case by: > 1.) Reverting this change > 2.) Collecting minidumps > 3.) Examining the minidumps to confirm that the debugging information exists > > Original change's description: > > Revert "[Prefetch]: DCHECK if recursive prefetch token is set incorrectly" > > > > This reverts commit b344652b. > > Reason for revert: We have collected enough crashdumps now, and this is > > causing crash metrics to be skewed as it's getting counted as a real > > crash. > > > > Bug: 1132770 > > Change-Id: Ia2e7a92bea2ebeca01c62ca9af73d3fe014685f6 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505985 > > Auto-Submit: Mugdha Lakhani <nator@chromium.org> > > Commit-Queue: Charlie Harrison <csharrison@chromium.org> > > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#822189} > > TBR=csharrison@chromium.org,nator@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > TBR: charrison@chromium.org > Bug: 1132770 > Change-Id: I31ac96c2c5f4f0738fd2d8c4e60236b2bc0c35a3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513109 > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > Reviewed-by: Mugdha Lakhani <nator@chromium.org> > Reviewed-by: Dominic Farolino <dom@chromium.org> > Commit-Queue: Dominic Farolino <dom@chromium.org> > Cr-Commit-Position: refs/heads/master@{#829091} TBR=csharrison@chromium.org,dom@chromium.org,nator@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1132770 Change-Id: Ie8515e382ba8d4610aaeb3026909bec63a1e9405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568110 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#832416}
-
Sadrul Habib Chowdhury authored
Explicitly turn on requestLegacyExternalStorage attribute for native tests, since it is disabled by default on Android 10. The storage access is needed for listing the tests in a test-suite. BUG=none Change-Id: I5f6a399dec50204e47aa4c162ede1a9f64111cf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567713Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#832415}
-
Maksim Ivanov authored
Now that the test_certificate_provider is installed via ExtensionForceInstallMixin, maintaining the .crx and the update_manifest.xml files manually is not needed anymore. Bug: 1090941 Change-Id: Ic76e722f580de5b03cfd5a06dfe5cfb89caeacdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566819 Commit-Queue: Fabian Sommer <fabiansommer@chromium.org> Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Fabian Sommer <fabiansommer@chromium.org> Cr-Commit-Position: refs/heads/master@{#832414}
-
Zhaoyang Li authored
After this CL coverage data from tests in these builders will surface in Gerrit. Changed try builders configs and test configs to enable it on the 2 iOS CQ builders. In order to pass CQ, this change includes builder and test configs. GN config change is in crrev/c/2566333 and will be landed right after. Bug: 1090188 Change-Id: Ia4ddb14633c24b7a0de1f2f85643b3fa0590291c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547921 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#832413}
-
Bruce Dawson authored
The first call to PinUser32 needs to acquire the loader lock and is therefore tagged as being a blocking call. This caused test failures in headless_browsertests.exe because it happened to occur when blocking calls were disallowed. Explicitly calling PinUser32 before blocking calls are prohibited is already done in other test setups so this change adds that to headless_test_launcher.cc and, through code inspection, three other locations (to prevent future issues). Bug: 1147063 Change-Id: I495602ab8f10eca0f756002afbee6d1b0417054c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548350Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Reviewed-by:
Cliff Smolinsky <cliffsmo@microsoft.com> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#832412}
-
sauski authored
Adds new, almost empty, WebUI page at chrome://settings/privacySandbox, which is built to enable access to existing chrome://settings resources. This is a standalone HTML page separate from the main chrome://settings SPA, but served from the same WebUI controller. This allows it to access resources directly via chrome://settings/[settings.js,lazy_load.js] Skipping string check as adding screenshots without context is of low value. Skip-Translation-Screenshots-Check: True Bug: 1152336 Change-Id: I084b57ea51ab750604cd14563b4e688e7c35133e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557502 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#832411}
-
Yoshifumi Inoue authored
This patch gets rid of |PositionAnchorType::kBeforeChildren| because it is equivalent for container@0 (|kOffsetInAnchor|) or before first child node (|kBeforeNode|) to simplify source code for improving code health. This patch also changes |AccessibilityWinBrowserTest| to wait |kValueChagned| event instead of |kTextSelectionChanged| event because selection isn't changed, e.g. selection is at 0 for "x" and 0 for "". Also, these test cases check value of <input> after making it to empty. So, it is better to wait for |kValueChagned| because |kValueChagned| is dispatched after |kTextSelectionChanged| to make test robust, e.g. we may access value of <input> before it changed. Bug: 592887 Change-Id: Ifd2297dcb918428c6a82adfc091e71a1c8902a9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567134Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#832410}
-
Alexander Surkov authored
by inspect factory Bug: 1133330 Change-Id: Ica77066e09a5e624c33d74f5435b8adcb62c3369 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495674Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Rahul Goyal authored
Before this patch, it was not possible to disable Autofill Assistant onboarding flow via feature. This patch, includes the changes to disable onboarding flow via feature. After this patch, it would be possible to disable onboarding flow via feature. Bug: b/174122295 Change-Id: Ieee6022f42cbe82bbcd908a7923a1c47716c6569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560748Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Rahul Goyal <goyalrahul@google.com> Cr-Commit-Position: refs/heads/master@{#832408}
-
Elaine Chien authored
Bug: 1145666 Change-Id: I9bf3357d7d03437ca75d2fe6150ee771ceab5d7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543083Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Elaine Chien <elainechien@chromium.org> Cr-Commit-Position: refs/heads/master@{#832407}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/efc444306186..aa250cf881de 2020-12-01 pprabhu@chromium.org Refresh build API bindings 2020-11-30 engeg@google.com cbuildbot: report cros/parent_buildbucket_id for COIL 2020-11-30 zhuohao@chromium.org volteer: add factory branch builder 2020-11-30 vapier@chromium.org portage_util: note when we can drop CROS_WORKON_BLACKLIST 2020-11-30 allenwebb@google.com portage_util: Add cros-rust to _ECLASS_IMPLIES_TEST. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Ib76439fbb31eeb1afa33cd0e0d0b12f55b5ce5d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568013Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#832406}
-
Vladimir Levin authored
This patch removes the IsMainFrame check since the event recording should still happen. The subframe url is stripped out already since the document is using a UkmSourceId that shouldn't have the url. The event can then be correlated with the main frame url while doing analysis. Bug: 1150619 R=rkaplow@chromium.org, chrishtr@chomium.org Change-Id: I9433b180d8b308c26701b18df99e640730d3aa96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550482 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Yue Ru Sun <yrsun@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/e50a1d65fa41..2095c0498a0f 2020-12-01 jophba@chromium.org Apply FlatMap patch feedback If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I217d9a7096e3e8761f017924519eae78d7d5d02d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568051Reviewed-by:
-
Glen Robertson authored
Bug: 1145757 Change-Id: Ib2b59562da450c5608fb727bef99a8d41db1e971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566535 Auto-Submit: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#832403}
-
Rahul Arakeri authored
This CL extends the lifetime of some scrollbar related histograms. Bug: 1140031,1140032 Change-Id: I5a6ecd1619e9806824c65b3c04e672aa056c0803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565438Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
-
Eric Lawrence authored
Remove the code for the arrow icon no longer used in the new layout. Bug: 1143472 Change-Id: Ic003e16bb392d21ba7136383b20511f705fd606f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560931Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Cr-Commit-Position: refs/heads/master@{#832401}
-
John Chen authored
The android-pixel4a_power-perf devices have been upgraded to Android R. Bug: 1151960 Change-Id: I6ce779c97d8f8ee39ab5826800bdf914e5b782ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566493 Auto-Submit: John Chen <johnchen@chromium.org> Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#832400}
-
Nina Satragno authored
Polish the security key settings page: * Wire up the forcePinChange flag. When a user attempts using a key with the forcePinChange flag on, they are shown a dialog explaining they have to set a new PIN. * Dialogs that require the user to set a new PIN will now show a default button taking the user directly to the set PIN dialog. * Fix the string shown when the user is required to set a new PIN on the bio enrollment dialog. TBR'ing cpu@ for grdp updates. UXW review: go/force-pin-change-ux Tbr: cpu@chromium.org Fixed: 1143427,1150131 Change-Id: Ice18acb7546cde4cd53d4dd4488636263325a50d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561702Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Reviewed-by:
-
Maksim Sisov authored
After use_x11 && use_ozone started to be set at the same time, non-Ozone/X11 (and it was also a bug in Ozone/Linux, actually) started to show cursor with wrong rotation. The reason was the code for ChromeOS that could rotate cursor as the physical and logical rotation can be different, which is not the case for other platforms. Bug: 1152217 Change-Id: I0f013f20c3aa2b5538cd6e37af73fd2b2d2dfae7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563298 Auto-Submit: Maksim Sisov (GMT+2) <msisov@igalia.com> Reviewed-by:
-
Wojciech Dzierżanowski authored
//components/remote_cocoa will start using these utilities in a subsequent CL. Bug: 1123249 Change-Id: I3a19b0233e59d7be6782e0c28b596a9a368864f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563669Reviewed-by:
-
John Chen authored
Two recent CLs https://crrev.com/832165 and https://crrev.com/832171 interfered with each other, resulting in an out-of-date chromium.fyi.json, causing presubmit errors and blocking any CLs that modifies testing/buildbot directory. (e.g., https://ci.chromium.org/ui/p/chromium/builders/try/chromium_presubmit/1062637/overview). Change-Id: Ie5aecd3ed98b564b86080ef2a399944e3d096e04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567174 Auto-Submit: John Chen <johnchen@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#832396}
-
David Van Cleve authored
This CL contains some comment changes that should make it somewhat easier to keep the docs in sync with protocol changes: - it adds warnings to the signing helper and to the key commitment parser, advising authors of code changes to make sure the docs agree with their changes; - it removes a large comment that basically reproduced the design doc's example key commitment result, which is pretty brittle and could easily go out of sync. R=svaldez CC=ykevin@google.com Bug: None Change-Id: I217d199997da04b19a3b339918af3da2aead0b88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565282 Auto-Submit: David Van Cleve <davidvc@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#832395}
-
Marc Treib authored
- Remove the AssociationGroup param of StartNextAssociation; instead just pass in the relevant ModelTypeSet. The AssociationGroup enum was just confusing. - Update a bunch of comments. - Random small cleanups (adding "const", updating DCHECKs, ...). Bug: 1102837 Change-Id: I47876ea845d4993567e312bc51467c05c5575f9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566933 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#832394}
-
Abigail Klein authored
Bug: 1055150, 1152615 Change-Id: I06c622fa60653868643e75d814f32c6c20e8742a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567040 Commit-Queue: Abigail Klein <abigailbklein@google.com> Reviewed-by:
-
Mike West authored
This patch moves `X-Frame-Options` parsing out of AncestorThrottle, and into the network.mojom.ParsedHeaders struct so that it's parsed along with other headers that affect how we load resources during navigation. Bug: 1153274 Change-Id: I2287de1f2610cb79a6dd4d37de6f3128c2c2b72f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563489 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#832392}
-
Fredrik Söderqvist authored
Empty containers will fail to create FilterData because they have an empty bounding box. When children were added to the container, making the bounding box non-empty we would fail to mark the paint properties as needing update because of the check for existing FilterData in SVGElementResourceClient::InvalidateFilterData(). Instead always dispose of the filter data and mark paint properties for update, and use the |filter_data_dirty_| flag as an early-out check. Since we can now call InvalidateFilterData() directly in SVGElementResourceClient::ResourceElementChanged(), fold ClearFilterData() into InvalidateFilterData(). Bug: 1154050 Change-Id: I01c8ebac4f62532e2c17aabc3d998d7601dbb71b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566992Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#832391}
-
Eric Robinson authored
Changing the names of files here and where they're referenced. There's also other locations in v8/tools/memory/asan and third_party/dawn/tools/memory/asan that will need to be changed, but scoping this to the changes referenced in the bug. Bug: 1097270 Change-Id: I008e8f5eae60ec4cadb224a4b652f183951c7cb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565170Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Reid Kleckner <rnk@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Commit-Queue: Eric Robinson <ericrobinson@chromium.org> Cr-Commit-Position: refs/heads/master@{#832390}
-
Natalie Chouinard authored
Test is failing on android-pie-x86-rel, but not android-pie-arm64-rel. TBR=peconn@chromium.org Bug: 1154180 Change-Id: Ifebfce5af7f0aec49e7b1d47f305fd1bb89ac7fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567816Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#832389}
-
Andres Calderon Jaramillo authored
This CL increases the size passed to VaapiWrapper::CreateContext() from 64x64 to 128x128. It seems that there is a minimum size that is not obvious through vainfo -a. However, when doing vadumpcaps, the VP9Profile0/EncSliceLP lists min_width: 128, min_height: 96 for the associated surface formats. Therefore, 128x128 should allow the context to be created and the test to continue. Bug: b:174486634 Test: graphics.VAAPIUnittest.common on volteer2 and drawlat. Change-Id: I5fe06e2aa3e5e5247fd14b3a016645fad948400c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566253 Auto-Submit: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#832388}
-
Clemens Backes authored
The faulty CL was reverted in v8 (https://crrev.com/c/2566446), thus the test can be re-enabled. This reverts commit 6060bada. R=ahaas@chromium.org Bug: chromium:1153626, chromium:1153968 Change-Id: Ia278167b2425d8e16b8d01162d24c513a33c89da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567874Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#832387}
-
Sebastien Lalancette authored
Reused UKM logging functions from the common shared_highlighting component to log UKM events when a link with text fragments has been opened and its fragments have been processed (LinkOpened event) and also when a link-to-text has been generated for the user (LinkGenerated event). Validated that the events show up on chrome://ukm. Bug: 1148807,1153990 Change-Id: Ibcab06305a31ee6c4d280a65a64f0b21af093209 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553002 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#832386}
-
