- 13 May, 2019 40 commits
-
-
Javier Ernesto Flores Robles authored
Adds a swipe gesture recognizer that dismiss the keyboard when the alert is swipped down. Bug: 960417 Change-Id: I1179a158f9860754278ce73f1ee068ccbbaf2d8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602642 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#659000}
-
Robert Ma authored
disabled-service-worker-servicification doesn't exist any more. Change-Id: Ia0527eab67a5a5de911f3f963eb286fc92f0e3ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604501 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#658999}
-
Javier Ernesto Flores Robles authored
Adds a tap gesture recognizer to the alert's chrome so when tapped the text fields resign first responder, causing the keyboard to dismiss. Bug: 960418 Change-Id: Ib855a66ffaedf6ee14ccac25422bf9b804b5a9c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602640 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
Victor Costan authored
Change-Id: Ie79eca491c80d656c4aa7313336e480d7541b0ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608317 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Staphany Park <staphany@chromium.org> Cr-Commit-Position: refs/heads/master@{#658997}
-
Alex Ilin authored
NOPRESUBMIT=true TBR: bsheedy@chromium.org Bug: 962397 Change-Id: I58422dc0f1356c82220b0b58d3f9f2655c3474ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608705 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#658996}
-
Alex Ilin authored
arm64 has execute-only memory (XOM) protecting code pages from being read. PosixModule reads executable pages in order to extract module info. This may result in a crash if the module is mapped as XOM. This CL effectively disables ModuleCache on POSIX arm64 platforms. Alternative solution would be to obtain map permissions before accessing module's executable memory by parsing /proc/self/maps. Then, return nullptr iff the mapping has execute-only protection. Bug: 957801 Change-Id: I37b2dfa012a0f723a75579d0aabe4c096762f948 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599391 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#658995}
-
Hwanseung Lee authored
there are some functions which node object was passed as a parameter at child_list_mutation_scope.h. and the object is never nullptr. so it can be changed to reference instead of pointer. Bug: 874385 Change-Id: I66f3840c688b50fe622712727e1c3fb0c90bae92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604394Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#658994}
-
Jérôme Lebel authored
Adding "Manage Your Google Account" in Google services settings. https://drive.google.com/open?id=1rTrTW4W94J_gWjQa5fsTeJqMk0jzVQbY Bug: 961257 Change-Id: I8a6b13f40e4b3b09e3ebcef546dc5d0f9b75e38f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602510Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#658993}
-
Javier Ernesto Flores Robles authored
Uses the center constrains of the view's safe area instead of the view ones. R=kkhorimoto@chromium.org Bug: 951300 Change-Id: If97c99f1d14dc4545833b9316364834f3862bb18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594712Reviewed-by:
-
Yi Su authored
This CL removes CRWWebController.referrerFromNavigationAction which is not a very helpful method. The HTTP header constant "Referer" is moved into wk_navigation_util.h/mm for possible reuse. Bug: 956511 Change-Id: I8036c773c2dabde04282e93b34d97e89940ca191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599588 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#658991}
-
Dominic Battre authored
TBR=nhiroki@chromium.org Bug: 867532 Change-Id: If70324e4f9d5f7479299efd1cd24cd7c5bbee5fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608702Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#658990}
-
Hiroki Nakagawa authored
This CL makes WorkerFetchContext::Detach() clear WorkerFetchContext::resource_timing_notifier_ to cut off the cross-thread persistent as soon as possible during worker thread termination. Before this CL, I guess the notifier can outlive worker thread's termination GC in WorkerBackingThread::ShutdownOnBackingThread(), and that causes the failure on the parent thread as the issues say. I tested this using the script in issue 960626, and confirmed the failure doesn't happen with this CL. I also tried the script in issue 959508 but couldn't reproduce it regardless of this CL. It will be tested by the fuzzer instead. Bug: 959508, 960626 Change-Id: I2663e5acddec0d9f88a78842c093c594fb57acb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609024 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#658989}
-
Michael Lippautz authored
Garbage collections on page navigations are also initiated by V8 (see v8::Heap::NotifyContextDisposed for non-dependent contexts) using its memory reducer mechanism. Since they cover Blink with with unified heap we do not need to schedule anything else there. Bug: 948807 Change-Id: I17a7d9235fd80b8cfc91fd55cab904873166056f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605408Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#658988}
-
Yi Su authored
CRWWebController.safeBrowsingWarningDetectionTimer is used for updating navigation status when SafeBrowsingWarning is displayed. This CL moves it into CRWWKNavigationHandler to support next step refactor. Bug: 956511 Change-Id: I662605492d461f4f8a5f3ed171705539f9a8eaa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598803Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes |NGAbstractInlineTextBox::GetText()| to include a collapsed space when it is collapsed by soft line wrap. This patch fixes unit test failure of DumpAccessibilityTreeTest.AccessibilityInputTypes. Change-Id: Ic17caddde97295adf3dd8c56826dd37c8c194371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609003 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#658986}
-
Oleg Davydov authored
Also added myself to owners, so next time histogram-eraser bot will notify me too. Bug: 960060 Change-Id: I67523ed33db6cc803dc95da8b11579681429572a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605414Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#658985}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c61db7ff2004..9b48fcfc9759 Created with: gclient setdep -r src-internal@9b48fcfc9759 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=anthonyvd@google.com,alph@google.com,battre@google.com Change-Id: I7e787a2250de8b8b38f2025e7f27e65ca1081d1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608838Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658984}
-
Mitsuru Oshima authored
It's regressed in crrev.com/c/1414170. It's just plain wrong but I don't remeber why I changed this way. Bug: 960121 Test: Covered by unittest Change-Id: I0448648c3d661b9a2a9a3b98104d949c2c5a5573 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595562Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Commit-Queue: Mitsuru Oshima (slow - gardening) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#658983}
-
Alex Clarke authored
This is the internal promise representation. It implements the machinery needed to marshal and dispatch promises as they become ready for execution. Care has been taken to try and minimize the size of the AbstractPromise class and to keep down the number of heap allocations. The promise result and the executor are both stored in the base::unique_any since they are never needed at the same time. The size of AbstractPromise on x64 is 96 bytes in builds without DCHECKS. In builds with DCHECKS it's larger because there's additional storage used to diagnose and prevent various usage hazards: * Unhandled rejection * Double move of promise results to callbacks * Mixed move and non-move semantics of promise results to callbacks The base::any_internal type has been adjusted so it can store the SmallUniqueObject<> inline, which is used to store the promise executor. The largest anticipated promise executor base::All is the size of 3x sizeof(void*) to hold a vtable and a std::vector. Design: https://docs.google.com/document/d/1l12PAJgEtlrqTXKiw6mk2cR2jP7FAfCCDr-DGIdiC9w/edit TBR=fdoray@chromium.org, etiennep@chromium.org Bug: 906125 Change-Id: I62cecf23ecc8ea3ef7417d6ad40c0911fac5339c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607643Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#658982}
-
Jan Krcal authored
This CL adds metrics to help investigate an increased number of address conversions in the USS implementation. Bug: 953693 Change-Id: I4085ce5ca11a8354d686ca7ae37f6e1d2dd7cfc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598812 Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#658981}
-
Mikel Astiz authored
There's no need to keep this code under sync/base after the last refactorings, so we can shrink base libraries, which many build targets depend on. Bug: 922971 Change-Id: Ib033a694c9bdd732a3e4346fb63121f540235e60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564129Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Satoru Takabayashi <satorux@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#658980}
-
Meredith Lane authored
Due to changes in the API, AccessibleNode will no longer be able to modify the underlying accessibility tree. For more information on the motivations for this, see: https://github.com/WICG/aom/blob/gh-pages/explainer.md#what-happened-to-accessiblenode BUG=746523 https://github.com/WICG/aom/blob/gh-pages/explainer.md Change-Id: Ia8fd5c6994e97e317a7360739a8a9d0d6d246fa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573299Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#658979}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/cd862e37ea29..42db0b42abad git log cd862e37ea29..42db0b42abad --date=short --no-merges --format='%ad %ae %s' 2019-05-13 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@42db0b42abad The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Id67d8e9fab628829351addd7cc4d3b8c9a636492 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608695Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658978}
-
Meredith Lane authored
Due to changes in the API, AccessibleNode will no longer be able to modify the underlying accessibility tree. For more information on the motivations for this, see: https://github.com/WICG/aom/blob/gh-pages/explainer.md#what-happened-to-accessiblenode BUG=746523 Change-Id: Ib4da0a078abc72fb348038dd1d78bb333fb25d91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591493Reviewed-by:
-
Koji Ishii authored
This patch fixes use-after-free when memory reallocation occurs by adding BoxData for bidi inline fragmentations. Bug: 925247, 961943 Change-Id: I5c2cd26546b45772fbff7d001d9e98e49ab19461 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607719 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#658976}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c3ab74371c2a..c61db7ff2004 Created with: gclient setdep -r src-internal@c61db7ff2004 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=anthonyvd@google.com,alph@google.com,aboxhall@google.com,battre@google.com Change-Id: I6c166f97027b8342c976adf204151575c1b255f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608693Reviewed-by:
-
Satoshi Niwa authored
This means using CrOS file selector as default Android file picker go/arc-file-selector Bug: 64281746 Test: atest android.appsecurity.cts.DocumentsTest Change-Id: Ie6f9e5319830b80da1d7a74e164945ef90ece9d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608864Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Satoshi Niwa <niwa@chromium.org> Auto-Submit: Satoshi Niwa <niwa@chromium.org> Cr-Commit-Position: refs/heads/master@{#658974}
-
Gyuyoung Kim authored
As the second step to move the date time picker to Blink, this CL moves all implementations of the date time picker from content/renderer to blink. Major changes are as below, - Rename DateTimePicker to DateTimeChooser. - Rename date_time_picker.mojom to date_time_chooser.mojom. - Make ExternalDateTimeChooser to communicate content::DateTimeChooserAndroid::OpenDateTimeDialog through mojom::DateTimeChooser interface. - Make ExternalDateTimeChooser call ExternalDateTimeChooser::OpenChooser instead of WebViewClient::OpenDateTimeChooser. - Remove struct WebDateTimeChooserParams, enum WebDateTimeInputType, WebDateTimeChooserCompletion, and struct WebDateTimeSuggestion because they're not used anymore. Instead, this CL converts blink::DateTimeSuggestion to blink::mojom::DateTimeSuggestionPtr directly. TEST: WebViewTest.ChooseValueFromDateTimeChooser is updated. Bug: 950157 Change-Id: Ia82454d44da1367f7d8269db88b1181f26ae33b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595203Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/695206d7149a..7bc76b45a4b9 git log 695206d7149a..7bc76b45a4b9 --date=short --no-merges --format='%ad %ae %s' 2019-05-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 ebab670cb32d..3dbe480b559e (16 commits) 2019-05-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 589d8ec2..97d57619 (957 commits) Created with: gclient setdep -r src/third_party/skia@7bc76b45a4b9 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Change-Id: Iebc081f0f66a9a9d4516cafd116794f8d3dada2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608831Reviewed-by:
-
Alexey Baskakov authored
Reuse one web contents for all pending synced web apps. This will avoid pathological cases where n renderers for n web apps are spun up on first sign-in to a new machine. - Implement WebAppInstallTask::InstallWebAppFromInfoRetrieveIcons method. - Plumb AppRegistrar to WebAppInstallManager. - Plumb error_on_unsupported_requirements and locally_installed params in InstallFinalizer::FinalizeOptions. - Extract UpdateWebAppIconsWithoutChangingLinks as a standalone util. Bug: 901226 Change-Id: I82c2e925a7f6fcaeca8bdc125b60ece6ee7e68fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591496Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#658971}
-
Yutaka Hirano authored
Now we're using mojo DataPipe and we can remove the class. Bug: 894819 Change-Id: I1d8a48e4b8bc72e795c00a83f12ffd08847bbbb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608862Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#658970}
-
Maggie Cai authored
This CL fixes an issue where the preferred app launched automatically even when not navigating from a link. Currently whenever we query ARC apps, the preferred app is always automatically launched. This CL plumbs a boolean to only automatically launch the preferred app when the app query is from a link navigation. BUG=939205,962356 Change-Id: I1784ee02140f043cba9d61a69d23a2aaceb02b34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608863 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
-
Kenichi Ishibashi authored
This arg was broken (see the attached image in the linked bug). Explicitly convert KURL to TracedValue to record the url correctly. Bug: 961553 Change-Id: I2abc1410527608c043375a522d5548fb974cb76a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604392 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#658968}
-
Luciano Pacheco authored
Previously ActionsController would calculate the additional actions for Drive (share, create-shortcut, etc) and FSP [1] like change directory, selection changed, and metadata updated. When these events arrive in FilesApp, they update the <command> and <cr-menu> DOM state. However, that can cause flickering in visible menus and also flakes in browser tests based on menus, since these events can happen while the menu is displayed for an entry or set of entries (selection) or affect entries other than those associated with the menu. This CL changes ActionsController to store state in an internal map, rather than in the DOM, and to only update the menu DOM state when a user-action shows the menu. Change CommandHandler to set the visibility for Drive actions/commands synchronously to avoid flickering the size of the menu - it still can flicker the disabled state and pinned check-mark, but these are softer to human eyes than the change in size. Change ToolbarController to update its refresh button disabled state. The button relied on FileManagerCommands to update the |refresh| state command, which was not correct because the refresh button always acts on the current directory, whereas the command was being evaluated for different entries. Change Action models and derived classes to have a |getEntries| method so that ActionsController can get the entries that it is acting upon to invalidate the state prior to executation. Change ActionsSubMenu.setActionsModel to forward the target element, so the <command> can be updated to the correct target element. Change PluginVM test to use keyaboard shortcut instead of refresh button, because it was failing to refresh speculatively due to the button been disabled when clicked. [1] https://developer.chrome.com/apps/fileSystemProvider#event-onGetActionsRequested Change-Id: I33f322689d083b307e55ec9f045ee253bcde2c60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608962 Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#658967}
-
Satoshi Niwa authored
Fix ConvertPathToArcUrl so DocumentsProvider path doesn't get encoded to a ChromeContentProvider URL. See b/132314050 for details Before: content://org.chromium.arc.chromecontentprovider/externalfile%3Aarc-documents-provider%2Fcom.android.cts.documentprovider%2Fdoc%253Alocal%2FWEB_LINKABLE_FILE After: content://com.android.cts.documentprovider/document/doc%3Aweb-linkable-file I tried to add a new test case for this but found it difficult to create a mock for chromeos::CreateExternalFileURLFromPath Bug: 132314050 Test: unit_tests --gtest_filter="FileManagerPathUtilConvertUrlTest.*" Change-Id: Ief4cc5dca4ad81c883c652efb02ffe64f938328d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605386Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Satoshi Niwa <niwa@chromium.org> Auto-Submit: Satoshi Niwa <niwa@chromium.org> Cr-Commit-Position: refs/heads/master@{#658966}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/806621b2e0b5..695206d7149a git log 806621b2e0b5..695206d7149a --date=short --no-merges --format='%ad %ae %s' 2019-05-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader ecfeede6014c..9e4f690166c1 (28 commits) Created with: gclient setdep -r src/third_party/skia@695206d7149a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Change-Id: I39361ff40e1e8cbfad8f0bdd6b7b5eb2d882cd45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608435Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0d4e828d2f38..c3ab74371c2a Created with: gclient setdep -r src-internal@c3ab74371c2a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=anthonyvd@google.com,alph@google.com,aboxhall@google.com,battre@google.com Change-Id: I82d0c247817adf94d7e1b4a95a3a7aaaa83b6171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608920Reviewed-by:
-
Simon Que authored
R=tikuta@chromium.org, ukai@chromium.org, yyanagisawa@chromium.org Bug: 915568 Change-Id: I6dfe325473b58aab7e1d6f79f2ab05b5db768da3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608870Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#658963}
-
Jia authored
A lot of implementation complexity is caused by this class not copyable. This cl also adds inequality operator. Bug: 881215 Change-Id: Ic638252eb6007d5bac7332621d28d8a78f6aae42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608869Reviewed-by:
Michael Martis <martis@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#658962}
-
Kenichi Ishibashi authored
If a worker creates a nested worker, there should be a performance entry on the parent worker because: * The spec specifies that the client of "run a worker"[1] comes from outside settings object. * [2] says that a performance entry should be included in the performance timeline of the client's global context. [1] https://html.spec.whatwg.org/multipage/workers.html#run-a-worker [2] https://w3c.github.io/resource-timing/#resources-included-in-the-performanceresourcetiming-interface Bug: 961552 Change-Id: I979f3f2e89a93545746ddd2124c931f4aa334bbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607714Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#658961}
-
