- 06 Feb, 2020 40 commits
-
-
David Bertoni authored
Bug: 1049214 Change-Id: I64018260d06070da03821bbcb72578de62359be3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042313Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#739076}
-
Donn Denman authored
Reenable testLongpressExtendinSelectionExactResolve which was disabled due to flakes. It's an important test of a new feature, so bringing it back in a limited way. It looks pretty solid on non-tablet M+. TBR=mastiz@chromium.org BUG=1048827 Change-Id: I5c3878a3e5059b71b9eebae6af43bd1e7158b273 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042377Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#739075}
-
chromium-autoroll authored
Roll broadwell AFDO profile from 81-4028.0-1580732019-benchmark-81.0.4044.9-r1 to 81-4028.0-1580732019-benchmark-81.0.4044.11-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Id57449e5a6c973f6e6dd1619c78a461fa10c45ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042333Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#739074}
-
Martin Kreichgauer authored
This adds a FidoDiscovery::Stop() method that can be used to terminate authenticator discovery without destroying the instance. FidoDeviceDiscovery upon receiving Stop() will ignore all calls to AddDevice() and RemoveDevice(). FidoCableDiscovery inherits this behavior and also calls Unregister() on all pending BleAdvertisements. Lastly, AuthenticatorCommon is changed to stop all discoveries of the current FidoRequestHandler prior to signaling failure of the request to the UI layer. This fixes an issue where Chrome might continue to advertise caBLE EIDs while the UI is showing an error sheet, e.g. because the request timed out or because one of the authenticator returned an error that causes the UI to show its retry error sheet. Bug: 1046164 Change-Id: Ic5678f13a10efbb56277e6bd3485dd985c8ab0c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036266 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#739073}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/74e27c36bc28..e4d9391c167c Created with: gclient setdep -r src-internal@e4d9391c167c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1028270,chromium:1033112 Tbr: jbudorick@google.com Change-Id: I89e04cd6b3ac94954cc73838b9e41e1b32d4cfa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041808Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#739072}
-
alex linker authored
histogram macros it was recommended by bcwhite@ on another cl to change all the macro calls to function calls to avoid instantiating the caching code. BUG=1044710 Change-Id: I1e6dfd9caa2f8250892a7505f30398a50f243483 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040632Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Alex Linker <ajlinker@chromium.org> Cr-Commit-Position: refs/heads/master@{#739071}
-
Austin Eng authored
This reverts commit 1fd0446b. Reason for revert: These tests are failing on Android Nexus 9 Original change's description: > Add EXT_texture_compression_bptc extension support > > Bug: 1013369 > Change-Id: I04a8ce5ce11fb6a5d67acc782c2e297224b8685b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029236 > Commit-Queue: Shrek Shao <shrekshao@google.com> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738764} TBR=dcheng@chromium.org,kbr@chromium.org,shrekshao@google.com Change-Id: I3478e6e5b698d4a660d62794b7b524c9cdf7f0ab No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1013369, 1049733 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042294Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#739070}
-
Steve Becker authored
Splits each of the following tests into 3 separate tests to avoid timeouts: native_FileSystemBaseHandle-postMessage-manual.https.tentative.html native_FileSystemBaseHandle-postMessage-MessagePort-manual.https.tentative.html These tests take 5 to 7 seconds to pass, which is dangerously close to the 7 second timeout. A previous attempt added <meta timeout=long> to address the timeouts. However, wpt.py does not respect <meta timeout=long> for tests with filenames that contain "manual". The following bug requests a fix for wpt.py: https://github.com/web-platform-tests/wpt/issues/21527 This change solves the timeout by splitting each test into 3 groups: iframe tests, window.open() tests and worker tests. The change adds the following 12 test files since each test runs twice, once for the native file system and once for the virtual file system: Native file system tests: native_FileSystemBaseHandle-postMessage-frames-manual.https.tentative.html native_FileSystemBaseHandle-postMessage-windows-manual.https.tentative.html native_FileSystemBaseHandle-postMessage-workers-manual.https.tentative.html native_FileSystemBaseHandle-postMessage-MessagePort-frames-manual.https.tentative.html native_FileSystemBaseHandle-postMessage-MessagePort-windows-manual.https.tentative.html native_FileSystemBaseHandle-postMessage-MessagePort-workers-manual.https.tentative.html Virtual file system tests: sandboxed_FileSystemBaseHandle-postMessage-frames.tentative.https.window.js sandboxed_FileSystemBaseHandle-postMessage-windows.tentative.https.window.js sandboxed_FileSystemBaseHandle-postMessage-workers.tentative.https.window.js sandboxed_FileSystemBaseHandle-postMessage-MessagePort-frames.tentative.https.window.js sandboxed_FileSystemBaseHandle-postMessage-MessagePort-windows.tentative.https.window.js sandboxed_FileSystemBaseHandle-postMessage-MessagePort-workers.tentative.https.window.js Bug: 1046634 Bug: 1044519 Change-Id: Ide552f708d7514e299a68887b91659ac2226018d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035055Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Steve Becker <stevebe@microsoft.com> Cr-Commit-Position: refs/heads/master@{#739069}
-
chromium-autoroll authored
Roll airmont AFDO profile from 81-4028.0-1580726817-benchmark-81.0.4044.9-r1 to 81-4028.0-1580726817-benchmark-81.0.4044.11-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I33b5b675912f644fd9a2ec762001d95fc43865d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042652Reviewed-by:
-
Karan Bhatia authored
This CL changes SubstringSetMatcher to require patterns as part of its constructor. This: - Simplifies the interface and the contract with the client. SubstringSetMatcher doesn't refer to memory owned by client anymore. - Reduces the need for storing the pattern vector in both SubstringSetMatcher and its clients, thereby reducing runtime memory usage. Also, modernize the code a bit, e.g. - Don't take references to primitives. - Use for-each loops when possible. This shouldn't introduce any behavior change. BUG=974391 Change-Id: Ie6cf1e7c08507b7eaccff39626d43062383e1383 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038075 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#739067}
-
Sharon Yang authored
When unserializing semantic information from Chrome, deletes are applied first, followed by adds and updates. Previously, commit was being called after a delete, which is not the end of an atomic update. Test: CQ Bug: fuchsia:42981 Change-Id: I5840d2c46f14f6a4ac387db7620d240a6ef7d5cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032342Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Sharon Yang <yangsharon@chromium.org> Cr-Commit-Position: refs/heads/master@{#739066}
-
ckitagawa authored
paint_preview_utils will be used in an experiment. To this end it should have test coverage and be refactored/cleaner. This also fixes a crash that occurred in some situations. Bug: 1049128 Change-Id: I66b031bd518996a13fdaedd437b80ce8c646bf8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038081Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#739065}
-
chromium-autoroll authored
Roll silvermont AFDO profile from 81-4028.0-1580727432-benchmark-81.0.4044.9-r1 to 81-4028.0-1580727432-benchmark-81.0.4044.11-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: If7f75214805272fa6045f8becee7db169ae5fab2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042651Reviewed-by:
-
Joe DeBlasio authored
This CL adds a link to the MIX-DL blog post to the console message printed when mixed-content downloads occur. This had to wait until today since, well, the blog posted wasn't posted until today. Fixed: 1049133 Change-Id: Id3df23e2d4ab6f63e9c33b23155fa27a056378ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042380 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#739063}
-
ckitagawa authored
This bug is due to not passing |same_document_| correctly to BuildDidCommitProvisionalLoadParams(). This causes some same-document navigations to behave as though they are cross-document in unit tests. This also fixes any unit tests that depended on this behavior to pass. Bug: 1049575 Change-Id: I81d08bee9c922c8070ab1d9d7a870141ff88c38e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041797Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#739062}
-
Henrique Nakashima authored
Change-Id: Ib4cf8982b249b78d67e37d894d1c831cb0f5061d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042381Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#739061}
-
Ian Kilpatrick authored
Fixes: fast/text-autosizing/cluster-inline-grid-flex-box.html We weren't applying any of the text-autosizing logic. This adds the correct scope so we can apply it. Bug: 845235 Change-Id: Ie7496043f80959bad342a4fe7f8876a8a8eeb7b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037859 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#739060}
-
Wenyu Fu authored
Test are reporting failed with Mocktio exceptions on a subset of builder bots. Disable these test for now. Bug: 1049557 Change-Id: Id635b448d7c44dfcd3b8167633f4e72fd3c45aec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042396 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Auto-Submit: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7572c967ba08..e9dc0201af3a git log 7572c967ba08..e9dc0201af3a --date=short --first-parent --format='%ad %ae %s' 2020-02-06 brianosman@google.com GL: Mark unused uniform locations that were explicitly bound as ignored Created with: gclient setdep -r src/third_party/angle@e9dc0201af3a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cnorthrop@google.com Change-Id: Icf0b379cdb2431c21b73790ed896c63ddfdd7b14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042237Reviewed-by:
-
Filip Gorski authored
Bug: 1049263 Change-Id: I66c7249e913360cd0c5b2478ec78055b0bbe3a25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039598 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Auto-Submit: Filip Gorski <fgorski@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#739057}
-
Vasiliy Telezhnikov authored
This CL implements External Stencil support for webview with SkiaRenderer by drawing to intermediate FBO and then drawing to main frame buffer the quad with it using stencil test. Bug: 805739 Change-Id: I00a3406cced343a08ee0ed3ad7264d3c8b65ca72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031556Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#739056}
-
Jonathan Backer authored
Bug: 1033001 Change-Id: Iafecf2e001c7c6535db1444c18bb4190bc8e5014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039592Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#739055}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/612c52d1..624f9f49 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I806df598668c1ccdbf18c984b7d374211b6a8c5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041413Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#739054}
-
Alex Moshchuk authored
The HasSecurityState() check was introduced as a temporary workaround to eliminate crashes caused by Mojo services trying to perform ChildProcessSecurityPolicy security checks after the RenderProcessHost has been destroyed. HasSecurityState() was used to detect that the process was gone and just fail open. Now, we have a better solution in place with ChildProcessSecurityPolicyImpl::Handle, which extends the lifetime of a process's security state even after the RPH has gone away. Switch local storage (StoragePartitionImpl::OpenLocalStorage) and session storage (SessionStorageNamespaceImplMojo::OpenArea) to use this approach instead. This takes care of the last two non-test uses of HasSecurityState() so we should be able to remove it in a followup CL. Bug: 943887 Change-Id: Ifc9d000f5bd89c4c058395954137db3d1bb474fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034095Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#739053}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/417d89c32ff9..50984a64faec git log 417d89c32ff9..50984a64faec --date=short --first-parent --format='%ad %ae %s' 2020-02-06 ehmaldonado@google.com Reland "presubmit_support: Add --all-files options." Created with: gclient setdep -r src/third_party/depot_tools@50984a64faec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1042324 Tbr: agable@chromium.org Change-Id: If9f524ec04a3e1692ccac8f0694814020cb3c8fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042249Reviewed-by:
-
Johannes Henkel authored
Upstream: "Remove Parser_{h,cpp}.template as promised." https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/2040571 New rev: 9fd0f91cc4331f931b7ac4040ceaa36de43937d0 Change-Id: I107c015b9e6a3a93bbe7abf297a129a933f906c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039971Reviewed-by:Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#739051}
-
llin@chromium.org authored
Bug: b/144800297 Test: unit tests Change-Id: I28694447360b12592ebf7fcd5a701d56a687d951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040235 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#739050}
-
Colin Blundell authored
This class is a dependency of ChromeMetricsReporter, which we are going to componentize for sharing with WebLayer. Bug: 1030692 Change-Id: Ib233440b5768b2123c972d61537c2e6b75da0e6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039456Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#739049}
-
Robert Ma authored
This reverts commit 6a196c81. Reason for revert: Unfortunately SVG files are not recognized as tests in WPT, so moving these files into WPT actually means that we stop running them altogether. See this CQ run: https://ci.chromium.org/p/chromium/builders/try/linux-rel/303153 Original change's description: > Move SMIL events tests to WPT > > Change-Id: Ie4c00b4b6b6eba3b55f86793620a502780590864 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041270 > Reviewed-by: Stephen Chenney <schenney@chromium.org> > Commit-Queue: Fredrik Söderquist <fs@opera.com> > Cr-Commit-Position: refs/heads/master@{#738955} TBR=pdr@chromium.org,fs@opera.com,schenney@chromium.org Change-Id: I09a5cde1c656ba765b710b7d5f01dd588c13da51 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042125Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#739048}
-
Alice Wang authored
This CL adds render tests for signout dialog of managed and not managed account. Bug: 1042222 Change-Id: Ie26de64c0f2f5b4e771aa8e461489d9c7e21431a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002809Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#739047}
-
Natalie Chouinard authored
Move Sync settings alongside Sync code. Bug: 1047357 Change-Id: I66839fc3a913ff3993a24afef051f5626f87ef43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040444Reviewed-by:
-
Robert Flack authored
The devtools frontend roll in https://chromium-review.googlesource.com/c/chromium/src/+/2038189 broke web_tests text output on debug bot runs. TBR=tvanderlippe@chromium.org Bug: 1049641 Change-Id: I12f91f3ed99d1d945b2fd780dcd69c7cf52563a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041532Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#739045}
-
Nate Fischer authored
This adds a targetSdk quirk for WebView's CookieManager API. Starting for apps which target Android R, WebView will no longer accept cookies for insecure ('http' scheme) URLs which also specify the 'Secure' cookie directive. While this changed for Chrome in M58 (https://www.chromestatus.com/feature/4506322921848832), WebView has been working around this by fixing up the URL's scheme to 'https'. WebView will continue to do so for apps targeting < R. This adds a histogram to track the new case. Bug: 933981 Test: run_webview_instrumentation_test_apk -f CookieManagerTest#testSetSecureCookieForHttpUrl* Change-Id: Ie31f02911d38984983fdf4afeb4d6e1eb4f7d094 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040685Reviewed-by:Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#739044}
-
Xianzhu Wang authored
When blink directly sets scroll offset in the scroll tree, we need to set the associated cc::Layer's NeedsPushProperties to ensure update of cc::LayerImpl's scroll related properties (see cc::LayerImpl::UpdateScrollable()). This reverts the change about cc::LayerTreeHost::LayerByElementId() in https://chromium-review.googlesource.com/c/chromium/src/+/2020554 because we still need it in layer list mode. Bug: 1048113 Change-Id: I686beebcf54e96cc517700c0f987aaceec880c58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036834Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#739043}
-
Peter Wen authored
Java targets use the contents of the res_sources_path file of all their dependencies to determine the resource_dirs value in the java target's build config. Thus these files need to be in its depfile through all_inputs. Also remove unused resource directory shortcut, and build/android/empty* Bug: 1049296 Change-Id: Icc8375bdeca1a4ba2d954a964a62bf852a81b788 Fixed: 1049296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042405 Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#739042}
-
Luke Zielinski authored
Bug: 1049607 Change-Id: Id99fb07fc85539dad0d4928761e1abe2857541fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042371 Auto-Submit: Luke Z <lpz@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
-
Mustafa Emre Acer authored
The presubmit code for translation screenshots parses grd and grdp files modified in the CL. It does this by referring to the old and new contents of the files passed to it by the presubmit. grd files can refer to grdp files via <part> tags. This causes the messages in the grdp file to be included in the grd file. If a modified grd file's old contents refers to a now renamed or deleted grdp file, grd reader fails to open the grdp and crashes. This CL fixes this by ignoring <part> tags while loading grd files. This should be safe: The presubmit processes grdp files separately, so all grdp files should still be processed, just not when loading grd files. Additionally, grdp files cannot contain part files, so ignoring the tag while loading grdp files should also be safe. Bug: 1047487 Change-Id: I3d79aa028c4ae360d74a437a019628d0bdab494a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037027Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#739040}
-
Alex Ilin authored
This CL adds a new field to OAuth2MintTokenConsentResult proto, modifies the parsing function and plumbs this new field to GaiaRemoteConsentFlow::Delegate::OnGaiaRemoteConsentFlowApproved(). IdentityGetAuthTokenFunction is going to remember this gaia id and reuse the same account for the next calls. The usage of the gaia id will be added in future CLs. Bug: 1026237 Change-Id: Ieb407ee26d8b2ab9e4a4f4bb3c164f5c88c37440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042097Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#739039}
-
Rohit Rao authored
This will allow us to add dependencies to ensure that EG2 host apps are always compiled alongside their test modules. Previously, bots would incrementally compile only the test modules and then fail when the host app wasn't present. BUG=1019533 Change-Id: I42fca4f6767fba723dcb425b6485a1211c714b09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949847 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#739038}
-
Jae Hoon Kim authored
BUG=b:145814572 Change-Id: I837389427d673c564fc2b3f147f8f56ac04e01ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036548Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Jae Hoon Kim <kimjae@chromium.org> Auto-Submit: Jae Hoon Kim <kimjae@chromium.org> Cr-Commit-Position: refs/heads/master@{#739037}
-
