GitLab

BUG=

Review URL: https://codereview.chromium.org/316223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275335 0039d316-1c4b-4281-b951-d872f2087c98

BUG=347825

Review URL: https://codereview.chromium.org/309593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275334 0039d316-1c4b-4281-b951-d872f2087c98

Focus a media source when it's view is tapped. Select it on double-tap.

BUG=380490

Review URL: https://codereview.chromium.org/317783007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275333 0039d316-1c4b-4281-b951-d872f2087c98

There's no reason to have this. It was originally because PermissionsData
didn't really belong on Extension (and was to be taken off), but now that
PermissionsData is refactored to only include active permissions, it belongs
on the extension object.

TBR=ben@chromium.org (c/b/ui - simple refactor, no functional changes)
TBR=thestig@chromium.org (c/b/media_galleries - simple refactor, no functional changes)
BUG=379356

Review URL: https://codereview.chromium.org/315573003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275332 0039d316-1c4b-4281-b951-d872f2087c98

Added two JSON tree dumps to be loaded by the perftests

Same as issue 305063002 (https://codereview.chromium.org/305063002)

Review URL: https://codereview.chromium.org/312233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275331 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/314223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275330 0039d316-1c4b-4281-b951-d872f2087c98

This fixes an issue where a lazy require of app bindings (when unavailable) will not yield a properly constructed bindings export.

BUG=373179

Review URL: https://codereview.chromium.org/319783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275329 0039d316-1c4b-4281-b951-d872f2087c98

And with this patch, the error detail is shown in case of error.

BUG=355545
TEST=manually tested
R=hirono@chromium.org

Review URL: https://codereview.chromium.org/315103004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275328 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275327 0039d316-1c4b-4281-b951-d872f2087c98

BUG=378911

Review URL: https://codereview.chromium.org/303123006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275326 0039d316-1c4b-4281-b951-d872f2087c98

This patch adds the upstream libaddressinput strings into the Chrome
build inside of chrome/app/address_input.grdp to work well with the
translation tools.

TBR=estade@chromium.org
BUG=327046

Review URL: https://codereview.chromium.org/312883005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275325 0039d316-1c4b-4281-b951-d872f2087c98

Only take a screenshot if the page id changes.

Looking at NavigationControllerImpl::ClassifyNavigation(), I think this is the
right check. If we could move the code for taking the screenshot post
controller_->RendererDidNavigate() call, we'd be able to use the NavigationType
calculated in that method, but based on the comments for the screenshot code,
this doesn't seem like a safe thing to do.


BUG=375921

Review URL: https://codereview.chromium.org/316553007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275324 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/314583003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275323 0039d316-1c4b-4281-b951-d872f2087c98

Listen for clicks in the embedded app and close the corresponding view when clicked.

R=sky@chromium.org
http://crbug.com/365012

Review URL: https://codereview.chromium.org/311423003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275322 0039d316-1c4b-4281-b951-d872f2087c98

BUG=381374

Review URL: https://codereview.chromium.org/317153003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275321 0039d316-1c4b-4281-b951-d872f2087c98

This is behind the cloud devices flag. Registration is nonworking at the moment. Scan for an display WiFi devices in the devices page.

Depends on:
https://codereview.chromium.org/294173002/ [build variable for WiFi bootstrapping]
https://codereview.chromium.org/226883002/ [WiFi library for cloud devices]
https://codereview.chromium.org/288043004/ [bootstrapping device lister]

BUG=370071

Review URL: https://codereview.chromium.org/296963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275320 0039d316-1c4b-4281-b951-d872f2087c98

R=wtc@chromium.org, rch@chromium.org, thestig@chromium.org

Review URL: https://codereview.chromium.org/312193005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275319 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/318893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275318 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275317 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=175582:175594&mode=html

TBR=peter@chromium.org

Review URL: https://codereview.chromium.org/321443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275316 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275309 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org
http://crbug.com/365012

Review URL: https://codereview.chromium.org/316083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275307 0039d316-1c4b-4281-b951-d872f2087c98

BUG=380680
TBR=reed@google.com

Review URL: https://codereview.chromium.org/322463004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275306 0039d316-1c4b-4281-b951-d872f2087c98

Moves many of the files in sync/notifier to components/invalidation.

This change does not introduce any new dependencies.  The relevant
dependency rules both before and after this change should be:
- chrome/browser/invalidation and chrome in general depend on
  components/invalidation.
- components/invalidation depends on sync/notifier and sync in
  general.
- sync/notifier, components/invalidation, and various parts of
  chrome all depend on sync/internal_api/public.

The eventual goal is to move all of sync/notifier into
components/invalidation.  The invalidation-related parts of
sync/internal_api/public should be moved to components/invalidation,
too.  This will allow us to remove the deopendencies from
components/invalidation to sync, and remove sync's dependencies on
cacheinvalidation and libjingle.

This change is a regression in terms of shared library componentization.
the files in the sync/notifier folder could be built as a shared
library.  The files in compononents/invalidation do not support this
yet.  The SYNC_EXPORT declarations in the moved files have been changed
to INVALIDATION_EXPORT so as to not lose this information, but the
macros are currently #defined to no-ops.

This change does not attempt to rename any classes or namespaces.
Many of the files ported from sync/notifier still use the syncer
namespace.  Some, like SyncSystemResources, still have names tied
to their sync heritage.  This will be addressed in future CLs.

Some non-trivial or non-obvious changes include:
- invalidator_state.h was moved to sync/internal_api/public/base so it
could be shared by both sync/ and components/invalidation.  This should
be fixed in a future CL.
- FromNotifierReason was split out of invalidator_state.h and moved to
the newly-created components/invalidator_reason_util.h

TBR=zea,rtenneti,mallinath,dcheng
BUG=259559

Review URL: https://codereview.chromium.org/315433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275305 0039d316-1c4b-4281-b951-d872f2087c98

BUG=381180

Review URL: https://codereview.chromium.org/314263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275304 0039d316-1c4b-4281-b951-d872f2087c98

The original CL was reverted in r275139 for XP test failures:
http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/31455
(MediaGalleriesPlatformAppBrowserTest.Scan timeouts)
I've addressed this here by reverting a test helper:
MediaGalleriesScanResultDialogViews::AcceptDialogForTesting

r272016 regressed web-modal dialog shadow styling.
Use CreateDialogWidget for dialog creation to fix that.
Only set SHADOW_TYPE_NONE for new-style dialogs there.
(removes the double border, consolidates dialog widget init)
Take WidgetDelegate for ConstrainedWebDialogDelegateViewViews.
Mark web-modals as ui::MODAL_TYPE_CHILD and child widgets.

Remove now unused Widget::CreateWindowAsFramelessChild.
(keep a copy for the system-modal captive portal dialog)
(that dialog is very odd, system-modal and "web-modal"?)

Add [Create|Show]WebModalDialogViews helper functions.
Use these for c/b/ui/views web-modal dialog init/show.
(cannot be used by c/b/chromeos, so cleanup less there)
Cleanup includes, cached widgets, using statements, etc.

BUG=376646, 378970
TEST=Views tab-modal dialogs appear as expected.
TBR=wittman@chromium.org,sky@chromium.org

Review URL: https://codereview.chromium.org/319013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275303 0039d316-1c4b-4281-b951-d872f2087c98

BUG=378064

Review URL: https://codereview.chromium.org/312043003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275302 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275301 0039d316-1c4b-4281-b951-d872f2087c98

Pulls in:
9caa384 avcodec/mpegaudiodec: Reset dither and mdct state

BUG=381356
TEST=md5 hashes of decoded packets match (test coming separately).
R=wolenetz@chromium.org
TBR=wolenetz

Review URL: https://codereview.chromium.org/319043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275300 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104711
TBR=sandersd

Review URL: https://codereview.chromium.org/319913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275299 0039d316-1c4b-4281-b951-d872f2087c98

The test now uses its own URLRequestJobFactory instead.
This is being done to remove use of a deprecated API in net/

Also remove most friend classes outside net/ from
URLRequest::Deprecated, as none of them are needed any more,
except for AppCacheInterceptor.

BUG=81979

Review URL: https://codereview.chromium.org/311263011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275298 0039d316-1c4b-4281-b951-d872f2087c98

BUG=https://code.google.com/p/nativeclient/issues/detail?id=3114
TEST=compile

Review URL: https://codereview.chromium.org/312323005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275297 0039d316-1c4b-4281-b951-d872f2087c98

This prevents Chrome from creating an infobar warning about unsupported flags (in particular --ignore-certificate-errors, which we also pass when launching Chrome).

BUG=chromedriver:799

Review URL: https://codereview.chromium.org/313003005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275296 0039d316-1c4b-4281-b951-d872f2087c98

This CL makes it possible to give a border insets to box layout which
overrides the constructor settings for border spacing. This lets the
client have more control on the insets of its child views.

This is a precursor to https://codereview.chromium.org/307333002/.

BUG=349727

Review URL: https://codereview.chromium.org/310753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275295 0039d316-1c4b-4281-b951-d872f2087c98

Extend TextInputClient to support validating and executing editing commands,
such as IDS_DELETE_BACKWARD, IDS_MOVE_RIGHT, IDS_APP_PASTE.
This will be used for implementing Textfield editing for the Mac port of Views.

BUG=374077

Review URL: https://codereview.chromium.org/302293003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275294 0039d316-1c4b-4281-b951-d872f2087c98

Update AUI to request an access token and send an Authorization header
with each requests.  If the server responds with 401, AUI invalidates
its token, but does not retry.  Retries will be implemented in a future
CL, probably at a higher level.

BUG=371516

Review URL: https://codereview.chromium.org/304253010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275293 0039d316-1c4b-4281-b951-d872f2087c98

Fails on all desktop GPU bots:
http://chromegw/i/chromium.perf/builders/Win%207%20ATI%20GPU%20Perf/builds/15808/steps/tab_capture_performance_tests/logs/stdio
http://chromegw/i/chromium.perf/builders/Win%207%20Intel%20GPU%20Perf/builds/15832/steps/tab_capture_performance_tests/logs/stdio
http://chromegw/i/chromium.perf/builders/Win%207%20Nvidia%20GPU%20Perf/builds/14702/steps/tab_capture_performance_tests/logs/stdio
http://chromegw/i/chromium.perf/builders/Mac%2010.7%20Intel%20GPU%20Perf/builds/18424/steps/tab_capture_performance_tests/logs/stdio

> Revert 273639 "Disable tab capture tests as they're failing on c..."
> 
> The chromium.perf waterfall will now only run these tests on the
> expected bots (desktop bots with GPUs). Re-enabling these tests.
> 
> > Disable tab capture tests as they're failing on chromium.perf.
> > 
> > BUG=377089
> > NOTRY=True
> > TBR=kbr@chromium.org
> > 
> > Review URL: https://codereview.chromium.org/303203002
> 
> TBR=tonyg@chromium.org
> 
> Review URL: https://codereview.chromium.org/317983002

TBR=kbr@chromium.org

Review URL: https://codereview.chromium.org/317293003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275292 0039d316-1c4b-4281-b951-d872f2087c98

Should not use createV8Entry() and toV8Value() without cntext and isolate.
Need to provide these information explicitly.

BUG=369451

Review URL: https://codereview.chromium.org/306063005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275291 0039d316-1c4b-4281-b951-d872f2087c98

MSVCS has a list of by-default supported capture formats |kVideoFormats|
used as a fallback for sources that don't support capability
enumeration. It's composed of a couple of resolutions and a fixed frame
rate of 30.

This CL adds also 60 fps to the fallback list, so the user can select
frame rates over 30, e.g. by setting min=54 and max=54.

BUG=381225

Review URL: https://codereview.chromium.org/311363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275290 0039d316-1c4b-4281-b951-d872f2087c98

When the avatar policy is cleared, the user can pick an avatar image
again. Until the user does this, Chrome has two options:
1) keep using the image that had most recently been set through policy
2) revert to a default image

Chrome's current behavior is (1). This CL changes it to (2), which may be
easier to understand for users and is consistent with the behavior of the
wallpaper policy.

BUG=380422
TEST=Updated browser test

Review URL: https://codereview.chromium.org/315213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275289 0039d316-1c4b-4281-b951-d872f2087c98