GitLab

Clarify function call parameter.
BUG=none
R=esprehn@chromium.org

Review-Url: https://codereview.chromium.org/2145613002
Cr-Commit-Position: refs/heads/master@{#407092}

Here is a DOM state when we only add a blockquote.
<div contenteditable><blockquote>|<br></blockquote></div>

After indenting the blockquote, the change is as follows:
<div contenteditable>
  <blockquote>
    <blockquote style="margin: 0 0 0 40px; border: none; padding: 0px;">
      <blockquote>|<br></blockquote>
    </blockquote>
  </blockquote>
</div>

There is an unnecessary blockquote so the result should be as follows:

<div contenteditable>
  <blockquote style="margin: 0 0 0 40px; border: none; padding: 0px;">
    <blockquote>|<br></blockquote>
  </blockquote>
</div>

This CL removes the additional blockquote.

BUG=625802
TEST=editing/execCommand/indent-empty-quote.html

Review-Url: https://codereview.chromium.org/2175433002
Cr-Commit-Position: refs/heads/master@{#407091}

Cr-Commit-Position: refs/heads/master@{#407090}

Revert of Reland "Implement FullScreen using top layer." (patchset #13 id:260001 of https://codereview.chromium.org/2107233002/ )

Reason for revert:
Multiple regressions around the fullscreen transition becoming visibly
worse, as well as a suspected leak.

BUG=628554,628605,628662,630191

Original issue's description:
> Reland "Implement FullScreen using top layer."
>
> This reverts commit 2460a952.
>
> Notable changes on top of previous attempt:
>
> full-screen-iframe-ua-style.html is changed to use overflow property
> instead, as position is no longer changed on ancestors.
>
> :root:-webkit-full-screen-ancestor { overflow: hidden !important; } is
> retained, as the previous attempt regressed on Vimeo (crbug.com/543946)
> and it's not clear yet how to handle this in the spec:
> https://github.com/whatwg/fullscreen/issues/19
>
> Make ::backdrop work for replaced content (video, iframe, etc.) by
> changing StyleResolver::createPseudoElementIfNeeded to allow creating
> the ::backdrop pseudo-element even if the parent doesn't support
> children. With this change, full-screen-stacking-context.html was
> simplified and full-screen-video-has-backdrop.html was
> simplified+renamed.
>
> The will-change override is dropped, as full-screen-will-change.html
> passes without it.
>
> BUG=240576, 543946
>
> Committed: https://crrev.com/d666f503ae854fac360cc70da1f5971a6724546a
> Cr-Commit-Position: refs/heads/master@{#405478}

TBR=dsinclair@chromium.org,esprehn@chromium.org,eae@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=240576, 543946

Review-Url: https://codereview.chromium.org/2168373002
Cr-Commit-Position: refs/heads/master@{#407089}

The plot thickens:

This checkin introduces all the classes, and the links
between them. The links are important for object
lifetime management. Lifetime architecture is described
at
https://docs.google.com/document/d/1G4OmqqlFY3H3erQAUmteKES02-bIECikDjWBrDKH9PA/edit?usp=sharing

BUG=612962

ResizeObserver: conecting Objects
Review-Url: https://codereview.chromium.org/2161313002
Cr-Commit-Position: refs/heads/master@{#407088}

This patch converts "editing/deleting/delete-block-content-00[123].html" to use
w3c test harness to simplify test files by consolidating them into
"delete-block-content.html".

Note: "delete-block-content-003.html" is identical to
"delete-block-content-002.html" expect for 003.html has two DIV[id=root].

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2170273002
Cr-Commit-Position: refs/heads/master@{#407087}

This patch converts "editing/deleting/delete-contiguous-ws-001.html" to use w3c
test harness to simplify test files.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2169263003
Cr-Commit-Position: refs/heads/master@{#407086}

This patch converts "editing/deleting/delete-tab-[1234].html" to use w3c
test harness and consolidates into "delete_tab.html" to simplify test files.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2172943002
Cr-Commit-Position: refs/heads/master@{#407085}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/71da59b9..5bc62d66

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2176443003
Cr-Commit-Position: refs/heads/master@{#407084}

BUG=

Review-Url: https://codereview.chromium.org/2137863002
Cr-Commit-Position: refs/heads/master@{#407083}

Specification:
https://www.w3.org/TR/payment-request/#updatewith

BUG=629462

Review-Url: https://codereview.chromium.org/2170783002
Cr-Commit-Position: refs/heads/master@{#407082}

This patch converts "editing/deleting/delete-and-undo.html" to use w3c test
harness to simplify test files.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2164243002
Cr-Commit-Position: refs/heads/master@{#407081}

This patch converts "editing/deleting/delete-3928305-fix.html" to use w3c test
harness to simplify test files.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2170753003
Cr-Commit-Position: refs/heads/master@{#407080}

BUG=624038,497094

Review-Url: https://codereview.chromium.org/2169213002
Cr-Commit-Position: refs/heads/master@{#407079}

Before, only 4 were shown, even though there was space for more.
It could confuse users, that there are no other apps matching the
criteria.

This CL increases this limit to 8, which fill the available space.

TEST=Tested manually on Samus.
BUG=629411

Review-Url: https://codereview.chromium.org/2165483002
Cr-Commit-Position: refs/heads/master@{#407078}

Per the spec[1] we can treat an object as a callback interface
if an effective overload set contains the callback interface.

[1] http://heycam.github.io/webidl/#es-overloads

BUG=629068

Review-Url: https://codereview.chromium.org/2175463002
Cr-Commit-Position: refs/heads/master@{#407077}

The Cotnrol-Click functionality navigates users from Styles Sidebar Pane
into the Source code.

This patch moves this functionality into the
StylePropertiesSection from StylesSidebarPane, which
simplifies it a lot.

BUG=none
R=pfeldman

Review-Url: https://codereview.chromium.org/2153263002
Cr-Commit-Position: refs/heads/master@{#407076}

BUG=624590

Review-Url: https://codereview.chromium.org/2166093002
Cr-Commit-Position: refs/heads/master@{#407075}

Currently ThreadableLoader's destructor implicitly cancels loading.
This CL requires a user to cancel the loader explicitly before
destructing a ThreadableLoader, as a preparation for moving it to
Oilpan heap.

BUG=587663

Review-Url: https://codereview.chromium.org/2146403004
Cr-Commit-Position: refs/heads/master@{#407074}

|EditAction| is used to describe editing operations in
Blink internal only, however with the introduction of
|InputEvent| we got a new type |InputType| which does the
same thing and SPECed.

Since having both is redundant, this CL removes
|EditAction| and finalized the list of possible
|InputType|.

This CL shouldn't have too much web-exposed effect (except
some trivial command mapping).

BUG=627740
Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/InputEvent/blink-dev/RrnitB0OElc/rirueVekCwAJ

Review-Url: https://codereview.chromium.org/2151353002
Cr-Commit-Position: refs/heads/master@{#407073}

The 32-bit metric is recorded as a sparse histogram. Each
sample contains information on transport RTT, HTTP RTT,
bandwidth, and time taken to download the resource. Each
metric occupies 7 bits with first 4 bits left unset.

BUG=624597

Review-Url: https://codereview.chromium.org/2107243003
Cr-Commit-Position: refs/heads/master@{#407072}

BUG=630056

Review-Url: https://codereview.chromium.org/2165023004
Cr-Commit-Position: refs/heads/master@{#407071}

Now the feature is moved to wayland, we can remove it.

BUG=b/29728385
TEST=Build and run ARC, with client side WindowManagerInstance removal.

Review-Url: https://codereview.chromium.org/2168533002
Cr-Commit-Position: refs/heads/master@{#407070}

We already have similar mechanism in cc. Blink-side DebugRedFill also
brings complexities about display item list and paint property tree.

Review-Url: https://codereview.chromium.org/2163113002
Cr-Commit-Position: refs/heads/master@{#407069}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/cc88d565..71da59b9

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2175573002
Cr-Commit-Position: refs/heads/master@{#407068}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/ab911d94c16a..20358d6bf8c9

$ git log ab911d94c..20358d6bf --date=short --no-merges --format='%ad %ae %s'

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2170183003
Cr-Commit-Position: refs/heads/master@{#407067}

Review-Url: https://codereview.chromium.org/2169243002
Cr-Commit-Position: refs/heads/master@{#407066}

BUG=chromedriver:1384

Review-Url: https://codereview.chromium.org/2170163002
Cr-Commit-Position: refs/heads/master@{#407065}

Cr-Commit-Position: refs/heads/master@{#407064}

Revert of Reland: H264 HW encode using MediaFoundation (patchset #2 id:20001 of https://codereview.chromium.org/2167333002/ )

Reason for revert:
Build errors on this bot: https://build.chromium.org/p/chromium/builders/Win%20x64/builds/2630/steps/compile/logs/stdio

Original issue's description:
> Reland: H264 HW encode using MediaFoundation
>
> Got reverted due to breaking MSVC build:
> https://bugs.chromium.org/p/chromium/issues/detail?id=630335#c2
>
> This CL moves GTEST_FAIL() lines so that they fail at the end of the
> function.
>
> Original description ----------------------------------------------
>
> H264 HW encode using MediaFoundation
>
> This CL adds MediaFoundationVideoEncodeAccelerator which enables H264 encode support
> using MediaFoundation on Windows 8.1+. Also, it includes a refactor of common
> MediaFoundation classes under mf_helpers.*.
>
> Note that, this is the first CL and H264 codec is still behind a flag.
>
> Design Doc(with perf measurements): http://goo.gl/UCnwyA
>
> BUG=590060
> TEST= Tested AppRTC loopback with Chrome flag "--enable-webrtc-hw-h264-encoding" and
> "--enable-mf-h264-encoding" on https://apprtc.appspot.com/?debug=loopback&vsc=h264
> Also, added WIN specific sections at vea_unittests.
>
> TBR=ananta@chromium.org,avi@chromium.org,grt@chromium.org,sandersd@chromium.org,wuchengli@chromium.org
> The incremented change is trivial.
>
> Committed: https://crrev.com/aa60bafce8cb29062030362aaa7c321350b67f84
> Cr-Commit-Position: refs/heads/master@{#407049}

TBR=
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=590060

Review-Url: https://codereview.chromium.org/2170133003
Cr-Commit-Position: refs/heads/master@{#407063}

Previously, the ViewportControl never stuck to the bottom after a scroll event.
The event.isTrusted check was always true, so it was not correctly
distinguishing user-generated scroll events from script-generated ones.  This
CL removes isUserGesture accordingly.

BUG=613879

Review-Url: https://codereview.chromium.org/2154893002
Cr-Commit-Position: refs/heads/master@{#407062}

TreeElement.expand() should not need to check that the element has children and
TreeOutline.insertChild() should not automatically expand a child when it is
inserted. ObjectPropertiesSection.js depended on this logic to automatically
expand the Entries property. This CL updates it so that the Entries property is
added before expanded.

BUG=

Review-Url: https://codereview.chromium.org/2147343002
Cr-Commit-Position: refs/heads/master@{#407061}

Currently hold-and-press dragging in direct input mode doesn't quite follow
the user's finger. The problem is that when the viewport moves (since
dragging around), the cursor position will be set to the center of the
screen, while the user's finger may be on somewhere else, causing an offset
between the user's finger and the cursor position. This CL fixes this problem
by always moving the cursor to the finger's position when it's in direct
input mode and the user is dragging around.

BUG=628031

Review-Url: https://codereview.chromium.org/2166423003
Cr-Commit-Position: refs/heads/master@{#407060}

Desired behavior when long press happens on an empty text field is to
activate touch selection and show the quick menu if there is anything
available to show in the quick menu. Otherwise, the regular context menu
should be shown. This was regressed due to changes in context menu
source type that added LONG_PRESS and LONG_TAP types. In addition to
fixing this regression, this CL fixes the regression on the new tab page
that shows an incorrectly placed quick menu instead of the context menu.

BUG=594101

Review-Url: https://codereview.chromium.org/2124913002
Cr-Commit-Position: refs/heads/master@{#407059}

As preparation for moving ThreadableLoader to Oilpan heap, this CL moves
ThreadableLoaderClientWrapper to Oilpan heap.

This CL also removes ThreadableLoaderClientWrapper::ResourceTimingClient and makes
ThreadableLoaderClient::didReceiveResourceTiming() to be called also for
ThreadableLoaderClient associated with WorkerThreadableLoader.

BUG=587663

Review-Url: https://codereview.chromium.org/2146333002
Cr-Commit-Position: refs/heads/master@{#407058}

BUG=626456

Review-Url: https://codereview.chromium.org/2169203002
Cr-Commit-Position: refs/heads/master@{#407057}

The way OriginTrialContext and the WebTrialTokenValidator API was
designed made a lot of sense when the bindings were still done in such
a way that only when a feature is first used we validate if there are
tokens for that feature. But now that we check every feature in every
context the current design is both not very efficient, and also
needlessly complex.

This simplifies things a lot by validating tokens as soon as AddToken
is called (as all tokens will be validated anyway). This way we only
have to validate each token once rather than once for each feature.

Also gets rid of the old histograms as they weren't very meaningful
anymore: The FeatureEnabled was logged regardless of if a feature was
actually being used on a page, making the data hard to reason about. And
the MessageGenerated histogram was 100% NotRequested after the bindings
changes, making it not useful at all.

BUG=627942

Review-Url: https://codereview.chromium.org/2123323004
Cr-Commit-Position: refs/heads/master@{#407056}

Eliminate one SpdyHeaderBlock copy in SpdyStream::ProduceSynStreamFrame() (soon
to be renamed ProduceHeaderFrame).  This is achived by saving the GURL as soon
as request_headers_ are set.

Note that |url_| is not necessarily the same as url_from_header_block_, see, for
example, SpdyHttpStreamTest.SpdyURLTest.

Also remove test-only SpdyStream::HasUrlFromHeaders().

BUG=621905

Review-Url: https://codereview.chromium.org/2169583002
Cr-Commit-Position: refs/heads/master@{#407055}

All changes to the color text from the spectrum should count as one change
for undo/redo. Pressing Ctrl-Z should also move the cursor to the change.

R=lushnikov

Review-Url: https://codereview.chromium.org/2168713004
Cr-Commit-Position: refs/heads/master@{#407054}

As the test is not slow on recent runs, remove the entry from SlowTests.

BUG=601726
NOTRY=true

Review-Url: https://codereview.chromium.org/2172543002
Cr-Commit-Position: refs/heads/master@{#407053}