- 08 Oct, 2020 40 commits
-
-
Gauthier Ambard authored
This CL removes dead code. Bug: none Change-Id: I35604f094924f30b6f342979369f8bbd8e089f3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424250 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#815085}
-
Tanmoy Mollik authored
The sync row should launch signin flow if the user is signed in but did not give sync consent. This cl adds tests for that behavior. Bug: 1135686 Change-Id: If90233ca63ab0b9ad69121e2d68ae2c1e5f84c4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454129 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#815084}
-
Rohit Agarwal authored
The test logic before was counting the incognito notifications after having opened incognito tabs. However, that resulted in flakiness as sometimes we have two notifications for two incognito tabs and some other time we have only one notification. This CL instead of verifying the count of the notification displayed, relies on verifying whether there exists a notification which matches the StatusBarNotification#getTag with that of IncognitoNotificationManager#INCOGNITO_TABS_OPEN_TAG. Bug: 1134241 Change-Id: Iaf80ab369b29e2efcd124f7980f3b1ccba5f76c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452472 Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#815083}
-
Felipe Andrade authored
This work is been done in preparation for enabling Kerberos on MGS. See associated bug for further details. Bug: 983041 Change-Id: I4b351941bab4312067bcd7d687c62639259e5d59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459367Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Felipe Andrade <fsandrade@chromium.org> Cr-Commit-Position: refs/heads/master@{#815082}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/38e6d226f24e..ac0723a06b53 2020-10-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 635de036d766 to 5f4e70b81046 (1 revision) 2020-10-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 3c775217 to af82ff26 (468 revisions) 2020-10-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 7e22b1c44fb0 to 6b4a4a85dfd7 (9 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jvanverth@google.com Change-Id: I9f8a3039e5fec20bc45f03fe69bfbae14832d60c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460565Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815081}
-
Eric Willigers authored
DesktopPWAsWithoutExtensions has shipped. The test is no longer needed. Retiring the test also closes flaky test bugs. Bug: 1065748,1043466,1043806,1044900 Change-Id: I1344f2a2373ead35cf0700a26cdbf1af713e7bc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455567Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#815080}
-
Rainhard Findling authored
Bug: 1087263 Change-Id: I38fe5c305a2726e5600770adeffba26b031d99a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445930Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#815079}
-
Alison Maher authored
In CL:2422213, the previous break token was stored as a reference in NGBoxFragmentBuilder. This change cleans up functions that take both as arguments since we can now access the break token from the builder. The only function where this was the case was FinishFragmentation(). No functional change. Bug: 829028 Change-Id: If9ea5a7ed937e9c2c127ae541b5c4de21dfed4f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458781Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#815078}
-
Jérôme Lebel authored
ChromeIdentityService::GetIdentityWithEmail() is unused. The implementation is removed with: crrev.com/i/3318008. Change-Id: I8926f60be9bfd18814b1fc2aaadf4a3f9321c5dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455607Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#815077}
-
Ioana Pandele authored
This is no longer useful. Bug: 1125735 Change-Id: Ib55174f552fcf6e05f72ee5db13ad24a18b51751 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440891Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#815076}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I849115f4af41f6c639f8424ae5cb868590501295 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460867Reviewed-by:
-
Kent Tamura authored
The function iterates over RootInlineBoxes, which are not used in LayoutNG. This CL adds LayoutNG FragmentItem support to ValueWithHardLineBreaks(). The new code in ValueWithHardLineBreaks() is almost equivalent to the existing NodeTraversal loop, and this CL introduces GetNextSoftBreak() function for FragmentItem. This CL fixes textarea-wrap-submission-value.html test with LayoutNGTextArea flag, but this doesn't change any user-visible behavior yet. Bug: 1040826 Change-Id: Ice5e3954df7cd0f8ccb4f1e94d9057be5cbcc3cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454893Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#815074}
-
Hidehiko Abe authored
The feature is not for Chrome OS. Remove it from Chrome OS. This is also for the preparation to unset OS_LINUX for Chrome OS build. With this CL, the part will not be affected on switching. Bug: 1110266 Test: Built locally. Change-Id: Ia22a2dff5cc82e223559abc11e76171c739f03dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452030 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Auto-Submit: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#815073}
-
Paula Vidas authored
The FakeInstanceIDDriver needs to be used in sync invalidations tests. Bug: 1135167 Change-Id: Ifa5c38ea18317d7b99635fee6ee12e129bf4dda8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455646Reviewed-by:
Rushan Suleymanov <rushans@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/cdd72c9222b3..1e48b0c6724e 2020-10-08 alexrudenko@chromium.org Migrate ProtocolMonitor.js to TypeScript 2020-10-08 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0b50734c723072ff47a17c8a2881b7e115b77f2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459192Reviewed-by:
-
Yoshifumi Inoue authored
This patch makes |LayoutText::PositionForPoint()| to find text fragment considering line height to return valid |Position| for point between lines. Example: <style> #container { font-size: 10px; line-height: 3; font-family: Ahem; width: 5ch; // to break line after "line1" } </style> <div id=container>line1 line2</div> In this example, we have two line boxes: line1 box: {0,0}x{50,30} "line1" {0,10}+{50,10} line2 box: {0,30}x{50,30} "line2" {0,10}+{50,10} Before this path, |LayoutText::PositionForPoint({10,30})| returns "line1 line2"[0] instead of "line1 line2"[7] because text fragment "line2" doesn't contains {10,30}. After this patch, we find the line contains {10,30} then locate fragment in line by using inline offset e.g. x-coordinate for horizontal writing mode, y-coordinate for vertical writing mode. Bug: 1133786 Change-Id: I7f76aadf6e1be4c3d8517562242158fadf5f2876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452169 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: -
Julie Jeongeun Kim authored
The request id could not be set from PrintRenderFrameHelper when it calls PrintPreviewFailed(), PrintPreviewCancelled(), or PrinterSettingsInvalid() as the request id is set from |print_pages_params_| and it could be null. This CL adds early return when the request id is -1. Bug: 1136025 Change-Id: I06caaef4050653ddb9ff82b477a74600e9796a55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455826 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
-
Rainhard Findling authored
Bug: 1087263 Change-Id: If6f8928141ee1569cf522fe738403143a4197bbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442735Reviewed-by:
-
Alan Screen authored
Adding support for PrintBackend queries to happen out of the browser process requires related data structures to be made available via a Mojo interface. These are moved into their own mojom file separate from the common definition in printing/mojom since they are specific to a new process being introduced and do not need to be encumbered by the dependencies which exist for print.mojom. Starting with the historically most prolific cause of browser crashes from printing (GetPrinterSemanticCapsAndDefaults), work towards having support definitions to enable that query to be moved out-of-process. Add the mojo definition for PrinterSemanticCapsAndDefaults to expose the needed structure for the query. Bug: 809738 Change-Id: Idf971066982ff989668e1b227276b13844e7a054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387545 Commit-Queue: Alan Screen <awscreen@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
-
Bettina Dea authored
After clicking on the Enhanced Protection promo on desktop, the Security settings page should open with the Enhanced Protection section expanded. Bug: 1130722 Change-Id: I646566199755862055e8be0fba00259ecf48d704 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454404Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I58b94352a5f4cb28c144f5b2089a91caecb4c3b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460752Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815065}
-
Hidehiko Abe authored
Currently OS_LINUX is defined on Chrome OS build, but it will be unset. This is preparation ot keep the current behavior. Bug: 1110266 Test: Built locally. Change-Id: Ia587de5b23cbe6e6622c0a9aaa918880d9762d45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449654Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1602115190-7131f9189957170a35177f66dc087c48158aec91.profdata to chrome-linux-master-1602136563-0d72642499ba1a8379313d017bceff00a59e9e7c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I030a5a8ab31eacb7d2f486660aef3d6970f93b60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460240Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1602115190-6522495ca352d45be49e234f0c6bf7d20bdcb906.profdata to chrome-mac-master-1602136563-35c37307a75e48d8d50dea3abef2bbe00d3f301f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I7fd3bf5cf8996187a2376379235daa21fafe630a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460550Reviewed-by:
-
Takashi Sakamoto authored
If use_ozone=true or use_x11=true, we need //ui/base:features. Change-Id: Id3ba57d5205c17de3c1f10230639e58131e8ea93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459945Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#815061}
-
Felipe Erias authored
Update LayoutBlockFlow::DetermineLogicalLeftPositionForChild to correctly take into account all the cases where the width of the logical left scrollbar may be different from 0. This fixes a problem where the "both" value of scrollbar-gutter was producing the wrong layout when LayoutNG was disabled. Bug: 710214 Change-Id: If3481ff2486fc3a7a447b892edc8ef98fa658f1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459793Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Felipe Erias Morandeira <felipeerias@gmail.com> Cr-Commit-Position: refs/heads/master@{#815060}
-
Reilly Grant authored
This changes the documentation for the WebUsbAllowDevicesForUrls policy to clarify when it is referring to a field in the JSON object that must be specified by the administrator. Bug: b:170255974 Change-Id: I23cdfa5fecdc8001df8d195fc1c63a529d60bc81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459935 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#815059}
-
Colin Blundell authored
//chrome currently defines and tracks metrics related to user interactions with the subresource filter feature. This CL componentizes the definition of these metrics in advance of componentizing some of the code doing the tracking (e.g., the ads blocked infobar) for reuse in WebLayer. Bug: 1116095 Change-Id: If9033d2aa4e2714b4610974409d1fdb179578740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456608Reviewed-by:
Eric Robinson <ericrobinson@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#815058}
-
Sven Zheng authored
We hope the crash might get fixed by using newer win version. Or at least we can have DLL symbols for debugging. Bug: 1123944 Change-Id: Ib8dfdfe99c166bbf692d7014b4bec4832357b767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454311 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#815057}
-
Makoto Shimazu authored
Ozone also includes ui/base/ui_base_features.h. Added a dependency of //ui/base:features. TBR=hashimoto@chromium.org Bug: 1136388 Change-Id: I2a8f4f3ba449f089b46710dc52562ab6b5898f80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460255Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#815056}
-
Klaus Weidner authored
Instead of using a heuristic to estimate how long ARCore's update is expected to block, place a GLFence after rendering and check its status to decide when the rendered frame is complete. Change-Id: I60de470302127d619ae1cfd44d194c7ed284fd70 Bug: 1136276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459230 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#815055}
-
Olga Sharonova authored
This reverts commit a5354ff6. Reason for revert: multiple crostini tests failing with "Failed to take screenshot by Chrome API: cdp.Runtime: Evaluate: context deadline exceeded.". Examples of first failing builds : https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome/10585, https://ci.chromium.org/p/chromium/builders/ci/chromeos-kevin-rel/29400, https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome/10585. Original change's description: > Move the entire modeset operation to Plane Manager Commit > > 1. Set all props for CRTC, Connector and Plane to Plane Manager to Commit. > 2. Maintain a consolidated path to modeset both Atomic and Legacy. > 3. Simplify CRTC Controller by removing all modeset operations and maintain its state from PlaneManager::CrtcState. > 4. This makes all CRTCs on the same hardware display controller to be modeset at the same time. > > BUG=1082882,1015104 > TEST=hardware_display_plane_manager_unittest > > Change-Id: I2401a1b40ce74158416484e6418239d5fb8c1c25 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429586 > Commit-Queue: Mark Yacoub <markyacoub@google.com> > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> > Cr-Commit-Position: refs/heads/master@{#814933} TBR=dnicoara@chromium.org,markyacoub@google.com Change-Id: If2d243c39d9d4940113b4c46382c1ad6635f9c83 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1082882 Bug: 1015104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460807Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#815054}
-
Harvey Yang authored
This commit adds fake classes: FakeSensorService and FakeSensorDevice in chromeos/components/sensors to add unit tests of sensor clients in Chromium, such as ash/accelerometer and Generic Sensor. BUG=chromium:1006141 TEST=unit tests of ash/accelerometer Change-Id: If4cab4907a3db0e84214ec274ce9dab0a7f2cc44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449311 Commit-Queue: Cheng-Hao Yang <chenghaoyang@chromium.org> Reviewed-by:
-
Bartek Nowierski authored
There are two functions named GetAllocatedSize, but return different value. Improve comments while at it. Change-Id: I5aef0fbf8f63bf94f184b85d40187363e05b08db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455947 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
-
Eric Willigers authored
The tests in app_service_app_model_builder_unittest.cc no longer need to support bookmark apps, as DesktopPWAsWithoutExtensions has shipped. Bug: 1065748 Change-Id: I0da59a448fa5fab619c10fdb4bd6f761ef8bca15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454554 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#815051}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/36ccb695bd6b..1a87f1f025ef 2020-10-08 syoussefi@chromium.org Add a test for deferred clears and 0-sized scissor clears If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: Ibadd22634eb171c00f99d3896320c602d62eaa17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460546Reviewed-by:
-
Colin Blundell authored
There is currently a check for the subresource filter feature being enabled that gates whether //chrome attaches a ContentSubresourceFilterThrottleManager instance as a tab helper. This CL moves the check to inside ContentSubresourceFilterThrottleManager::CreateForWebContents() itself to (1) ensure that all //chrome-level invocations of this method respect the state of the feature, and (2) ensure that //weblayer also transparently reflects the state of the feature in this flow once the ThrottleManager is brought up there. This CL also adds a relevant //components-level unittest. Bug: 1116095 Change-Id: Iadfe6e40979307746e9573da85b05ea1306dfd7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456526Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#815049}
-
Ewann authored
This CL adds ExtendOpenInFilesSupport to the fieldtrial testing config Bug: 1117398 Change-Id: I9d52da7c57e101b1e2607b0c9c6e700e9415468c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454075Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Hayato Ito authored
Add path restriction so that this matches the recent change [1] of the explainer. Subresource path restriction is: > its [path](https://url.spec.whatwg.org/#concept-url-path) contains > the bundle's path as a prefix, Note that the explainer says "the bundle's path as a prefix", however, this CL uses "the bundle's path *without a filename* as a prefix" as subresource path restriction. For example, if a bundle's URL is "https://foo.com/dir/foo.wbn", a subresource's path should contain "dir/", instead of "dir/foo.wbn", as a prefix. We'll update the explainer to match the implementation. - [1] https://github.com/WICG/webpackage/pull/601. Bug: 1082020 Change-Id: I9c2d25108c4169310c395372ac8f7ae74c6a7325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460366 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#815047}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/306f83589eb0..c267a5583028 2020-10-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I2b23ba5a807f4e259b1ea3e910d28b94f0e2d744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460585Reviewed-by:
-
