GitLab

Change-Id: I75b1f41dd03cb9b76d00cd99dc359d825053e351
Reviewed-on: https://chromium-review.googlesource.com/948263
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540845}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d5002715..00dbe028

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I563415051b8c3f43996b48691559b3f5f55a5ca8
Reviewed-on: https://chromium-review.googlesource.com/948723Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540844}

https://chromium.googlesource.com/angle/angle.git/+log/b27b03a2c9ea..78e39b3fd675

$ git log b27b03a2c..78e39b3fd --date=short --no-merges --format='%ad %ae %s'
2018-02-26 lucferron Vulkan: Line loops for indexed draw calls

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Change-Id: Icfda15ec46f6bf9ce872bef6f52007fefc3de4a1
Reviewed-on: https://chromium-review.googlesource.com/949005
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#540843}

- When all history is cleared, simply wipe all of MEI data instead of
  handling it per website.
- When history is expired, do nothing. Better handling of this event
  will be implemented as par tof bug 818153

Bug: 815163
Change-Id: I87c5d3e91b4c4e0c3191bb3c4e9c889ac6830790
Reviewed-on: https://chromium-review.googlesource.com/946169
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540842}

Previously, failures to create First Run Sentinel file are dropped
silently. Frequent failures of creating First Run Sentinel file (not
expected, but possible) may cause FirstRun.SignIn to appear to have
high sign-in failure.

This is a precautionary metrics collection CL to help diagnose whether
such a problem exists or not.

Bug: 814437
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I8a1c6dce86b59d66f57b068ef1f2b44636edbb34
Reviewed-on: https://chromium-review.googlesource.com/947396Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540841}

std::unique_ptr's default_delete expects a complete type for it to delete,
and we were only forward-declaring PrefHashStore in pref_hash_filter.h.

clang somehow works despite this, but GCC (tested 7.3.1) fails as expected:

    In file included from /usr/include/c++/7/memory:80:0,
                     from ../../services/preferences/tracked/pref_hash_filter.h:11,
                     from ../../services/preferences/tracked/tracked_split_preference.h:14,
                     from ../../services/preferences/tracked/tracked_split_preference.cc:5:
    /usr/include/c++/7/bits/unique_ptr.h: In instantiation of ‘void std::default_delete<_Tp>::operator()(_Tp*) const [with _Tp = PrefHashStore]’:
    /usr/include/c++/7/bits/unique_ptr.h:268:17:   required from ‘std::unique_ptr<_Tp, _Dp>::~unique_ptr() [with _Tp = PrefHashStore; _Dp = std::default_delete<PrefHashStore>]’
    /usr/include/c++/7/bits/stl_pair.h:293:17:   required from ‘struct std::is_trivially_move_constructible<std::pair<std::unique_ptr<PrefHashStore>, std::unique_ptr<HashStoreContents> > >’
    ../../base/optional.h:290:22:   required from ‘class base::internal::OptionalBase<std::pair<std::unique_ptr<PrefHashStore>, std::unique_ptr<HashStoreContents> > >’
    ../../base/optional.h:416:7:   required from ‘class base::Optional<std::pair<std::unique_ptr<PrefHashStore>, std::unique_ptr<HashStoreContents> > >’
    ../../services/preferences/tracked/pref_hash_filter.h:142:37:   required from here
    /usr/include/c++/7/bits/unique_ptr.h:76:22: error: invalid application of ‘sizeof’ to incomplete type ‘PrefHashStore’
      static_assert(sizeof(_Tp)>0,
                          ^

Fix it by including the header instead of just forward-declaring the
class (which is already done for the other member of |StoreContentsPair|,
|HashStoreContents|).

Change-Id: I5a71e20c5a1330992610e26bdbf69d7f79b052dc
Reviewed-on: https://chromium-review.googlesource.com/948847Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#540840}

This also changes layout constraints, to make sure that grey line is
streatched across all download toolbar.

UI Mocks: https://docs.google.com/presentation/d/1GzbAoJrpW9IAQF78afh5SZLWJWErNcC67t_ctujjEus/edit#slide=id.g2f6fee2339_3_0

Bug: 791806
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I32f79dba26efe618ac9ac20012c94a01466a06b6
Reviewed-on: https://chromium-review.googlesource.com/947702Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540839}

If everything goes smoothly we can remove the flag in M68.

Bug: 642722
Change-Id: Ica2eb3037f204605146fc36edc8b0ce91a8c2b3a
Reviewed-on: https://chromium-review.googlesource.com/947775Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540838}

The test taps on Download link, verifies that download UI appears, taps
close button and verifies that download UI is dismissed.

Bug: 791806
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I131e319cd230ce6820956f52d310a487285756d4
Reviewed-on: https://chromium-review.googlesource.com/947706Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540837}

Some support for GL_TEXTURE_RECTANGLE_ARB was implemented,
but many cases, including using proper GLSL sampling functions,
were missing. This fixes some WebGL conformance tests on MacOS.

Bug: chromium:757974
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I645dc545643c4cd0f392d8000550c098c7b109f6
Reviewed-on: https://chromium-review.googlesource.com/944185
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540836}

Adds a browsertest that verifies CSS animation properties.

Bug: 646774
Change-Id: I12eeb74ce5a97a1c6b0d09e82bb8cf062faacc93
Reviewed-on: https://chromium-review.googlesource.com/948853Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540835}

Delete a bunch of headers that aren't actually used.

Use display::Display to get the primary screen height instead of
calling [NSScreen screens], as display::Display has been robust for a
long time now.

Delete references to NSOpenGLView, since it is no longer used.

Change-Id: Iceffb4b8bf44f0af2f06ec0051d08f8a7118a804
Reviewed-on: https://chromium-review.googlesource.com/948823Reviewed-by: Sidney San Martín <sdy@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540834}

R=amineer@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ic58c50651b3375fb41d9bda3e97914c689f7da8b
Reviewed-on: https://chromium-review.googlesource.com/949042Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540833}

https://pdfium.googlesource.com/pdfium.git/+log/9a7c2396705a..e9b553270481

$ git log 9a7c23967..e9b553270 --date=short --no-merges --format='%ad %ae %s'
2018-03-05 thestig Add CPDF_DIBSource::LoadState enum class.

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I0051968026275ff956c24b6ccccb13dba55806e5
Reviewed-on: https://chromium-review.googlesource.com/948800
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#540832}

They all crash flakily during teardown with:

[42009:775:0305/032212.554804:FATAL:audio_manager_base.cc(122)] Check failed: input_streams_.empty().

BUG=810321
TBR=grt@chromium.org

Change-Id: Iec3ba5359d75cbdcca02d44eb1f603af47750ec7
Reviewed-on: https://chromium-review.googlesource.com/948545
Commit-Queue: Greg Thompson <grt@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540831}

We're even hitting all of these in our tests, but I guess since they
happen during shutdown after the test has passed, nothing cares?

Bug: 818211
Change-Id: I1dc85763fe3c268b352452f6dd703e4996732ae6
Reviewed-on: https://chromium-review.googlesource.com/946524Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540830}

https://skia.googlesource.com/skia.git/+log/4be123fb6c04..a445fdd6e95f

$ git log 4be123fb6..a445fdd6e --date=short --no-merges --format='%ad %ae %s'
2018-03-01 liyuqian Set SkDAARecord to empty type if the scan converter returns early

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=fmalita@chromium.org

Change-Id: I2f4113b39d16baf5ec2c43e851345cef7a53cefd
Reviewed-on: https://chromium-review.googlesource.com/948824Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#540829}

Compilation in GCC 7.x fails in SupervisedURLFilter, creating a
base::NoDestructor of a flat_set initialized with braces initializer
list syntax, as it fails to retrieve the right constructor (it states
the constructors are ambiguous).

Workaround the problem explicitely declaring flat_set constructor.

Change-Id: Icff5021685a6cbc727d5f4fb5fc6d2ce94fe9921
Reviewed-on: https://chromium-review.googlesource.com/944405
Commit-Queue: José Dapena Paz <jose.dapena@lge.com>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540828}

According to https://drafts.csswg.org/css-syntax/#serializing-anb, if a
is 1 or -1 the number should be omitted. We did not follow this, causing
us to fail parts of external/wpt/css/cssom/selectorSerialize.html.
Change our behavior to match the spec and the test.

Bug: 818475
Change-Id: Ie0f44e2a3fb51069aad492096138020b67359982
Reviewed-on: https://chromium-review.googlesource.com/948066Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Chris Nardi <cnardi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540827}

This change is fairly mechanical and purely cosmetic.

Use make_unique instead of creating an object with new and passing that
into a unique_ptr constructor.  (This often changes local variable type,
but when passed as an argument an implicitly cast takes care of this).
Use MakeRefCounted instead of creating an object with new and passing
that into a scoped_refptr constructor.  (This never changes variable
type in this CL).  Do these in constructor initializer lists as well.
Remove unnecessary namespace qualifiers in a few places (where
unique_ptr template parameter has it but new statement does not in the
same line).

Use assignment operator instead of reset() method of unique_ptr.

Use std::move instead of two-step WrapUnique(unique_ptr.release()).

Where object needs to be constructed with new statement and raw pointer
is already available, use WrapUnique instead of passing the raw pointer
to a unique_ptr constructor.

Use auto where appropriate.

Replace NULL by nullptr in one line which is touched anyway.

Make sure to include memory for new, unique_ptr.

Include scoped_refptr.h for scoped_refptr and MakeRefCounted.

Delete unnecessary ref_counted.h include (only needed for RefCounted*
base classes).

Delete unnecessary memory include where corresponding header file
already included it.

Change-Id: I6fa58780e5ae89e2684aabdd21452b76be52a4f8
Reviewed-on: https://chromium-review.googlesource.com/946053
Commit-Queue: Bence Béky <bnc@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540826}

Constructing origins manually and storing them in Urls is error-prone
(eg the port could be missed out) and there are discrepancies in how
the origin could be formed (eg GURLUtils has a trailing '/' while
current manually formed origins don't). This is especially important as
origins are critical to security.

This CL creats an Origin class that offloads all the heavy lifting to
the well tested native origin class and allows the type system to
prevent the errors listed above.

Bug: 800422
Change-Id: I87759ea12a87f2b57bbdf40994d35ec468a43cff
Reviewed-on: https://chromium-review.googlesource.com/934289
Commit-Queue: Peter Conn <peconn@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540825}

https://skia.googlesource.com/skia.git/+log/9e8a59490531..4be123fb6c04

$ git log 9e8a59490..4be123fb6 --date=short --no-merges --format='%ad %ae %s'
2018-03-04 update-skps Update SKP version
2018-03-02 bungeman IWYU for test files starting with 'A'.
2018-03-02 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 437664b4b..b27b03a2c (10 commits)
2018-03-02 bryct dm: support printing specific page of mskp to SVG
2018-03-02 brianosman Blacklist image sources with 1010102 configs
2018-03-02 egdaniel Remove blacklist of dual source blending on AMD vulkan
2018-03-02 brianosman Revert "Revert "Add 1010102 support to Ganesh""
2018-03-02 robertphillips Fix creation of extra GrContextThreadSafeProxies in DDL world
2018-03-02 egdaniel Update Flush and Invalidate Memory calls in vulkan to take offset and size
2018-03-02 halcanary SkQP: Host APK list on cloud; no more commits
2018-03-02 halcanary SkQP/Doc: two more APKs
2018-03-02 jvanverth Various fixes for scaled emojis
2018-03-02 angle-skia-autoroll Roll skia/third_party/externals/angle2/ b7d145861..437664b4b (1 commit)
2018-03-01 robertphillips Make use of the buffer data null hint a GrContextOption
2018-03-02 angle-skia-autoroll Roll skia/third_party/externals/angle2/ d6fef528f..b7d145861 (1 commit)
2018-03-01 egdaniel Add ctor to GrVkAlloc
2018-03-01 halcanary SkString: remove externally unused ::setUTF16() from API
2018-03-01 scroggo Fix fuschia roll
2018-03-01 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 98e6a5f7b..d6fef528f (1 commit)
2018-03-01 ethannicholas Fixed SkSL use-after-free fuzzer bug and added defensive code to catch such problems in the future.
2018-03-01 benjaminwagner Omit path_text_clipped_uncached for RadeonHD7770.
2018-03-01 egdaniel Move workaround for fSRGBsupport before config table init in GrVkCaps
2018-03-01 brianosman Revert "Add 1010102 support to Ganesh"
2018-03-01 robertphillips sk_sp-ify GrGlyphCache
2018-02-28 benjaminwagner Upgrade Windows Skolo NVIDIA GPU drivers.
2018-03-01 robertphillips Move atlas manager creation to GrContext derived classes (take 2)
2018-03-01 kjlubick [skpbench] experiment with not disabling services
2018-03-01 egdaniel Move the rest of Vulkan driver workarounds into helper function in GrVkCaps
2018-03-01 halcanary SkQP: new apk
2018-03-01 robertphillips Fission GrAtlasGlyphCache in two (take 2)
2018-03-01 halcanary SkString: fix ::setUTF16
2018-03-01 brianosman Add 1010102 support to Ganesh
2018-03-01 benjaminwagner Omit longpathdash on Chorizo to avoid OOM.
2018-03-01 halcanary SkQP/Doc: new apks
2018-03-01 egdaniel Add unit test the explicit tests create a GrVkCopyPipeline
2018-03-01 robertphillips Clean up GrDrawOpAtlas (take 2)
2018-03-01 robertphillips Separate creation time & flush time behavior in GrDrawOpAtlas (take 3)
2018-02-28 liyuqian Fix a tiny typo
2018-03-01 kjlubick Change force_quarantine to use bot id
2018-02-28 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 2f3a0dc5c..98e6a5f7b (2 commits)

Created with:
  roll-dep src/third_party/skia
BUG=none


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=fmalita@chromium.org

Change-Id: I5a15c63d9df6b698d861c846f98e8de8dc946a04
Reviewed-on: https://chromium-review.googlesource.com/947895Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#540824}

In QUIC, incrementally calculate newly acked packets. Protected by FLAGS_quic_reloadable_flag_quic_use_incremental_ack_processing2.

Merge internal change: 187526927

R=rch@chromium.org

Change-Id: Iae1d28a17d693d11331b6cf7e9e5f741084ffd9e
Reviewed-on: https://chromium-review.googlesource.com/946329
Commit-Queue: Fan Yang <fayang@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540823}

It is possible that tabs on Android have no web_contents. Check for
this case to avoid crashing.

Bug: 818265
Change-Id: I803569fedd23510103923e03d6ba9e79457c57f9
Reviewed-on: https://chromium-review.googlesource.com/948488
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540822}

BUG=816346

Change-Id: Ic4dc4b63cc9254683e5f2c5072030beeaab0c686
Reviewed-on: https://chromium-review.googlesource.com/945988
Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540821}

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
and SequencedTaskRunnerHandle::Get() with other appropriate task runners
in the renderer.

This avoids the SequencedTaskRunnerHandle::Get() call when the constructor's
default parameter is used. We are trying to ban SequencedTaskRunnerHandle::Get()
in content/renderer because it usually is not the right task runner to use,
as a per-frame runner should be used instead. In this case, it doesn't
really matter since frames are not involved, but we still want to remove the
calls for the bigger benefit of banning it in content/renderer.

Bug: 786332
Change-Id: I96a5c6657c029bd685e2302a778316b69b3af683
Reviewed-on: https://chromium-review.googlesource.com/942287
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540820}

This reverts commit cc4be1cb.

Reason for revert: speculative revert for test crashes deep in ShelfWidget::Shutdown; see https://crbug.com/818603.
BUG=818603

Original change's description:
> cros: Cleanup ShelfWidget::DelegateView shutdown
> 
> Make it use DeleteDelegate() to be more consistent with
> StatusAreaWidgetDelegate. Defer closing the widget until all the
> top-level windows are closed.
> 
> Bug: 628655
> Test: ash_unittests
> Change-Id: I066b45dab9c848b8f990f7fb51f0170e5e66a861
> Reviewed-on: https://chromium-review.googlesource.com/907390
> Commit-Queue: James Cook <jamescook@chromium.org>
> Reviewed-by: Michael Wasserman <msw@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#540550}

TBR=jamescook@chromium.org,msw@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 628655
Change-Id: Ia3eb845627c77761bb15e94f9bbc9b3f1643f584
Reviewed-on: https://chromium-review.googlesource.com/948494Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540819}

NOTRY=true
TBR=ashleymarie@chromium.org

Change-Id: I871b9fff3689356ba636c559ff86a50f8d1552e6
Reviewed-on: https://chromium-review.googlesource.com/948799Reviewed-by: Emily Hanley <eyaich@chromium.org>
Commit-Queue: Emily Hanley <eyaich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540818}

(and hopefully the last ones, for real...)

The process is the same as previous:
rebaseline-cl --builders=<all mac ports...> <list of failures>

Two changes in TestExpectations:
1. fast/encoding/denormalised-voiced-japanese-chars.html also fails on
   Mac 10.13, which seems to be expected considering it fails on all
   previous Mac versions the same way.
2. editing/caret/caret-color.html isn't in SmokeTests anymore (i.e. the
   test doesn't run on Android).

Bug: 774301, 545140, 595483
Change-Id: Ie37cc7f6b3837ad520807c52ebce56b4b464938c
Reviewed-on: https://chromium-review.googlesource.com/947803Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540817}

These tests test HIRAGANA/KATANAKA small letters have the [NS]
Nonstarter line break property based on Unicode 5.1.0.

These code points are changed to [CJ] Conditional Japanese Starter
property in Unicode 6.1.0 (UAX#14 revision 28.)

The same code points are tested as [CJ] in following tests, and
that these tests are not needed.
css3-text-line-break-jazh-[0-2]{01..24}.html

[CJ]: http://unicode.org/reports/tr14/#CJ
[NS]: http://unicode.org/reports/tr14/#NS

Bug: 817778
Change-Id: Icffcdfdb1ef41bc4f929913217c051047a340fca
Reviewed-on: https://chromium-review.googlesource.com/948662Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540816}

In GCC 7.2/7.3, base::Optional<T> fails to compile, if T has still
only been forward declared, as it cannot properly resolve the
is_trivially_* declarations. In this case it is needed to include the
full declaration of the type, and not only the forward declaration.

Change-Id: I63e5c6307394c6c2eda6af108c80395152bfc04f
Reviewed-on: https://chromium-review.googlesource.com/944401
Commit-Queue: José Dapena Paz <jose.dapena@lge.com>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540815}

https://webrtc.googlesource.com/src.git/+log/3ba7a57f8fff..3f693b9e75fc

$ git log 3ba7a57f8..3f693b9e7 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=None,None


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I1e6e4b7b99b7cc1f9352156b377a1b242b96474c
Reviewed-on: https://chromium-review.googlesource.com/948071Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#540814}

Change-Id: I1f0d494f0a1d83cde0c632aec642fadecbe7b9b3
Reviewed-on: https://chromium-review.googlesource.com/946628Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540813}

Bug: 788657
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Idb284c691eec3b6c468431c2a16ae2a7977211cf
Reviewed-on: https://chromium-review.googlesource.com/921281Reviewed-by: Olga Sharonova <olka@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540812}

WorkQueue class has work_queue_ field, which is confusing. Rename it to
tasks_.

R=alexclarke@chromium.org,skyostil@chromium.org

Change-Id: Ibdf4c69cf29a9ffbd48205fac1cd9b20c92f7a13
Reviewed-on: https://chromium-review.googlesource.com/897525
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540811}

Follow-up for comments in 939469.

R=haraken@chromium.org

Change-Id: I7ff56c9ef77a7174c8e6cc2e3a9a91faebff2ed2
Reviewed-on: https://chromium-review.googlesource.com/941327Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540810}

6.7.1 and newer are failing CFI builds.

BUG=818611
TBR=grt@chromium.org

Change-Id: Ie0439da3fd330a8814daee9f3da3e2c412fbbf6f
Reviewed-on: https://chromium-review.googlesource.com/948485Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540809}

This reverts commit 5c7dc5f2.

Reason for revert: Broke Linux x64 clobber build.

Original change's description:
> Apply snake_case to generated files in gen/blink/core/css/properties/*/.
> 
> Generated files in these directories are often identical to other
> checked-in files. It's difficult to make move_blink_source.py workable
> in such situation. So, this CL renames these generated files beforehand.
> 
> This CL has no behavior changes.
> 
> Bug: 770603
> Change-Id: I3bf2312b7a238fe605e33a9217959d84d43ffb4f
> Reviewed-on: https://chromium-review.googlesource.com/947546
> Reviewed-by: nainar <nainar@chromium.org>
> Commit-Queue: Kent Tamura <tkent@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#540796}

TBR=tkent@chromium.org,nainar@chromium.org

Change-Id: I5203839d03f67e7b28098c051803769ed3fa817a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 770603
Reviewed-on: https://chromium-review.googlesource.com/948643Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540808}

This CL makes sure document.pictureInPictureEnabled always returns false
and video.requestPictureInPicture() rejects if PictureInPicture and
UseSurfaceLayerForVideo features are not enabled.

Bug: 806249
Change-Id: Icc91903aa0f44dde577ce479a8d5d453952e6575
Reviewed-on: https://chromium-review.googlesource.com/937301
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540807}

This is a tentative care to silence all flaky tests.
We have found all the tests using the test mount point info are flaky
affecting the trybot runs every time. So we'll disable all the affected
test before fixing the root cause.

TBR=yamaguchi@chromium.org

Bug: 804413
Change-Id: I7f711446accc61a8bedf00f52c328a1037a11791
Reviewed-on: https://chromium-review.googlesource.com/948483Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540806}