- 01 Jul, 2020 40 commits
-
-
Noel Gordon authored
Remove a stray extra line. Add some in canPasteOrDrop_ to end the code squishing competition and instead promote code readability. No change in behavior, no new tests. Tbr: (mr-no-nbn) adanilo Bug: 1002394 Change-Id: I038646234385c7b0dd73b72752f8c5a160e70877 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275161 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#784315}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3f5d1ca9a8eb..9e100526c3df 2020-07-01 dberris@chromium.org sched: Show the queue in job results If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:981429 Tbr: wenbinzhang@google.com Change-Id: Iff5e096042bebac0ddac66f83451f851d619170d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276626Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784314}
-
Ella Ge authored
All usage has been updated to base::Bind{Once,Repeating} and base::{Once,Repeating}Callback respectively. Fix: 1007641 Change-Id: Ieb7aaacdfa2df52a51092cc332e09951db3c3758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275103 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#784313}
-
Melissa Zhang authored
This CL adds a temporary button to the toolbar that will be used to trigger the sharesheet during development. Bug: 1097623 Change-Id: Icb9029fbd508e6e358bd82381886dbd7b6050cae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262400Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#784312}
-
Robert Sesek authored
GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: 1052560 Change-Id: I3292ad8d76e9b25e56f01f52db8c3fc9aedf3a76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276660 Auto-Submit: Robert Sesek <rsesek@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I7d5df44976ba63862d848176cc4eed2d90c19d9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277481Reviewed-by:
-
Ella Ge authored
All usage has been updated to base::Bind{Once,Repeating} and base::{Once,Repeating}Callback respectively. Fix: 1007638 Change-Id: I31ee3da38efebdd5cf402d3faa79d42dd2bed095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275471 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by: -
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I04c835a7e5557782e5b3e77fe6df20b061943196 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277408Reviewed-by:
-
Haiyang Pan authored
Bug: 1098927 Change-Id: Ibd209ea32d8c47e115499c20741ef4dc9e851924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277051 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#784307}
-
Rachel Carpenter authored
CIPD package: https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/Uu11Q1wqNSVwkH2IvVt8kSs867Nu-6mf0O9kxpQfckAC Release notes: http://go/help_app-x20/relnotes/Nightly/help_app_nightly_202006240800_RC01.html Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Change-Id: I1ca4c636d0049e09fc0c7517d7817862a838c19e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277364Reviewed-by:
Patti <patricialor@chromium.org> Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Cr-Commit-Position: refs/heads/master@{#784306}
-
Kyle Milka authored
Refactor SendTabToSelfNotificationReceiver out of NotificationManager. Bug: 1090917 Change-Id: I8cd10e739af093dc35138a8ac4478d4f251ce639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261174 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#784305}
-
Robert Sesek authored
GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: 1052560 Change-Id: I88e2c0191af5e52e86b4a27e0caba52bd960e66a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276761 Auto-Submit: Robert Sesek <rsesek@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#784304}
-
Koji Ishii authored
This patch changes the iterator of |PostLayoutChildren| to eliminate fragments for destroyed or moved |LayoutObject|. The root cause is probably pre-paint with dirty tree, and this patch does not address that, but makes fragment traversal safer. This patch is speculative. Bug: 1099863 Change-Id: Ia78d55cc43a50f54f4b547ae8febc025770ac004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275944Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#784303}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fe7e74b3a786..77d7d5ea92ca 2020-07-01 mtklein@google.com with sanitizers, JIT but ignore it 2020-06-30 fmalita@chromium.org [skottie] Fix wipe effects for images If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ethannicholas@google.com Change-Id: Ifa647b7fc0203e90de7c9e4cb01cf16228af6f48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277270Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d0779351..c3dc5798 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4835fc7b5ba8acf937d47dd794db01c54ffb3161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277240Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784301}
-
Gyuyoung Kim authored
FrameToken can be available in RenderFrameImpl. So, we don't need to get it from browser through Mojo method. This CL removes the method and related tests, then just return the frame token through the media::RoutingTokenCallback. - RenderFrameImplTest.TestOverlayRoutingTokenSendsLater - RenderFrameImplTest.TestOverlayRoutingTokenSendsNow Bug: 1093917 Change-Id: I52cb4b09f497062cff3279d788bf8c1bce517dc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269986Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#784300}
-
dpapad authored
Fixed: 1100429 Change-Id: I100e069dc5dc249647f7ed5697d8e36bbce932af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276762 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#784299}
-
Alexey Baskakov authored
This mimics the missing logic from ExtensionAppsBase::Launch() method specified for bookmark apps. Note: We should not do RecordAppWindowLaunch because web_app_launch_manager_->OpenApplication() does it. Bug: 1062885 Change-Id: Ie5a444692b9de98087db899a73a139950cd537f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277367Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#784298}
-
Koji Ishii authored
This patch changes to associate floating |LayoutObject|s to |NGFragmentItem| using |FirstInlineFragmentItemIndex|. The index is used for many purposes, but one of them is to mark destroyed or moved |LayoutObject| in |NGFragmentItem|. Because floating objects are stored in |NGFragmentItem|, they need to be indexed to mark correctly. Also changes |LayoutBlockFlow:: SetShouldDoFullPaintInvalidationForFirstLine| to skip items for destroyed or moved |LayoutObject| because it may be called on dirty tree. Bug: 1100900 Change-Id: If35bf2c77b9a46a9ba598e6785926f6b0e1c5455 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275373 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#784297}
-
Xida Chen authored
This CL converts base::Closure to base::RepeatingClosure in banners/ folder. This is a code health CL, no behavior change. Bug: 1007635 Change-Id: I51130356d46394c0a9b57552adf879628d288902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273459Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=pbommana@chromium.org Change-Id: I7ac05ad4e8817a78ca15f868ba9a113b3d457929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277443Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784295}
-
Jesse McKenna authored
This change removes the SlowDCTimerInterruptsWin experiment and makes its behavior the default, lowering the raised timer-interrupt frequency to 125 Hz when on battery power. This is expected to result in a ~4% system power savings (per crbug.com/927165). The SlowDCTimerInterruptsWin experiment has been gradually rolled out through the Canary, Dev, Beta, and Stable channels, and has currently been active on 50% of the Stable channel for four weeks. It has shown no regression to its guardrail metric, FirstContentfulPaint.OnBattery. Background: Chrome frequently raises the system's global timer-interrupt frequency in order to increase responsiveness for timers. Windows handles timers by checking whether the timer has finished on a given interval; this is called the 'timer-interrupt frequency'. Increasing the timer-interrupt frequency is done by many programs to increase the granularity at which timers can be set, so waiting processes can be notified more accurately (which in some cases will mean more quickly) when their timers have finished. However, raising the timer-interrupt frequency makes the system consume additional power, so should be done sparingly. Chrome currently sets the following limits for interrupt frequency depending on whether the system is on battery power: Default, not raised: 64 Hz Raised, AC (wall power): 1000 Hz, i.e. kMinTimerIntervalHighResMs = 1 Raised, DC (battery power): 250 Hz, i.e. kMinTimerIntervalLowResMs = 4 This change halves the raised frequency of interrupts when on DC power: Raised, DC (battery power): 125 Hz, i.e. kMinTimerIntervalLowResMs = 8 Bug: 927165 Change-Id: I321599c7ce679671b29804660d5589dc88df6bf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265402Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#784294}
-
zhaoyangli authored
This is a reland of 6a309aad Original change's description: > [iOS] Remove all EG1 test targets and related GN components. > > Removed all test targets, EG1 specific test utils in GN files. > Removed gni files to build EG1 targets. > Removed build files in ios/third_party/earl_grey. > > Bug: 1046369 > Change-Id: Iec1d60fa40d10969c4e6e6840f2983b02c3170dc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275353 > Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#784204} Bug: 1046369 Change-Id: I1690dcd79d4848cf042c06cfe2b479ed37b2df17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276682Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#784293}
-
Will Cassella authored
This CL revamps the way a VideoDecoder or AudioDecoder is selected to decode a given VideoDecoderConfig or AudioDecoderConfig, respectively. The goal is to first filter and rank available decoders based on their high-level attributes ("IsPlatformDecoder", "SupportsDecryption"), rather than attempting to initialize them in the order they're submitted. The result is that an initial decoder is selected more efficiently, and the decoding system can gracefully transition between platform and non-platform decoders if the config changes mid-stream. The full design doc is available at: go/predicate-based-decoder-selection Bug: 684792 Change-Id: I8660e7315881b2bea44bf52afb4505f979a43728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247331 Commit-Queue: Will Cassella <cassew@google.com> Reviewed-by:Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#784292}
-
Yoshifumi Inoue authored
This patch changes dependency graph of |LayoutNGFragmentItem| to make |ScopedLayoutNGForTest()| to work with both LayoutNG and legacy layout for running blink units for legacy layout tree. When we use "implied_by", |LayoutNGEnabled()| is implemented as: static bool LayoutNGEnabled() { if (LayoutNGFragmentItemEnabled()) return true; ... features in "implied_by". return is_layout_ng_enabled_; } Change-Id: Id65a621bc6b041755b7897f9e5698aff26369370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275952 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#784291}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I03bbba060b79d8597f643dff33c4a5d428232321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276686Reviewed-by:
-
Sophie Chang authored
Bug: 1099371 Change-Id: I5d88c52547f0bcaab082521c0a084ca21bc415d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276759 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#784289}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/947260e25933..465b1021048a 2020-07-01 chrche@microsoft.com [Loc] Fix <LOCKED> and <ex> get removed when messages move across grdps If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1071004 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5340a35f94140c98f685eee2c37a8dc412ab8427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277052Reviewed-by:
-
Istiaque Ahmed authored
This CL makes error in any of "homepage", "search_provider", and "startup_pages" keys correctly point to the specific error, rather than generic "Empty dictionary for 'chrome_settings_overrides'" error message. For chrome_settings_overrides.search_provider key, the sub-keys "name", "keyword", "encoding" and "favicon_url" are mandatory, this CL also clarifies that in error message. Bug: 1088065 Test: Better error messages for missing/invalid keys, see bug for details. Change-Id: I034e62ab8a636a5c65872e8c770798bb5cd4641b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271887 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#784287}
-
Jinsuk Kim authored
Extends the experiments to M90 so the flag options will be visible. Change-Id: Ia838f222146def57691d50c5fd25a27c7dc3033a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275812Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#784286}
-
Sorin Jianu authored
Change-Id: I67566752373601fae9a667811be0d6ea146f2858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276683Reviewed-by:
S. Ganesh <ganesh@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#784285}
-
Jimmy Gong authored
- ChromeVox was announcing ongoing print jobs twice. There seems to be a with ChromeVox and iron-list focusable items. The fix is to remove fow-row-control from the high level row wrapper div and move it down to either the completed status or ongoing status. - A side effect of this is that the cancel print job button will now be focused when tabbing through ongoing print jobs. - Optimize ChromeVox user experience for ongoing print jobs by announcing to users that print jobs can be cancelled by pressing the 'Enter' key. - ChromeVox will now announce when a print job has been cancelled. Bug: 1100789 Change-Id: I8d60e9bc6bed8eeec6eb9003dbf7be4c7de0a8a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275480 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#784284}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/af04ef2a7d2e..fdd2cd6e5fc0 2020-06-30 dpranke@google.com Reland "Add a Str() function to gclient for use in DEPS files." 2020-06-30 dpranke@google.com Add dpranke@google.com to //OWNERS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1099242 Tbr: agable@chromium.org Change-Id: Id0f3db271c6dcb0a718496f0a4bab59a6b1bca44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277050Reviewed-by:
-
Sangwoo Ko authored
Previously, MediaToolbarButton has different image for enabled states on Mac. Please refer to https://chromium-review.googlesource.com/c/chromium/src/+/1815904. But it's not true at this point, so we don't need this calls anymore. This is prework for ToolbarButton refactoring Bug: 1048901 Change-Id: Ife793fe1bc5093fe30cce4fcbd01bcff58799f43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275359Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Cr-Commit-Position: refs/heads/master@{#784282}
-
Liviu Tinta authored
Bug: 989958 Change-Id: I6b22f34ad6b1da138bbd90a905508d9dd789cd96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268384Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2e401eea3e9a..3f5d1ca9a8eb 2020-07-01 fancl@chromium.org auto-triage: Only reopen issue when auto-bisect is enabled If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1100716 Tbr: wenbinzhang@google.com Change-Id: If08d91f59fcdd871c01ade1fe36375bf43453513 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277203Reviewed-by:
-
Fergal Daly authored
This was fixed in https://crrev.com/c/2246087 and reenabling got lost in some rebasing. Bug: 1064944 Change-Id: I5f1ff9c2135f0861e044590482760708fbe171da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275362Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#784279}
-
Toby Huang authored
Currently, if an extension has permission updates pending the user's approval, non-supervised users such as regular and enterprise users will see the kite icon over the extension on the chrome://extensions page. This CL fixes this UI bug so that only supervised users will see the kite icon. There should be no restrictions on the extension itself for non-supervised users. Bug: 1100395 Change-Id: I2d5a61e92925d093fa3ee4183c427d89dc8988b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273684Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#784278}
-
Rakina Zata Amni authored
This reverts commit e8275717. Reason for revert: Causes ToolbarActionsBarUnitTest.ReuploadExtensionFailed to crash, e.g. https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/b8876023303247456768 Original change's description: > [Extensions] Handle reloading an extension that failed to load > > This CL enables ExtensionService::ReloadExtension() to handle reload > failures, where subsequent calls can retry the reload, rather than > immediately giving up. > > Bug: 792277 > Change-Id: I482da093133a1baee7f2f5cad8abbc9c85e9e074 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242642 > Commit-Queue: Ghazale Hosseinabadi <ghazale@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#784037} TBR=rdevlin.cronin@chromium.org,ghazale@chromium.org Change-Id: Id229fde9a694ac3e0a0b8376492604b11f461292 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 792277, 1101189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277366Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#784277}
-
Alex Moshchuk authored
Previously, this was only set from CommitNavigation. Error pages go through FailedNavigation instead of CommitNavigation, so they were never setting this to true. Looking at the use cases of has_committed_any_navigation_, it seems that this is a bug, so this CL fixes it. This is a prerequisite for https://crrev.com/c/2250945, which will avoid BrowsingInstance swaps for browser-initiated navigations if has_committed_any_navigation_ is false, to fix issues with improperly using a spare process for initial RFHs. Doing this also makes the test SitePerProcessBrowserTest.ProcessTransferAfterError fail with RenderDocument for subframes due to https://crbug.com/1068965, so that test is disabled in that mode. Bug: 1094088,1068965 Change-Id: I942fd4046bb1c6941cf5c8aaf1c17b37ed9cdbdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272029 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#784276}
-
