- 20 Jun, 2018 40 commits
-
-
Mikel Astiz authored
This logically reverts the precaution introduced in https://chromium-review.googlesource.com/843574 which prevented sync IDs from being vended when the browser itself was not running (no tabbed activity/window), effectively resulting in a partial unlaunch session sync for Custom Tabs. The reason to do this was UMA metric Sync.SesssionsDuplicateSyncId reporting many sync ID conflicts, now investigated in depth in crbug.com/843554. The suspicion was that duplicate IDs were produced by a race condition due to using two separate persistence databases (one for sync, one for session restore). We recently reworked the SyncedTabDelegate API to migrate away from sync IDs, which renders the above concern moot and makes it straightforward (as proposed here) to start syncing Custom Tabs even when no tabbed window exists. Bug: 840722,853459 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I8a27e68faa79271a6058f00c3dd5355ef635f1a4 Reviewed-on: https://chromium-review.googlesource.com/1092536 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#568785}
-
Jeremy Roman authored
This prevents the resolver from being prematurely collected. Bug: 852751 Change-Id: I9516c9cdb84133291008cb045108e41baa956272 Reviewed-on: https://chromium-review.googlesource.com/1106543 Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#568784}
-
Javier Fernandez authored
The Grid Layout code needs to run a pre-layout for some specific case, which include orthogonal and baseline aligned grid items. We decided to execute this logic as part of the PlaceItemsOnGrid function, aiming for a better performance and simpler and more elegant code. However, the PlaceItemsOnGrid function is not executed on re-layouts if no item has changed its position. Hence, there may be cases where we need to repeat the layout of the grid and some of the items involved in baseline alignment items are marked for layout as well. In those cases, like the one described in the bug this CL tries to fix, the grid item is assumed as not participating in baseline alignment, but we resolve that it actually participates during the layout phase. This CL tries to solve the issue my moving the pre-layout logic out of the PlaceItemOnGrid function, so we ensure both orthogonal and baseline alignment are laid out before running the intrinsic size and layout operations. Bug: 853427 Change-Id: I31d0357e647cccf728376a4abc12e8ea19983822 Reviewed-on: https://chromium-review.googlesource.com/1104425 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#568783}
-
Jerry Lin authored
The tests in components/autofill/c/b/password_generator_fips181_unittest.cc use a random source during tests and are thus non-deterministic. This patch adds a method of PasswordGeneratorFips181 called SetGeneratorForTest. It accepts a parameter generate_func so PasswordGeneratorFips181 will use this function to generate password to achieve deterministic unittesting. Unittest code uses this function to set generator for test to make test deterministic. R=vabr@chromium.org Bug: 847200 Change-Id: If2924ed0e59843336f0e642053eefaca4c353163 Reviewed-on: https://chromium-review.googlesource.com/1084392 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#568782}
-
Sylvain Defresne authored
IdentityManager is the recommended API to access the Google account used by the user and SigninManager is deprecated. Convert PrivetPrinterHandler to the new API. Bug: 798408 Change-Id: I9cd18bd698f88ecda52d085ba661641d7c6fe06d Reviewed-on: https://chromium-review.googlesource.com/1100758Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#568781}
-
Joel Einbinder authored
Bug: 853439 Change-Id: Iea24e161de8fd82be7b1a6b3f4c5ffdf99425f14 Reviewed-on: https://chromium-review.googlesource.com/1107014Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#568780}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2e5de0eb. With Chromium commits locally applied on WPT: 03ef65db "Update existing WebUSB WPT to be multi-global" 89102421 "Reland "Multi-global WebUSB WPT for window and worker"" 08784a11 "[Mojo Blob URLs] Make clicking an <a target="blank_"> with a blob URL work correctly." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19931 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: alexander.shalamov@intel.com, rijubrata.bhaumik@intel.com, timvolodine@chromium.org: external/wpt/generic-sensor TBR=robertma No-Export: true Change-Id: I8421a0ee11455014847ce071e0448e0ca4a6d693 Reviewed-on: https://chromium-review.googlesource.com/1107492 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#568779}
-
Kush Sinha authored
This is a reland of 94c42a4f Original change's description: > Code Cleanup: Dedup usages of AccountManager's URL Context > > |InlineLoginHandlerChromeOS| and |ChromeOSOAuth2TokenServiceDelegate| > use the system URL context because they 'know' that AccountManager is > going to use the same. This is a leaky abstraction. > > Add a method in AccountManager that returns its URL Request Context. > This request context happens to be the system URL context for now. > > Bug: 820046 > Change-Id: I668769167893c995f73df63acc575eb410c0f986 > Reviewed-on: https://chromium-review.googlesource.com/1088617 > Commit-Queue: Kush Sinha <sinhak@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Lutz Justen <ljusten@chromium.org> > Cr-Commit-Position: refs/heads/master@{#566998} Bug: 820046 Change-Id: I614beba63f15ebe3a3db9a267ef8d747a7728a50 Reviewed-on: https://chromium-review.googlesource.com/1105777Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#568778}
-
Hayato Ito authored
A part of crbug.com/738794. trustedtypes are not related to DOM Standard. BUG=777761,738794 Change-Id: I56906a4ca41a3a3318b26cc52579661ed25f3c50 Reviewed-on: https://chromium-review.googlesource.com/1107519Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#568777}
-
Ramin Halavati authored
Flash permissions are on the way to become only persistent through current session. This CL adds an experimental flag for the required changes. Bug: 850062 Change-Id: Iccc22dbb2c9d63711e8b58c76e59a6939bd58d46 Reviewed-on: https://chromium-review.googlesource.com/1105986Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#568776}
-
Aleksei Loshkarev authored
Removes from ModelTypeController preferences dependent logic for purging sync metadata. Now ModelAssociationManager advises data type controllers when is it necessery to purge sync metadata. Bug: 823721 Change-Id: Ib4e73fde912accc6b84188d0f21c3df724000f5e Reviewed-on: https://chromium-review.googlesource.com/1008303 Commit-Queue: Aleksei Loshkarev <lixan@yandex-team.ru> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#568775}
-
Ivan Sandrk authored
In public session, US international was the default keyboard layout for Brazilian Portuguese while the want is to have Brazilian as the default layout. The default is chosen as the first layout from the list, so fix the default by reordering the lists in (google_)xbk_manifest.json. More details at the linked bug. Bug: chromium:851625 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I524cf6bf0b625ae60c26820a1b224815b6d7d1cb Reviewed-on: https://chromium-review.googlesource.com/1102685 Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#568774}
-
Denis Yaroshevskiy authored
This function is never called. If there is ever a need to do this, chome_paths has a generalized mechanism for overriding file paths. Change-Id: I0822b22aed510492f88ecc0b4595649aee749583 Reviewed-on: https://chromium-review.googlesource.com/1102466Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Denis Yaroshevskiy <dyaroshev@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#568773}
-
stkhapugin@chromium.org authored
Update the location_bar_secure icon to a new one. Bug: 852787 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iea6784608548fd25463df21de3952dcdb87745b0 Reviewed-on: https://chromium-review.googlesource.com/1101199 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#568772}
-
cathiechen authored
While ComputeInlinePreferredLogicalWidths ignore spaces after LayoutNGMarker. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I9ced3a959c6f89412c82686ffe2fcee4f141737e Reviewed-on: https://chromium-review.googlesource.com/1102284 Commit-Queue: cathie chen <cathiechen@tencent.com> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#568771}
-
Ivan Kotenkov authored
Update documentation and remove an unused variable. This is a cleanup after https://chromium-review.googlesource.com/c/chromium/src/+/935670 Bug: 651348 Change-Id: I6e974b282c61497a8e5fdc2ea092e48d32ee26ed Reviewed-on: https://chromium-review.googlesource.com/1105827 Commit-Queue: Ivan Kotenkov <kotenkov@yandex-team.ru> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#568770}
-
Uladzimir Miniailau authored
Remove unnecessary "Enable" from a password manager feature name. Bug: 785953 Change-Id: I7c979dc97e34595db69976d673c0afe31aceb879 Reviewed-on: https://chromium-review.googlesource.com/1106377Reviewed-by:
-
Gauthier Ambard authored
This CL changes the vertical constraints of the collapsed toolbar to have the location bar displayed in the middle of the collapsed toolbar by changing the constraint to position its bottom anchor. Bug: 836817 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I35ad32681a820b8480ecec76e825defc4c0aa2ef Reviewed-on: https://chromium-review.googlesource.com/1107061 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#568768}
-
Hajime Hoshi authored
Design Doc: https://docs.google.com/document/d/1BBtBPTarOF4NeVKSWZe3XaDHo4yTGhdlqYm35yVzPs4/edit# Bug: 846618 Change-Id: I15903843b0377c45db9caf3d54914ed942caf361 Reviewed-on: https://chromium-review.googlesource.com/1098742 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#568767}
-
Christopher Lam authored
This CL removes all compiled_resources2.gyp files from ui/webui and third_party/polymer, and removes the script that generates them for Polymer Elements. TBR=jochen@chromium.org Bug: 632206 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I1866d4e682e41c462958ac1185b6cb7e70cb7130 Reviewed-on: https://chromium-review.googlesource.com/1105677 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#568766}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/66cadcc6b924..f04148c810aa git log 66cadcc6b924..f04148c810aa --date=short --no-merges --format='%ad %ae %s' 2018-06-20 qingsi@google.com Enable any address ports by default. 2018-06-20 buildbot@webrtc.org Roll chromium_revision 6e14efc1..20579735 (568572:568689) 2018-06-20 steveanton@webrtc.org Mark unused/deprecated DTMF methods for removal 2018-06-19 shampson@webrtc.org Fixing flakiness in PeerConnectionIntegrationTest. Created with: gclient setdep -r src/third_party/webrtc@f04148c810aa The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I935d390e8be1182e0c65f64645b756a30c30dcd2 Reviewed-on: https://chromium-review.googlesource.com/1107140 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568765}
-
Marc Treib authored
- Move "enum SyncInitialState" into the .cc. - Get rid of many rarely or inconsistently used "using syncer::*"s. - Update some comments. - Remove a few unnecessary "virtual"s. - Merge ChangePreferredDataTypes into OnUserChoseDatatypes - all updates must go through that. - As a consequence, update SyncAwareCounterTests. In particular, don't use syncer::HISTORY_DELETE_DIRECTIVES which is not a user-selectable type. Instead use syncer::TYPED_URLS, which corresponds to the "History" checkbox, and which implies HISTORY_DELETE_DIRECTIVES. Bug: 839834 Change-Id: Ifea0178c1f1e1c1546a1f904c1e52d527df9ed7b Reviewed-on: https://chromium-review.googlesource.com/1106171Reviewed-by:Christian Dullweber <dullweber@chromium.org> Reviewed-by:
-
Raphael Kubo da Costa authored
The other pages were referring to android_emulators.md (plural), which does not exist. TBR=agrieve Change-Id: I6bd1c2ac95f851b8aae02550c650607ed2182a1f Reviewed-on: https://chromium-review.googlesource.com/1103569Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#568763}
-
Matt Falkenhagen authored
The linked bug is because Blink is surprised when we skip a non-fetch event controller. This CL is preparation to fix that. We have IsControlledByServiceWorker() but some callsites might be interested in the no-fetch vs fetch cases. Most likely, Blink only cares about the fetch case. However, in non-S13nServiceWorker, it's complicated because Blink doesn't know which controller will handle a request, since it's ultimately decided by the browser process and skipWaiting() may occur in the meantime. It's safest to just make things explicit and make IsControlledByServiceWorker() return an enum of state. If it turns out after S13nSW we can collapse "no controller" and "no fetch event controller" together, we can simplify then. This CL doesn't have an expected behavior change, just preparation. Bug: 850839 Change-Id: Ic7b2b527947c09be46c337ce90024aabccecbb1c Reviewed-on: https://chromium-review.googlesource.com/1104078 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#568762}
-
Ken Rockot authored
It's no longer used in these places, so wipe out any corresponding DEPS and gn deps entries. TBR=sky@chromium.org TBR=dschuff@chromium.org TBR=danakj@chromium.org TBR=xhwang@chromium.org TBR=nick@chromium.org Bug: 844763 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ia2237301555ceba399dc63373ab13fab5f0ab02b Reviewed-on: https://chromium-review.googlesource.com/1107105 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#568761}
-
Sasha Morrissey authored
Check for canCopy/canAddChildren capabilities when copying/moving in the Files App. This also affects drag-drop operations, although only on the RHS file listing (not the LHS directory tree). Also added integration tests for cut/copy/paste, including some that try copying a file and pasting it into a folder with and without the canAddChildren capability. Test: browser_test --gtest-filter="ContextMenu/FilesApp*" Bug: 719959 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I8621e873360dceffdb977b33a7261757841e929d Reviewed-on: https://chromium-review.googlesource.com/1096716 Commit-Queue: Sasha Morrissey <sashab@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#568760}
-
Nigel Tao authored
The EntryAction type is (now) fictional, and no longer corresponds to anything in chrome/common/extensions/api/file_manager_private.idl Test: "ninja ui/file_manager:closure_compile" runs without error Bug: 613096 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I3afc580cbcf259fac2a450f24cb7088164ee235c Reviewed-on: https://chromium-review.googlesource.com/1107027Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#568759}
-
Jan Wilken Doerrie authored
This change simplifies base/win/async_operation.h by deduplicating logic and flattening the class hierarchy. This is possible by introducing two compile time switches, that pick the correct storage and result type depending on the provided template instantiation. Bug: 821766 Change-Id: Ia04dc4cdbc42a4005204491cc47650d35f413cdb Reviewed-on: https://chromium-review.googlesource.com/1106382Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#568758}
-
Koji Ishii authored
Following bot results are included. 6947 6948 6951 6953 6957 6960 6968 6 lines were removed and 1 lines were deflaked by consecutive results since 6935. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: If3878b7f06bf1b38a56e08f35d872e318b90879d Reviewed-on: https://chromium-review.googlesource.com/1106177 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Tatsuhisa Yamaguchi authored
Show date/time setting when the date view is clicked. Bug: 850439 Test: manual (--enable-features=SystemTrayUnified) Change-Id: I597776e79cf639cd2ce1a3890fc31064d21de8bd Reviewed-on: https://chromium-review.googlesource.com/1092555Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#568756}
-
Donna Wu authored
BUG=769630 Change-Id: I9566ec9c3efae1f8b7d30dec8622f35dc2ba3f7a Reviewed-on: https://chromium-review.googlesource.com/1096655 Commit-Queue: Donna Wu <donna.wu@intel.com> Reviewed-by:
-
Nicholas Verne authored
Since installing crostini involved downloading around 300MB, we prevent the install flow from proceeding if we're offline. Added a browser test with ExtraParts support. Bug: 843065 Change-Id: Ia0049d4ec30ac79c585d129e05aa2240eeecba09 Reviewed-on: https://chromium-review.googlesource.com/1107419Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#568754}
-
Tetsui Ohkubo authored
This CL changes sub header separator color of detailed views in UnifiedSystemTray. Screenshot: http://screen/t36mz755DuP TEST=manual BUG=854146 Change-Id: I77b37bc6e352f427453c5da635c9d6d9dd649f0f Reviewed-on: https://chromium-review.googlesource.com/1107428Reviewed-by:
-
Tetsui Ohkubo authored
The button on the right of the brightness sldier is no-op, so we should call SetEnabled(false). In order to do this, this CL changed disabled color of the buton icon. TEST=manual BUG=854148 Change-Id: I1f0e98540a86696351135275be8946b7250cbc12 Reviewed-on: https://chromium-review.googlesource.com/1107423Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium b14d60b3. With Chromium commits locally applied on WPT: 03ef65db "Update existing WebUSB WPT to be multi-global" 89102421 "Reland "Multi-global WebUSB WPT for window and worker"" 08784a11 "[Mojo Blob URLs] Make clicking an <a target="blank_"> with a blob URL work correctly." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19930 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kozyatinskiy@chromium.org: external/wpt/console TBR=robertma No-Export: true Change-Id: Ifc3c52bfc29afe7fc3ad3e2e4e6cdf7ccb26d1e0 Reviewed-on: https://chromium-review.googlesource.com/1107395 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Christopher Cameron authored
Also move render_widget_host_ns_view_bridge.mm to render_widget_host_ns_view_bridge_local.mm, in anticipation of adding a remote version. TBR=avi Bug: 821651 Change-Id: I90b5a1e85fdb52339a4b30cc65d14cb212741bb0 Reviewed-on: https://chromium-review.googlesource.com/1107389Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#568750}
-
Gauthier Ambard authored
This CL fixes the bubble tips for UI Refresh by adding a 1s delay before displaying the tip and increasing the duration to 5s. Bug: 830635 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic9ee7f9e01449965068832c67743354478799ce7 Reviewed-on: https://chromium-review.googlesource.com/1106344Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#568749}
-
Yuri Wiitala authored
1. Remove the unused viz.mojom.FrameSinkVideoConsumer.OnTargetLost() API. 2. Fix the viz.mojom.FrameSinkVideoCapturer.ChangeTarget() to accept an optional FrameSinkId (original intended behavior of the API before new struct traits restrictions on "null" FrameSinkIds). 3. C++ Style: Fixed argument ordering in a few methods of viz::FSVCImpl so that the output argument would come last. 4. Ran lint on all files changed, and made fixes (mostly include-what-you-use). Bug: 754872 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Idbceb49089811dd6f8494f8ee17d578239108866 Reviewed-on: https://chromium-review.googlesource.com/1090220 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Xiangjun Zhang <xjz@chromium.org> Cr-Commit-Position: refs/heads/master@{#568748}
-
Joe Downing authored
A component in ASH was directly including one of the now-private inc files. We want to keep that data private so this CL introduces a header which exposes a DomCode[] to allow iterating over them w/o directly including the data files. CL which introduced this dependency: https://chromium-review.googlesource.com/c/chromium/src/+/1058080 Change-Id: I78b1fe1447e1f6354e690e5ec6fdd7132f61c74d Reviewed-on: https://chromium-review.googlesource.com/1091147Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#568747}
-
Raphael Kubo da Costa authored
IWYU. This fixes the build with libstdc++ after c1ab712a ("Stop using x-devtools-emulate-network-conditions-client-id header"): In file included from ../../services/network/throttling/scoped_throttling_token.cc:5:0: ../../services/network/throttling/scoped_throttling_token.h:29:15: error: ‘unique_ptr’ in namespace ‘std’ does not name a template type static std::unique_ptr<ScopedThrottlingToken> MaybeCreate( ^~~~~~~~~~ Bug: 819294 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I66b2db483ac9e90d0a132a65f83f15aa673f12f9 Reviewed-on: https://chromium-review.googlesource.com/1105825Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
-
