- 14 May, 2019 40 commits
-
-
Fergal Daly authored
It was reenabled in https://crrev.com/c/1604334 by update_expectations but it's still timing out. TBR=robertma@chromium.org Bug: 937991 Change-Id: I30955905d6c32280b6d489a0d389e2c1d9af0216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610271Reviewed-by:
Fergal Daly <fergal@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Auto-Submit: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#659429}
-
Jan Wilken Dörrie authored
This change introduces a new enum to autofill_types.mojom with the goal to provide more information during FocusedNodeChanged. Eventually this information will be used to show the TouchToFill feature for username fields, but browser implementation will be left for a follow-up CL. Bug: 957532 Change-Id: Iba9492a9ec2d612962898e43c02e8600925f98fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605901 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#659428}
-
Daniel Bratell authored
In some extreme (non-default) jumbo builds, both OnProfileCreated ended up in the same translation unit. This renames one of them DownloadOnProfileCreated to avoid that build problem. Bug: 959208 Change-Id: I31686fc741c1365de0ef6fdc9101ce960e2fe6ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602649Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Auto-Submit: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#659427}
-
Michael Lippautz authored
Change-Id: I28779394b1e040dd1b101f85611ed08d93f1a339 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610762 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#659426}
-
Abhishek Bhardwaj authored
This change makes FakePowerManagerClient now use mock ticks for timers. This means that timer expiration can be tested more strigently in tests instead of earlier tests where only timer expiration was checked and not the time when they expired. BUG=962638 TEST=Unit tests. Change-Id: Ic6b94e927dff2b55d9b622d77f663e377be7a4f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610224 Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Auto-Submit: Abhishek Bhardwaj <abhishekbh@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#659425}
-
Lowell Manners authored
This test was originally disabled due to flakiness in 2012. Now when enabled, it fails 100% of the time. Change-Id: I7b207bcc67fb133e2aebf3670f57202244914c35 Bug: 157357,786836 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588387 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#659424}
-
Shik Chen authored
If the information is available in the vendor tags, we will 1. set the display name to the webcam model name instead "External Camera". 2. set the model id to USB "vendor_id:product_id". Bug: b:131142270, chromium:939996, b:117816888, b:80502887 Test: With CL:1583571 and CL:1583572, 1. check the model name is shown on https://webrtc.github.io/samples/src/content/devices/input-output/ 2. check IPEVO Presenter works with the IPEVO document camera. Without that two CLs, check the name is falled back to "External Camera" as expected. Passes capture_unittests. Change-Id: I469327b1b224689ebb698278505aee68a2fb88a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594388Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#659423}
-
Yi Su authored
CRWWKNavigationHandler. CRWWebController.didReceiveWebViewNavigationDelegateCallback is called when it receives any callback from WKWebView. This CL moves it into CRWWKNavigationHandler and delegates all WKNavigationDelegate callbacks to CRWWKNavigationHandler. This CL also makes CRWWebController._isBeingDestroyed visible to CRWWKNavigationHandler through CRWWKNavigationHandlerDelegate protocol. Bug: 956511 Change-Id: Iecb377c603eb62e3a7265149b9394c8a2310c3ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599013 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#659422}
-
Timothy Loh authored
The PluginVmFilesTest currently uses SetChromeOSVersionInfoForTest, but this affects global state which is currently causing subsequent runs of the unrelated PluginVmManager tests to fail. This CL changes this to use the ScopedSetRunningOnChromeOSForTesting object instead. Bug: 957477 Change-Id: Ie639e796aef536cd28bb884a310252b267b15270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611072Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#659421}
-
David 'Digit' Turner authored
This is the last CL required to implement proper wrapping of android_dlopen_ext() with the crazy linker. R=pasko@chromium.org, rmcilroy@chromium.org, agrieve@chromium.org, cjgrant@chromium.org, tiborg@chromium.org BUG=936001 Change-Id: I89070de677de3bf3ec590c2afcb1284bb607a81e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609838 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#659420}
-
Tetsui Ohkubo authored
Currently, Ozone converts evdev scancode to Web Gamepad keycode, and the keycode is stored in |code| field of GamepadEvent. This CL adds |raw_code| field to GamepadEvent, which is the original evdev scancode. This is a part of ARC++ Improved Gamepad Support, which will forward raw scancode to Android container rather than converting scancode to keycode in Ozone. For further background, please check the design doc: go/arc-improved-gamepad TBR=oshima@chromium.org TEST=manual BUG=b:130597086 Change-Id: Id66565631eae9f0e90432b63160b7d82728ec12f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602232 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Cr-Commit-Position: refs/heads/master@{#659419}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/973f67f20b7f..18fe16aad947 Created with: gclient setdep -r src-internal@18fe16aad947 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=anthonyvd@google.com,alph@google.com,battre@google.com Change-Id: I1397e7bcf8e918ad59a05a889b57aacab4fd999d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610036Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659418}
-
Staphany Park authored
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/3f5b5b8f8493..9d4cde44a4a3 $ git log 3f5b5b8f8..9d4cde44a --date=short --no-merges --format='%ad %ae %s' 2019-05-13 gennadiycivil Added docs for testing::RegisterTest 2019-05-08 absl-team Googletest export Created with: roll-dep src/third_party/googletest/src Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel,mac_optional_gpu_tests_rel,linux_chromium_cfi_rel_ng;luci.chrome.try:win_chrome_official Change-Id: I00b157b8373d2a550541d7ace5cad635b7752313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610535 Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Staphany Park <staphany@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#659417}
-
Fergal Daly authored
It was reenabled in https://crrev.com/c/1604334 by update_expectations but it's still timing out (it doesn't seem to be crashing anymore). TBR=robertma@chromium.org Bug: 937170 Change-Id: Ic412fa6f5a4703451bf53cc674a995badb9683ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611071Reviewed-by:
Fergal Daly <fergal@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Auto-Submit: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#659416}
-
Leon Han authored
Previously content::NavigationPreloadRequest::owner_ was changed to be a WeakPtr in order to do some DCHECKs helping investigate the root case of crbug.com/907311, although in effect it's unnecessary. As the bug has been resolved now, this CL just changes it back to be a raw pointer. BUG=907311 Change-Id: Ia158ad28a2bf7d0088149ae4a65acceb49c09bed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610035 Commit-Queue: Leon Han <leon.han@intel.com> Auto-Submit: Leon Han <leon.han@intel.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#659415}
-
Hirokazu Honda authored
This adds test cases for the conversion from Dmabuf to memory on all the exitsting conversion cases except I420 to NV12. This is because there is currently no way of creating I420 buffer using NativePixmap. Bug: 944822 Test: image_processor_test on octopus Change-Id: Id9f51f00e78c6c391ac2fc76c41da96841c3a71a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574870 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#659414}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5e97971d. With Chromium commits locally applied on WPT: c4dc3441 "[WPT] Reland Upload a test for sending mouse events with key pressed" fec827fb "Added wpt tests for overscroll customization." c9077e39 "Restore original tail-processing for ScriptProcessor and AudioWorklet" d814fafc "Check for detached ArrayBuffers in Web Bluetooth writeValue functions" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: Ic917779bd863fecc0cc84f833db3ad10c4d75a94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610034Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659413}
-
Lutz Justen authored
This CL moves allow_gssapi_library_load_ from the static HTTP params to the dynamic ones. This allows dynamically creating negotiate auth handlers. This allows Kerberos support (i.e. KerberosEnabled policy) to be turned on while a session is running and no relog is required. BUG=chromium:952235 TEST=Once Kerberos is fully implemented, disable the KerberosEnabled policy, log in, enable the KerberosEnabled policy, refresh policy, log into a Kerberos account, (search for Kerberos in settings), e.g. chromeadm-lab.com, then navigate to a site that requires Kerberos auth, e.g. https://www.chromeadm-lab.com. The site should NOT display a 401 unauthorized error. Change-Id: Ia1f6a2994903af6f8b2ab67995d31e3504fb6a58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599626 Commit-Queue: Lutz Justen <ljusten@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#659412}
-
Matthew Cary authored
This is a step in updating chromium's shared memory API. See details in https://docs.google.com/document/d/13rMRD5kEl_5NFDOSWHEfmooBY2W5h5whNAl9nwBeEb8/edit#heading=h.x4ivxr8nivid This change should introduce no functional changes. Most of the change changes uses of media::BitstreamBuffer from a const& to a value type. Bug: 849207, 640840. Change-Id: I9a74ae193bff5723c1c32d96d897cb94dbdc2927 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524354Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Eero Häkkinen <eero.hakkinen@intel.com> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#659411}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d1fbae93..b0d52f7e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie12e898c2046ae3fb84bb3b7959fdf06cb87a7dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610032Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659410}
-
Giovanni Ortuño Urquidi authored
InstallApps and UninstallApps give no guarantees that their callback won't be called when the client gets destroyed. Use a WeakPtr in PendingAppManager to avoid running callbacks when PendingAppManager gets destroyed. Bug: 962808 Change-Id: I39b1d02ac75c87b4dbf1a6fbe9edb802e99494c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609002Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#659409}
-
Pâris MEULEMAN authored
This method was only used by disabled tests. The need for this function was removed by modifying those tests https://crrev.com/c/1609900. Bug: 960281 Change-Id: If44a9681251080c9212faf395872a561382cf04c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609825 Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#659408}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4e66df54e7da..136ad09848f5 git log 4e66df54e7da..136ad09848f5 --date=short --no-merges --format='%ad %ae %s' 2019-05-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 3dbe480b559e..f7033c55be3f (11 commits) 2019-05-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 97d57619..156f1f75 (423 commits) Created with: gclient setdep -r src/third_party/skia@136ad09848f5 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Change-Id: I01a856acc262c861e57bec8ee4736ed1c263eac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610031Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659407}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a0cc08d19d95..973f67f20b7f Created with: gclient setdep -r src-internal@973f67f20b7f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=anthonyvd@google.com,alph@google.com,battre@google.com Change-Id: Id85ce5cebad7eae848f10f61e343ac6b6469b2fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611155Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659406}
-
Maksim Sisov authored
It may happen that the zwp linux dmabuf protocol is not available. In this case, we have already been resetting the gbm device and make the gpu use wl_egl instead, but the WaylandConnection still has been trying to add a window to the WaylandBufferManager upon creation. However, as previously said, the manager may not exist because the zwp linux dmabuf had not been advertised as supported protocol. Without this patch, it just crashes. Bug: 578890 Change-Id: I15bcd7ae968590d358a4590d79a54067de02e8d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609822Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#659405}
-
John Abd-El-Malek authored
I converted this to work with network service in r607652, but to make it easier to review I left it in the old browsertest file that's intended for non-network-service code. This change just moves it. Change-Id: Ieaf0ee2946e929d797845d2db4a2975d3906381f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610306Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#659404}
-
Pâris MEULEMAN authored
Try to re-enable previously flaky tests. This will be followed up by the removal of OAuth2TokenService.GetAccessTokenWithTimeout which is an unused API. Some modifications were required to run a part of the test in the UIThread (assertions added after the tests were disabled). Bug: 960281 Change-Id: I34081fcdbc40fd6635ee4e2ade01a7be39e7df25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609900Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#659403}
-
Anand K. Mistry authored
If UpdateSharePath results in a error, the callback is run, but then is run again because the response function doesn't return. This results in attempting to run a null callback. BUG=962811 Change-Id: I7b18b7f5b22dd39c6be908e0d5110708f2c78ba7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609725 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#659402}
-
Hirokazu Honda authored
This enable GenericDmabufVFMapper to map ABGR and XBGR formats. Bug: 944822 Test: image_processor_test Change-Id: I19f6556c16a13104322c022a0179ca249a5d11f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611065Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#659401}
-
Nicholas Hollingum authored
Exo could not handle some cases of popup placement, particularly when the new window would be too large to fit on screen. This CL reworks the implementation in some ways: - We break the placement problem down into two 1D problems, which minimises code duplication. - We respect the transformation order specified in the wayland spec, i.e. flip > slide > resize. - We maximize the visibility of the popup subject to the above, so when no valid transformations result in an unconstrained window, we choose the transformations that make the popup most visible. - We handle the case of resize, where previously only the top-left corner of the popup could be chosen. - We properly send the configuration callback, to inform the popup surface of its actual placement. Bug: 942859 Change-Id: I892678492047ac2849afa84b1004731b7decab92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588058 Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#659400}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b286dfef4182..13e06be378d8 git log b286dfef4182..13e06be378d8 --date=short --no-merges --format='%ad %ae %s' 2019-05-14 dburger@chromium.org Update generated python proto, removing Image.ImageType. Created with: gclient setdep -r src/third_party/chromite@13e06be378d8 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I89e2e5e43b4448f2d4e2dcd4627c7493b67fa73e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611400Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659399}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f7033c55be3f..b783fbc79992 git log f7033c55be3f..b783fbc79992 --date=short --no-merges --format='%ad %ae %s' 2019-05-14 syoussefi@chromium.org Vulkan: Fix matrix uniforms Created with: gclient setdep -r src/third_party/angle@b783fbc79992 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@google.com Change-Id: I6ff4e9f1de65571ead0c3cfd36f6f50f1593ed66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611401Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659398}
-
Takashi Toyoshima authored
Make the safelisted response header name up to date to conform the latest spec. Bug: 841308 Change-Id: I4f27f520e2596dd24d2737f4d1d0a712a3e79bfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599765 Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#659397}
-
Alex Moshchuk authored
This prevents launching JavaScript in unprivileged mode via Internet Explorer. Bug: 959438 Change-Id: Ib359be8de82458b4e4276337123245ef5a2118e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607131Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#659396}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/01eaf1779b3a..4e66df54e7da git log 01eaf1779b3a..4e66df54e7da --date=short --no-merges --format='%ad %ae %s' 2019-05-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 9e4f690166c1..65b1e97d13eb (7 commits) Created with: gclient setdep -r src/third_party/skia@4e66df54e7da The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Change-Id: I3cc91df2c73857bf1ddbc851e49d3e036a32ccc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610199Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659395}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/65b1e97d13eb..40a6ed8d5cbb git log 65b1e97d13eb..40a6ed8d5cbb --date=short --no-merges --format='%ad %ae %s' 2019-05-14 swiftshader.regress@gmail.com Regres: Update test lists @ 65b1e97d Created with: gclient setdep -r src/third_party/swiftshader@40a6ed8d5cbb The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Change-Id: Id94d1521e8660af8ac1443297ee8735d82346538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610754Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659394}
-
Tetsui Ohkubo authored
This reverts commit d0e50543. Reason for revert: Build error https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8913511061716148464/+/steps/compile/0/stdout Original change's description: > wayland-protocols: Remove gaming-input-unstable-v1 > > It seems gaming-input-unstable-v1 is no longer used as there's > gaming-input-unstable-v2. > > TEST=trybot pass > BUG=b:130597086 > > Change-Id: I4e904ba126a50d956051e45eb1ebab07bc9e3d21 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602192 > Reviewed-by: Mitsuru Oshima (slow - gardening) <oshima@chromium.org> > Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> > Cr-Commit-Position: refs/heads/master@{#659353} TBR=oshima@chromium.org,tetsui@chromium.org Change-Id: Ifa38ea746a269858311f9be7ef368c429ab0fadd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:130597086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610267Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#659393}
-
Hirokazu Honda authored
This expands the storage type of input video frame on LibYUVImageProcessor. LibyuvImageProcessor maps an input video frame and performs libyuv functions with the mapped video frame. Bug: 944822 Test: image_processor_test Change-Id: Id7a466e6bd58e4d94f81b237e690fb0c7ae1f2da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567712 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#659392}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ib7c7a150bc56990bb3ffc245d30e1a60e6c14600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610356Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659391}
-
Fergal Daly authored
TBR=rakina@chromium.org Bug: 962726 Change-Id: Ibfd26f1547ecfe87495216a5d1460b3d8452ff97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610262Reviewed-by:
Fergal Daly <fergal@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#659390}
-